59ef6f983f
Removes Driller from ScriptCanvas
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
4 years ago
50f094c51e
Fixing warnings caused by system components not added to serialize context
...
==================================================================
2021-11-30T20:21:23{000000000000395C}[Module Manager] Trace::Warning
D:/projects/lyengine/git/ly-dev/o3de/Code/Framework/AzCore/AzCore/Module/ModuleManager.cpp(34): 'bool __cdecl AZ::ShouldUseSystemComponent(const class AZ::ComponentDescriptor &,const class AZStd::vector<class AZ::Crc32,class AZStd::allocator> &,const class AZ::SerializeContext &)'
2021-11-30T20:21:23{000000000000395C}[Module Manager] Component type MultiplayerToolsSystemComponent not reflected to SerializeContext!
2021-11-30T20:21:23{000000000000395C}[Module Manager] ==================================================================
2021-11-30T20:21:23{000000000000395C}[Module Manager]
==================================================================
2021-11-30T20:21:23{000000000000395C}[Module Manager] Trace::Warning
D:/projects/lyengine/git/ly-dev/o3de/Code/Framework/AzCore/AzCore/Module/ModuleManager.cpp(34): 'bool __cdecl AZ::ShouldUseSystemComponent(const class AZ::ComponentDescriptor &,const class AZStd::vector<class AZ::Crc32,class AZStd::allocator> &,const class AZ::SerializeContext &)'
2021-11-30T20:21:23{000000000000395C}[Module Manager] Component type PythonEditorFuncs not reflected to SerializeContext!
2021-11-30T20:21:23{000000000000395C}[Module Manager] ==================================================================
Signed-off-by: Guthrie Adams <guthadam@amazon.com>
4 years ago
b262909117
Misc whitespace edit
...
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
c8b631054f
Misc edit to keep an AZLOG_INFO instead of AZPrint. No real difference, but good as an example for pytest
...
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
78d0a8e54a
Merging latest LYN-8025_PipeEditorServerLogsToEditor
...
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
8afd47950c
Removing an extra new-line I added by accident
...
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
6d0ba68b55
Using new GetBool value when checking if we're an editor-server. Clean up MPEditorSystemComponent for unused #includes, and null-checking when piping server logs
...
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
d786e9d8e2
Merge branch 'LYN-8025_PipeEditorServerLogsToEditor' into LYN-8514_AutomatedReviewServerLogChecks
4 years ago
9c9d2c70f5
Making sure to stop pulling server logs before terminating the server process; otherwise we might be pulling an invalid process-communicator. Updating AZCoreLogSink to also allow for piping warnings/errors/asserts
...
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
f4e762d9bd
Adding warning if server fails to load the sv_defaultPlayerSpawnAsset when a client joins the server. Updating Multiplayer PyTest to watch out for this warning.
...
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
75e8ef8089
Misc cleanup. Making sure ServerLauncher closes if tests fail
...
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
97b27513e9
Editor is now listening to editor-server stdout so adding newlines to lines we care about. (Editor is separating out the log lines based on newline)
...
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
ff862a2f20
Fix memory leak of ProcessWatcher
...
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
0bd86cf0a4
small edit: removing pragma optimize offs
...
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
02590a1766
AzCoreLogSink will check if it's running in an editor-server and will allow stdouts
...
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
6005a4e08b
Merging last dev
...
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
7100d48e16
Cherry-picking some changes from stabilization into development ( #5810 )
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
4 years ago
e804fd2a42
Refactored away circular dependencies in Multiplayer gem cmake targets.
4 years ago
52742dff48
Created Gem::Multiplayer.Tools.Static cmake target
...
Signed-off-by: Olex Lozitskiy <5432499+AMZN-Olex@users.noreply.github.com>
4 years ago
69efe7cf26
Addressing PR
...
Signed-off-by: Olex Lozitskiy <5432499+AMZN-Olex@users.noreply.github.com>
4 years ago
89f4ebb298
Refactored away circular dependencies in Multiplayer gem.
...
Signed-off-by: Olex Lozitskiy <5432499+AMZN-Olex@users.noreply.github.com>
4 years ago
21d5e62f85
Merge commit 'cb1a45f9ec01ebaede35da2924bde66f31c31ea2' into amzn-tommy/gitflow_211116_o3de2
4 years ago
4d161f42df
WiP. fwrites are being stopped by AZCoreLogSink; need a long term solution to work around this...
...
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
f9824fc4ee
Merge pull request #5586 from aws-lumberyard-dev/IMGUI_EntityOutlinerFix
...
Fixed IMGUI Entity Outliner to show net entities
4 years ago
38a03817bb
Removal and Replacement of the CryTimer (gEnv->pTimer) ( #5409 )
...
Replaced and removed the CryTimer (gEnv->pTimer). The new TimeSystem is a merger of the current time functionality found in the engine.
* Rename TimeSystemComponent.h/.cpp to TimeSystem.h/.cpp
* Adding New TimeSystem
* remove old timer cvars
* small improvements to the time system.
- updated parts to use the time conversion functions.
- in AdvanceTickDeltaTimes applying t_simulationTickScale is now uses doubles instead of floats.
* Replace gEnv->pTimer / ITimer usages with TimeSystem
* Updating usages of AZ::TimeMs{ 0 } and AZ::TimeUs{ 0 } to AZ::Time::ZeroTimeMs and AZ::Time::ZeroTimeUs
* red code the CryTimer
* using TimeUs instead of TimeMs is some cases + updating usages of old cvars to new
Signed-off-by: amzn-sean <75276488+amzn-sean@users.noreply.github.com>
4 years ago
3fb97b1334
Added more info to comment
...
Signed-off-by: Sergey Pereslavtsev <pereslav@amazon.com>
4 years ago
435f839666
Fixed IMGUI Entity Outliner to show net entities
...
Signed-off-by: Sergey Pereslavtsev <pereslav@amazon.com>
4 years ago
2cd732de6c
Fixing RPC autogen so that RPCs without parameters compile (and function).
...
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
8d5dd4e35f
Merge remote-tracking branch 'upstream/stabilization/2110' into nvsickle/StabToDevNov21
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com>
4 years ago
e5dbd0a2a9
Merge pull request #5467 from aws-lumberyard-dev/LYN-7815_RPCCompilationFix
...
Fix to Allow Compiling the 4 Types of RPCs
4 years ago
fe5aeb9a5f
Merging latest dev
...
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
d6803d800b
Externed cvars dont get registered with setreg (not sure why). Updating sv_defaultPlayer to grab the variable via console string lookup instead so the proper value is gathered
...
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
b9f6d1ec9f
Merge pull request #5311 from aws-lumberyard-dev/HierarchiesFixes
...
Fixed client hierarchy construction to check for authority instead of controller
4 years ago
c99071533d
Small: fix typo
...
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
c8b9f05079
Ensuring the 4 types of RPCs (1)Autonomous->Authority (2)Authority->Autonomous (3)Authority->Client and (4)Server->Authority all compile. Invoking anything that starts from Autonomous or Authority requires a controller (otherwise just requires a component), and anything handled by Authority or Autonomous requires a controller for Handle on OnEvent methods (otherwise OnEvent and Handle occurs on the component)
...
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
5d5087e0d3
Moving CommunicatorTracePrinter to a place that AP and Multiplayer gem can use it. MultiplayerEditorSystemComponent now watching the server process and pumping the trace printer. Wip; for some reason not all the server logs are reaching the editor
...
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
5fc4551ac0
[LYN-8041] Enable relocation of the Project Game Release Layout ( #5380 )
...
* Enable relocation of the Project Game Release Layout
Relocating the Project Game Release Layout to another directory on the file system failed due to the querying of the engine root failing due to the ComponentApplication::m_engineRoot not using the project path stored in the SettingsRegisry if the engine root cannot be detected
Removed the ApplicationRequestBus GetEngineRoot function.
The ComponentApplicationRequestBus has a function of the same name that returns the same path.
Removed the deprecated GetAppRoot function.
The path it returns has no defined value. It was not the engine root or the project root.
Removed unused CFileUtil and CFileUtil_impl functions that were invoking the ApplicationREquestBus GetEngineRoot function.
On the way to update the functions it was discovered that they aren't called
Added a CalculateBranchToken overload that can populate a fixed_string to avoid heap allocations
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
* Protect against an empty list of artifacts to remove when generating the
engine.pak
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
4 years ago
7fce5e52a4
PR feedback addressing
...
Signed-off-by: Sergey Pereslavtsev <pereslav@amazon.com>
4 years ago
1e6518abab
Build fix after the merge from dev
...
Signed-off-by: Sergey Pereslavtsev <pereslav@amazon.com>
4 years ago
33d5109fe8
Merge `stabilization/2110` as of `20edb35cdc` into `development` ( #5319 )
4 years ago
4468a9213d
Merge pull request #5359 from aws-lumberyard-dev/LYN-8035_MultiplayerFlakyTest_ServerLogging
...
Wait to Activate Editor-server Until the Logging System is Ready
4 years ago
32f72a1213
Merge from development
...
Signed-off-by: Sergey Pereslavtsev <pereslav@amazon.com>
4 years ago
479ff188a0
merging latest development
...
Signed-off-by: kberg-amzn <karlberg@amazon.com>
4 years ago
989952e106
Fix comment
...
Signed-off-by: kberg-amzn <karlberg@amazon.com>
4 years ago
988561920a
Sets up the event scheduler system component for hierarchy tests
...
Signed-off-by: kberg-amzn <karlberg@amazon.com>
4 years ago
384d631485
Switch to use the new ComponentApplicationLifecycle system to listen for legacy systems to be ready
...
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
807d0d7a5a
Fixed hierarchies migration. Fixed assert with invalid entity bounds
...
Signed-off-by: Sergey Pereslavtsev <pereslav@amazon.com>
4 years ago
3973a59d77
Wait to activate the editor-server until CrySystemInitialized so that the logging system is ready. Automated testing listens for these logs
...
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
ed06ef7ed2
Removing ITimeoutHandler to simplify timeout queue interface, removes some unneeded code
...
Signed-off-by: kberg-amzn <karlberg@amazon.com>
4 years ago
dedb367e9a
Remove lots of mock interface code duplication
...
Signed-off-by: kberg-amzn <karlberg@amazon.com>
4 years ago
97e10d8210
Fix mock and benchmark interfaces
...
Signed-off-by: kberg-amzn <karlberg@amazon.com>
4 years ago
d942c90c56
Merge branch stabilization/2110 into development
...
Signed-off-by: Chris Burel <burelc@amazon.com>
4 years ago
4721ef8298
License Info is Displayed as Clickable Link in Gem Catalog + Other Inspector Improvements ( #5272 )
...
Signed-off-by: nggieber <nggieber@amazon.com>
4 years ago
54c1b00902
Fixed AR nightly for non-prefab levels where MultiplayerEditorSystemComponent prints an error
...
Signed-off-by: Sergey Pereslavtsev <pereslav@amazon.com>
4 years ago
2b2e5c6367
Fixed client hierarchy construction to check for authority instead of controller
...
Signed-off-by: Sergey Pereslavtsev <pereslav@amazon.com>
4 years ago
7e65104155
Addressing PR feedback
...
Signed-off-by: kberg-amzn <karlberg@amazon.com>
4 years ago
8a3d055f8b
Some cleanup around handling of migrations to simplify interfaces and add additional hooks for functionality
...
Signed-off-by: kberg-amzn <karlberg@amazon.com>
4 years ago
fda7a6353e
Backing out some temporary debugging code
...
Signed-off-by: kberg-amzn <karlberg@amazon.com>
4 years ago
5b734b9d41
A number of fixes to timeout and disconnect handling
...
Signed-off-by: kberg-amzn <karlberg@amazon.com>
4 years ago
2ac75d1231
Merge branch 'development' of https://github.com/o3de/o3de into NetHierarchies2
4 years ago
2a3667f7b0
Merge branch 'upstream/development' into LYN-6770_AutomatedTestNetInputs
4 years ago
fa32940205
Adding logs to dedicated-server start up (unable to use for automated testing just yet since remote console cant be connected that early). Adding pytest check to make sure AutomatedTesting.ServerLauncher is running. Moved sveditor_port to MultiplayerEditorConnection since it was never actually getting used when it was in EditorSystemComponent (dedicated servers dont know about editor)
...
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
2f38873e03
Adding logs for successful steps occurring in the editor-server process. AutomatedTesting will expect these logs and can be helpful to narrow down any test fails
...
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
0ee7ab9df5
Merge commit '837831a91990861220d982ca21a302197178092a' into barlev/gitflow_211028_O3DE
4 years ago
6d673643be
Re-merging latest dev after rebasing to fix DCO. Re-resolving conflicts
...
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
b324b3a1a9
Minor code comment grammar change
...
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
013beafe7e
Minor code warning grammar fix
...
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
9109b9de8d
Removed includes
...
Signed-off-by: Sergey Pereslavtsev <pereslav@amazon.com>
4 years ago
43e6731714
Removed hierarchy validation since it is not always applicable
...
Signed-off-by: Sergey Pereslavtsev <pereslav@amazon.com>
4 years ago
348bb7d37e
Added setreg option for network spawnables serialization format
...
Signed-off-by: Sergey Pereslavtsev <pereslav@amazon.com>
4 years ago
e6650f1ff4
LYN-7655 Fix Race Condition When Launching at Editor-Server ( #4946 )
...
* Fix a race condition where the editor tries to connect to the editor-server before the editor-server is ready (originally discovered on lower-spec Jenkin machines). Change editor-server so that editor waits to receive a EditorServerReadyForInit before trying to send all the level data.
* The editor might not be the connector so make sure to connect to the actual MP simulation even if the editor isn't the editor-server connect (if editorsv_launch=true then the editor-server will connect to the editor)
* Adding warnings if MPEditorConnection cannot find certain cvars
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
250a91dd96
Network Hierarchy Root and Child components can now act as MultiplayerInputDriver for components with NetworkInputs
...
Signed-off-by: AMZN-Olex <5432499+AMZN-Olex@users.noreply.github.com>
4 years ago
dc336ffaba
Added validation to net prefab processing to error if there are hierarchical entities without Net hierarchy components
...
Signed-off-by: Sergey Pereslavtsev <pereslav@amazon.com>
4 years ago
eabfed5562
Merge branch 'LYN-7655_MultiplayerEditorToEditorServerConnectionReverse' into LYN-6770_AutomatedTestNetInputs
4 years ago
b4865e32f5
Minor whitespace fix
...
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
fe071f0736
Adding warnings if MPEditorConnection cannot find certain cvars
...
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
03e90e7df5
Merge branch 'LYN-7655_MultiplayerEditorToEditorServerConnectionReverse' into LYN-6770_AutomatedTestNetInputs
4 years ago
7de5c17fb6
The editor might not be the connector so make sure to connect to the actual MP simulation even if the editor isn't the editor-server connect (if editorsv_launch=true then the editor-server will connect to the editor)
...
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
ea4a898d74
Minor, adding some null checks
...
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
5ade5291b0
Minor code comment edit
...
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
5ba090feec
Merge branch 'upstream/development' into LYN-7655_MultiplayerEditorToEditorServerConnectionReverse
4 years ago
6ef6164ad8
merging latest dev
...
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
569dbc7db3
Merge editor-server race condition fix; will test on Jenkins
...
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
0c5110b1ed
Fix a race condition where the editor tries to connect to the editor-server before the editor-server is ready (originally discovered on lower-spec Jenkin machines). Change editor-server so that editor waits to receive a EditorServerReadyForInit before trying to send all the level data.
...
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
775dda8ed2
NetBindComponent::SetOwningConnectionId is for a hierarchy based on its root's network entity
...
- for hierarchies, on both servers and clients NetBindComponent::SetOwningConnectionId is set for the all involved entities based on the root entity owning connection id
- added new unit tests to cover these scenarios
- all unit tests pass, hierarchy benchmarks remain unaffected
4 years ago
a2592e9ff8
Correction in set hierarchy entity logic.
...
Signed-off-by: AMZN-Olex <5432499+AMZN-Olex@users.noreply.github.com>
4 years ago
15fbe97504
Adding a guard for this, since tests attempt to apply autonomy to an invalid entity
...
Signed-off-by: kberg-amzn <karlberg@amazon.com>
4 years ago
7b77961962
removing unused local variable causing a compiler warning
...
Signed-off-by: kberg-amzn <karlberg@amazon.com>
4 years ago
214a2899ad
oops =(
...
Signed-off-by: kberg-amzn <karlberg@amazon.com>
4 years ago
2df466228a
fixing one more broken include
...
Signed-off-by: kberg-amzn <karlberg@amazon.com>
4 years ago
4cd6ce1e96
Fixing broken include path
...
Signed-off-by: kberg-amzn <karlberg@amazon.com>
4 years ago
317bb7aa67
Owning connection id will happen on clients as well.
...
Signed-off-by: AMZN-Olex <5432499+AMZN-Olex@users.noreply.github.com>
4 years ago
37873f81cf
Setting owning connection id based on the hierarchy root network entity.
...
Signed-off-by: AMZN-Olex <5432499+AMZN-Olex@users.noreply.github.com>
4 years ago
79b41686c4
Merging latest dev
...
Signed-off-by: kberg-amzn <karlberg@amazon.com>
4 years ago
6b102cadac
Removing hacked Jenkins fix in order to rerun with more logging and get a better idea of why its failing in the first place
...
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
3a1c377c03
Fix compiler warning
...
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
b81bf1064f
Noticing the Jenkins machine fails to connect to server before the server logs even begin. Giving the server some time (5 seconds) to boot up before trying to connect to see if that helps
...
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
322e339543
Printing error if the editor server launcher has not been built. Updating pytest to fail if the serverlauncher does not exist.
...
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
9e2eba2829
Network Hierarchy optimizations for rebuilding hierarchies
...
- reworked recursive rebuilding to iterative breadth first method
- some minor optimization here and there
4 years ago
9e4a39f9ed
Hierarchy code enhancements
...
Signed-off-by: AMZN-Olex <5432499+AMZN-Olex@users.noreply.github.com>
4 years ago
Esteban Papp
Guthrie Adams
Gene Walters
Olex Lozitskiy
Tommy Walton
SergeyAMZN
amzn-sean
Sergey Pereslavtsev
Nicholas Van Sickle
lumberyard-employee-dm
Chris Burel
puvvadar
kberg-amzn
AMZN-nggieber
Adi Bar-Lev
Gene Walters