6fad254b59
Merge branch 'development' into optimization/unused_files
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
# Conflicts:
# Code/Editor/IEditorImpl.cpp
# Code/Editor/IEditorImpl.h
# Gems/LmbrCentral/Code/Tests/lmbrcentral_editor_tests_files.cmake
2022-01-25 15:40:30 -08:00
b98bc34eb1
Merge pull request #7031 from aws-lumberyard-dev/LYN-9321_RequestNetSpawnableErrorFix
...
Fix Editor Play-Mode RequestNetSpawnable Error
2022-01-25 09:52:00 -08:00
0a5f472f43
Clang 13: Fix build errors ...
...
... due to local variables only being written to (but never read).
Signed-off-by: Daniel Edwards <dev@danieledwards.de >
2022-01-23 22:29:03 +01:00
be2e2ed4d1
Removes PhysicsUtils.h and PhysicsUtils.cpp from Gems/Multiplayer
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2022-01-20 16:07:51 -08:00
a452da819d
Dont allow spawning netbound entities by default, we first need to initialize multiplayer and know our network agent type (dedicated-server/client-server/client). This will stop the editor playmode (which doesn't init multiplayer until it connects to the server) from spawning netbound entities
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2022-01-19 14:36:36 -08:00
57394bc81d
Merge pull request #6958 from Bindless-Chicken/fix-imgui-multiplayer
...
Fix missing ImGui::End in multiplayer windows
2022-01-19 11:53:31 -08:00
fbfea49b68
small comment tweak based on feedback
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2022-01-18 23:55:40 -08:00
54de15b0ec
Adding '.network.spawnable' as a network constant
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2022-01-18 16:34:58 -08:00
626b16dbae
Updating NetworkingSpawnableLibrary to only store network spawnables, instead of all spawnables
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2022-01-18 10:27:10 -08:00
786d6b5f85
minor code readability tweak
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2022-01-18 10:22:31 -08:00
aac28f73aa
Fix missing ImGui::End in multiplayer windows
...
Signed-off-by: Bindless-Chicken <1039134+Bindless-Chicken@users.noreply.github.com >
2022-01-17 14:25:50 +00:00
e4bd28f636
Update NetworkSpawnableLibrary to only hold onto network.spawnables (instead of all spawnables)
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2022-01-14 13:48:37 -08:00
c8e5bcc901
Dont allow spawning netbound entities by default, we first need to initialize multiplayer and know our network agent type (dedicated-server/client-server/client). This will stop the editor playmode (which doesn't init multiplayer until it connects to the server) from spawning netbound entities
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2022-01-14 12:01:32 -08:00
ffde762081
Minor comment tweak, and code readability
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2022-01-12 12:43:39 -08:00
18ea4ba6a8
Added a CriticalAssetsCompiled Lifecycle event ( #6469 )
...
The CriticalAssetsCompiled event can be handled to detect when the
AssetProcessor has finished processing Critical Assets
Also with the new event, an audit has been performed over all the
locations where the AssetCatalogEventBus OnCatalogLoaded event was being
handle to make sure it was the proper event to use.
If the handler was actually examing the enumerating over the full
catalog or querying all assets within the catalog, then it was a proper
use.
For handlers that were interested in a particular asset it was not
Moreover added implementations of `OnCatalogAssetChanged` and
`OnCatalogAssetAdded` to the FileTagComponent and the MaterialViewportComponent.
Any applications which uses the AtomToolsApplication
class(MaterialEditor, AtomSampleViewerStandalone,
ShaderMangementConsole) now signals a "CriticalAssetsCompiled" lifecycle
event as well as loads the "assetcatalog.xml" if it exists.
The Launcher application signals the "CrticalAssetsCompiled" event and
reloads the "assetcatalog.xml" for the ${project}.GameLauncher and
${project}.ServerLauncher in Launcher.cpp
Finally the Editor signals the "CriticalAssetsCompiled" and reloads the
"assetcatalog.xml" in CryEdit.cpp
resolves #6093
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com >
2022-01-10 15:21:04 -06:00
13375cd7d9
Merge branch 'development' into Prefabs/ProcessStackAddPrefabBug
2022-01-05 11:12:57 -08:00
8cd4a3dced
Fix netbind component to use the new svg icons instead of png (which no longer exist)
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-12-30 12:50:06 -08:00
8b041f5280
merging latest dev
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-12-18 10:34:49 -08:00
92d3df17fa
Fix incomplete comment
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-12-18 10:16:02 -08:00
bf8422152b
Turn off stdout buffering when connecting to editor-server so that the editor properly gets all the server-logging without having to first fill up a buffer. Allows the logs to pipe instantly for easier debugging, and also fixes a problem where the logs wont reach the editor because the buffer doesn't fill
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-12-17 00:12:21 -08:00
a964120b7a
Updated the NetworkPrefabProcessor with the latest Prefab builder changes.
...
Signed-off-by: AMZN-koppersr <82230785+AMZN-koppersr@users.noreply.github.com >
2021-12-16 16:01:09 -08:00
ca49eedc5f
Convert prefab to temp spawnable assets ( #6179 )
...
* Convert prefab to temp in-memory spawnable assets
Signed-off-by: chiyenteng <82238204+chiyenteng@users.noreply.github.com >
2021-12-10 10:55:01 -08:00
8b044e23ce
Merge branch 'upstream/development' into LYN-6769_TestingRPCs
2021-12-09 10:43:16 -08:00
4b3d1452fd
Merge pull request #6066 from aws-lumberyard-dev/LYN-8514_AutomatedReviewServerLogChecks
...
Updating Multiplayer PyTests To Check Server Logs
2021-12-09 09:15:58 -08:00
80a216e079
Adding RPC test. Update editor-servers to flush stdout
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-12-08 00:21:02 -08:00
1983e94580
Minor tweak to re-add ';' to LOG
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-12-07 16:27:23 -08:00
b123379380
Properly adding newlines when using LogInternalV; removing the need of hand-placed newlines to AZ_LOG
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-12-07 14:53:59 -08:00
9ae3da7acd
Merge branch 'upstream/development' into LYN-8514_AutomatedReviewServerLogChecks
2021-12-06 11:30:12 -08:00
b19f96f1fe
Small safety check. It's unlikely, but possible, that a component is created and not assigned to an entity.
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-12-06 09:53:41 -08:00
b50739f55e
Small tweak to assert back to match existing format
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-12-06 09:06:04 -08:00
4f9d4b7045
Improved logged to print entity name if improperly deleted; helps when debugging to find the problem entity
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-12-06 09:02:15 -08:00
50f094c51e
Fixing warnings caused by system components not added to serialize context
...
==================================================================
2021-11-30T20:21:23{000000000000395C}[Module Manager] Trace::Warning
D:/projects/lyengine/git/ly-dev/o3de/Code/Framework/AzCore/AzCore/Module/ModuleManager.cpp(34): 'bool __cdecl AZ::ShouldUseSystemComponent(const class AZ::ComponentDescriptor &,const class AZStd::vector<class AZ::Crc32,class AZStd::allocator> &,const class AZ::SerializeContext &)'
2021-11-30T20:21:23{000000000000395C}[Module Manager] Component type MultiplayerToolsSystemComponent not reflected to SerializeContext!
2021-11-30T20:21:23{000000000000395C}[Module Manager] ==================================================================
2021-11-30T20:21:23{000000000000395C}[Module Manager]
==================================================================
2021-11-30T20:21:23{000000000000395C}[Module Manager] Trace::Warning
D:/projects/lyengine/git/ly-dev/o3de/Code/Framework/AzCore/AzCore/Module/ModuleManager.cpp(34): 'bool __cdecl AZ::ShouldUseSystemComponent(const class AZ::ComponentDescriptor &,const class AZStd::vector<class AZ::Crc32,class AZStd::allocator> &,const class AZ::SerializeContext &)'
2021-11-30T20:21:23{000000000000395C}[Module Manager] Component type PythonEditorFuncs not reflected to SerializeContext!
2021-11-30T20:21:23{000000000000395C}[Module Manager] ==================================================================
Signed-off-by: Guthrie Adams <guthadam@amazon.com >
2021-12-02 14:34:36 -06:00
b262909117
Misc whitespace edit
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-12-01 10:06:04 -08:00
c8b631054f
Misc edit to keep an AZLOG_INFO instead of AZPrint. No real difference, but good as an example for pytest
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-12-01 10:04:26 -08:00
78d0a8e54a
Merging latest LYN-8025_PipeEditorServerLogsToEditor
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-11-30 12:08:19 -08:00
8afd47950c
Removing an extra new-line I added by accident
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-11-30 12:01:04 -08:00
6d0ba68b55
Using new GetBool value when checking if we're an editor-server. Clean up MPEditorSystemComponent for unused #includes, and null-checking when piping server logs
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-11-30 11:12:07 -08:00
d786e9d8e2
Merge branch 'LYN-8025_PipeEditorServerLogsToEditor' into LYN-8514_AutomatedReviewServerLogChecks
2021-11-29 18:27:40 -08:00
9c9d2c70f5
Making sure to stop pulling server logs before terminating the server process; otherwise we might be pulling an invalid process-communicator. Updating AZCoreLogSink to also allow for piping warnings/errors/asserts
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-11-29 18:26:31 -08:00
f4e762d9bd
Adding warning if server fails to load the sv_defaultPlayerSpawnAsset when a client joins the server. Updating Multiplayer PyTest to watch out for this warning.
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-11-29 16:36:28 -08:00
75e8ef8089
Misc cleanup. Making sure ServerLauncher closes if tests fail
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-11-29 13:36:41 -08:00
97b27513e9
Editor is now listening to editor-server stdout so adding newlines to lines we care about. (Editor is separating out the log lines based on newline)
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-11-23 19:27:16 -08:00
ff862a2f20
Fix memory leak of ProcessWatcher
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-11-22 18:56:48 -08:00
0bd86cf0a4
small edit: removing pragma optimize offs
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-11-20 14:58:09 -08:00
02590a1766
AzCoreLogSink will check if it's running in an editor-server and will allow stdouts
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-11-20 14:48:48 -08:00
6005a4e08b
Merging last dev
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-11-19 23:12:59 -08:00
e804fd2a42
Refactored away circular dependencies in Multiplayer gem cmake targets.
2021-11-18 21:55:55 -05:00
89f4ebb298
Refactored away circular dependencies in Multiplayer gem.
...
Signed-off-by: Olex Lozitskiy <5432499+AMZN-Olex@users.noreply.github.com >
2021-11-16 20:32:48 -05:00
4d161f42df
WiP. fwrites are being stopped by AZCoreLogSink; need a long term solution to work around this...
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-11-15 12:37:21 -08:00
f9824fc4ee
Merge pull request #5586 from aws-lumberyard-dev/IMGUI_EntityOutlinerFix
...
Fixed IMGUI Entity Outliner to show net entities
2021-11-15 14:23:10 +00:00
Esteban Papp
Gene Walters
Daniel Edwards
Gene Walters
Karl Berg
Bindless-Chicken
lumberyard-employee-dm
AMZN-koppersr
chiyenteng
Guthrie Adams
Olex Lozitskiy
SergeyAMZN