Commit Graph

557 Commits

Author SHA1 Message Date
Gene Walters bf8422152b Turn off stdout buffering when connecting to editor-server so that the editor properly gets all the server-logging without having to first fill up a buffer. Allows the logs to pipe instantly for easier debugging, and also fixes a problem where the logs wont reach the editor because the buffer doesn't fill
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-12-17 00:12:21 -08:00
Gene Walters 8b044e23ce Merge branch 'upstream/development' into LYN-6769_TestingRPCs 2021-12-09 10:43:16 -08:00
Gene Walters 4b3d1452fd Merge pull request #6066 from aws-lumberyard-dev/LYN-8514_AutomatedReviewServerLogChecks
Updating Multiplayer PyTests To Check Server Logs
2021-12-09 09:15:58 -08:00
Gene Walters 80a216e079 Adding RPC test. Update editor-servers to flush stdout
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-12-08 00:21:02 -08:00
Gene Walters 1983e94580 Minor tweak to re-add ';' to LOG
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-12-07 16:27:23 -08:00
Gene Walters b123379380 Properly adding newlines when using LogInternalV; removing the need of hand-placed newlines to AZ_LOG
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-12-07 14:53:59 -08:00
Gene Walters 9ae3da7acd Merge branch 'upstream/development' into LYN-8514_AutomatedReviewServerLogChecks 2021-12-06 11:30:12 -08:00
Gene Walters b19f96f1fe Small safety check. It's unlikely, but possible, that a component is created and not assigned to an entity.
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-12-06 09:53:41 -08:00
Gene Walters b50739f55e Small tweak to assert back to match existing format
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-12-06 09:06:04 -08:00
Gene Walters 4f9d4b7045 Improved logged to print entity name if improperly deleted; helps when debugging to find the problem entity
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-12-06 09:02:15 -08:00
Guthrie Adams 50f094c51e Fixing warnings caused by system components not added to serialize context
==================================================================
2021-11-30T20:21:23{000000000000395C}[Module Manager]     Trace::Warning
 D:/projects/lyengine/git/ly-dev/o3de/Code/Framework/AzCore/AzCore/Module/ModuleManager.cpp(34): 'bool __cdecl AZ::ShouldUseSystemComponent(const class AZ::ComponentDescriptor &,const class AZStd::vector<class AZ::Crc32,class AZStd::allocator> &,const class AZ::SerializeContext &)'
2021-11-30T20:21:23{000000000000395C}[Module Manager]     Component type MultiplayerToolsSystemComponent not reflected to SerializeContext!
2021-11-30T20:21:23{000000000000395C}[Module Manager]     ==================================================================
2021-11-30T20:21:23{000000000000395C}[Module Manager]
==================================================================
2021-11-30T20:21:23{000000000000395C}[Module Manager]     Trace::Warning
 D:/projects/lyengine/git/ly-dev/o3de/Code/Framework/AzCore/AzCore/Module/ModuleManager.cpp(34): 'bool __cdecl AZ::ShouldUseSystemComponent(const class AZ::ComponentDescriptor &,const class AZStd::vector<class AZ::Crc32,class AZStd::allocator> &,const class AZ::SerializeContext &)'
2021-11-30T20:21:23{000000000000395C}[Module Manager]     Component type PythonEditorFuncs not reflected to SerializeContext!
2021-11-30T20:21:23{000000000000395C}[Module Manager]     ==================================================================

Signed-off-by: Guthrie Adams <guthadam@amazon.com>
2021-12-02 14:34:36 -06:00
Gene Walters b262909117 Misc whitespace edit
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-12-01 10:06:04 -08:00
Gene Walters c8b631054f Misc edit to keep an AZLOG_INFO instead of AZPrint. No real difference, but good as an example for pytest
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-12-01 10:04:26 -08:00
Gene Walters 78d0a8e54a Merging latest LYN-8025_PipeEditorServerLogsToEditor
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-11-30 12:08:19 -08:00
Gene Walters 8afd47950c Removing an extra new-line I added by accident
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-11-30 12:01:04 -08:00
Gene Walters 6d0ba68b55 Using new GetBool value when checking if we're an editor-server. Clean up MPEditorSystemComponent for unused #includes, and null-checking when piping server logs
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-11-30 11:12:07 -08:00
Gene Walters d786e9d8e2 Merge branch 'LYN-8025_PipeEditorServerLogsToEditor' into LYN-8514_AutomatedReviewServerLogChecks 2021-11-29 18:27:40 -08:00
Gene Walters 9c9d2c70f5 Making sure to stop pulling server logs before terminating the server process; otherwise we might be pulling an invalid process-communicator. Updating AZCoreLogSink to also allow for piping warnings/errors/asserts
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-11-29 18:26:31 -08:00
Gene Walters f4e762d9bd Adding warning if server fails to load the sv_defaultPlayerSpawnAsset when a client joins the server. Updating Multiplayer PyTest to watch out for this warning.
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-11-29 16:36:28 -08:00
Gene Walters 75e8ef8089 Misc cleanup. Making sure ServerLauncher closes if tests fail
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-11-29 13:36:41 -08:00
Gene Walters 97b27513e9 Editor is now listening to editor-server stdout so adding newlines to lines we care about. (Editor is separating out the log lines based on newline)
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-11-23 19:27:16 -08:00
Gene Walters ff862a2f20 Fix memory leak of ProcessWatcher
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-11-22 18:56:48 -08:00
Gene Walters 0bd86cf0a4 small edit: removing pragma optimize offs
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-11-20 14:58:09 -08:00
Gene Walters 02590a1766 AzCoreLogSink will check if it's running in an editor-server and will allow stdouts
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-11-20 14:48:48 -08:00
Gene Walters 6005a4e08b Merging last dev
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-11-19 23:12:59 -08:00
Olex Lozitskiy e804fd2a42 Refactored away circular dependencies in Multiplayer gem cmake targets. 2021-11-18 21:55:55 -05:00
Olex Lozitskiy 89f4ebb298 Refactored away circular dependencies in Multiplayer gem.
Signed-off-by: Olex Lozitskiy <5432499+AMZN-Olex@users.noreply.github.com>
2021-11-16 20:32:48 -05:00
Gene Walters 4d161f42df WiP. fwrites are being stopped by AZCoreLogSink; need a long term solution to work around this...
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-11-15 12:37:21 -08:00
SergeyAMZN f9824fc4ee Merge pull request #5586 from aws-lumberyard-dev/IMGUI_EntityOutlinerFix
Fixed IMGUI Entity Outliner to show net entities
2021-11-15 14:23:10 +00:00
amzn-sean 38a03817bb Removal and Replacement of the CryTimer (gEnv->pTimer) (#5409)
Replaced and removed the CryTimer (gEnv->pTimer). The new TimeSystem is a merger of the current time functionality found in the engine.

* Rename TimeSystemComponent.h/.cpp to TimeSystem.h/.cpp
* Adding New TimeSystem
* remove old timer cvars
* small improvements to the time system.
 - updated parts to use the time conversion functions.
 - in AdvanceTickDeltaTimes applying t_simulationTickScale is now uses doubles instead of floats.
* Replace gEnv->pTimer / ITimer usages with TimeSystem
* Updating usages of AZ::TimeMs{ 0 } and AZ::TimeUs{ 0 } to AZ::Time::ZeroTimeMs and AZ::Time::ZeroTimeUs
* red code the CryTimer
* using TimeUs instead of TimeMs is some cases + updating usages of old cvars to new

Signed-off-by: amzn-sean <75276488+amzn-sean@users.noreply.github.com>
2021-11-15 12:11:58 +00:00
Sergey Pereslavtsev 3fb97b1334 Added more info to comment
Signed-off-by: Sergey Pereslavtsev <pereslav@amazon.com>
2021-11-12 18:13:20 +00:00
Sergey Pereslavtsev 435f839666 Fixed IMGUI Entity Outliner to show net entities
Signed-off-by: Sergey Pereslavtsev <pereslav@amazon.com>
2021-11-12 13:36:14 +00:00
Gene Walters fe5aeb9a5f Merging latest dev
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-11-10 19:41:36 -08:00
Gene Walters d6803d800b Externed cvars dont get registered with setreg (not sure why). Updating sv_defaultPlayer to grab the variable via console string lookup instead so the proper value is gathered
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-11-10 19:37:11 -08:00
SergeyAMZN b9f6d1ec9f Merge pull request #5311 from aws-lumberyard-dev/HierarchiesFixes
Fixed client hierarchy construction to check for authority instead of controller
2021-11-10 12:47:43 +00:00
Gene Walters 5d5087e0d3 Moving CommunicatorTracePrinter to a place that AP and Multiplayer gem can use it. MultiplayerEditorSystemComponent now watching the server process and pumping the trace printer. Wip; for some reason not all the server logs are reaching the editor
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-11-09 11:11:15 -08:00
Sergey Pereslavtsev 7fce5e52a4 PR feedback addressing
Signed-off-by: Sergey Pereslavtsev <pereslav@amazon.com>
2021-11-09 17:36:01 +00:00
Sergey Pereslavtsev 1e6518abab Build fix after the merge from dev
Signed-off-by: Sergey Pereslavtsev <pereslav@amazon.com>
2021-11-09 14:50:44 +00:00
puvvadar 4468a9213d Merge pull request #5359 from aws-lumberyard-dev/LYN-8035_MultiplayerFlakyTest_ServerLogging
Wait to Activate Editor-server Until the Logging System is Ready
2021-11-08 12:10:37 -08:00
Sergey Pereslavtsev 32f72a1213 Merge from development
Signed-off-by: Sergey Pereslavtsev <pereslav@amazon.com>
2021-11-08 15:41:40 +00:00
kberg-amzn 479ff188a0 merging latest development
Signed-off-by: kberg-amzn <karlberg@amazon.com>
2021-11-05 15:05:23 -07:00
Gene Walters 384d631485 Switch to use the new ComponentApplicationLifecycle system to listen for legacy systems to be ready
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-11-05 12:23:00 -07:00
Sergey Pereslavtsev 807d0d7a5a Fixed hierarchies migration. Fixed assert with invalid entity bounds
Signed-off-by: Sergey Pereslavtsev <pereslav@amazon.com>
2021-11-05 17:32:16 +00:00
Gene Walters 3973a59d77 Wait to activate the editor-server until CrySystemInitialized so that the logging system is ready. Automated testing listens for these logs
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-11-04 18:37:15 -07:00
kberg-amzn ed06ef7ed2 Removing ITimeoutHandler to simplify timeout queue interface, removes some unneeded code
Signed-off-by: kberg-amzn <karlberg@amazon.com>
2021-11-04 16:48:39 -07:00
Sergey Pereslavtsev 54c1b00902 Fixed AR nightly for non-prefab levels where MultiplayerEditorSystemComponent prints an error
Signed-off-by: Sergey Pereslavtsev <pereslav@amazon.com>
2021-11-04 14:55:03 +00:00
Sergey Pereslavtsev 2b2e5c6367 Fixed client hierarchy construction to check for authority instead of controller
Signed-off-by: Sergey Pereslavtsev <pereslav@amazon.com>
2021-11-04 14:52:35 +00:00
kberg-amzn 7e65104155 Addressing PR feedback
Signed-off-by: kberg-amzn <karlberg@amazon.com>
2021-11-03 19:40:20 -07:00
kberg-amzn 8a3d055f8b Some cleanup around handling of migrations to simplify interfaces and add additional hooks for functionality
Signed-off-by: kberg-amzn <karlberg@amazon.com>
2021-11-03 19:34:10 -07:00
kberg-amzn fda7a6353e Backing out some temporary debugging code
Signed-off-by: kberg-amzn <karlberg@amazon.com>
2021-11-03 14:20:56 -07:00