Commit Graph

3222 Commits

Author SHA1 Message Date
chcurran f1b3bf4c73 Fix for running game mode with brand new graph with prefabs. 2021-06-10 17:43:45 -07:00
lumberyard-employee-dm a9e59fd75f Updating the DefaultProject template to not insert the project-path parameter (#1223)
* Updating the DefaultProject template to not insert the project-path parameter into the VS Debugger Arguments for any applications

Added project-path injection directly within the LauncherUnified and AssetBuilder cmake scripts where their targets are defined

* Removing the add_vs_debugger_arguments call from the AutomatedTesting CMakeLists.txt
2021-06-09 18:50:47 -05:00
cgalvan da4e006621 Merge pull request #1227 from aws-lumberyard-dev/cgalvan/RemoveUnhandledEventMessages
[LYN-3145] Removed unnecessary spam message from legacy CEntityObject class when entering game mode.
2021-06-09 18:49:15 -05:00
AMZN-koppersr 773dc42537 Merge pull request #1228 from aws-lumberyard-dev/Prefab/EntitySpawnNotificationRemoval
Removed AddOn(De)SpawnedHandler from Spawnable Entities Interface
2021-06-09 16:42:08 -07:00
Terry Michaels 05d177568c Fixed cut & paste error of menu item name (#1230) 2021-06-09 18:33:12 -05:00
dmcdiarmid-ly 9ecdbd9d75 Merge pull request #1229 from aws-lumberyard-dev/Atom/dmcdiar/ATOM-15765
[ATOM-15765] Meshes without a material will cause a crash in MeshFeatureProcessor::SetRayTracingData
2021-06-09 16:16:23 -07:00
carlitosan 8e35ba8b58 Merge pull request #1222 from aws-lumberyard-dev/carlito/stabilization/2106
Carlito/stabilization/2106 fix for LYN-4098, LY-4019, LY-3777
2021-06-09 16:14:41 -07:00
AMZN-nggieber 5330309cb1 Set Desktop Icon for Project Manager (#1225)
* Set executable icon for O3DE
2021-06-09 16:01:48 -07:00
Terry Michaels aa7bab1027 Make SimpleAssetPropertyHandler handle showing the edit button on component cards (#1221) 2021-06-09 17:47:35 -05:00
chcurran d1a5fb651b Fixes for reflection code that hides itself frm Script explicitly but NOT from ScriptCanvas 2021-06-09 15:14:23 -07:00
Doug McDiarmid d94015f5e1 Skipped meshes with no materials in MeshFeatureProcessor::SetRayTracingData 2021-06-09 14:53:32 -07:00
chcurran c4ab5fff9a testing code files for fixes for LYN-3777 2021-06-09 14:52:55 -07:00
chcurran 8ab2752f42 Fix for using BC class constants LYN-3777 2021-06-09 14:52:33 -07:00
Chris Galvan 6ac13c19a3 [LYN-3145] Removed unnecessary spam message from legacy CEntityObject class when entering game mode. 2021-06-09 16:32:15 -05:00
AMZN-koppersr 4ad0560d06 Removed AddOn(De)SpawnedHandler from Spawnable Entities Interface
The calls AddOnSpawnedHandler and AddOnDespawnedHandler were removed from the SpawnableEntitiesInterface. These functions will eventually be called from multiple threads and AZ::Event currently doesn't have a thread-safe version to support this. There's also a performance concern as these callbacks are called for each individual (de)spawn requests which can lead to multiple handlers being called without information that's relevant to the callback. It would be better to batch up all (de)spawn requests per ProcessQueue call and only have a single event do a single signal. Since both events are currently not being used they have been removed for now, but can be introduced -with the previously mentioned concerns in mind- when needed.
2021-06-09 14:22:40 -07:00
Terry Michaels 3c23f5fead Fixed size of Save As window (#1208) 2021-06-09 16:21:02 -05:00
Fuzzy Carter c4d01b62ef Merge pull request #1202 from aws-lumberyard-dev/LYN-2765_update_fbx_test_assets
Lyn 2765 update fbx test assets
2021-06-09 13:02:32 -07:00
greerdv 492225931c Merge pull request #1216 from aws-lumberyard-dev/pyrunfile_args_fix
fix handling of multiple arguments when running python scripts from console
2021-06-09 20:53:07 +01:00
chcurran b51103c2bf Merge branch 'stabilization/2106' of https://github.com/aws-lumberyard/o3de into carlito/stabilization/2106 2021-06-09 12:46:32 -07:00
chcurran ec7edac932 Hide the raw input handler bus from the SC node palette list 2021-06-09 12:43:43 -07:00
lumberyard-employee-dm 217eddc8bd Fixing the enable_gem.py and disable_gem.py commands (#1207)
* Fixing the enable_gem.py and disable_gem.py commands
The project path wasn't taking into account when querying for gems,
templates and restricted directories registered with the project

Fixing the cmake.py add_gem_dependency and remove_gem_dependency methods
to properly detect a gem within a `set(ENABLED_GEM ...)` cmake variable
Also updated the add_gem_dependency to add the gem right before the end
marker of ')'
Updated the remove_gem_dependency to remove each instance of a gem with
a content that is in between in the `set(ENABLED_GEM ...)` cmake
variable

* Correct Typo in manifest.get_registered doc string
2021-06-09 14:14:01 -05:00
AMZN-nggieber b26b472bba Fix Editor being opened twice by project (#1213) 2021-06-09 11:59:15 -07:00
dmcdiarmid-ly f159de72f5 Merge pull request #1204 from aws-lumberyard-dev/Atom/dmcdiar/ATOM-15670
[ATOM-15670] AtomSampleViewer All RPI Samples Crash On Vulkan
2021-06-09 10:46:14 -07:00
greerdv 15766d6bc1 Merge branch 'stabilization/2106' into pyrunfile_args_fix 2021-06-09 18:22:19 +01:00
greerdv 33c5bd874b fix handling of multiple arguments running python scripts from console 2021-06-09 18:19:28 +01:00
FuzzyCarterAWS a2be10f00b Merge latest into local 2021-06-09 10:15:51 -07:00
srikappa-amzn 20dc47e6d0 Merge pull request #1198 from aws-lumberyard-dev/Prefab/RemoveFileSizeLimits
Remove file size limits when loading prefabs and prefab-based-levels
2021-06-09 10:05:45 -07:00
carlitosan 52425d0949 Merge pull request #1194 from aws-lumberyard-dev/carlito/stabilization/2106
Fixes for internal if-branch node parser bug  (LYN-4347) and exposing…
2021-06-09 09:57:54 -07:00
amzn-sean 4241eb9c2c fix crash in ragdoll (#1210) 2021-06-09 17:42:16 +01:00
rhongAMZ 3fd2f1305f Selecting and deleting the level prefab root entity crashes editor (#1179)
Early remove the level instance from the entity id list in the delete function and duplicate function.
2021-06-09 09:15:09 -07:00
Doug McDiarmid 432b330d22 Skipped empty unbounded arrays when updating the Vulkan DescriptorSet 2021-06-08 21:24:01 -07:00
FuzzyCarterAWS 9cc8e95945 Updates FBX test assets to remove suzanne 2021-06-08 19:48:38 -07:00
srikappa b23c95cab3 Removed the new added flavor of ReadFile and reused existing one 2021-06-08 17:58:59 -07:00
Danilo Aimini fd81000d53 Fix the relative path in the Source param for the PrefabLevel_OpensLevelWithEntities prefab (#1196)
* Fixed the relative path in the Source param for the PrefabLevel_OpensLevelWithEntities prefab. Plus bonus capitalization fix.

* Add empty Cached Transform Parent parameter to prevent patch application issues. This will be fixed once prefab sanitation on load is added.
2021-06-08 17:44:30 -07:00
srikappa 9dec723e33 Remove file size limits when loading prefabs and prefab-based-levels 2021-06-08 17:28:23 -07:00
chcurran 8cb6ef0721 Fix tmeplate arg names 2021-06-08 16:39:36 -07:00
chcurran 8d35a4255e Merge branch 'stabilization/2106' of https://github.com/aws-lumberyard/o3de into carlito/stabilization/2106 2021-06-08 16:08:17 -07:00
bosnichd 5f82e5a111 Fix typo. (#1192) 2021-06-08 15:15:20 -06:00
Esteban Papp 4b3d0d1054 LYN-4327 [SDK] External Gem's aren't added to the project solution when using SDK (#1191)
* should pickup the external directories registered by the project

* Add support for AzTest and AzTestRunner in the SDK

* missing IMPORT_LIB

* Moved where .Assets targets get generated so they are visible in the SDK

* generate the Directory.Build.props in the right path

* excluding target on platforms that dont support it
2021-06-08 14:01:50 -07:00
chcurran a766e3af5c Fixes for internal if-branch node parser bug (LYN-4347) and exposing properties for AZStd::tuple (LYN-3910) 2021-06-08 13:54:25 -07:00
Tom Hulton-Harrop dd95d2b02e ensure brute force ray intersection works (#1170)
* ensure brute force ray intersection works in the same space as kd-tree intersection

* add additional tests for ray casts against meshes using brute force approach

* update api and add some additional test cases

* comment tidy-up and other small updates/fixes for ray intersection code

* fix issue with values at the end of a ray
2021-06-08 19:44:33 +01:00
Danilo Aimini 80f62d0523 LYN-3708 | Optimize Prefab instance propagation to stabilize UX (#700)
* Add instanceToIgnore to calls leading to instances being added to the queue for propagation.

* Change PrefabUndoEntityUpdate to make it so that the instance triggering the prefab template change is not reloaded on propagation, since it will already be up to date due to the way we generated the patch to begin with.

* Add FindPrefabDomValue utility function for paths

* Expose the level root prefab template id in the Prefab EOS Interface

* Fix Instance Alias Path generation to work with the new FindValueInPrefabDom function

* Stop reloading ancestors on propagation, and fix instance reloading so that the level dom is used (and overrides are preserved)

* Remove commented out code, refactor FindPrefabDomValue for paths (was handling an edge case incorrectly, and it's not even triggered)

* Fix issue with PathView reference - with PathView already being a reference, this resulted in a copy and triggered a warning during automated review builds.

* Additional fix to the build warning, remove redundant error message

* Revert changes to Instance::GetAbsoluteInstanceAliasPath(), as they were impacting serialization.

* Remove the dependency to the level root prefab template in the propagation code, climb up the hierarchy instead. This allows tests to work despite not using the EOS properly.
Also use PrefabDomPaths to retrieve the instance dom from the root dom instead of iterating.

* Remove now unused PrefabDomUtils function, extend optimization to link updates.

* Trigger a full instance propagation to correctly refresh alias references.
This is an issue in the test because some operations are called from the backend API and will not trigger propagation properly. Tests will soon be rewritten to more properly represent frontend workflows.

* Fixes lingering issues with propagation:
- Restores code that fixes the selection if entityIds have changed;
- Fixes Do() function on link update. Prefab containers will propagate correctly while still being stable during editing.

* Remove GetRootPrefabInstanceTemplateId (no longer necessary after the code has been rewritten)

* Fix optimization code to account for instances being removed and propagation being run out of order in Create Prefab undo.

* Renamed variable, added comments for clarity.

* Restore asserts on instance not being found; Rename Do to Redo for clarity; Add comments.

* Fixed incomplete comment.
2021-06-08 10:44:20 -07:00
amzn-sean 47e5c72f2e fixed missing methods in SC from Trigger and Collision events (#1185) 2021-06-08 18:20:34 +01:00
Danilo Aimini 2d1e47793d Move Duplicate menu items and shortcuts out of the Prefab Wip flag
Make duplicate prefab workflows available by default in Prefab mode.
2021-06-08 10:06:25 -07:00
Terry Michaels 0fcd6e84ec Added mechanism for viewpanes to request buttons on the main toolbar (#1189) 2021-06-08 12:02:02 -05:00
sharmajs-amzn b24c83122e fixes for missing dependency tests (#1141) 2021-06-08 09:52:17 -07:00
amzn-sean 937118f0a1 physxdebug switch viewport id to AzFramework::g_defaultSceneEntityDebugDisplayId (#1188) 2021-06-08 17:49:52 +01:00
Scott Romero 3eb612b652 [main] option for installer upload to s3 (#1173)
Fixed issue with quoted regex when invoking upload_to_s3.py via script
Improved error handling in online install bootstrapper generation commands
2021-06-08 09:30:20 -07:00
Gene Walters 260b2851f3 Merge pull request #1148 from aws-lumberyard-dev/SPEC7174_ReceiveRPCsViaScriptViaEntityId
Allow Script Canvas Users to Listen for RPC Events Via EntityId
2021-06-08 09:23:36 -07:00
greerdv d7cef1acef Merge pull request #1182 from aws-lumberyard-dev/physx_debug_args_fix
fix argument processing for physx debug console commands
2021-06-08 16:11:31 +01:00