Commit Graph

7670 Commits

Author SHA1 Message Date
Guthrie Adams 78f4e0d0de Combined common thumbnail classes
Signed-off-by: Guthrie Adams <guthadam@amazon.com>
2021-10-09 23:57:04 -05:00
Guthrie Adams 44eb0af9e7 Merge branch 'development' into Atom/guthadam/thumbnail_and_preview_refactor 2021-10-09 18:18:54 -05:00
Guthrie Adams 2c6cfdd7dc Implemented support for semi-live previews of materials in the material property inspector.
Changed thumbnailer bus to use const pixmap
Changed capture request call back to use const pixmap instead of image
Replaced scene and pipeline members with constructor parameters
Added material preview renderer to editor material system component with new requests and notifications
Changed material property inspector details group to persistent heading so the preview image widget would not get destroyed during refreshes. But this was also a backlog task.
Changed common preview render camera to use lookat
Moved default asset caching to thumbnail renderer

Signed-off-by: Guthrie Adams <guthadam@amazon.com>
2021-10-09 18:17:50 -05:00
lumberyard-employee-dm 7b1dd01d1d Implemented a deferred LoadLevel queue for the SpawnableLevelSystem (#4561)
* Moved the SettingsRegistryTests.cpp and
SettingsRegistryMergeUtilsTests.cpp to the Settings folder

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Implemented a deferred level load queue, that allows the
SpawnableLevelSystem to re-run the last LoadLevel command that occured
before it was constructed.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Added SettingsRegistryVisitorUtils to reduce Array and Object visitor
boilerplate.

The VisitArray and VisitObject functions allows iteration over each
element of array and object respectively via a callback.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Removed the queuing logic for levels that attempt to load before the SpawnableLevelSystem is available

Only the last level name that could not load is stored off and deferred until the SpawnableLevelsystem is created.

Made the FieldVisitor AggregateTypes constructor protected and added a comment specifying the expected values.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Bring in the SettingsRegistry::Visitor::Visit functions into scope to fix MSVC compilation errors.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Changed the list of supported SettingsRegistry types to visit to an enum to constrain the values to Array and/or Object.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
2021-10-08 20:09:22 -05:00
lumberyard-employee-dm e4d3ab118c Console changes: Added a new SettingsRegistry root key for executing (#4567)
console commands.

The new key is "/O3DE/Autoexec/ConsoleCommands" and the only difference
with the "/Amazon/AzCore/Runtime/ConosleCommands" key is that it isn't
excluded by the SettingsRegistryBuilder.

Due to not being excluded by the SettingsRegistryBuilder this key can be
used to forward console commands to the aggregate
`bootstrap.game.<config>.<platform>.setreg` files.

For GameLauncher specific console commands it is recommend to be put them in
.setreg file that uses the "game" specialization, such as
"autoexec.game.setreg".

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
2021-10-08 17:59:57 -05:00
jromnoa d3f6898ad6 Fixes test_MaterialEditorLaunch_AllRHIOptionsSucceed() test by searching for RHI log lines (#4511)
* double test timeout from 60 seconds to 120 seconds in attempt to fix it for nightly GPU runs

Signed-off-by: jromnoa <jromnoa@amazon.com>

* add a file to launch with the test to ensure we get a full viewport load completed

Signed-off-by: jromnoa <jromnoa@amazon.com>

* fix import error

Signed-off-by: jromnoa <jromnoa@amazon.com>

* remove python error checks

Signed-off-by: jromnoa <jromnoa@amazon.com>

* add new log line specific to each RHI to check for

Signed-off-by: jromnoa <jromnoa@amazon.com>

* remove the new test script as it is no longer needed with our improved log lines check - the viewport logs don't show up in AR for some reason

Signed-off-by: jromnoa <jromnoa@amazon.com>
2021-10-08 15:01:20 -07:00
Brian Herrera 0d576004fe Merge pull request #4577 from aws-lumberyard-dev/pipelines/add-retry-inc-build-util
Add retry config to boto3 clients
2021-10-08 14:27:43 -07:00
Guthrie Adams 56b7ee2bd4 Merge branch 'development' into Atom/guthadam/thumbnail_and_preview_refactor 2021-10-08 16:03:56 -05:00
Guthrie Adams 4c3d7a7e04 Reorganized thumbnail and preview are files into common folder
Signed-off-by: Guthrie Adams <guthadam@amazon.com>
2021-10-08 16:02:57 -05:00
smurly cef4126100 Mesh component parallel test automation P0 (#4562)
* Mesh component P0 automation for parallel testing

Signed-off-by: Scott Murray <scottmur@amazon.com>

* Remove unused imports

Signed-off-by: Scott Murray <scottmur@amazon.com>

* Decorating test classes with test_case_id to corresponding testrail cases

Signed-off-by: Scott Murray <scottmur@amazon.com>
2021-10-08 13:49:51 -07:00
jromnoa de41653d26 remove LY_PROJECTS check in Atom test registrations so that the targets build in project centric builds (#4581)
Signed-off-by: jromnoa <jromnoa@amazon.com>
2021-10-08 13:36:46 -07:00
lumberyard-employee-dm b7c2401056 Added a ThreadDispatch Policy to the EBus code (#4405)
* Added a ThreadDispatch Policy to the EBus code

The ThreadDispatch Policy can be configured by authors of an EBusTraits to
invoke a callback function after an EBus has finished it's dispatching
mechanism on a specific thread.

It takes into account recursive calls as well and will only invoke the
PostDispatch callback after all callstack entries for the current thread
are cleared.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Clang build fix

The Traits type is dependent on the template parameter, therefore the compiler needs to be told that the ThreadDispatchPolicy is a type and not a value.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Fixed DispatchLockGuard cxall in the TerrainWorldRendererComponent.cpp

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Added EBusTrait for configuring the DispatchLockGuard

Removed the ThreadPolicy trait, now that the DispatchLockGuard for the
EBus Context can be configured.

Used the DispatchLockGuard template along with the
IsInDispatchThisThread function to determine when an EBus has finished
dispatching on thread and released it's Context Mutex.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Tweaked comment format for the IsInDispatch function


Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Removed explicit GetContext call from ThreadDispatchTestBus.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Clang EBus Test fix for DispatchLockGuard trait

Due to the clang compiler evalating constants within templates at the time of declaration, the LocklessDispatch value supplied to the template was always false resulting in the LocklessDispatch feature always locking.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
2021-10-08 15:14:22 -05:00
Steve Pham 73f8537030 Fix Issue saving new assets in Asset Editor on Linux (#4537)
* Add helper function to apply a selected file filter from a file dialog to the result filename if needed
* Add platform traits to restrict the use of the helper function on platforms that need to apply it
* Fix building of file filters of multiple extensions for a file type

Signed-off-by: Steve Pham <spham@amazon.com>
2021-10-08 11:41:46 -07:00
Pip Potter 960edf857d LYN-4831: AWCore code cleanup pass, fixing issues with ResolvePath (#4538)
Signed-off-by: rppotter <rppotter@amazon.com>
2021-10-08 11:20:09 -07:00
Stephen Tramer 396edd22fb Merge pull request #4461 from aws-lumberyard-dev/LYN-7080_FixEditorServerConnectionRaceCondition
Fix EditorServer Connection
2021-10-08 11:07:52 -07:00
Junbo Liang a5cd1b55e4 Make the access log bucket optional in the AWSCore CDK application (#4553)
* Make the access log bucket optional in the AWSCore CDK application

Signed-off-by: Junbo Liang <junbo@amazon.com>
2021-10-08 10:37:50 -07:00
brianherrera e256df3f05 Add retry config to boto3 clients
This change makes the inc_build_util script more resilient against transient network issues and issues encountered during node boot-up.

Signed-off-by: brianherrera <briher@amazon.com>
2021-10-08 10:05:50 -07:00
Guthrie Adams 5ff6e9951f Merge pull request #2904 from yuriy0/SkinnedMeshOutputStreamManager_deferred_buffer_init
Make the maximum amount of vmem available for skinning related things…
2021-10-08 11:26:47 -05:00
Terry Michaels 00b938b6a7 Merge pull request #4212 from ppinfel/component-doc-links
Fixes various component's help URL links to correct o3de.org page
2021-10-08 10:30:13 -05:00
Allen Jackson dcadfe6e1f Feature json assetloading assethints (#4554)
* capture assets using SerializedAssetTracker in LoadInstanceFromPrefabDom()
assign assets using asset hints where the asset ID is not valid
switch up SerializedAssetTracker to store pointers instead of copies of Asset<>

Signed-off-by: jackalbe <23512001+jackalbe@users.noreply.github.com>

* PoC for the AssetFixUp strategy


Signed-off-by: jackalbe <23512001+jackalbe@users.noreply.github.com>

* clean up of PoC

Signed-off-by: jackalbe <23512001+jackalbe@users.noreply.github.com>
2021-10-08 09:20:17 -05:00
FiniteStateGit 591854c384 Edit help menu lua documentation link (#4520) 2021-10-08 14:05:24 +01:00
hultonha 2fb4a9d2c3 Add xfail to test that failed in an unrelated development build (#4569)
Signed-off-by: hultonha <hultonha@amazon.co.uk>
2021-10-08 13:13:52 +01:00
Guthrie Adams 76b4dafbb3 Everything compiling again after moving preview renderer to atom tools framework
Signed-off-by: Guthrie Adams <guthadam@amazon.com>
2021-10-08 04:33:45 -05:00
Guthrie Adams 569318e9e1 Moved preview renderer files to atom tools framework
Signed-off-by: Guthrie Adams <guthadam@amazon.com>
2021-10-08 02:56:24 -05:00
Guthrie Adams ab5547fdf7 • Created interface for preview rendering content
• moved all thumbnail classes and registration back to the common feature editor component
• added lighting preset thumbnail as a quick test

Signed-off-by: Guthrie Adams <guthadam@amazon.com>
2021-10-08 02:46:00 -05:00
Guthrie Adams fe7854e5a5 Merge branch 'development' into Atom/guthadam/thumbnail_and_preview_refactor 2021-10-07 21:07:24 -05:00
Guthrie Adams c90e1da475 • Moved everything related to the subject being captured by the preview renderer into a preview render content class which will become an interface in the next iteration
• Extracted all of the thumbnail specific code from the common preview render class as a step towards separating it from the thumbnail system completely
• Created a capture request structure that stores all of the info related to the content being captured and callbacks for success and failure
• Request to capture any kind of content can be added to the renderer using this structure

Signed-off-by: Guthrie Adams <guthadam@amazon.com>
2021-10-07 21:05:10 -05:00
Luis Sempé 6be8c9d622 Merge pull request #4516 from aws-lumberyard-dev/animation/dev/atomRenderViewport
1st check-in for atom render window.
2021-10-07 17:07:38 -07:00
Jeremy Ong e0a1164a92 Merge pull request #4424 from aws-lumberyard-dev/rgba16f/AZJobToIdle
Move Job system towards being used for Idle tasks
2021-10-07 17:31:05 -06:00
Qing Tao e64b9d3536 ATOM-16320 Remove PVRTC and ETC compressor (#4557)
Signed-off-by: Qing Tao <qingtao@amazon.com>
2021-10-07 16:23:13 -07:00
Chris Galvan 2496bc38b5 Merge pull request #4555 from aws-lumberyard-dev/cgalvan/CreateTemplatePreferSanitizedNameForCppFilesContent
Updated create-template logic to prefer the SanitizedCppName when running replacements on cpp file contents.
2021-10-07 18:22:22 -05:00
Chris Galvan 437a4d2d63 Updated engine template unit tests.
Signed-off-by: Chris Galvan <chgalvan@amazon.com>
2021-10-07 17:38:54 -05:00
rhhong 38efd58173 Fix merging issue with camera input
Signed-off-by: rhhong <rhhong@amazon.com>
2021-10-07 14:54:30 -07:00
rgba16f 4b92aa34b7 Updated with PR feedback. Created a common function to calculate the number of worker threads.
Signed-off-by: rgba16f <82187279+rgba16f@users.noreply.github.com>
2021-10-07 16:49:34 -05:00
Tommy Walton 9686ff034f Merge remote-tracking branch 'upstream/development' into SkinnedMeshOutputStreamManager_deferred_buffer_init
Signed-off-by: Tommy Walton <waltont@amazon.com>
2021-10-07 14:22:10 -07:00
rhhong 4d2f65c4d8 code review feedback 2
Signed-off-by: rhhong <rhhong@amazon.com>
2021-10-07 14:20:39 -07:00
rhhong a448caea7c fix broken build
Signed-off-by: rhhong <rhhong@amazon.com>
2021-10-07 14:20:38 -07:00
rhhong 265d3792f0 fix broken build
Signed-off-by: rhhong <rhhong@amazon.com>
2021-10-07 14:20:36 -07:00
rhhong 5fca7ffd86 CR feedback
Signed-off-by: rhhong <rhhong@amazon.com>
2021-10-07 14:20:34 -07:00
rhhong 8897040315 Gems/EMotionFX/Assets/Editor/Layouts/Character2.layout
Signed-off-by: rhhong <rhhong@amazon.com>
2021-10-07 14:20:31 -07:00
rhhong 646369c1b5 update camera naming and behavior after the merge in
Signed-off-by: rhhong <rhhong@amazon.com>
2021-10-07 14:20:29 -07:00
rhhong 10febe2a4b Move some utility class and settings to a setting file.
Signed-off-by: rhhong <rhhong@amazon.com>
2021-10-07 14:20:27 -07:00
rhhong ffa637d115 Code cleanup
Signed-off-by: rhhong <rhhong@amazon.com>
2021-10-07 14:20:24 -07:00
rhhong 47a2240fc3 Using modular camera system to replace the camera entity.
Signed-off-by: rhhong <rhhong@amazon.com>
2021-10-07 14:20:21 -07:00
rhhong 09f9e5c6c3 CR feedback
Signed-off-by: rhhong <rhhong@amazon.com>
2021-10-07 14:20:19 -07:00
rhhong 82bfbd5c98 Add ability to load actor from the ui
Signed-off-by: rhhong <rhhong@amazon.com>
2021-10-07 14:20:16 -07:00
rhhong c463721b52 move the function setactorasset
Signed-off-by: rhhong <rhhong@amazon.com>
2021-10-07 14:20:13 -07:00
rhhong b7900bf646 render an actor
Signed-off-by: rhhong <rhhong@amazon.com>
2021-10-07 14:20:11 -07:00
rhhong d185338978 Code clean
Signed-off-by: rhhong <rhhong@amazon.com>
2021-10-07 14:20:08 -07:00
rhhong cda2bb9d4d Add anim viewport renderer
Signed-off-by: rhhong <rhhong@amazon.com>
2021-10-07 14:20:05 -07:00