bf8422152b
Turn off stdout buffering when connecting to editor-server so that the editor properly gets all the server-logging without having to first fill up a buffer. Allows the logs to pipe instantly for easier debugging, and also fixes a problem where the logs wont reach the editor because the buffer doesn't fill
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-12-17 00:12:21 -08:00
80a216e079
Adding RPC test. Update editor-servers to flush stdout
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-12-08 00:21:02 -08:00
1983e94580
Minor tweak to re-add ';' to LOG
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-12-07 16:27:23 -08:00
b123379380
Properly adding newlines when using LogInternalV; removing the need of hand-placed newlines to AZ_LOG
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-12-07 14:53:59 -08:00
9ae3da7acd
Merge branch 'upstream/development' into LYN-8514_AutomatedReviewServerLogChecks
2021-12-06 11:30:12 -08:00
50f094c51e
Fixing warnings caused by system components not added to serialize context
...
==================================================================
2021-11-30T20:21:23{000000000000395C}[Module Manager] Trace::Warning
D:/projects/lyengine/git/ly-dev/o3de/Code/Framework/AzCore/AzCore/Module/ModuleManager.cpp(34): 'bool __cdecl AZ::ShouldUseSystemComponent(const class AZ::ComponentDescriptor &,const class AZStd::vector<class AZ::Crc32,class AZStd::allocator> &,const class AZ::SerializeContext &)'
2021-11-30T20:21:23{000000000000395C}[Module Manager] Component type MultiplayerToolsSystemComponent not reflected to SerializeContext!
2021-11-30T20:21:23{000000000000395C}[Module Manager] ==================================================================
2021-11-30T20:21:23{000000000000395C}[Module Manager]
==================================================================
2021-11-30T20:21:23{000000000000395C}[Module Manager] Trace::Warning
D:/projects/lyengine/git/ly-dev/o3de/Code/Framework/AzCore/AzCore/Module/ModuleManager.cpp(34): 'bool __cdecl AZ::ShouldUseSystemComponent(const class AZ::ComponentDescriptor &,const class AZStd::vector<class AZ::Crc32,class AZStd::allocator> &,const class AZ::SerializeContext &)'
2021-11-30T20:21:23{000000000000395C}[Module Manager] Component type PythonEditorFuncs not reflected to SerializeContext!
2021-11-30T20:21:23{000000000000395C}[Module Manager] ==================================================================
Signed-off-by: Guthrie Adams <guthadam@amazon.com >
2021-12-02 14:34:36 -06:00
b262909117
Misc whitespace edit
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-12-01 10:06:04 -08:00
c8b631054f
Misc edit to keep an AZLOG_INFO instead of AZPrint. No real difference, but good as an example for pytest
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-12-01 10:04:26 -08:00
78d0a8e54a
Merging latest LYN-8025_PipeEditorServerLogsToEditor
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-11-30 12:08:19 -08:00
8afd47950c
Removing an extra new-line I added by accident
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-11-30 12:01:04 -08:00
6d0ba68b55
Using new GetBool value when checking if we're an editor-server. Clean up MPEditorSystemComponent for unused #includes, and null-checking when piping server logs
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-11-30 11:12:07 -08:00
d786e9d8e2
Merge branch 'LYN-8025_PipeEditorServerLogsToEditor' into LYN-8514_AutomatedReviewServerLogChecks
2021-11-29 18:27:40 -08:00
9c9d2c70f5
Making sure to stop pulling server logs before terminating the server process; otherwise we might be pulling an invalid process-communicator. Updating AZCoreLogSink to also allow for piping warnings/errors/asserts
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-11-29 18:26:31 -08:00
75e8ef8089
Misc cleanup. Making sure ServerLauncher closes if tests fail
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-11-29 13:36:41 -08:00
97b27513e9
Editor is now listening to editor-server stdout so adding newlines to lines we care about. (Editor is separating out the log lines based on newline)
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-11-23 19:27:16 -08:00
ff862a2f20
Fix memory leak of ProcessWatcher
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-11-22 18:56:48 -08:00
02590a1766
AzCoreLogSink will check if it's running in an editor-server and will allow stdouts
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-11-20 14:48:48 -08:00
6005a4e08b
Merging last dev
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-11-19 23:12:59 -08:00
4d161f42df
WiP. fwrites are being stopped by AZCoreLogSink; need a long term solution to work around this...
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-11-15 12:37:21 -08:00
38a03817bb
Removal and Replacement of the CryTimer (gEnv->pTimer) ( #5409 )
...
Replaced and removed the CryTimer (gEnv->pTimer). The new TimeSystem is a merger of the current time functionality found in the engine.
* Rename TimeSystemComponent.h/.cpp to TimeSystem.h/.cpp
* Adding New TimeSystem
* remove old timer cvars
* small improvements to the time system.
- updated parts to use the time conversion functions.
- in AdvanceTickDeltaTimes applying t_simulationTickScale is now uses doubles instead of floats.
* Replace gEnv->pTimer / ITimer usages with TimeSystem
* Updating usages of AZ::TimeMs{ 0 } and AZ::TimeUs{ 0 } to AZ::Time::ZeroTimeMs and AZ::Time::ZeroTimeUs
* red code the CryTimer
* using TimeUs instead of TimeMs is some cases + updating usages of old cvars to new
Signed-off-by: amzn-sean <75276488+amzn-sean@users.noreply.github.com >
2021-11-15 12:11:58 +00:00
fe5aeb9a5f
Merging latest dev
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-11-10 19:41:36 -08:00
d6803d800b
Externed cvars dont get registered with setreg (not sure why). Updating sv_defaultPlayer to grab the variable via console string lookup instead so the proper value is gathered
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-11-10 19:37:11 -08:00
b9f6d1ec9f
Merge pull request #5311 from aws-lumberyard-dev/HierarchiesFixes
...
Fixed client hierarchy construction to check for authority instead of controller
2021-11-10 12:47:43 +00:00
5d5087e0d3
Moving CommunicatorTracePrinter to a place that AP and Multiplayer gem can use it. MultiplayerEditorSystemComponent now watching the server process and pumping the trace printer. Wip; for some reason not all the server logs are reaching the editor
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-11-09 11:11:15 -08:00
7fce5e52a4
PR feedback addressing
...
Signed-off-by: Sergey Pereslavtsev <pereslav@amazon.com >
2021-11-09 17:36:01 +00:00
384d631485
Switch to use the new ComponentApplicationLifecycle system to listen for legacy systems to be ready
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-11-05 12:23:00 -07:00
3973a59d77
Wait to activate the editor-server until CrySystemInitialized so that the logging system is ready. Automated testing listens for these logs
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-11-04 18:37:15 -07:00
54c1b00902
Fixed AR nightly for non-prefab levels where MultiplayerEditorSystemComponent prints an error
...
Signed-off-by: Sergey Pereslavtsev <pereslav@amazon.com >
2021-11-04 14:55:03 +00:00
fa32940205
Adding logs to dedicated-server start up (unable to use for automated testing just yet since remote console cant be connected that early). Adding pytest check to make sure AutomatedTesting.ServerLauncher is running. Moved sveditor_port to MultiplayerEditorConnection since it was never actually getting used when it was in EditorSystemComponent (dedicated servers dont know about editor)
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-11-01 13:01:59 -07:00
2f38873e03
Adding logs for successful steps occurring in the editor-server process. AutomatedTesting will expect these logs and can be helpful to narrow down any test fails
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-10-29 13:55:32 -07:00
6d673643be
Re-merging latest dev after rebasing to fix DCO. Re-resolving conflicts
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-10-28 09:56:01 -07:00
013beafe7e
Minor code warning grammar fix
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-10-28 09:47:15 -07:00
e6650f1ff4
LYN-7655 Fix Race Condition When Launching at Editor-Server ( #4946 )
...
* Fix a race condition where the editor tries to connect to the editor-server before the editor-server is ready (originally discovered on lower-spec Jenkin machines). Change editor-server so that editor waits to receive a EditorServerReadyForInit before trying to send all the level data.
* The editor might not be the connector so make sure to connect to the actual MP simulation even if the editor isn't the editor-server connect (if editorsv_launch=true then the editor-server will connect to the editor)
* Adding warnings if MPEditorConnection cannot find certain cvars
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-10-27 10:38:09 -07:00
eabfed5562
Merge branch 'LYN-7655_MultiplayerEditorToEditorServerConnectionReverse' into LYN-6770_AutomatedTestNetInputs
2021-10-25 14:15:05 -07:00
b4865e32f5
Minor whitespace fix
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-10-25 13:04:20 -07:00
fe071f0736
Adding warnings if MPEditorConnection cannot find certain cvars
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-10-25 12:57:40 -07:00
03e90e7df5
Merge branch 'LYN-7655_MultiplayerEditorToEditorServerConnectionReverse' into LYN-6770_AutomatedTestNetInputs
2021-10-24 23:09:21 -07:00
7de5c17fb6
The editor might not be the connector so make sure to connect to the actual MP simulation even if the editor isn't the editor-server connect (if editorsv_launch=true then the editor-server will connect to the editor)
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-10-24 23:07:58 -07:00
ea4a898d74
Minor, adding some null checks
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-10-23 19:30:51 -07:00
5ade5291b0
Minor code comment edit
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-10-22 17:13:44 -07:00
569dbc7db3
Merge editor-server race condition fix; will test on Jenkins
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-10-22 16:39:04 -07:00
0c5110b1ed
Fix a race condition where the editor tries to connect to the editor-server before the editor-server is ready (originally discovered on lower-spec Jenkin machines). Change editor-server so that editor waits to receive a EditorServerReadyForInit before trying to send all the level data.
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-10-22 16:34:42 -07:00
6b102cadac
Removing hacked Jenkins fix in order to rerun with more logging and get a better idea of why its failing in the first place
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-10-21 09:56:03 -07:00
3a1c377c03
Fix compiler warning
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-10-21 06:23:51 -07:00
b81bf1064f
Noticing the Jenkins machine fails to connect to server before the server logs even begin. Giving the server some time (5 seconds) to boot up before trying to connect to see if that helps
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-10-20 23:33:22 -07:00
322e339543
Printing error if the editor server launcher has not been built. Updating pytest to fail if the serverlauncher does not exist.
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-10-20 11:45:42 -07:00
5e8b6da8b2
Ensure editor server launches with the same render hardware interface as the editor. This way when Automated Review runs the Multiplayer tests with the headless editor, by default the server launcher will also be headless (rhi=null). Also added a cvar to override the default rhi (editorsv_rhi_override); this way if you're in the normal editor with a gui, you can launch a headless server
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-10-19 15:04:46 -07:00
580153b16e
Adding EditorPython methods to Multiplayer gem for launching the editor gamemode with a server. Adding a test for networkinput with scriptcanvas to ensure the autonomous client can create input and that the server can receive and process the input via script canvas.
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-10-18 21:47:40 -07:00
7e6d35b046
small fix to include using <>
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-10-06 20:11:29 -07:00
b464ff966c
merging latest dev + resolving 1 merge conflict
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-10-06 16:53:25 -07:00
Gene Walters
Guthrie Adams
amzn-sean
SergeyAMZN
Sergey Pereslavtsev
Gene Walters