Commit Graph

88 Commits (03adf700fe1dd7c85446266e08f35fe61ba548ee)

Author SHA1 Message Date
Guthrie Adams 50f094c51e Fixing warnings caused by system components not added to serialize context
==================================================================
2021-11-30T20:21:23{000000000000395C}[Module Manager]     Trace::Warning
 D:/projects/lyengine/git/ly-dev/o3de/Code/Framework/AzCore/AzCore/Module/ModuleManager.cpp(34): 'bool __cdecl AZ::ShouldUseSystemComponent(const class AZ::ComponentDescriptor &,const class AZStd::vector<class AZ::Crc32,class AZStd::allocator> &,const class AZ::SerializeContext &)'
2021-11-30T20:21:23{000000000000395C}[Module Manager]     Component type MultiplayerToolsSystemComponent not reflected to SerializeContext!
2021-11-30T20:21:23{000000000000395C}[Module Manager]     ==================================================================
2021-11-30T20:21:23{000000000000395C}[Module Manager]
==================================================================
2021-11-30T20:21:23{000000000000395C}[Module Manager]     Trace::Warning
 D:/projects/lyengine/git/ly-dev/o3de/Code/Framework/AzCore/AzCore/Module/ModuleManager.cpp(34): 'bool __cdecl AZ::ShouldUseSystemComponent(const class AZ::ComponentDescriptor &,const class AZStd::vector<class AZ::Crc32,class AZStd::allocator> &,const class AZ::SerializeContext &)'
2021-11-30T20:21:23{000000000000395C}[Module Manager]     Component type PythonEditorFuncs not reflected to SerializeContext!
2021-11-30T20:21:23{000000000000395C}[Module Manager]     ==================================================================

Signed-off-by: Guthrie Adams <guthadam@amazon.com>
4 years ago
Gene Walters 8afd47950c Removing an extra new-line I added by accident
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters 6d0ba68b55 Using new GetBool value when checking if we're an editor-server. Clean up MPEditorSystemComponent for unused #includes, and null-checking when piping server logs
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters 9c9d2c70f5 Making sure to stop pulling server logs before terminating the server process; otherwise we might be pulling an invalid process-communicator. Updating AZCoreLogSink to also allow for piping warnings/errors/asserts
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters ff862a2f20 Fix memory leak of ProcessWatcher
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters 02590a1766 AzCoreLogSink will check if it's running in an editor-server and will allow stdouts
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters 6005a4e08b Merging last dev
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters 4d161f42df WiP. fwrites are being stopped by AZCoreLogSink; need a long term solution to work around this...
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
amzn-sean 38a03817bb
Removal and Replacement of the CryTimer (gEnv->pTimer) (#5409)
Replaced and removed the CryTimer (gEnv->pTimer). The new TimeSystem is a merger of the current time functionality found in the engine.

* Rename TimeSystemComponent.h/.cpp to TimeSystem.h/.cpp
* Adding New TimeSystem
* remove old timer cvars
* small improvements to the time system.
 - updated parts to use the time conversion functions.
 - in AdvanceTickDeltaTimes applying t_simulationTickScale is now uses doubles instead of floats.
* Replace gEnv->pTimer / ITimer usages with TimeSystem
* Updating usages of AZ::TimeMs{ 0 } and AZ::TimeUs{ 0 } to AZ::Time::ZeroTimeMs and AZ::Time::ZeroTimeUs
* red code the CryTimer
* using TimeUs instead of TimeMs is some cases + updating usages of old cvars to new

Signed-off-by: amzn-sean <75276488+amzn-sean@users.noreply.github.com>
4 years ago
Gene Walters fe5aeb9a5f Merging latest dev
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters d6803d800b Externed cvars dont get registered with setreg (not sure why). Updating sv_defaultPlayer to grab the variable via console string lookup instead so the proper value is gathered
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
SergeyAMZN b9f6d1ec9f
Merge pull request #5311 from aws-lumberyard-dev/HierarchiesFixes
Fixed client hierarchy construction to check for authority instead of controller
4 years ago
Gene Walters 5d5087e0d3 Moving CommunicatorTracePrinter to a place that AP and Multiplayer gem can use it. MultiplayerEditorSystemComponent now watching the server process and pumping the trace printer. Wip; for some reason not all the server logs are reaching the editor
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Sergey Pereslavtsev 7fce5e52a4 PR feedback addressing
Signed-off-by: Sergey Pereslavtsev <pereslav@amazon.com>
4 years ago
Gene Walters 384d631485 Switch to use the new ComponentApplicationLifecycle system to listen for legacy systems to be ready
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters 3973a59d77 Wait to activate the editor-server until CrySystemInitialized so that the logging system is ready. Automated testing listens for these logs
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Sergey Pereslavtsev 54c1b00902 Fixed AR nightly for non-prefab levels where MultiplayerEditorSystemComponent prints an error
Signed-off-by: Sergey Pereslavtsev <pereslav@amazon.com>
4 years ago
Gene Walters fa32940205 Adding logs to dedicated-server start up (unable to use for automated testing just yet since remote console cant be connected that early). Adding pytest check to make sure AutomatedTesting.ServerLauncher is running. Moved sveditor_port to MultiplayerEditorConnection since it was never actually getting used when it was in EditorSystemComponent (dedicated servers dont know about editor)
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters 2f38873e03 Adding logs for successful steps occurring in the editor-server process. AutomatedTesting will expect these logs and can be helpful to narrow down any test fails
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters 6d673643be Re-merging latest dev after rebasing to fix DCO. Re-resolving conflicts
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters 013beafe7e Minor code warning grammar fix
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters e6650f1ff4
LYN-7655 Fix Race Condition When Launching at Editor-Server (#4946)
* Fix a race condition where the editor tries to connect to the editor-server before the editor-server is ready (originally discovered on lower-spec Jenkin machines).  Change editor-server so that editor waits to receive a EditorServerReadyForInit before trying to send all the level data.

* The editor might not be the connector so make sure to connect to the actual MP simulation even if the editor isn't the editor-server connect (if editorsv_launch=true then the editor-server will connect to the editor)

* Adding warnings if MPEditorConnection cannot find certain cvars

Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters eabfed5562 Merge branch 'LYN-7655_MultiplayerEditorToEditorServerConnectionReverse' into LYN-6770_AutomatedTestNetInputs 4 years ago
Gene Walters b4865e32f5 Minor whitespace fix
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters fe071f0736 Adding warnings if MPEditorConnection cannot find certain cvars
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters 03e90e7df5 Merge branch 'LYN-7655_MultiplayerEditorToEditorServerConnectionReverse' into LYN-6770_AutomatedTestNetInputs 4 years ago
Gene Walters 7de5c17fb6 The editor might not be the connector so make sure to connect to the actual MP simulation even if the editor isn't the editor-server connect (if editorsv_launch=true then the editor-server will connect to the editor)
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters ea4a898d74 Minor, adding some null checks
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters 5ade5291b0 Minor code comment edit
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters 569dbc7db3 Merge editor-server race condition fix; will test on Jenkins
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters 0c5110b1ed Fix a race condition where the editor tries to connect to the editor-server before the editor-server is ready (originally discovered on lower-spec Jenkin machines). Change editor-server so that editor waits to receive a EditorServerReadyForInit before trying to send all the level data.
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters 6b102cadac Removing hacked Jenkins fix in order to rerun with more logging and get a better idea of why its failing in the first place
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters 3a1c377c03 Fix compiler warning
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters b81bf1064f Noticing the Jenkins machine fails to connect to server before the server logs even begin. Giving the server some time (5 seconds) to boot up before trying to connect to see if that helps
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters 322e339543 Printing error if the editor server launcher has not been built. Updating pytest to fail if the serverlauncher does not exist.
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters 5e8b6da8b2 Ensure editor server launches with the same render hardware interface as the editor. This way when Automated Review runs the Multiplayer tests with the headless editor, by default the server launcher will also be headless (rhi=null). Also added a cvar to override the default rhi (editorsv_rhi_override); this way if you're in the normal editor with a gui, you can launch a headless server
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters 580153b16e Adding EditorPython methods to Multiplayer gem for launching the editor gamemode with a server. Adding a test for networkinput with scriptcanvas to ensure the autonomous client can create input and that the server can receive and process the input via script canvas.
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters 7e6d35b046 small fix to include using <>
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters b464ff966c merging latest dev + resolving 1 merge conflict
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters 50fe8bc04d pass in AZ::Utils::GetProjectPath().c_str() directly since converting projectpath is not needed
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters d36041d1b7 Update based on feedback. Adding event to MPSystemComponent for receiving a server acceptance packet. The editor system component subscribes to this event and tells the server we're ready for entity updates
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
puvvadar 170a32d667 Merge latest to mp_handshake_conndata
Signed-off-by: puvvadar <puvvadar@amazon.com>
4 years ago
Gene Walters 73891c71b7 Fix EditorServer connection by ensuring that SendReadyForEntityUpdates is only called after a handshake is finished and the editor has accepted the editorserver's connection. Also allow engine-centric projects to use editor-server by passing in the project-path when launching the editor-server. Also allow devs to set sv_defaultPlayerSpawnAsset from inside the editor and it'll be used by the editor-server
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
puvvadar 2811a84187 Move did handshake logic to connection data plus an optimization
Signed-off-by: puvvadar <puvvadar@amazon.com>
4 years ago
kberg-amzn 6e84495975 Changes to make client and entity migration functional, needed in the event of a host quitting necessitating a host migration
Signed-off-by: kberg-amzn <karlberg@amazon.com>
4 years ago
kberg-amzn b1faad8406 Merge remote-tracking branch 'upstream' into ContainerReplicationAndStats 4 years ago
kberg-amzn 99d71cfbc5 Added delta replication and stat tracking to vector and array network property container types, + some minor cleanup I ran into when looking for the best hook points for this functionality
Signed-off-by: kberg-amzn <karlberg@amazon.com>
4 years ago
puvvadar ebbe4b99a4 Add const to some funcs and fix a comment
Signed-off-by: puvvadar <puvvadar@amazon.com>
4 years ago
puvvadar decf15df21 Move packet dispatch to return an enum that includes a pending option
Signed-off-by: puvvadar <puvvadar@amazon.com>
4 years ago
puvvadar 115f669679 Rename timeout functions for readability
Signed-off-by: puvvadar <puvvadar@amazon.com>
5 years ago