Commit Graph

11718 Commits

Author SHA1 Message Date
Danilo Aimini dc6d8ab2ba Fix conversion issues blocking nightly builds.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
2022-02-04 17:21:48 -08:00
Terry Michaels b1df4c90d5 Merge pull request #7440 from aws-lumberyard-dev/antonmic/quickFixForEditor
removing compute queue flag from SSAO
2022-02-04 17:18:50 -06:00
Steve Pham 69e0090a0b Remove -Wno-return-local-addr warning suppression for GCC
- Remove '-Wno-return-local-addr' warning suppression flag for GCC
- Fixed discovered error resulting from -Wreturn-local-addr

Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com>

* Remove extra ws

Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com>
2022-02-04 14:20:09 -08:00
antonmic 5baf7d5147 removing compute queue flag from SSAO since it's causing crashes for some people
Signed-off-by: antonmic <56370189+antonmic@users.noreply.github.com>
2022-02-04 12:46:42 -08:00
AMZN-Phil 4982787043 Merge pull request #7251 from aws-lumberyard-dev/Prism/AdditionalCLIMessages
Catch URLError so that a message can be printed.
2022-02-04 12:10:38 -08:00
Mike Balfour d9ba0af645 SurfacePoint data structure encapsulations (#7413)
* First pass at encapsulating SurfacePointList.
The biggest challenge in optimizing SurfacePointList(s) usage is the overall memory management associated with it. There are M surface points with N surface mask entries created for every input point, which leads to a lot of container reallocation and memory shuffling when processing multiple input points. By encapsulating the list, it should become easier to preallocate the entries, as well as keep "helper data" around for managing the bookkeeping to associate the input points with the output points.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Small fixes and TODO reminders.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Encapsulate surface point creation and separate EnumeratePoints out from modifications.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Start removing SurfacePoint from the exposed API.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Changed SurfacePointList to split out the surface point storage to allow for span<> usage over time.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Removed entity id

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Removed SurfacePoint from SurfaceData, changed all remaining uses to AzFramework::SurfaceData::SurfacePoint.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Encapsulated SurfaceTagWeightMap and renamed to SurfaceTagWeights.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Fixed make file.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Better commenting and parameter naming.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Renamed methods to be more descriptive.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>
2022-02-04 11:27:59 -06:00
Ken Pruiksma ff4412db7c Calculating uv transforms for terrain detail materials (#7375)
Calculating uv transforms for terrain detail materials

This adds support for uv transforms in terrain detail materials. To support this work, the code for generating a matrix from material properties was pulled out of the material functor and put into a new MaterialUtils file in Atom Utils.
2022-02-04 11:01:47 -06:00
galibzon d77403f9df Upgrade AZSLc to version 1.7.35 (#7411)
* Upgrade AZSLc to version 1.7.35 for
Windows, Linux & Mac.

Signed-off-by: galibzon <66021303+galibzon@users.noreply.github.com>
2022-02-04 10:58:42 -06:00
Guthrie Adams 61c2f77287 Merge pull request #7423 from aws-lumberyard-dev/Atom/guthadam/atom_tools_support_automatic_inspector_population_and_nested_groups
Atom Tools: Document system exposes reflected object data
2022-02-04 10:19:53 -06:00
Allen Jackson 76b2932cae {lyn7307} disable saving procedural prefabs in the Editor (#4877)
disable saving procedural prefabs in the Editor since the templates are backed by asset files that will change outside the Editor


Signed-off-by: jackalbe <23512001+jackalbe@users.noreply.github.com>
2022-02-04 08:50:14 -06:00
Guthrie Adams c9c172794e Atom Tools: Document system exposes reflected object data
• This removes a direct dependency on dynamic property groups and data from the document system.
• Added support for names, descriptions, and nesting to dynamic property groups.
• Moved property related functions from base document classes into material editor document classes because dynamic property groups are an implementation detail of the material editor document to support material type flexible data format.
• Change material document to use a table of dynamic property groups instead of a map of properties.
• Added functions to traverse groups and properties.
• This keeps groups and properties organized consistently with the material type file as well as what’s expected in the UI.
• Document data can now be maps directly to the inspector reflective property editors instead of copying one property at a time out of the document and keeping those synchronized.

Signed-off-by: Guthrie Adams <guthadam@amazon.com>
2022-02-03 21:42:27 -06:00
Qing Tao 1e11df5d92 ATOM-17264 ASV: StreamingImageTest crashes (#7415)
Signed-off-by: Qing Tao <55564570+VickyAtAZ@users.noreply.github.com>
2022-02-03 17:32:12 -08:00
antonmic 4216e4cfed Added support for hardware queue class on passes (#7339)
* Added support for hardware queue class on passes. Compute pass data and copy pass data can now specify to run on their appropriate queue.

Signed-off-by: antonmic <56370189+antonmic@users.noreply.github.com>

* addressed PR feedaback

Signed-off-by: antonmic <56370189+antonmic@users.noreply.github.com>

* fixing python test failures on AR

Signed-off-by: antonmic <56370189+antonmic@users.noreply.github.com>
2022-02-03 16:37:42 -08:00
Qing Tao 01892914ea Atom/qingtao/atom 16135 (#7334)
* Changes to AttachmentImage related classes to have better support using render target as texture.
- Updated AttachmentImageAsset to support an unique name which can be used as AttachmentId.
- Functions in ImageSystemInterface to find an AttachmentImage by its unique name.
- Added InsertChild function to ParentPass class so it can insert a child pass at any location.
- Change to ImageAttachmentPreviewPass so it can preview cached pass attachment even the source pass was disabled.

Signed-off-by: Qing Tao <55564570+VickyAtAZ@users.noreply.github.com>
2022-02-03 14:58:58 -08:00
Allen Jackson 02bb73c0b0 {lyn9694} removing abstract nodes from scene graph (#7362)
Removed:
	SceneAPI::DataTypes::IAnimationData
	SceneAPI::DataTypes::IBlendShapeAnimationData
	SceneAPI::DataTypes::IBlendShapeData
	SceneAPI::DataTypes::IBoneData
	SceneAPI::DataTypes::IMaterialData
	SceneAPI::DataTypes::IMeshData

Signed-off-by: Allen Jackson <23512001+jackalbe@users.noreply.github.com>
2022-02-03 16:32:31 -06:00
Allen Jackson c3c79b25c2 {ghi7403} fixing Python PYI symbols on Editor start (#7404)
Fixing Python PYI symbols on Editor start by processing the queue symbols
after the "azlmbr import" step since that is what queues the symbols

Signed-off-by: Allen Jackson <23512001+jackalbe@users.noreply.github.com>
2022-02-03 15:44:17 -06:00
jromnoa 25e5101cdf Merge pull request #7256 from aws-lumberyard-dev/Neil_P0_updates
Updated Light, Grid, and Physical Sky P0 tests
2022-02-03 13:29:24 -08:00
Roman 2560d6b41e Load workspace should activate the graph by default. (#7389)
Signed-off-by: rhhong <rhhong@amazon.com>
2022-02-03 12:08:15 -08:00
Tommy Walton dea89a7539 Removing bitangent flip from ConstructTBN. Tangent.w should only be used for flipping the bitangent when recomputing the bitangent using the cross product of the normal and tangent, not when reading bitangents directly from vertex data. (#7221)
Signed-off-by: Tommy Walton <waltont@amazon.com>
2022-02-03 11:55:44 -08:00
Vincent Liu 74a876ae3b Move multiplayer session interface out of AzFramework library (#7338)
Signed-off-by: onecent1101 <liug@amazon.com>
2022-02-03 11:53:00 -08:00
SuryanshSangwan 58f4a5259a Lua Editor: Prev Document Tab option from the View menu is misspelled #7345 (#7402)
Signed-off-by: suryanshsangwan <sangwansuryansh@gmail.com>
2022-02-03 11:52:23 -08:00
Danilo Aimini 69c8ebd7fb Prefabs UI | Finalize RootAliasPath as a standardized instance handle system, and refactor PrefabFocusHandler to take advantage of it. (#7365)
* Move the RootAliasPath class definition to the Prefab EOS. Introduce utility functions to enable using the path as an instance handler in UI.

Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>

* Refactor the PrefabFocusHandler to use the utility functions that were introduced to the Prefab EOS. Remove the m_instanceFocusHierarchy from the Focus Handler, and simplify calls for performance.

Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>

* Minor adjustments after PR discussion

Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>

* Silly mistake in function simplification. Turns out == and != are different.

Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>

* Fixed doxygen comments

Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>

* Add numeric cast when storing result of AZStd::distance to int.

Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>

* Restore additional checks in FocusOnparentOfFocusedPrefab that got removed during merge.

Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
2022-02-03 11:13:19 -08:00
Tommy Walton f9fc858576 Editor script for assigning a material to all entities (#7219)
* Create an editor script that can be run to assign a material to all entities in the current level.

Signed-off-by: Tommy Walton <waltont@amazon.com>

* Update path to the default debugvertexstreams.material

Signed-off-by: Tommy Walton <waltont@amazon.com>

* Updating the location of the default debugvertexstreams material, which was moved in another PR

Signed-off-by: Tommy Walton <waltont@amazon.com>
2022-02-03 11:01:04 -08:00
Tommy Walton 837d4fde3e Create a debug material type for displaying per-vertex data (#7220)
* Create a debug material type for displaying per-vertex data

Signed-off-by: Tommy Walton <waltont@amazon.com>

* PR feedback. Added color display mode, multiple uv-set support, split tangent/bitangent options into two separate enums, and added a functor for showing only the applicable properties in the UI depending on which vertex stream and uv set are selected.

Signed-off-by: Tommy Walton <waltont@amazon.com>
2022-02-03 11:00:52 -08:00
Tommy Walton 122eef2680 GHI-7125 : Tangent generation updates (#7252)
* Add a settings registry setting for choosing the default tangent generation method. Add another setting that will force scenes to fail to process if they are impacted by GHI-7125. Fix a bug where assets that return a Failure state from the TangentGenerateComponent will still successfully process.

Signed-off-by: Tommy Walton <waltont@amazon.com>

* Update with minor pr feedback

Signed-off-by: Tommy Walton <waltont@amazon.com>

* Update Gems/SceneProcessing/Code/Source/Generation/Components/TangentGenerator/TangentGenerateComponent.cpp

Use the AZ_STRING_FORMAT and AZ_STRING_ARG macros for printing a string_view

Co-authored-by: Chris Burel <burelc@amazon.com>
Signed-off-by: Tommy Walton <waltont@amazon.com>

Co-authored-by: Chris Burel <burelc@amazon.com>
Signed-off-by: Tommy Walton <waltont@amazon.com>
2022-02-03 11:00:23 -08:00
Junbo Liang d88fc40157 Update O3DE to use new version of AWS IoT Device SDK (#7364)
Signed-off-by: Junbo Liang <68558268+junbo75@users.noreply.github.com>
2022-02-03 10:44:54 -08:00
Neil Widmaier 655576cf12 Merge branch 'development' of https://github.com/aws-lumberyard/o3de into Neil_P0_updates 2022-02-03 10:32:31 -08:00
carlitosan 50128e7a7c Fix for Lua properties not loading properly in play-in-editor. (#7369)
* debug information for lua script error

Signed-off-by: carlitosan <82187351+carlitosan@users.noreply.github.com>

* actual fix for script properties not being loaded in play-in-editor unless modified or editor restarted

Signed-off-by: carlitosan <82187351+carlitosan@users.noreply.github.com>

* remove debugging artifacts

Signed-off-by: carlitosan <82187351+carlitosan@users.noreply.github.com>
2022-02-03 10:31:45 -08:00
Neil Widmaier a67671759e Merge branch 'development' of https://github.com/aws-lumberyard/o3de into Neil_P0_updates 2022-02-03 10:03:48 -08:00
Gene Walters be783e2c3c Merge pull request #7324 from aws-lumberyard-dev/LYN-6769_TestingRPCs_AutonToAuth_ServerToAuth
Multiplayer AutomatedTesting: Autonomous->Authority and Server->Authority RPCs
2022-02-03 10:02:22 -08:00
Sean Sweeney 2bdc102f63 Merge pull request #6795 from aws-lumberyard-dev/scspaldi_lytt_improvements
Changed kill to protected.
2022-02-03 10:02:13 -08:00
jckand-amzn eb1aee0230 Finalizing Terrain automated test conversions to utilize prefab system (#7360)
Signed-off-by: jckand-amzn <82226555+jckand-amzn@users.noreply.github.com>
2022-02-03 09:58:53 -08:00
lumberyard-employee-dm 7652369567 Fix find_program not finding host platform programs when using Android (#7385)
There was an issue in CMake where it set the
CMAKE_FIND_USE_SYSTEM_ENVIRONMENT_PATH cache variable to OFF only when
configuring for Android
https://gitlab.kitware.com/cmake/cmake/-/issues/22634

This caused the find_program calls in o3de cmake files to fail.
Such as the call to located the "aws" binary in
cmake/LYPackage_S3Downloader.cmake

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
2022-02-03 11:56:21 -06:00
Danilo Aimini 65e651388c Add tests for FocusOnParentOfFocusedPrefab. Refactor tests to match, and re-enable disabled tests as the fixture now correctly supports the Prefab EOS. (#7372)
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
2022-02-03 08:01:30 -08:00
Allen Jackson e85ec9baf8 {lyn9996} fixes for the default procedural prefab (#7354)
* {lyn9996} adding a default transform for procprefab

adding a default transform for procprefab when the DCC transform is
also a default transform. The import logic is not to create a
transform data node unless there is a delta.

Signed-off-by: Allen Jackson <23512001+jackalbe@users.noreply.github.com>

* cleaning up the code


Signed-off-by: Allen Jackson <23512001+jackalbe@users.noreply.github.com>

* adding unique optimized mesh entries using Mesh Group + Mesh Name
adding blank LOD rule to skip that logic for default proc prefab
unique mesh group names based on file name

Signed-off-by: Allen Jackson <23512001+jackalbe@users.noreply.github.com>

* updated a comment
bumped the scene builder version number
fixed up the mesh asset path for azmodel assets

Signed-off-by: Allen Jackson <23512001+jackalbe@users.noreply.github.com>

* update the proc prefab unit tests

Signed-off-by: Allen Jackson <23512001+jackalbe@users.noreply.github.com>

* fixing SceneProcessing MeshOptimizerComponentTests due to the name changes
in the mesh opt mesh group names now


Signed-off-by: Allen Jackson <23512001+jackalbe@users.noreply.github.com>
2022-02-03 09:00:58 -06:00
amzn-mike 9168fe07f1 Asset Processor: Zero analysis dependency fingerprint verification (#7292)
* Move modtime scanning tests out of APM tests file and into its own file.

Changes were kept to a minimum to get things compiling, this is just a move of code

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Fix rebase compile errors

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Verify dependency fingerprints during Zero Analysis.

This fixes an issue where dependencies that weren't finished processing when AP shuts down would not resume when AP is started back up due to Zero Analysis ignoring dependencies when determining files to skip.
Added unit test for verification

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Fix compile error, make 17 a constexpr

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Fix compile error

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>
2022-02-03 06:50:35 -08:00
Chris Galvan c3e0830586 Merge pull request #7332 from aws-lumberyard-dev/cgalvan/AddedPresetForConvertingGSIImages
Added preset for converting gsi images
2022-02-03 06:01:45 -06:00
Benjamin Jillich ff09b24604 Motion Matching: Fix for nightly build issue (#7392)
Signed-off-by: Benjamin Jillich <jillich@amazon.com>
2022-02-03 12:34:24 +01:00
Benjamin Jillich 67fcf42268 Motion Matching: Bug fixes, adding more class descriptions, automatic target mode for trajectory query#7341
Motion Matching: Fixed several bugs and improved anim graph node RPE layout
* Fixed several crashes that happened when adjusting the cost function in the UI.
* Automatically hide the trajectory path radius and path speed properties when the mode is set to target-based.
* Re-ordered the properties for better grouping.

Motion Matching: Moved discard event check into consolidated IsFrameDiscarded() method
* Moved the extract events call and the check for a discard frame event to the IsFrameDiscarded() function.
* Added class description for the frame database and ported the comments to //! and //<

Motion Matching: Fixed crash on empty KD-tree

Motion Matching: Automatic target mode for trajectory query
* Consolidated the different automatic path generation modes into a single automatic demo mode.
* Moved the static phase variable to a member so that multiple instances won't follow the same path and speedup the phase increment.

Motion Matching: Added class description and member comments
* Added description for Feature, FeatureMatrix, FeatureTrajectory classes.
* Changed default residual type to absolute as that results in better visual quality.
* Moved to //! doxygen style code to not affect /**/ sourounding temporary code commenting.
2022-02-03 09:18:36 +01:00
Gene Walters f1680daa96 Small log change based on feedback
Signed-off-by: Gene Walters <genewalt@amazon.com>
2022-02-02 16:06:29 -08:00
Neil Widmaier 2ce9db972d Merge branch 'development' of https://github.com/aws-lumberyard/o3de into Neil_P0_updates 2022-02-02 15:10:21 -08:00
Neil Widmaier 57ab6d5e7c making minor variable name changes
Signed-off-by: Neil Widmaier <nwidmaie@amazon.com>
2022-02-02 15:08:54 -08:00
Chris Galvan b4a03ff516 Updated per PR feedback
Signed-off-by: Chris Galvan <chgalvan@amazon.com>
2022-02-02 17:01:51 -06:00
antonmic 611598cd5d Merge pull request #7340 from aws-lumberyard-dev/Atom/antonmic/RenderPipelineTick
Changed how pass system controls pipeline tick rate
2022-02-02 14:36:15 -08:00
scspaldi 92da291bb4 Changed kill() to protected. Changed references from kill() to stop().
Signed-off-by: scspaldi <scspaldi@amazon.com>
2022-02-02 13:32:10 -08:00
Roman 5509764fc2 Make atom render viewport the default for animation editor. (#7282)
* Make atom render viewport the default for animation editor.

Signed-off-by: rhhong <rhhong@amazon.com>

* Fixed the automated test problem caused by making atom vp the default

Signed-off-by: rhhong <rhhong@amazon.com>

* Fix another test failure

Signed-off-by: rhhong <rhhong@amazon.com>

* fix failed test

Signed-off-by: rhhong <rhhong@amazon.com>

* more fix to the automation test

Signed-off-by: rhhong <rhhong@amazon.com>

* we don't need to manuelly call init on the ragdoll plugin anymore

Signed-off-by: rhhong <rhhong@amazon.com>
2022-02-02 11:46:00 -08:00
Jeremy Ong 5c2ce583cd Merge pull request #7356 from aws-lumberyard-dev/Atom/ShaderDefinitions
Add "Definitions" field to shader asset
2022-02-02 12:05:18 -07:00
moudgils 608411ab99 Metal pso caching support via MTLBinaryArchive (#7212)
* PipelineLibrary (PSO Caching) support for Metal

- API changes to handle Metal drivers implictly doing save/load of PipelineLibrary data
- Fixed up code related to Metal device selection
- PipelineLibrary support for Mac and ios

Signed-off-by: moudgils <moudgils@amazon.com>

* Fix compile errors for Dx12, Vulkan backend + Unit tests

Signed-off-by: moudgils <47460854+moudgils@users.noreply.github.com>

* Fixed errors related to M1 GPU

Signed-off-by: moudgils <moudgils@amazon.com>

* Fix a minor 'tab' validation issue

Signed-off-by: moudgils <moudgils@amazon.com>

* Addressed feedback

Signed-off-by: moudgils <moudgils@amazon.com>

* Minor feedback

Signed-off-by: moudgils <moudgils@amazon.com>

* Added a few asserts

Signed-off-by: moudgils <47460854+moudgils@users.noreply.github.com>

* Fix a typo

Signed-off-by: moudgils <moudgils@amazon.com>
2022-02-02 10:50:37 -08:00
jromnoa 9a30c5366c Merge pull request #7302 from aws-lumberyard-dev/Atom/scottmur/P1_decal_null
P1 Decal tests for null renderer
2022-02-02 10:43:07 -08:00
antonmic 3d2f9528f2 Merge pull request #6443 from aws-lumberyard-dev/Atom/antonmic/BasePBR
Atom/antonmic/base pbr
2022-02-02 10:35:03 -08:00