Commit Graph

50 Commits

Author SHA1 Message Date
jromnoa 5d9f5ae15a Merge pull request #5564 from aws-lumberyard-dev/Atom/jromnoa/fix-asset-path-calls-to-use-new-asset-test-class
Update asset files, & update golden image files to match new smaller asset file.
2021-11-11 15:32:23 -08:00
jromnoa d7c31184dc add AtomComponentProperties.grid('Secondary Grid Spacing') direct call, remove fmt:on comment
Signed-off-by: jromnoa <80134229+jromnoa@users.noreply.github.com>
2021-11-11 13:57:11 -08:00
jromnoa 01081fea32 update asset called in global skylight test as well
Signed-off-by: jromnoa <80134229+jromnoa@users.noreply.github.com>
2021-11-11 11:55:04 -08:00
Sean Masterson 35cb018d5c Add P0 Look Modification Test
Signed-off-by: Sean Masterson <semaster@amazon.com>
2021-11-11 11:52:53 -08:00
jromnoa 9d93282e42 Merge pull request #5530 from aws-lumberyard-dev/Atom/scottmur/ssao_p0
SSAO component P0 automation
2021-11-11 10:36:22 -08:00
SWMasterson 984ea571f4 Add P0 test for Entity Reference component. (#5456)
Signed-off-by: Sean Masterson <semaster@amazon.com>
2021-11-11 10:32:33 -06:00
jromnoa 99f1783138 Merge branch 'development' into Atom/jromnoa/fix-asset-path-calls-to-use-new-asset-test-class 2021-11-10 15:44:01 -08:00
Scott Murray b202bbfbc9 SSAO component P0 automation
Signed-off-by: Scott Murray <scottmur@amazon.com>
2021-11-10 15:26:32 -08:00
Sean Masterson 901aa217b8 removed unused import and fixed line length
Signed-off-by: Sean Masterson <semaster@amazon.com>
2021-11-08 13:10:55 -08:00
Sean Masterson cd508415ef Removed unused tuple.
Signed-off-by: Sean Masterson <semaster@amazon.com>
2021-11-08 11:57:21 -08:00
Sean Masterson 6242d1ee8e Added P0 test for Diffuse Probe Grid component
Signed-off-by: Sean Masterson <semaster@amazon.com>
2021-11-08 11:19:30 -08:00
jromnoa fc3d2ce94c drop the 'as helper' for TestHelper and re-factor the helper. calls to TestHelper.
Signed-off-by: jromnoa <80134229+jromnoa@users.noreply.github.com>
2021-11-05 16:36:45 -07:00
jromnoa f42c034437 Merge branch 'development' into Atom/jromnoa/fix-asset-path-calls-to-use-new-asset-test-class 2021-11-05 14:11:59 -07:00
Sean Masterson 708582731d Add P0 Deferred Fog Test
Signed-off-by: Sean Masterson <semaster@amazon.com>
2021-11-04 16:56:46 -07:00
jromnoa cf245e0ad3 delete unused TestSuite_Main_Optimized.py file
Signed-off-by: jromnoa <80134229+jromnoa@users.noreply.github.com>
2021-11-04 15:07:21 -07:00
jromnoa 06ac304968 use smaller asset files, fix asset to use asset.id for tests
Signed-off-by: jromnoa <80134229+jromnoa@users.noreply.github.com>
2021-11-04 13:53:27 -07:00
Sean Masterson bbeefe43b8 Added extra line above class Tests
Signed-off-by: Sean Masterson <semaster@amazon.com>
2021-11-04 13:52:54 -07:00
Sean Masterson 64ab8d5956 Add P0 Bloom Test
Signed-off-by: Sean Masterson <semaster@amazon.com>
2021-11-04 13:30:57 -07:00
jromnoa b82ea09a67 remove redundant sandbox test, remove unsued/old hydra script for old log lines test approach
Signed-off-by: jromnoa <80134229+jromnoa@users.noreply.github.com>
2021-11-04 11:54:21 -07:00
jromnoa 2539fb6065 saving initial round of edits for the using the Asset class
Signed-off-by: jromnoa <80134229+jromnoa@users.noreply.github.com>
2021-11-04 11:40:01 -07:00
jromnoa cdf5a0519f Merge pull request #5284 from aws-lumberyard-dev/Atom/semaster/add_hdr_colorgrading_p0
Test parallel P0  HDR Color Grading Component
2021-11-03 19:34:26 -07:00
Sean Masterson 68e2770caf Adding P0 Automation for HDR Color Grading Component
Signed-off-by: Sean Masterson <semaster@amazon.com>
2021-11-03 15:52:39 -07:00
jromnoa f0ba0ff7eb Merge pull request #5033 from aws-lumberyard-dev/Atom/jromnoa/assert-for-screenshot-comparisons
Fixes the test_BasicLevelSetup_SetsUpLevel() test and adds proper asserts for screenshot comparisons.
2021-11-03 12:26:56 -07:00
Neil Widmaier ebfb34733d fixing new line formatting issues
Signed-off-by: Neil Widmaier <nwidmaie@amazon.com>
2021-11-02 16:28:49 -07:00
Neil Widmaier 36b6aed2df fixing function name formatting issues
Signed-off-by: Neil Widmaier <nwidmaie@amazon.com>
2021-11-02 15:21:50 -07:00
Neil Widmaier 3466e51206 fixing formatting issues
Signed-off-by: Neil Widmaier <nwidmaie@amazon.com>
2021-11-02 13:36:44 -07:00
jromnoa a8efd5da95 add the correct paths for Light component test and use the 'Base' level instead of 'auto_test' level to resolve remaining issues with screenshot angles
Signed-off-by: jromnoa <80134229+jromnoa@users.noreply.github.com>
2021-11-01 23:42:14 -07:00
jromnoa 2329e4302f Merge branch 'development' into Atom/jromnoa/assert-for-screenshot-comparisons 2021-11-01 21:10:16 -07:00
Neil Widmaier 4a57b13a0e Adding P0 Occlusion Culling Plane test
Signed-off-by: Neil Widmaier <nwidmaie@amazon.com>
2021-11-01 17:11:07 -07:00
Scott Murray 7536073df0 remove and unused import
Signed-off-by: Scott Murray <scottmur@amazon.com>
2021-10-28 13:36:48 -07:00
Neil Widmaier 308fcd8bf2 Adding the Hydra P0 Grid component test, and including it in the Test_Suite_Main_Optomized.
Signed-off-by: Neil Widmaier <nwidmaie@amazon.com>
2021-10-27 14:53:20 -07:00
jromnoa 6d62dbba76 fixes the basic level GPU test screenshot comparison failure
Signed-off-by: jromnoa <jromnoa@amazon.com>
2021-10-26 18:51:09 -07:00
Scott Murray e28bf7179f test cleanup and adding AtomComponentProperties
Signed-off-by: Scott Murray <scottmur@amazon.com>
2021-10-22 16:17:49 -07:00
jromnoa 267d690171 Merge pull request #4770 from aws-lumberyard-dev/Atom/scottmur/Atom-16561
AtomComponentProperties class for atom_constants to store property paths and other constant values
2021-10-22 11:56:22 -07:00
jromnoa 3fc32675fd removes general.log() checks for pass/fail status as these do not appear in AR and only appear locally
Signed-off-by: jromnoa <jromnoa@amazon.com>
2021-10-21 12:39:09 -07:00
Scott Murray 268b9da857 atom constant component property class
Signed-off-by: Scott Murray <scottmur@amazon.com>
2021-10-18 14:21:34 -07:00
smurly d1d4bf812e P0 PostFX Gradient Weight Modifier component parallel test automation (#4709)
* PostFX Gradient Weight Modifiere component P0 parallel test

Signed-off-by: Scott Murray <scottmur@amazon.com>

* fixing some comment step numbering

Signed-off-by: Scott Murray <scottmur@amazon.com>

* fixing PostFX casing and method camel casing of the test function

Signed-off-by: Scott Murray <scottmur@amazon.com>

* changing the casing of the file name

Signed-off-by: Scott Murray <scottmur@amazon.com>
2021-10-15 09:18:46 -07:00
Scott Murray 408e27e0f1 wait_for_condition added and merged development
Signed-off-by: Scott Murray <scottmur@amazon.com>
2021-10-13 15:01:58 -07:00
Scott Murray 718fc97bb6 changes from review feedback
Signed-off-by: Scott Murray <scottmur@amazon.com>
2021-10-13 12:57:31 -07:00
Artur K 80db67e90a Remove many unused variables and unused setting files (#4607)
* Remove many unused variables and unused setting files

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

* Remove a few more dead config vars

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

* fix android test_ConfigureSettings_DefaultValues_SetsValues

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>
2021-10-12 17:06:15 -05:00
Scott Murray c35b0e5efa fix a test string to indicate PostFX Layer
Signed-off-by: Scott Murray <scottmur@amazon.com>
2021-10-12 13:46:02 -07:00
Scott Murray 4c5906a8d4 PostFX Shape Weight Modifier component P0 parallel test
Signed-off-by: Scott Murray <scottmur@amazon.com>
2021-10-12 13:21:55 -07:00
smurly 7fcaeb16c4 PostFX Layer component P0 parallel test (#4619)
* PostFX Layer component P0 parallel test

Signed-off-by: Scott Murray <scottmur@amazon.com>

* removing an unused import

Signed-off-by: Scott Murray <scottmur@amazon.com>
2021-10-12 14:23:29 -04:00
smurly 9dee92a708 Mateiral component P0 tests editor script (#4585)
Signed-off-by: Scott Murray <scottmur@amazon.com>
2021-10-11 16:09:11 -07:00
smurly cef4126100 Mesh component parallel test automation P0 (#4562)
* Mesh component P0 automation for parallel testing

Signed-off-by: Scott Murray <scottmur@amazon.com>

* Remove unused imports

Signed-off-by: Scott Murray <scottmur@amazon.com>

* Decorating test classes with test_case_id to corresponding testrail cases

Signed-off-by: Scott Murray <scottmur@amazon.com>
2021-10-08 13:49:51 -07:00
smurly cdca77acd1 Reflection Probe component test for parallel execution (#4532)
Signed-off-by: Scott Murray <scottmur@amazon.com>
2021-10-07 10:56:10 -07:00
jromnoa 02b6b1dbf4 First in set of PRs for adding parallel GPU test runs to Atom tests. (#4276)
* add remaining hydra code for test to run using new parallel test classes and interfaces
* fix return value of Secondary Grid Spacing property test for Grid Entity
* Add `or error_tracer.has_asserts` call for better error catching
* make `Tests.viewport_set` test check a `Report.critical_result()` check instead of `Report.result()` check
* add updates from PR feedback: makes constants for re-used component name strings, move test verifications into the Report() call instead of setting first then calling Report(), use builtin math.isclose function over custom function
* remove after_level_load() and split it into several function calls, add screenshot check, cleanup the GPU script and fix the rendering not displaying by setting global_extra_cmdline_args = []
* fixes the viewport Test check and splits up the helper functions into multiple functions
* add comment for global_extra_cmdline_args update in test and rename the zip file to f'screenshots_{formatted_timestamp}.zip'

Signed-off-by: jromnoa <jromnoa@amazon.com>
Co-authored-by: smurly <scottmur@amazon.com>
2021-10-05 20:05:06 -07:00
lumberyard-employee-dm f648cb1fd8 Update the FileIO Aliases (#4186)
* Update the FileIOAlias naming to make the cache, project root and engine
root paths more clear

The alias of `@root@`, `@assets@`, and `@projectplatformcache@` has been
collapsed to `@projectproductassets@`

The alias of `@devroot@` and `@engroot@` has been collapsed to
`@engroot@`

The alias of `@devassets@` and `@projectroot@` has been collapsed to
`@projectroot@`

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated use of devassets and devroot properties in python

Those properties now use projectroot and engroot

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updating the alias @engroot@ alias path comment in each platform specific LocalFileIO_*.cpp file

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Removed hardcoded size of 9 for the product asset alias.

The ResolvePath function now just appends the @projectproductassets@
alias with the input path

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Remove duplicate @projectproductassets@ check in ProcessFileTreeRequest

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Fix for typos in Hydra python test

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated LocalFileIO::Copy call on Windows to use the Unicode aware CopyFileW API

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated the AWSMetreicsGemAllocatorFixture to properly suppress asset
cache write errors for Test file creation.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Removed unneeded call to set the @projectproductasstes@ alias at the bottom of the AssetSeedManagerTest SetUp

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Added a deprecated alias map to the FileIO System

When a deprecated alias is accessed, the FileIO System logs an AZ_Error and indicates the alias that should be used

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated python test scripts to use the projectroot binding

Retrieving the AutomatedTesting project path based on "<devroot>/AutomatedTesting" has been removed.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated references to devroot and devgame within the codebase

The GetAbsoluteDevGameFolderPath functions has been replaced with direct call to AZ::Utils::GetProjectPath
The GetAbsoluteDevRootFolderPath functions has been replaced with direct calls to AZ::Utils::GetEnginePath

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated <engroot>/AutomatedTesting references to projectroot


Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Replaced references that assumes the project path is <engroot>/AutomatedTesting with <projectroot> in the AutomatedTesting python test

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Correct casing in emfxworkspace file


Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Removed newly added AppendPathParts function
Removed the Path constructors which accepts a PathIterable instance

The PathIterable isn't safe to return to a user of the Path class as it might be referencing temporary paths supplied via PathView arguments

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Fixed unused parameter warning

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Undid change to the LexicallyProximate function to set the path result to the base path.

It needs to return the *this path if the pathResult is empty

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Moved the LocalFileIO ConvertToAbsolutePath implementations to AZ::Utils

Fixed the ConvertToAbsolutePath implementation for Unix platforms to use a buffer that is size PATH_MAX(4096 on all our supported Unix platforms).
Because the buffer before was AZ::IO::MaxPathLength which as a size of 1024, this was resulting in the Unix `realpath` function smashing the stack when it converts a path to an absolute path that is longer than 1024 characters

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated the EditorCore.Tests to attach the AZ Environment to the EditorCore shared library that is statically loaded on launch.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Fixed for DeprecatedAlaisesKeyVisitor Visit function causing the non string_view overloads being hidden causing a hidden base class function warning

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Changed the AWSMetricsGemMock to use a temporary for writing test assets

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated the LocalFileIO::ResolvePath function to use HasRootPath to determine if a path starts with a root path such as "D:", "D:/" or "/"

IsAbsolute was not the corect check as the path of "D:" is a relative
path.
To be absolute according to the Windows the path must have a root
directory. i.e "D:/" or "D:\"

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Removed absolute path comment from LocalFile_UnixLike.cpp and LocalFile_Android.cpp FindFiles implementations
Updated the ConvertToAlias to supply an AZ::IO::FixedMaxPath

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Replaced usage of the @projectproductassets@ alias with @engroot@ when referring to the LmbrCentral source folder in the CopyDependencyBuilderTest and the SeedBuilderTests

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated the ScriptCanvas Upgrade Tool to output backed up files to the
Project User Path instead of the engine root

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Fixed whitespacing issues in Application.cpp

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Remove unnecessary creation of a FixedMaxPath in the UpgradeTool.cpp

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Modified testSeedFolder variable in the SeedBuilderTests to use the
@engroot@ alias instead of @projectproductassets@/.. alias when
referring to the LmbrCentral Gem source path

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated references to the Project Asset Cache in the PythonTests.

Those tests no longer use the logic `azlmbr.paths.projectroot / "Cache" / "pc"` to retrieve a path to the cache root but instead the `azlmbr.paths.projectproductassets` constant

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Fixed the FileIO Deprecated Alias test on Windows

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Removing @projectsourceassets@ alias, as it is only used once.

Updated the PhysX EditorSystemComponent.cpp to query the ProjectPath
form the SettingsRegistry.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Replaced @projectproductassets@ alias with @products@

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Rollback changes to the PhysX EditorSystemComponent.cpp

The changes to use the ProjectPath from the SettingsRegistry has been implemented in PR #4497

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
2021-10-05 15:12:53 -05:00
mrieggeramzn 50fabb1bf7 Atom/mriegger/fixupname (#4187)
* Removing atom from the Decal (atom) name
* Decal component can take advantage of non-uniform scale option
* Using the base class nonuniform scale property rather than firing an event
* removing pragma optimize off
* Python tests need the updated name

Signed-off-by: mrieggeramzn <mriegger@amazon.com>
2021-09-21 15:06:55 -07:00
jromnoa fa163f49b9 Re-structure Atom test folders in AutomatedTesting. (#4206)
* move shader asset builder test into test_Atom_MainSuite_Optimized.py, update CMakeLists.txt, and move all imports inside the test class for hydra_ShaderAssetBuilder_RecompilesShaderAsChainOfDependenciesChanges.py

Signed-off-by: jromnoa <jromnoa@amazon.com>

* re-organize the Atom automated test structure to match the new parallel + batched test structures

Signed-off-by: jromnoa <jromnoa@amazon.com>

* fix CMakeLists.txt registrations for test files

Signed-off-by: jromnoa <jromnoa@amazon.com>
2021-09-21 10:55:48 -07:00