Commit Graph

3200 Commits

Author SHA1 Message Date
AMZN-koppersr ccbb0f45f5 Merge branch 'stabilization/2106' into JsonSerialization/UnsupportedWarnings 2021-06-09 12:12:39 -07:00
AMZN-nggieber b26b472bba Fix Editor being opened twice by project (#1213) 2021-06-09 11:59:15 -07:00
AMZN-koppersr 6063e3a391 Simplified Json Serializer registration code
Updated the Json Serializer registeration code in the RegistrationContext.cpp to use try_emplace instead of find + end check + insert.
2021-06-09 11:07:28 -07:00
dmcdiarmid-ly f159de72f5 Merge pull request #1204 from aws-lumberyard-dev/Atom/dmcdiar/ATOM-15670
[ATOM-15670] AtomSampleViewer All RPI Samples Crash On Vulkan
2021-06-09 10:46:14 -07:00
srikappa-amzn 20dc47e6d0 Merge pull request #1198 from aws-lumberyard-dev/Prefab/RemoveFileSizeLimits
Remove file size limits when loading prefabs and prefab-based-levels
2021-06-09 10:05:45 -07:00
carlitosan 52425d0949 Merge pull request #1194 from aws-lumberyard-dev/carlito/stabilization/2106
Fixes for internal if-branch node parser bug  (LYN-4347) and exposing…
2021-06-09 09:57:54 -07:00
amzn-sean 4241eb9c2c fix crash in ragdoll (#1210) 2021-06-09 17:42:16 +01:00
rhongAMZ 3fd2f1305f Selecting and deleting the level prefab root entity crashes editor (#1179)
Early remove the level instance from the entity id list in the delete function and duplicate function.
2021-06-09 09:15:09 -07:00
Doug McDiarmid 432b330d22 Skipped empty unbounded arrays when updating the Vulkan DescriptorSet 2021-06-08 21:24:01 -07:00
srikappa b23c95cab3 Removed the new added flavor of ReadFile and reused existing one 2021-06-08 17:58:59 -07:00
AMZN-koppersr dba1832821 Improved reporting on unsupported types by the Json Serialization
The Json Serialization currently doesn't support AZStd::any, AZStd::variant and AZStd::optional due to various JSON formatting concerns. This wasn't properly reported resulting in confusion about whether the missing functionality is intentional or a bug. This change makes this explicit with an error message.
As this solution uses a custom json serializer to report the issue, an option was added so it's possible to overwrite a serializer for a specific type.
This doesn't mean that the three listed types will never be supported. If/when a suitable format is found an implementation will be added.
2021-06-08 17:53:26 -07:00
Danilo Aimini fd81000d53 Fix the relative path in the Source param for the PrefabLevel_OpensLevelWithEntities prefab (#1196)
* Fixed the relative path in the Source param for the PrefabLevel_OpensLevelWithEntities prefab. Plus bonus capitalization fix.

* Add empty Cached Transform Parent parameter to prevent patch application issues. This will be fixed once prefab sanitation on load is added.
2021-06-08 17:44:30 -07:00
srikappa 9dec723e33 Remove file size limits when loading prefabs and prefab-based-levels 2021-06-08 17:28:23 -07:00
chcurran 8cb6ef0721 Fix tmeplate arg names 2021-06-08 16:39:36 -07:00
chcurran 8d35a4255e Merge branch 'stabilization/2106' of https://github.com/aws-lumberyard/o3de into carlito/stabilization/2106 2021-06-08 16:08:17 -07:00
bosnichd 5f82e5a111 Fix typo. (#1192) 2021-06-08 15:15:20 -06:00
Esteban Papp 4b3d0d1054 LYN-4327 [SDK] External Gem's aren't added to the project solution when using SDK (#1191)
* should pickup the external directories registered by the project

* Add support for AzTest and AzTestRunner in the SDK

* missing IMPORT_LIB

* Moved where .Assets targets get generated so they are visible in the SDK

* generate the Directory.Build.props in the right path

* excluding target on platforms that dont support it
2021-06-08 14:01:50 -07:00
chcurran a766e3af5c Fixes for internal if-branch node parser bug (LYN-4347) and exposing properties for AZStd::tuple (LYN-3910) 2021-06-08 13:54:25 -07:00
Tom Hulton-Harrop dd95d2b02e ensure brute force ray intersection works (#1170)
* ensure brute force ray intersection works in the same space as kd-tree intersection

* add additional tests for ray casts against meshes using brute force approach

* update api and add some additional test cases

* comment tidy-up and other small updates/fixes for ray intersection code

* fix issue with values at the end of a ray
2021-06-08 19:44:33 +01:00
Danilo Aimini 80f62d0523 LYN-3708 | Optimize Prefab instance propagation to stabilize UX (#700)
* Add instanceToIgnore to calls leading to instances being added to the queue for propagation.

* Change PrefabUndoEntityUpdate to make it so that the instance triggering the prefab template change is not reloaded on propagation, since it will already be up to date due to the way we generated the patch to begin with.

* Add FindPrefabDomValue utility function for paths

* Expose the level root prefab template id in the Prefab EOS Interface

* Fix Instance Alias Path generation to work with the new FindValueInPrefabDom function

* Stop reloading ancestors on propagation, and fix instance reloading so that the level dom is used (and overrides are preserved)

* Remove commented out code, refactor FindPrefabDomValue for paths (was handling an edge case incorrectly, and it's not even triggered)

* Fix issue with PathView reference - with PathView already being a reference, this resulted in a copy and triggered a warning during automated review builds.

* Additional fix to the build warning, remove redundant error message

* Revert changes to Instance::GetAbsoluteInstanceAliasPath(), as they were impacting serialization.

* Remove the dependency to the level root prefab template in the propagation code, climb up the hierarchy instead. This allows tests to work despite not using the EOS properly.
Also use PrefabDomPaths to retrieve the instance dom from the root dom instead of iterating.

* Remove now unused PrefabDomUtils function, extend optimization to link updates.

* Trigger a full instance propagation to correctly refresh alias references.
This is an issue in the test because some operations are called from the backend API and will not trigger propagation properly. Tests will soon be rewritten to more properly represent frontend workflows.

* Fixes lingering issues with propagation:
- Restores code that fixes the selection if entityIds have changed;
- Fixes Do() function on link update. Prefab containers will propagate correctly while still being stable during editing.

* Remove GetRootPrefabInstanceTemplateId (no longer necessary after the code has been rewritten)

* Fix optimization code to account for instances being removed and propagation being run out of order in Create Prefab undo.

* Renamed variable, added comments for clarity.

* Restore asserts on instance not being found; Rename Do to Redo for clarity; Add comments.

* Fixed incomplete comment.
2021-06-08 10:44:20 -07:00
amzn-sean 47e5c72f2e fixed missing methods in SC from Trigger and Collision events (#1185) 2021-06-08 18:20:34 +01:00
Danilo Aimini 2d1e47793d Move Duplicate menu items and shortcuts out of the Prefab Wip flag
Make duplicate prefab workflows available by default in Prefab mode.
2021-06-08 10:06:25 -07:00
Terry Michaels 0fcd6e84ec Added mechanism for viewpanes to request buttons on the main toolbar (#1189) 2021-06-08 12:02:02 -05:00
sharmajs-amzn b24c83122e fixes for missing dependency tests (#1141) 2021-06-08 09:52:17 -07:00
amzn-sean 937118f0a1 physxdebug switch viewport id to AzFramework::g_defaultSceneEntityDebugDisplayId (#1188) 2021-06-08 17:49:52 +01:00
Scott Romero 3eb612b652 [main] option for installer upload to s3 (#1173)
Fixed issue with quoted regex when invoking upload_to_s3.py via script
Improved error handling in online install bootstrapper generation commands
2021-06-08 09:30:20 -07:00
Gene Walters 260b2851f3 Merge pull request #1148 from aws-lumberyard-dev/SPEC7174_ReceiveRPCsViaScriptViaEntityId
Allow Script Canvas Users to Listen for RPC Events Via EntityId
2021-06-08 09:23:36 -07:00
greerdv d7cef1acef Merge pull request #1182 from aws-lumberyard-dev/physx_debug_args_fix
fix argument processing for physx debug console commands
2021-06-08 16:11:31 +01:00
Gene Walters be0d0afc67 Merge pull request #1155 from aws-lumberyard-dev/LYN4281_ScriptCanvasNodePaletteSearchIgnoreWhitespace
Graph Canvas Node Palette Search Ignore Whitespace
2021-06-08 07:44:29 -07:00
greerdv bcff7ff698 fix argument processing for physx debug console commands 2021-06-08 14:53:22 +01:00
evanchia-ly-sdets 9a148477e2 Merge pull request #1178 from aws-lumberyard-dev/xml_dir_race_condition
Fixing xml directory race condition on incremental runs
2021-06-08 00:43:21 -07:00
Benjamin Jillich 863aac2cb9 [LYN-3727] Actor Draw Bounds Draw Bounds & [LYN-3725] Actor Draw Skeleton Doesn't Draw Skeleton (#1168)
* [LYN-3727] Actor Draw Bounds Draw Bounds & [LYN-3725] Actor Draw Skeleton Doesn't Draw Skeleton

* Added skeleton, aabb and emfx debug drawing to the actor component.
* Aux geom rendering is flickering as also reported in the Discord channels. Trick with using the scene notification bus did not work as the actor instance is not bound to a given scene as far as I am aware.
2021-06-08 08:41:58 +02:00
Benjamin Jillich 4e79e6004c [LYN-3845] On the Actor component, click on the Animation Editor button, EMFX isn't opening (#1169)
We're opening the Animation Editor now also in case no actor has been chosen yet. In this case the Animation Editor will also just be started without loading any assets.
2021-06-08 07:39:35 +02:00
Alex Peterson 7ca7ad9b72 Fix missing user_tags exception and configure gems button 2021-06-07 19:50:40 -07:00
evanchia b2a6616a31 fixed cwd error 2021-06-07 18:50:21 -07:00
Guthrie Adams 29eb61aaf5 Merge pull request #1174 from aws-lumberyard-dev/Atom/guthadam/ATOM-15701_changed_material_inspector_highlight_color
ATOM-15701 changed material inspector highlight color
2021-06-07 20:42:45 -05:00
evanchia 9afe5225e6 removing wildcard from rmdir, not windows compatible 2021-06-07 18:39:03 -07:00
evanchia 9373c5fd0d Fixing xml directory race condition on incremental runs 2021-06-07 18:31:57 -07:00
guthadam d67628d88c ATOM-15701 changed material inspector highlight color 2021-06-07 18:23:40 -05:00
Terry Michaels 593b679fa3 Main toolbar consolidation and cleanup (#1167)
* Moving menu options around

* Consolidation and moving of toolbar functioanlity

* Fixed non-unity build missing header

* Updated camera icon to the correct one

* Addressed review feedback

* Addressed review feedback

* Moved icons to new folder structure/naming
2021-06-07 18:11:56 -05:00
Esteban Papp 36cb0f6d40 SPEC-7178 Removal of precompiled cpp files (#1171)
* SPEC-7178  Removal of precompiled cpp files

* Missing files...
2021-06-07 15:59:58 -07:00
Jonny Galloway fe152ea8da Merge pull request #1156 from aws-lumberyard-dev/Atom/gallowj/Atom15729
Atom15729 Fixed broken materials
2021-06-07 17:39:39 -05:00
scottr 8aa310dff5 [cpack_installer] option to set upload url via environment variable 2021-06-07 15:29:29 -07:00
scottr 57faa2d377 [cpack_installer] installer upload to s3 2021-06-07 15:15:14 -07:00
gallowj 2ad5a1916d Merge branch 'main' of https://github.com/aws-lumberyard/o3de into Atom/gallowj/Atom15729 2021-06-07 16:36:34 -05:00
amzn-mgwynn 38865c95e2 Merge pull request #1162 from aws-lumberyard-dev/Prism/gem-db
Adding python bindings for modifying project properties
2021-06-07 16:59:10 -04:00
mgwynn 1900a42203 remove const ref from iterator for python object conversion since pybind only returns copies and produces a clang error 2021-06-07 15:43:47 -04:00
AMZN-tpeng 3997f4a875 Merge pull request #1165 from aws-lumberyard-dev/Atom/tonypeng/ATOM-15723
ATOM-15723 [RHI][Vulkan] Set unbounded array support based on physica…
2021-06-07 12:19:19 -07:00
mgwynn b0826c5f9c added tag managerment arguments for CLI to mutually exclusive group 2021-06-07 15:08:18 -04:00
mgwynn 01b200ad42 removing unused define 2021-06-07 14:19:48 -04:00