Commit Graph

3875 Commits

Author SHA1 Message Date
Benjamin Jillich b6a1f62dec EMotion FX: Fix for broken workspaces after asset path change (#4662)
Some days ago an impactful change deprecated @assets@ and @root@ keywords from paths which our workspaces used. Some workspaces used these and were broken. This change makes them backward compatible and loads the assets correctly again. It also auto fixes broken paths that were present in some of the saved workspaces + making sure new workspaces are saved correctly.

Signed-off-by: Benjamin Jillich <jillich@amazon.com>
2021-10-13 18:20:48 +02:00
lumberyard-employee-dm 97e9f4dc7d [LYN-6838] Various Monolithic shutdown fixes for the GameLauncher (#4564)
* Added a stateless allocator which uses AZ_OS_MALLOC/AZ_OS_FREE to
allocate memory for objects in static memory.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated the Maestro and LyShine Anim Nodes to use the
stateless_allocator for its static containers.

This prevents crashes in static de-init due to the SystemAllocator being
destroyed at that poitn

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated the EBus AllocatorType to use the EBusEnvironmentAllocator

Because the EBus Context resides in static memory, the SystemAllocator
lifetime is shorter than the EBus Context.

This results in shutdown crashes in monolithic builds due to all of the
gem modules being linked in as static libraries and the EBus context now
destructing at the point of the executable static de-init, instead of
the module de-init, where the SystemAllocator would still be around.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Fixed an assortment of shutdown issues due to deleting objects after
AZ allocators are no longer available

Fixed the NameDictionary IsReady() function to not assert when the
dictionary when invoked after the environment variable it was stored in
was destroyed.
Updated the NameData destructor to check that the NameDictionary
IsReady() before attempting to remove itself from the dictionary

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Fixed NameDictionary destory workflow, to reset the EnvironmentVariable
instance

Updated the EnvironmentVariable instance to store the NameDictionary as a
value.

Added a rvalue reference `Set` function overload to the
EnvironmentVariable class to support move only types.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Clang 6.0.0 build fixes

The C++17 std::launder feature isn't available in that compiler version

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
2021-10-13 09:38:36 -05:00
Adi Bar-Lev 3af07e5117 Hair - creating parent class for raster pass as prep for ShortCut technique (#4560)
Signed-off-by: Adi-Amazon <barlev@amazon.com>
2021-10-13 09:37:47 -04:00
Benjamin Jillich da1fde8314 ImGui histogram container improvements (#4630)
* Added auto scale mode that uses a running average to expand and shrink the visible vertical range.
* Added option to set the move direction and either push new values to the front of the buffer (left) and make the histogram move to the right or the inverse.
* Changed the camera monitor to use auto scaling as well as the current one was not showing anything because of an outlier.
* Pre-fill the histogram with zeros so that the first pushed sample moves in without horizontal scaling effects which made it hard to read out any information from the histogram.

Signed-off-by: Benjamin Jillich <jillich@amazon.com>
2021-10-13 09:57:15 +02:00
Benjamin Jillich 2b79abb8c4 EMotion FX: A parameter’s text box of Blend Space 2D and 1D Motions only takes one numerical input value including fractions (#4626)
The on value changed event was recevied too often - with every newly typed character. As we're updating elements outside of the value spinbox, we need to wait for the actual done editing signal. This can be achieved by not tracking the keyboard for the spinbox.

Signed-off-by: Benjamin Jillich <jillich@amazon.com>
2021-10-13 09:13:19 +02:00
Luis Sempé 3b78132833 Split StyleHelper.h into a header and source file (#4614)
* Split StyleHelper.h into a header and source file

Signed-off-by: lsemp3d <58790905+lsemp3d@users.noreply.github.com>

* Missing file from commit

Signed-off-by: lsemp3d <58790905+lsemp3d@users.noreply.github.com>

* Removed incorrect path

Signed-off-by: lsemp3d <58790905+lsemp3d@users.noreply.github.com>

* Fixed includes

Signed-off-by: lsemp3d <58790905+lsemp3d@users.noreply.github.com>

* Removed unnecessary comment

Signed-off-by: lsemp3d <58790905+lsemp3d@users.noreply.github.com>

* Missing include

Signed-off-by: lsemp3d <58790905+lsemp3d@users.noreply.github.com>
2021-10-12 15:45:41 -07:00
Artur K 80db67e90a Remove many unused variables and unused setting files (#4607)
* Remove many unused variables and unused setting files

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

* Remove a few more dead config vars

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

* fix android test_ConfigureSettings_DefaultValues_SetsValues

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>
2021-10-12 17:06:15 -05:00
Guthrie Adams f34811c373 Merge pull request #4639 from aws-lumberyard-dev/Atom/guthadam/thumbnail_bus_passes_const_qpixmap
Updated thumbnail notification bus to use const QPixmap&
2021-10-12 16:47:26 -05:00
mrieggeramzn c38c9739da Adding vertexNormal to the Surface structure and using it for shadows (#4617)
* Adding vertex shadow and using it for all shadows
* Fixing small issue with it not being initialized
* Adis recommendations for hair

Signed-off-by: mrieggeramzn <mriegger@amazon.com>
2021-10-12 13:32:47 -07:00
moudgils 5cefd552a6 - Optimize SRG compilation to not update the whole SRG if not needed across all backends (#4499)
- Each resource type is tracked and updated separately
- Added caching ability for Raytracing srg to save ~2ms for a scene containing 100 x 50 vegetation patch

Signed-off-by: moudgils <moudgils@amazon.com>
2021-10-12 13:24:40 -07:00
Guthrie Adams 8487373b0c Updated thumbnail notification bus to use const QPixmap&
Signed-off-by: Guthrie Adams <guthadam@amazon.com>
2021-10-12 14:41:26 -05:00
Adi Bar-Lev 05767f2d2b Atom Timer fix - changed milliseconds to seconds (#4631)
* Atom Timer fix - changed milliseconds to seconds

- Tested on both fog and EyeAdaptation animations - both are the only affected and were broken before
- This is a small fix for pull #3969 that replaced the timer mechanism: https://github.com/o3de/o3de/pull/3969

Signed-off-by: Adi-Amazon <barlev@amazon.com>

* Atom Timer fix - using seconds to begin with and removing obsolete variable

Signed-off-by: Adi-Amazon <barlev@amazon.com>
2021-10-12 15:40:12 -04:00
Junbo Liang 736c2fe27b [O3DE][GameLift] Add client side change for starting and stopping matchmaking (#4536)
* [O3DE][GameLift] Add client side change for starting and stopping matchmaking

Signed-off-by: Junbo Liang <junbo@amazon.com>
2021-10-12 10:41:27 -07:00
Qing Tao 01448c5c49 ATOM-16658 Remove PBSreferenceMaterials gem which is a gem for legacy cry3dengine (#4616)
Signed-off-by: Qing Tao <qingtao@amazon.com>
2021-10-12 09:11:50 -07:00
Roman 129d249cb4 Do not delete the actor instance if it's belong to an entity. (#4624)
Signed-off-by: rhhong <rhhong@amazon.com>
2021-10-12 17:53:30 +02:00
Qing Tao 89e6df1c7f ATOM-16575 clean up image builder presets files (#4611)
ATOM-16575 clean up image builder presets files
Removed unused image builder presets
Deprecating preset UUID and use preset name as unique id
Delete all .exportsettings file which were only used for legacy imageProcessing gem.

Signed-off-by: Qing Tao <qingtao@amazon.com>
2021-10-11 15:18:39 -07:00
Scott Romero a95c609bd8 [development] Migrate Atom CPU timing stats tracking to use global stats profiler (#4549)
This change is a preparation for moving the CPU profiler/visualization system from Atom into its own Gem by removing the dependency on local time tracking object AZ::RHI::CpuTimingStatistics

Full changes include:
- Removed all usage of AZ::RHI::CpuTimingStatistics
-- Replaced with pushing to AZ::Statistics::StatisticalProfilerProxy global instance
- Promoted VariableTimer from AZ::RHI to AZ::Debug
- Removed now unused CpuTimingStatistics.h

Signed-off-by: AMZN-ScottR 24445312+AMZN-ScottR@users.noreply.github.com
2021-10-11 14:00:42 -07:00
Vincent Liu 843f993fc9 Improve ticket tracker workflow for testing (#4610)
* Improve ticket tracker workflow for testing

Signed-off-by: onecent1101 <liug@amazon.com>
2021-10-11 13:17:07 -07:00
Tobias Alexander Franke 091b729183 Do not run SSAO pass when disabled (#3826)
* Define fallback slots when shader is disabled

* Disable SSAO parent pass depending on the settings

* Move SSAO modulation pass into SsaoParent pass so it can be disabled with the rest of SSAO

* Enable SSAO by default

Co-authored-by: Tobias Alexander Franke <tobias.alexander.franke@huawei.com>
2021-10-11 11:48:28 -05:00
hultonha 5c859cb134 Fix camera drift issues (#4576)
* remove some unused code in RenderViewportWidget and make viewing devicePixelRatioF easier

Signed-off-by: hultonha <hultonha@amazon.co.uk>

* updates to how cursor positions are calculate to handle the viewport widget moving

Signed-off-by: hultonha <hultonha@amazon.co.uk>

* remove optional for previous position

Signed-off-by: hultonha <hultonha@amazon.co.uk>

* add test to capture error with moving the widget

Signed-off-by: hultonha <hultonha@amazon.co.uk>

* minor comment updates before publishing PR

Signed-off-by: hultonha <hultonha@amazon.co.uk>
2021-10-11 16:23:24 +01:00
greerdv c3ff1e0cd3 feedback from PR
Signed-off-by: greerdv <greerdv@amazon.com>
2021-10-11 11:15:55 +01:00
greerdv 622a9bc009 merge from development
Signed-off-by: greerdv <greerdv@amazon.com>
2021-10-11 10:23:42 +01:00
Pip Potter 960edf857d LYN-4831: AWCore code cleanup pass, fixing issues with ResolvePath (#4538)
Signed-off-by: rppotter <rppotter@amazon.com>
2021-10-08 11:20:09 -07:00
Stephen Tramer 396edd22fb Merge pull request #4461 from aws-lumberyard-dev/LYN-7080_FixEditorServerConnectionRaceCondition
Fix EditorServer Connection
2021-10-08 11:07:52 -07:00
Junbo Liang a5cd1b55e4 Make the access log bucket optional in the AWSCore CDK application (#4553)
* Make the access log bucket optional in the AWSCore CDK application

Signed-off-by: Junbo Liang <junbo@amazon.com>
2021-10-08 10:37:50 -07:00
Guthrie Adams 5ff6e9951f Merge pull request #2904 from yuriy0/SkinnedMeshOutputStreamManager_deferred_buffer_init
Make the maximum amount of vmem available for skinning related things…
2021-10-08 11:26:47 -05:00
greerdv c562f0a807 small improvements to triangle mesh rigid body warning
Signed-off-by: greerdv <greerdv@amazon.com>
2021-10-08 16:56:53 +01:00
Terry Michaels 00b938b6a7 Merge pull request #4212 from ppinfel/component-doc-links
Fixes various component's help URL links to correct o3de.org page
2021-10-08 10:30:13 -05:00
Luis Sempé 6be8c9d622 Merge pull request #4516 from aws-lumberyard-dev/animation/dev/atomRenderViewport
1st check-in for atom render window.
2021-10-07 17:07:38 -07:00
Qing Tao e64b9d3536 ATOM-16320 Remove PVRTC and ETC compressor (#4557)
Signed-off-by: Qing Tao <qingtao@amazon.com>
2021-10-07 16:23:13 -07:00
rhhong 38efd58173 Fix merging issue with camera input
Signed-off-by: rhhong <rhhong@amazon.com>
2021-10-07 14:54:30 -07:00
Tommy Walton 9686ff034f Merge remote-tracking branch 'upstream/development' into SkinnedMeshOutputStreamManager_deferred_buffer_init
Signed-off-by: Tommy Walton <waltont@amazon.com>
2021-10-07 14:22:10 -07:00
rhhong 4d2f65c4d8 code review feedback 2
Signed-off-by: rhhong <rhhong@amazon.com>
2021-10-07 14:20:39 -07:00
rhhong a448caea7c fix broken build
Signed-off-by: rhhong <rhhong@amazon.com>
2021-10-07 14:20:38 -07:00
rhhong 265d3792f0 fix broken build
Signed-off-by: rhhong <rhhong@amazon.com>
2021-10-07 14:20:36 -07:00
rhhong 5fca7ffd86 CR feedback
Signed-off-by: rhhong <rhhong@amazon.com>
2021-10-07 14:20:34 -07:00
rhhong 8897040315 Gems/EMotionFX/Assets/Editor/Layouts/Character2.layout
Signed-off-by: rhhong <rhhong@amazon.com>
2021-10-07 14:20:31 -07:00
rhhong 646369c1b5 update camera naming and behavior after the merge in
Signed-off-by: rhhong <rhhong@amazon.com>
2021-10-07 14:20:29 -07:00
rhhong 10febe2a4b Move some utility class and settings to a setting file.
Signed-off-by: rhhong <rhhong@amazon.com>
2021-10-07 14:20:27 -07:00
rhhong ffa637d115 Code cleanup
Signed-off-by: rhhong <rhhong@amazon.com>
2021-10-07 14:20:24 -07:00
rhhong 47a2240fc3 Using modular camera system to replace the camera entity.
Signed-off-by: rhhong <rhhong@amazon.com>
2021-10-07 14:20:21 -07:00
rhhong 09f9e5c6c3 CR feedback
Signed-off-by: rhhong <rhhong@amazon.com>
2021-10-07 14:20:19 -07:00
rhhong 82bfbd5c98 Add ability to load actor from the ui
Signed-off-by: rhhong <rhhong@amazon.com>
2021-10-07 14:20:16 -07:00
rhhong c463721b52 move the function setactorasset
Signed-off-by: rhhong <rhhong@amazon.com>
2021-10-07 14:20:13 -07:00
rhhong b7900bf646 render an actor
Signed-off-by: rhhong <rhhong@amazon.com>
2021-10-07 14:20:11 -07:00
rhhong d185338978 Code clean
Signed-off-by: rhhong <rhhong@amazon.com>
2021-10-07 14:20:08 -07:00
rhhong cda2bb9d4d Add anim viewport renderer
Signed-off-by: rhhong <rhhong@amazon.com>
2021-10-07 14:20:05 -07:00
rhhong c4a3162c85 CR feedback - code cleaning
Signed-off-by: rhhong <rhhong@amazon.com>
2021-10-07 14:20:00 -07:00
rhhong af9448d4ea delete auto moc header
Signed-off-by: rhhong <rhhong@amazon.com>
2021-10-07 14:19:55 -07:00
rhhong f2b449c4b9 Registering an empty atom render plugin in the emfxatom gem.
Signed-off-by: rhhong <rhhong@amazon.com>
2021-10-07 14:19:48 -07:00