Esteban Papp
5dfd40d056
Removes leftover from profiler tool
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-02 14:39:38 -08:00
Gene Walters
efcbc7ccd7
Removing code which was supposed to add a newline, but never did. The comment said it was required because of an assumption with Trace, but clearly Trace doesn't make that assumption
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-12-02 14:36:41 -08:00
carlitosan
6bd0308339
Merge remote-tracking branch 'origin/development' into sc-editor-asset-redux
...
Signed-off-by: carlitosan <82187351+carlitosan@users.noreply.github.com >
2021-12-02 14:17:35 -08:00
Esteban Papp
59ef6f983f
Removes Driller from ScriptCanvas
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-02 13:55:00 -08:00
Esteban Papp
de06bb75e5
Fixes some unit tests due to the removal of the MemoryDriller
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-02 12:41:32 -08:00
Esteban Papp
19ddeeded9
Removes ThreadDrillerEvents, replaces handlers with TreadEventBus
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-02 12:40:39 -08:00
Esteban Papp
72f338a689
Fixes for HeapSchema to get a default block if none is passed
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-02 11:55:36 -08:00
Steve Pham
bd1a4a3062
Removed trait AZ_TRAIT_DISABLE_FAILED_INPUT_TESTS
...
* Removed trait AZ_TRAIT_DISABLE_FAILED_INPUT_TESTS (#6078 )
* Added check for gamepad support
* Skip tests that rely on gamepad support on platforms that dont support it
* Use GTEST_SKIP(() if available, otherwise just use SUCCEED()
Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com >
2021-12-02 10:20:55 -08:00
Esteban Papp
8bde44d5fb
Removes TraceMessageDrillerBus
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-02 10:09:42 -08:00
Esteban Papp
1b01ec18b0
Replaces handlers of TraceMessageDrillerBus with handlers of TraceMessageBus
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-02 10:09:39 -08:00
Steve Pham
d89dcff7df
Fix failing zero color conversion test on Linux
...
* Removed AZ_TRAIT_DISABLE_FAILED_ZERO_COLOR_CONVERSION_TEST (#6074 )
* Protect against 'NaN' (divide by zero) for saturation calculations by setting value to zero instead
Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com >
2021-12-02 08:50:03 -08:00
srikappa-amzn
625fca71ab
Prefab/unit tests for deletion ( #6034 )
...
* Added tests for deleting entity under level and other prefabs
Signed-off-by: srikappa-amzn <82230713+srikappa-amzn@users.noreply.github.com >
* Added class comments and improved variable names
Signed-off-by: srikappa-amzn <82230713+srikappa-amzn@users.noreply.github.com >
* Called the reflect function of PrefabFocusHandler from PrefabSystemComponent
Signed-off-by: srikappa-amzn <82230713+srikappa-amzn@users.noreply.github.com >
* Added couple of unit tests around entity and prefab deletion
Signed-off-by: srikappa-amzn <82230713+srikappa-amzn@users.noreply.github.com >
* Used engine root path from settings registry as fake path for prefab creation
Signed-off-by: srikappa-amzn <82230713+srikappa-amzn@users.noreply.github.com >
* Added 2 unit tests around deleting prefabs
Signed-off-by: srikappa-amzn <82230713+srikappa-amzn@users.noreply.github.com >
2021-12-02 08:09:28 -08:00
Michael Pollind
bd1c8ec961
chore: remove duplicate instance of FancyDockingDropZoneConstants ( #5827 )
...
* chore: remove duplicate instance of FancyDockingDropZoneConstants
Signed-off-by: Michael Pollind <mpollind@gmail.com >
* chore: move to namespace
Signed-off-by: Michael Pollind <mpollind@gmail.com >
2021-12-02 09:28:29 +00:00
Esteban Papp
668d1bba1e
Minor cleanup of a unused variable in GridMate related to Driller
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-01 19:27:58 -08:00
Esteban Papp
59714fb31d
Removes MemoryDrillerBus
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-01 19:27:30 -08:00
Esteban Papp
c3f035c4e3
Removes AssetMemoryAnalyzer that relies on the MemoryDrillerBus
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-01 19:08:12 -08:00
Esteban Papp
95ed1015a5
Removes the MemoryDriller
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-01 18:48:07 -08:00
Esteban Papp
075eeee0bd
Removes PlatformMemoryInstrumentation.h and PLATFORM_MEMORY_INSTRUMENTATION_ENABLED
...
This was part of another instrumentation framework that was never fully integrated
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-01 18:47:23 -08:00
Esteban Papp
3f6246ccbe
Removes recording of memory records through the MemoryDriller
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-01 18:21:39 -08:00
Esteban Papp
47de333e94
Removes m_enableDrilling
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-01 16:50:45 -08:00
Nicholas Van Sickle
1aaa267585
Fix one last bit of minor feedback
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-01 16:49:48 -08:00
Nicholas Van Sickle
2dddb97b7c
One last round of stray review feedback I missed
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-01 16:32:23 -08:00
Nicholas Van Sickle
d519d4cb03
Improve performance for both in-place and copy parsing (faster than AZ::JsonSerializationUtils::ReadJsonString now!)
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-01 16:22:48 -08:00
Danilo Aimini
e16781e6b6
LYN-8629 | Read-Only Entities - Setup ( #6059 )
...
* Introduce read-only entity interface, handler and unit tests.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Switch from a push paradigm to a pull paradigm - handlers get to implement logic to determine if an entity should be read-only. This allows multiple systems to weigh into whether an entity is read-only.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Fixed to missing call in test
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Renaming ReadOnlyEntityQueryNotificationBus to ReadOnlyEntityQueryRequestBus for consistency with engine patterns.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-12-01 12:24:49 -08:00
Nicholas Van Sickle
e0508ddefc
Make JsonBackend templated
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-01 12:10:22 -08:00
lumberyard-employee-dm
e8750f8096
Rename sr_regset-file CVar to sr_regset_file ( #6067 )
...
The Legacy Cry XConsole code validates that CVars only contain
underscore and alphanumeric characters via an Assert in `debug`
configurations.
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com >
2021-12-01 13:16:19 -06:00
Gene Walters
d2ee1b92f3
Merge branch 'upstream/development' into LYN-8514_AutomatedReviewServerLogChecks
2021-12-01 08:41:11 -08:00
Gene Walters
7c445d9c7d
Merge pull request #5820 from aws-lumberyard-dev/LYN-8025_PipeEditorServerLogsToEditor
...
Pipe Editor-Server Logs Back to the Editor
2021-12-01 07:36:02 -08:00
amzn-mike
828431f185
Update AssetManager unit tests to not interact with the disk ( #5815 )
...
* Changed AssetManager tests to use memory streams for asset reading/writing
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix compilation on non-unity builds
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fixed handling of path lookups when test folder path is non-empty
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Add more detailed error message for "asset is not loaded"
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Make numThreads a constexpr
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Add FindFile function
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Remove unused lambda capture
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Remove trailing whitespace
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Add size to assert
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
2021-12-01 09:05:35 -06:00
sphrose
786a72cf63
LYN-7376 test_TerrainHeightGradientList_AddRemoveGradients
...
Signed-off-by: sphrose <82213493+sphrose@users.noreply.github.com >
2021-12-01 10:41:45 +00:00
Nicholas Van Sickle
f87021d856
Expose JSON parse flag options
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-11-30 22:08:48 -08:00
Esteban Papp
b5a697cb1c
Merge branch 'development' into memory/benchmarks
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-11-30 18:26:49 -08:00
Esteban Papp
fbd2d60fc1
Fixes for mac
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-11-30 18:15:22 -08:00
Esteban Papp
0f5cb54a38
Fixes Linux build
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-11-30 18:11:08 -08:00
Nicholas Van Sickle
a9c05372d5
API tweaks
...
- Use ref types
- Support using rapidjson::Value in lieu of rapidjson::Document
- Use the existing JSON comparison util function in tests
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-11-30 18:00:59 -08:00
Esteban Papp
f062b563c8
Improving runtime and making the whole duration manageable
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-11-30 17:30:55 -08:00
Esteban Papp
215cb9b52f
Adds mulit-threaded tests
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-11-30 16:06:26 -08:00
Esteban Papp
fb6e6e339f
Add CRC validator ( #5857 )
...
* Adds crc validation checks
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Fixes invalid CRCs
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Changes test to smoke suite
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* excludes some test data from the validator
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* uses pathlib instead of os.path
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* fixes wrong path to test scripts
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Escape not needed
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-11-30 15:07:57 -08:00
Gene Walters
4b079b7608
Merge branch 'upstream/development' into LYN-8514_AutomatedReviewServerLogChecks
2021-11-30 14:34:42 -08:00
Gene Walters
0772664ba0
Merge branch 'LYN-8025_PipeEditorServerLogsToEditor' into LYN-8514_AutomatedReviewServerLogChecks
2021-11-30 14:34:25 -08:00
Gene Walters
530bcb9428
//! for code comments autogen
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-11-30 14:17:02 -08:00
Esteban Papp
febaebc386
PR comment (NULL->nullptr)
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-11-30 13:51:08 -08:00
Nicholas Van Sickle
5dbe9e387b
Address some review feedback, remove DomBackendRegistry
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-11-30 12:10:16 -08:00
lumberyard-employee-dm
879012b1ae
Added the --regset-file option for setreg file loading ( #5768 )
...
The SettingsRegistryMergeUtils.cpp now supports specifying a path to a JSON Merge Patch formated settings registry file via the --regset-file option.
The option supports specify an anchor key to merge the settings underneath that is separated from the filepath via "::"
Ex. `--regset-file="Registry/custom.setreg::/Custom/Anchor"`
An AZ::Console command of "sr_regset-file" has also been added to allow merging of a setting registry file as well.
closes #5767
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com >
2021-11-30 13:03:46 -06:00
Mike Balfour
dc3c126662
GetSurfacePoint - expose to BehaviorContext ( #6017 )
...
* Fix GetSurfacePoint exposure to BehaviorContext.
The previous way of exposing it made it unusable from ScriptCanvas, since the public API uses an "out" parameter. This introduces a private variation of the API that returns the value instead, so that it functions correctly in Script Canvas.
Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com >
* Added descriptive comment.
Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com >
* Addressed PR feedback.
Fixed comment spacing and renamed private methods to remove the need for the typecast.
Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com >
2021-11-30 11:30:00 -06:00
Steve Pham
3a1e6744fb
Save Data linux support ( #6014 )
...
Implementation of SaveData for Linux
Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com >
2021-11-30 08:47:21 -08:00
Scott Romero
12efc84632
[development] minor Profiler gem fixes ( #5473 )
...
Fixed incorrect frame boundary guess when loading a profile capture
Added some missing default initializers
Removed implicit dependency on Atom timing marker constants
Fixed issue with small visualizer viewport bounds when loading a saved capture
Signed-off-by: AMZN-ScottR 24445312+AMZN-ScottR@users.noreply.github.com
2021-11-30 08:27:27 -08:00
srikappa-amzn
4dd9e94bc3
Add tests for deleting an entity from the level and from another prefab ( #5839 )
...
* Added tests for deleting entity under level and other prefabs
Signed-off-by: srikappa-amzn <82230713+srikappa-amzn@users.noreply.github.com >
* Added class comments and improved variable names
Signed-off-by: srikappa-amzn <82230713+srikappa-amzn@users.noreply.github.com >
* Called the reflect function of PrefabFocusHandler from PrefabSystemComponent
Signed-off-by: srikappa-amzn <82230713+srikappa-amzn@users.noreply.github.com >
* Added function comments and made an if statement to be one line
Signed-off-by: srikappa-amzn <82230713+srikappa-amzn@users.noreply.github.com >
2021-11-30 08:20:25 -08:00
rgba16f
768a196b63
Add a way to set the vsync_interval CVar from code ( #5813 )
...
* Add a way to set the render vsync from code
Signed-off-by: rgba16f <82187279+rgba16f@users.noreply.github.com >
* Update change with PR feedback. Missing whitespace plus a comment on why the assignment is outside the value changed check
Signed-off-by: rgba16f <82187279+rgba16f@users.noreply.github.com >
2021-11-30 10:11:26 -06:00
Tom Hulton-Harrop
6908a3e945
Update intersect behavior for positioning entities in the viewport ( #5906 )
...
* update intersect behavior for positioning entities in the viewport and restore SurfaceManipulator
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* tests for surface manipulator from EditorTransformComponentSelection
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* update comments in tests and remove #pragma optimize('', off)@
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* add new file for FindClosestPickIntersection tests
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* add remaining tests for surface manipulator and snap fixes
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* some small updates and polish before PR
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* small updates following PR feedback
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
2021-11-30 15:07:40 +00:00