Removes m_enableDrilling

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

Code/Editor/Lib/Tests/test_CryEditDocPythonBindings.cpp

@@ -30,7 +30,6 @@ namespace CryEditDocPythonBindingsUnitTests
         void SetUp() override
         {
             AzFramework::Application::Descriptor appDesc;
-            appDesc.m_enableDrilling = false;
 
             m_app.Start(appDesc);
             // Without this, the user settings component would attempt to save on finalize/shutdown. Since the file is

Code/Editor/Lib/Tests/test_CryEditPythonBindings.cpp

@@ -32,7 +32,6 @@ namespace CryEditPythonBindingsUnitTests
         void SetUp() override
         {
             AzFramework::Application::Descriptor appDesc;
-            appDesc.m_enableDrilling = false;
 
             m_app.Start(appDesc);
             // Without this, the user settings component would attempt to save on finalize/shutdown. Since the file is

Code/Editor/Lib/Tests/test_DisplaySettingsPythonBindings.cpp

@@ -30,7 +30,6 @@ namespace DisplaySettingsPythonBindingsUnitTests
         void SetUp() override
         {
             AzFramework::Application::Descriptor appDesc;
-            appDesc.m_enableDrilling = false;
 
             m_app.Start(appDesc);
             m_app.RegisterComponentDescriptor(AzToolsFramework::DisplaySettingsPythonFuncsHandler::CreateDescriptor());
@@ -60,7 +59,6 @@ namespace DisplaySettingsPythonBindingsUnitTests
         void SetUp() override
         {
             AzFramework::Application::Descriptor appDesc;
-            appDesc.m_enableDrilling = false;
 
             m_app.Start(appDesc);
             m_app.RegisterComponentDescriptor(AzToolsFramework::DisplaySettingsComponent::CreateDescriptor());

Code/Editor/Lib/Tests/test_EditorPythonBindings.cpp

@@ -87,7 +87,6 @@ namespace EditorPythonBindingsUnitTests
         void SetUp() override
         {
             AzFramework::Application::Descriptor appDesc;
-            appDesc.m_enableDrilling = false;
 
             m_app.Start(appDesc);
             // Without this, the user settings component would attempt to save on finalize/shutdown. Since the file is

Code/Editor/Lib/Tests/test_MainWindowPythonBindings.cpp

@@ -30,7 +30,6 @@ namespace MainWindowPythonBindingsUnitTests
         void SetUp() override
         {
             AzFramework::Application::Descriptor appDesc;
-            appDesc.m_enableDrilling = false;
 
             m_app.Start(appDesc);
             // Without this, the user settings component would attempt to save on finalize/shutdown. Since the file is

Code/Editor/Lib/Tests/test_ObjectManagerPythonBindings.cpp

@@ -30,7 +30,6 @@ namespace ObjectManagerPythonBindingsUnitTests
         void SetUp() override
         {
             AzFramework::Application::Descriptor appDesc;
-            appDesc.m_enableDrilling = false;
 
             m_app.Start(appDesc);
             // Without this, the user settings component would attempt to save on finalize/shutdown. Since the file is

Code/Editor/Lib/Tests/test_TerrainHoleToolPythonBindings.cpp

@@ -31,7 +31,6 @@ namespace TerrainFuncsUnitTests
         void SetUp() override
         {
             AzFramework::Application::Descriptor appDesc;
-            appDesc.m_enableDrilling = false;
 
             m_app.Start(appDesc);
             // Without this, the user settings component would attempt to save on finalize/shutdown. Since the file is

Code/Editor/Lib/Tests/test_TerrainLayerPythonBindings.cpp

@@ -31,7 +31,6 @@ namespace TerrainFuncsUnitTests
         void SetUp() override
         {
             AzFramework::Application::Descriptor appDesc;
-            appDesc.m_enableDrilling = false;
 
             m_app.Start(appDesc);
             // Without this, the user settings component would attempt to save on finalize/shutdown. Since the file is

Code/Editor/Lib/Tests/test_TerrainModifyPythonBindings.cpp

@@ -30,7 +30,6 @@ namespace TerrainModifyPythonBindingsUnitTests
         void SetUp() override
         {
             AzFramework::Application::Descriptor appDesc;
-            appDesc.m_enableDrilling = false;
 
             m_app.Start(appDesc);
             // Without this, the user settings component would attempt to save on finalize/shutdown. Since the file is

Code/Editor/Lib/Tests/test_TerrainPainterPythonBindings.cpp

@@ -31,7 +31,6 @@ namespace TerrainFuncsUnitTests
         void SetUp() override
         {
             AzFramework::Application::Descriptor appDesc;
-            appDesc.m_enableDrilling = false;
 
             m_app.Start(appDesc);
             // Without this, the user settings component would attempt to save on finalize/shutdown. Since the file is

Code/Editor/Lib/Tests/test_TerrainPythonBindings.cpp

@@ -31,7 +31,6 @@ namespace TerrainFuncsUnitTests
         void SetUp() override
         {
             AzFramework::Application::Descriptor appDesc;
-            appDesc.m_enableDrilling = false;
 
             m_app.Start(appDesc);
             // Without this, the user settings component would attempt to save on finalize/shutdown. Since the file is

Code/Editor/Lib/Tests/test_TerrainTexturePythonBindings.cpp

@@ -31,7 +31,6 @@ namespace TerrainFuncsUnitTests
         void SetUp() override
         {
             AzFramework::Application::Descriptor appDesc;
-            appDesc.m_enableDrilling = false;
 
             m_app.Start(appDesc);
             // Without this, the user settings component would attempt to save on finalize/shutdown. Since the file is

Code/Editor/Lib/Tests/test_TrackViewPythonBindings.cpp

@@ -30,7 +30,6 @@ namespace TrackViewPythonBindingsUnitTests
         void SetUp() override
         {
             AzFramework::Application::Descriptor appDesc;
-            appDesc.m_enableDrilling = false;
 
             m_app.Start(appDesc);
             // Without this, the user settings component would attempt to save on finalize/shutdown. Since the file is
@@ -90,7 +89,6 @@ namespace TrackViewPythonBindingsUnitTests
         void SetUp() override
         {
             AzFramework::Application::Descriptor appDesc;
-            appDesc.m_enableDrilling = false;
 
             m_app.Start(appDesc);
             m_app.RegisterComponentDescriptor(AzToolsFramework::TrackViewComponent::CreateDescriptor());

Code/Editor/Lib/Tests/test_ViewPanePythonBindings.cpp

@@ -30,7 +30,6 @@ namespace ViewPaneFuncsUnitTests
         void SetUp() override
         {
             AzFramework::Application::Descriptor appDesc;
-            appDesc.m_enableDrilling = false;
 
             m_app.Start(appDesc);
             // Without this, the user settings component would attempt to save on finalize/shutdown. Since the file is

Code/Editor/Lib/Tests/test_ViewportTitleDlgPythonBindings.cpp

@@ -30,7 +30,6 @@ namespace ViewportTitleDlgFuncsUnitTests
         void SetUp() override
         {
             AzFramework::Application::Descriptor appDesc;
-            appDesc.m_enableDrilling = false;
 
             m_app.Start(appDesc);
             // Without this, the user settings component would attempt to save on finalize/shutdown. Since the file is

Code/Framework/AzCore/AzCore/Component/ComponentApplication.cpp

@@ -156,7 +156,6 @@ namespace AZ
         m_reservedDebug = 0;
         m_recordingMode = Debug::AllocationRecords::RECORD_STACK_IF_NO_FILE_LINE;
         m_stackRecordLevels = 5;
-        m_enableDrilling = false;
         m_useOverrunDetection = false;
         m_useMalloc = false;
     }
@@ -328,7 +327,6 @@ namespace AZ
                 ->Field("blockSize", &Descriptor::m_memoryBlocksByteSize)
                 ->Field("reservedOS", &Descriptor::m_reservedOS)
                 ->Field("reservedDebug", &Descriptor::m_reservedDebug)
-                ->Field("enableDrilling", &Descriptor::m_enableDrilling)
                 ->Field("useOverrunDetection", &Descriptor::m_useOverrunDetection)
                 ->Field("useMalloc", &Descriptor::m_useMalloc)
                 ->Field("allocatorRemappings", &Descriptor::m_allocatorRemappings)
@@ -367,7 +365,6 @@ namespace AZ
                         ->Attribute(Edit::Attributes::Step, &Descriptor::m_pageSize)
                     ->DataElement(Edit::UIHandlers::SpinBox, &Descriptor::m_reservedOS, "OS reserved memory", "System memory reserved for OS (used only when 'Allocate all memory at startup' is true)")
                     ->DataElement(Edit::UIHandlers::SpinBox, &Descriptor::m_reservedDebug, "Memory reserved for debugger", "System memory reserved for Debug allocator, like memory tracking (used only when 'Allocate all memory at startup' is true)")
-                    ->DataElement(Edit::UIHandlers::CheckBox, &Descriptor::m_enableDrilling, "Enable Driller", "Enable Drilling support for the application (ignored in Release builds)")
                     ->DataElement(Edit::UIHandlers::CheckBox, &Descriptor::m_useOverrunDetection, "Use Overrun Detection", "Use the overrun detection memory manager (only available on some platforms, ignored in Release builds)")
                     ->DataElement(Edit::UIHandlers::CheckBox, &Descriptor::m_useMalloc, "Use Malloc", "Use malloc for memory allocations (for memory debugging only, ignored in Release builds)")
                     ;

Code/Framework/AzCore/AzCore/Component/ComponentApplication.h

@@ -143,7 +143,6 @@ namespace AZ
             AZ::u64         m_reservedDebug;            //!< Reserved memory for Debugging (allocation,etc.). Used only when m_grabAllMemory is set to true. (default: 0)
             Debug::AllocationRecords::Mode m_recordingMode; //!< When to record stack traces (default: AZ::Debug::AllocationRecords::RECORD_STACK_IF_NO_FILE_LINE)
             AZ::u64         m_stackRecordLevels;        //!< If stack recording is enabled, how many stack levels to record. (default: 5)
-            bool            m_enableDrilling;           //!< True to enabled drilling support for the application. RegisterDrillers will be called. Ignored in release. (default: true)
             bool            m_useOverrunDetection;      //!< True to use the overrun detection memory management scheme. Only available on some platforms; greatly increases memory consumption.
             bool            m_useMalloc;                //!< True to use malloc instead of the internal memory manager. Intended for debugging purposes only.
 

Code/Framework/AzCore/Tests/Components.cpp

@@ -175,7 +175,6 @@ namespace UnitTest
         ComponentApplication componentApp;
         ComponentApplication::Descriptor desc;
         desc.m_useExistingAllocator = true;
-        desc.m_enableDrilling = false; // we already created a memory driller for the test (AllocatorsFixture)
         ComponentApplication::StartupParameters startupParams;
         startupParams.m_allocator = &AZ::AllocatorInstance<AZ::SystemAllocator>::Get();
         Entity* systemEntity = componentApp.Create(desc, startupParams);
@@ -631,7 +630,6 @@ namespace UnitTest
 
             ComponentApplication::Descriptor desc;
             desc.m_useExistingAllocator = true;
-            desc.m_enableDrilling = false; // we already created a memory driller for the test (AllocatorsFixture in Components)
 
             ComponentApplication::StartupParameters startupParams;
             startupParams.m_allocator = &AZ::AllocatorInstance<AZ::SystemAllocator>::Get();

Code/Framework/AzCore/Tests/Math/TransformTests.cpp

@@ -402,7 +402,6 @@ namespace UnitTest
             AllocatorsFixture::SetUp();
             AZ::ComponentApplication::Descriptor desc;
             desc.m_useExistingAllocator = true;
-            desc.m_enableDrilling = false; // we already created a memory driller for the test (AllocatorsFixture)
             m_app.Create(desc);
         }
 

Code/Framework/AzCore/Tests/StreamerTests.cpp

@@ -258,7 +258,6 @@ namespace AZ
                 m_application = aznew GemTestApplication();
                 AZ::ComponentApplication::Descriptor appDesc;
                 appDesc.m_useExistingAllocator = true;
-                appDesc.m_enableDrilling = false;
                 auto m_systemEntity = m_application->Create(appDesc);
                 m_systemEntity->AddComponent(aznew AZ::StreamerComponent());
                 m_systemEntity->Init();

Code/Framework/AzFramework/Tests/BinToTextEncode.cpp

@@ -34,7 +34,6 @@ namespace UnitTest
             AllocatorInstance<ThreadPoolAllocator>::Create();
             ComponentApplication::Descriptor desc;
             desc.m_useExistingAllocator = true;
-            desc.m_enableDrilling = false; // we already created a memory driller for the test (AllocatorsFixture)
             m_app.Create(desc);
         }
 

Code/Framework/AzFramework/Tests/EntityContext.cpp

@@ -58,7 +58,6 @@ namespace UnitTest
             ComponentApplication app;
             ComponentApplication::Descriptor desc;
             desc.m_useExistingAllocator = true;
-            desc.m_enableDrilling = false; // we already created a memory driller for the test (AllocatorsFixture)
             app.Create(desc);
 
             Data::AssetManager::Instance().RegisterHandler(aznew SliceAssetHandler(app.GetSerializeContext()), AZ::AzTypeInfo<AZ::SliceAsset>::Uuid());

Code/Framework/AzFramework/Tests/FileTagTests.cpp

@@ -83,7 +83,6 @@ namespace UnitTest
             m_data = AZStd::make_unique<StaticData>();
             using namespace  AzFramework::FileTag;
             AZ::ComponentApplication::Descriptor desc;
-            desc.m_enableDrilling = false;
             m_data->m_application.Start(desc);
 
             const char* testAssetRoot = m_tempDirectory.GetDirectory();

Code/Framework/AzFramework/Tests/Scene.cpp

@@ -113,7 +113,6 @@ namespace SceneUnitTest
             m_app.RegisterComponentDescriptor(AZ::StreamerComponent::CreateDescriptor());
 
             AZ::ComponentApplication::Descriptor desc;
-            desc.m_enableDrilling = false; // the unit test framework already adds a driller
             m_systemEntity = m_app.Create(desc);
             m_systemEntity->Init();
 

Code/Framework/AzTest/AzTest/GemTestEnvironment.cpp

@@ -91,7 +91,6 @@ namespace AZ
             m_application = CreateApplicationInstance();
             AZ::ComponentApplication::Descriptor appDesc;
             appDesc.m_useExistingAllocator = true;
-            appDesc.m_enableDrilling = false;
 
             // Set up gems for loading.
             for (const AZStd::string& dynamicModulePath : m_parameters->m_dynamicModulePaths)

Code/Framework/AzToolsFramework/Tests/ComponentAddRemove.cpp

@@ -578,7 +578,6 @@ namespace UnitTest
             AZ::SettingsRegistryMergeUtils::MergeSettingsToRegistry_AddRuntimeFilePaths(*registry);
 
             AzFramework::Application::Descriptor descriptor;
-            descriptor.m_enableDrilling = false;
             m_app.Start(descriptor);
 
             // Without this, the user settings component would attempt to save on finalize/shutdown. Since the file is

Code/Framework/AzToolsFramework/Tests/EntityOwnershipService/EntityOwnershipServiceTestFixture.cpp

@@ -19,7 +19,6 @@ namespace UnitTest
         AllocatorsTestFixture::SetUp();
         AZ::ComponentApplication::Descriptor componentApplicationDescriptor;
         componentApplicationDescriptor.m_useExistingAllocator = true;
-        componentApplicationDescriptor.m_enableDrilling = false; // we already created a memory driller for the test(AllocatorsTestFixture)
         m_app = AZStd::make_unique<EntityOwnershipServiceApplication>();
         m_app->Start(componentApplicationDescriptor);
 

Code/Framework/AzToolsFramework/Tests/EntityTestbed.h

@@ -163,7 +163,6 @@ namespace UnitTest
         void SetupComponentApplication()
         {
             AZ::ComponentApplication::Descriptor desc;
-            desc.m_enableDrilling = true;
             desc.m_allocationRecords = true;
             desc.m_recordingMode = AZ::Debug::AllocationRecords::RECORD_FULL;
             desc.m_stackRecordLevels = 10;

Code/Framework/AzToolsFramework/Tests/TransformComponent.cpp

@@ -43,7 +43,6 @@ namespace UnitTest
             AllocatorsFixture::SetUp();
             ComponentApplication::Descriptor desc;
             desc.m_useExistingAllocator = true;
-            desc.m_enableDrilling = false; // we already created a memory driller for the test (AllocatorsFixture)
 
             m_app.Start(desc);
 

Code/Framework/AzToolsFramework/Tests/UI/EntityPropertyEditorTests.cpp

@@ -53,7 +53,6 @@ namespace UnitTest
 
         ToolsApplication::Descriptor desc;
         desc.m_useExistingAllocator = true;
-        desc.m_enableDrilling = false;
         ToolsApplication::StartupParameters startupParams;
         startupParams.m_allocator = &AZ::AllocatorInstance<AZ::SystemAllocator>::Get();
 

Code/Tools/DeltaCataloger/Tests/tests_main.cpp

@@ -52,7 +52,6 @@ protected:
 
         AZ::ComponentApplication::Descriptor desc;
         desc.m_useExistingAllocator = true;
-        desc.m_enableDrilling = false; // we already created a memory driller for the test (AllocatorsFixture)
         app.Start(desc);
 
         // Without this, the user settings component would attempt to save on finalize/shutdown. Since the file is

Code/Tools/SerializeContextTools/Converter.cpp

@@ -553,8 +553,6 @@ namespace AZ
                 rapidjson::Value(descriptor.m_reservedOS), memoryDoc.GetAllocator());
             memoryDoc.AddMember(rapidjson::StringRef("reservedDebug"),
                 rapidjson::Value(descriptor.m_reservedDebug), memoryDoc.GetAllocator());
-            memoryDoc.AddMember(rapidjson::StringRef("enableDrilling"),
-                rapidjson::Value(descriptor.m_enableDrilling), memoryDoc.GetAllocator());
             documents.emplace_back(AZStd::move(memoryFilePath.Native()), AZStd::move(memoryDoc));
             
             return true;

Gems/AssetMemoryAnalyzer/Code/Tests/AssetMemoryAnalyzerTest.cpp

@@ -27,7 +27,6 @@ protected:
         testalloc = &AZ::AllocatorInstance<AZ::SystemAllocator>::GetAllocator();
         AZ::ComponentApplication::Descriptor desc;
         desc.m_useExistingAllocator = true;
-        desc.m_enableDrilling = false;
         m_app = new (&m_appStorage) AZ::ComponentApplication;
         m_systemEntity = m_app->Create(desc);
         m_app->RegisterComponentDescriptor(AssetMemoryAnalyzerSystemComponent::CreateDescriptor());

Gems/EditorPythonBindings/Code/Tests/PythonTestingUtility.h

@@ -84,7 +84,6 @@ namespace UnitTest
             m_fileIOHelper->m_fileIO.SetAlias("@engroot@", m_engineRoot.c_str());
 
             AzFramework::Application::Descriptor appDesc;
-            appDesc.m_enableDrilling = false;
             m_app.Create(appDesc);
 
             AzFramework::ApplicationRequests::Bus::Handler::BusConnect();

Gems/ScriptCanvasTesting/Code/Source/Framework/ScriptCanvasTestFixture.h

@@ -67,7 +67,6 @@ namespace ScriptCanvasTests
                 {
                     ScriptCanvasEditor::TraceSuppressionBus::Broadcast(&ScriptCanvasEditor::TraceSuppressionRequests::SuppressPrintf, true);
                     AZ::ComponentApplication::Descriptor descriptor;
-                    descriptor.m_enableDrilling = false;
                     descriptor.m_useExistingAllocator = true;
 
                     AZ::DynamicModuleDescriptor dynamicModuleDescriptor;

Gems/ScriptEvents/Code/Tests/ScriptEventsTestFixture.h

@@ -58,7 +58,6 @@ namespace ScriptEventsTests
 
                 {
                     AZ::ComponentApplication::Descriptor descriptor;
-                    descriptor.m_enableDrilling = false; // We'll manage our own driller in these tests
                     descriptor.m_useExistingAllocator = true; // Use the SystemAllocator we own in this test.
 
                     appStartup.m_createStaticModulesCallback =