Commit Graph

2914 Commits

Author SHA1 Message Date
Nicholas Van Sickle 15e0bb1693 Add tests, fix missing bool in Accept and operator[] insert
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com>
2021-12-09 21:37:22 -08:00
Nicholas Van Sickle a2d474cc4f Add some intial tests
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com>
2021-12-09 17:47:01 -08:00
Esteban Papp 947adc0248 Removal of OverrideShim, AP seems to be crashing
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
2021-12-09 17:13:09 -08:00
Nicholas Van Sickle e7c92b5658 Move ValueWriter out, add DeepCompareIsEqual
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com>
2021-12-09 15:25:20 -08:00
Scott Romero e9379c1746 [development] updated editor event handling with respect to imgui (#6114)
Fixes #4366

- Added support for sending text events from the Qt event mapper
- Fixed several issues found while running the Profiler gem in debug
- Added ability to track AZ-consumed events in the Qt event mapper
- Minor clean up to input handling in ImGuiManager
- Select ImGui mouse events can now be properly consumed during AZ-input processing in the editor viewport
- Added tests for the Qt event mapper

Signed-off-by: AMZN-ScottR 24445312+AMZN-ScottR@users.noreply.github.com
2021-12-09 13:58:27 -08:00
amzn-mike c63b4eb905 Removing unused variable and fix typo (#6265)
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>
2021-12-09 12:53:25 -08:00
Chris Galvan e1d36bc445 Merge pull request #6302 from aws-lumberyard-dev/cgalvan/HideViewportManiuplatorsOnReadOnlyEntitiesEdgeCase
Fixed logic for when to cull entities from having their viewport manipulators regenerated.
2021-12-09 14:24:39 -06:00
srikappa-amzn ac03b6f50b Improve error messaging when duplicating entities before they are created (#4922) (#6279)
* Improved error messaging when user tries to duplicate before entities are created

Signed-off-by: srikappa-amzn <82230713+srikappa-amzn@users.noreply.github.com>
2021-12-09 11:25:23 -08:00
Chris Galvan e636ea39e3 Fixed comment casing to match rest of file.
Signed-off-by: Chris Galvan <chgalvan@amazon.com>
2021-12-09 13:15:20 -06:00
Steve Pham 8fd603cd50 Fix failed archive tests on linux and remove trait
- Change the test Archive Folder name, Extract Folder Name, and File List file to be all lowercase to prevent the 'ResolvePath' function in LocalFileIO when executed to cause issues on case sensitive file systems (#6277)
- Fix memory corruption in profile builds on Linux when using AZ::IO::PathView by using AZ::IO::FixedMaxPath instead

Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com>
2021-12-09 10:18:11 -08:00
Chris Galvan 0bccecaa15 Fixed logic for when to cull entities from having their viewport manipulators regenerated.
Signed-off-by: Chris Galvan <chgalvan@amazon.com>
2021-12-09 11:36:39 -06:00
Gene Walters 4b3d1452fd Merge pull request #6066 from aws-lumberyard-dev/LYN-8514_AutomatedReviewServerLogChecks
Updating Multiplayer PyTests To Check Server Logs
2021-12-09 09:15:58 -08:00
Tom Hulton-Harrop c2341a7e3c Fix for change with axis gizmo labels not appearing (#6256)
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>
2021-12-09 09:30:51 +00:00
Tom Hulton-Harrop f62ba7d1a4 Add ComponentApplicationLifecycle::RegisterEvent calls to avoid test console spam (#6245)
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>
2021-12-09 09:30:24 +00:00
Nicholas Van Sickle fada7ace23 Add visitor support to Value
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com>
2021-12-08 22:22:18 -08:00
Esteban Papp b96be71c61 More stability changes, improvement on type usage within the benchmark, cleanup of unstable stats
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
2021-12-08 19:55:55 -08:00
galibzon 76e09a36d9 Make math classes & EntityId visible in Lua Documentation. (#6261)
Small change in behavior context attribute for a few
classes so they become visible when extracting Lua symbols
from the ScriptContextDebug() API.

From:
Attribute(AZ::Script::Attributes::ExcludeFrom,
    AZ::Script::Attributes::ExcludeFlags::All)

To:
Attribute(AZ::Script::Attributes::ExcludeFrom,
    AZ::Script::Attributes::ExcludeFlags::ListOnly)

It seems the previous code was simply trying to hide those symbols from
the Script Canvas node palette. But it was also, seemingly unintentional,
hiding those symbol from Lua Documentation.

Signed-off-by: galibzon <66021303+galibzon@users.noreply.github.com>
2021-12-08 16:51:44 -06:00
Steve Pham 9b480f252e Fix and enable failed gradient signal tests on Linux
* Fix failure reason for PerlinGradientComponent_GoldenTest: non-standard behavior of std::shuffle producing different results across platforms
* Fix failure reason for GradientImageAssetConversionU8SingleScale: Undefined behavior when float casts to a uint8 has overflow

Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com>
2021-12-08 14:28:45 -08:00
Nicholas Van Sickle f36255b22a Initial value implementation
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com>
2021-12-08 13:57:24 -08:00
Chris Galvan fc71f3f81d Merge pull request #6257 from aws-lumberyard-dev/cgalvan/MoreReadOnlyPrefabChanges
Additional read-only prefab workflow changes.
2021-12-08 15:53:33 -06:00
Esteban Papp 0d66278ef7 Makes the recorded benchmark more stable
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
2021-12-08 13:44:15 -08:00
Chris Galvan 1aed839271 Fixed typo.
Signed-off-by: Chris Galvan <chgalvan@amazon.com>
2021-12-08 15:02:41 -06:00
Esteban Papp bb33f906d2 Merge branch 'development' into memory/benchmarks
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
2021-12-08 10:45:48 -08:00
Chris Galvan 9dc32a0381 Additional read-only prefab workflow changes.
Signed-off-by: Chris Galvan <chgalvan@amazon.com>
2021-12-08 12:30:31 -06:00
Steve Pham 558532f094 Process launcher updates (#6183)
* Enable process and ap connection tests on linux
* Updated 'OpenProjectManager' to use new the ProcessLauncher argument type
* Add logic to double-escape escaped double quotes in arguments on windows platforms
* Updated argument for LaunchProjectManager to reflect new ProcessLauncher argument type
* Fixed unit test arguments for 'arg=value' condition
* Fix compile errors for BuilderManager and RHI.Edit\Utils.cpp
* PAL'ify the GetCommandLineParametersAsString() to handle windows specific behavior

Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com>

Co-authored-by: byrcolin <byrcolin@amazon.com>
2021-12-08 09:30:19 -08:00
John Jones-Steele 9e7d5fe52b Test the Terrain World configuration changes when parameters are chan… (#6063)
* Test the Terrain World configuration changes when parameters are changed in the component

Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com>

* Changes from PR

Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com>

* Before merge

Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com>

* Before merge 2

Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com>

* Changes from PR

Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com>

* Change from PR

Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com>

* Change before merge

Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com>

* Change before merge 2

Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com>

* Change before merge 3

Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com>

* Change after merge to fix conflicts

Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com>

* Fix merge conflict

Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com>

* Fix merge conflict

Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com>

* CHanges from PR

Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com>
2021-12-08 14:09:56 +00:00
Tom Hulton-Harrop b54215552c Prevent the camera from easily being set to an invalid orientation (#6203)
* add temporary debug logging

Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>

* improvement for box select sometimes getting stuck on

Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>

* add temporary debug logging

Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>

* improvement for box select sometimes getting stuck on

Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>

* remove temporary logging

Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>

* fixes for camera pitch issues

Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>

* missed file with camera pitch fixes

Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>

* remove debug logs

Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>

* add some tests for new pitch constraint updates

Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>
2021-12-08 09:42:40 +00:00
Tobias Alexander Franke 363007363a In the entity outliner search box, the matching results are not expanded and displayed
Signed-off-by: T.J. McGrath-Daly <tj.mcgrath.daly@huawei.com>
2021-12-08 09:02:05 +00:00
Esteban Papp 3dd8a60034 Merge branch 'development' into memory/benchmarks
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
2021-12-07 18:44:03 -08:00
Esteban Papp f96a466212 WIP trying to use SystemAllocator instead of raw reads
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
2021-12-07 17:58:49 -08:00
Chris Galvan a8ef23e4ae Merge pull request #6232 from aws-lumberyard-dev/cgalvan/ReadOnlyPrefabWorkflowChanges
Some read-only prefab workflow updates.
2021-12-07 19:38:54 -06:00
Danilo Aimini 3a7d9f9b3a LYN-8633 | Read-Only Entities - Entity Outliner behavior changes (#6230)
* Add invalid entityId check to IsReadOnly

Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>

* Ensure read-only entities editing is limited (no renaming, limited drag/drop, no asset drop on them)

Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>

* Removing redundant class definition in wrong namespace.

Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
2021-12-07 16:58:29 -08:00
Gene Walters f97707a28a Removing hand-written /n from all AZLOG_ now that we properly add \n automatically
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-12-07 16:14:08 -08:00
Esteban Papp da5ec1f478 Merge branch 'development' into memory/benchmarks
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
2021-12-07 15:47:29 -08:00
lsemp3d 72bfd8bdf8 Script Canvas node translation system and naming consistency
Signed-off-by: lsemp3d <58790905+lsemp3d@users.noreply.github.com>
2021-12-07 15:40:04 -08:00
Chris Galvan 6532c50c27 Some read-only prefab workflow updates.
Signed-off-by: Chris Galvan <chgalvan@amazon.com>
2021-12-07 17:22:10 -06:00
Gene Walters b123379380 Properly adding newlines when using LogInternalV; removing the need of hand-placed newlines to AZ_LOG
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-12-07 14:53:59 -08:00
Esteban Papp 5cca52e73c Merge branch 'development' into redcode/driller_removal
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

# Conflicts:
#	Code/Framework/AzCore/AzCore/azcore_files.cmake
#	Gems/Atom/Feature/Common/Assets/Materials/Presets/MacBeth/15_red_sRGB.tif
2021-12-07 13:31:55 -08:00
Esteban Papp cd5306febf Merging from development
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
2021-12-07 12:35:41 -08:00
Nicholas Van Sickle 3d8664ee92 Merge pull request #5511 from aws-lumberyard-dev/nvsickle/GenericDomJson
Generic DOM: Add DomBackend abstraction and JSON support
2021-12-07 11:20:53 -08:00
amzn-mike 7c96bc4f1f Fix loaded procprefabs not going through the asset hint fixup process… (#6077)
* Fix loaded procprefabs not going through the asset hint fixup process for all versions of LoadInstanceFromPrefabDom.

Fixes procprefab asset references not working when pressing Ctrl+G in the editor

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Add unit test

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Add missing include

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>
2021-12-07 13:00:47 -06:00
carlitosan 4b97f7bac2 Merge pull request #5296 from aws-lumberyard-dev/sc-editor-asset-redux
Sc editor asset redux
2021-12-07 09:15:52 -08:00
Esteban Papp 4b07665496 Removes Heap allocator from being possible to use as a SystemAllocator since it doesnt allow dynamic allocating (only works with pre-allocated blocks)
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
2021-12-06 18:35:39 -08:00
Esteban Papp cf9aab9911 Adds recording functionality (disabled) and a benchmark that can run recordings
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
2021-12-06 18:34:52 -08:00
Nicholas Van Sickle 6cf805256b Make backend write API string-based
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com>
2021-12-06 15:55:35 -08:00
Danilo Aimini 6e0ac97f13 Merge pull request #6178 from aws-lumberyard-dev/daimini/gitflow_211206_o3de
Merged `stabilization/2111RTE` to `development`
2021-12-06 15:51:01 -08:00
Danilo Aimini efe63f3e95 Merge commit 'c5615f812ccc9d235747a1c5ba396ac2e9a23690' into daimini/gitflow_211206_o3de
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>

# Conflicts:
#	Code/Framework/AzToolsFramework/Tests/Prefab/PrefabTestFixture.cpp
#	Code/Framework/AzToolsFramework/Tests/Prefab/PrefabTestFixture.h
#	Code/Framework/AzToolsFramework/Tests/UI/EntityOutlinerTests.cpp
2021-12-06 13:14:14 -08:00
Chris Galvan d04f4d238c Merge branch 'development' of https://github.com/o3de/o3de into cgalvan/ReadOnlyViewportChanges 2021-12-06 14:24:19 -06:00
carlitosan 15e26b7515 merge development
Signed-off-by: carlitosan <82187351+carlitosan@users.noreply.github.com>
2021-12-06 12:21:45 -08:00
Chris Galvan 10e95cd863 Updated logic to use AZStd::erase_if
Signed-off-by: Chris Galvan <chgalvan@amazon.com>
2021-12-06 14:21:00 -06:00