Commit Graph

8538 Commits

Author SHA1 Message Date
sphrose 398decd06e review changes
Signed-off-by: sphrose <82213493+sphrose@users.noreply.github.com>
2021-11-11 12:57:48 +00:00
sphrose c3093edffe Redoing tests that got lost when TerrainPhysicsManager was merged.
Signed-off-by: sphrose <82213493+sphrose@users.noreply.github.com>
2021-11-11 12:12:18 +00:00
galibzon f24c3d3457 ASV Trace::Assert Environment.h(438) You are using an invalid variable, (#5521)
the owner has removed it!

This fixes the issue by forcing NameDictionary to not transfer
ownership. This means ComponentApplication()::Destroy will fully destroy
the NameDictionary before the OS::Allocator is destroyed.

In Windows the bug was not happening when running AssetProcessorBatch
because for Windows, _exit() is called before the application shutsdown
forcing all module to properly decrease the reference count of
EnvironmentVaqriableHolderBase::m_useCount for NameDictionary.

In MacOS, there's no _exit() so when the NameDictionary destructor was being called
before existing the application the reference count wouldn't be 0, and
would eventually try to destry the NameDictionary BUT the OS::Allocator
was already destroyed.

Signed-off-by: galibzon <66021303+galibzon@users.noreply.github.com>
2021-11-11 05:24:33 -06:00
SergeyAMZN e5dbd0a2a9 Merge pull request #5467 from aws-lumberyard-dev/LYN-7815_RPCCompilationFix
Fix to Allow Compiling the 4 Types of RPCs
2021-11-11 11:06:59 +00:00
greerdv d65f863cec Merge pull request #5510 from aws-lumberyard-dev/prevent-invalid-twist-limits
prevent twist limits being created with equal lower and upper limits
2021-11-11 10:28:28 +00:00
moraaar e98a65a735 Fixed casing of all .fbx.assetinfo files to match their .fbx (#5490)
Signed-off-by: moraaar <moraaar@amazon.com>
2021-11-11 09:31:28 +00:00
jonawals f564903f37 Merge pull request #5497 from aws-lumberyard-dev/viewport/select_rect_fix
Fix attempted rendering of invalid Entity selection boxes.
2021-11-11 09:15:27 +00:00
Chris Galvan 3ca30d559b Merge pull request #5522 from aws-lumberyard-dev/cgalvan/FixLCPrefabCrash
Fixed LC crash by preventing graphs from staying open after they are no longer in prefab focus.
2021-11-10 18:30:44 -06:00
hershey5045 9c57c9e64f Fix track view bug where postfxs do not render correctly. (#5465)
* Fix track view bug where postfxs do not render correctly.

Signed-off-by: hershey5045 <43485729+hershey5045@users.noreply.github.com>

* Reduce scope and add comments.

Signed-off-by: hershey5045 <43485729+hershey5045@users.noreply.github.com>
2021-11-10 16:03:50 -08:00
Chris Galvan e7035c5af6 Fixed typo.
Signed-off-by: Chris Galvan <chgalvan@amazon.com>
2021-11-10 16:56:29 -06:00
Danilo Aimini 27f0aa7f13 LYN-7468 | Viewport manipulators for the container of the focused prefab should be hidden (#5432)
* Extend the level entity behavior to open prefab containers in focus mode. Disable manipulators for these entities too.

Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>

* Minor adjustments

Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>

* Fix enum casing in Entity Inspector.

Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>

* Split views between for Level and FocusedContainer entities.

Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>

* Slightly different fix to support components on focused containers.

Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>

* Minor fixesto RefreshSelectedEntityIds.

Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
2021-11-10 14:43:32 -08:00
antonmic 0712bc7f87 Merge pull request #5482 from aws-lumberyard-dev/Atom/antonmic/skinMeshSrgFix
Fixed issue where skin material wouldn't render if applied to a model with several submeshes and those submeshes had different material types applied to them.
2021-11-10 14:28:51 -08:00
Chris Galvan 7a2eb349ca Fixed LC crash by preventing graphs from staying open after they are no longer in prefab focus.
Signed-off-by: Chris Galvan <chgalvan@amazon.com>
2021-11-10 16:20:12 -06:00
greerdv 5054cfe9b5 fix typo
Signed-off-by: greerdv <greerdv@amazon.com>
2021-11-10 22:04:40 +00:00
jiaweig d5081a47db Fix/update swapchain recreation on vsync interval changes (#5502)
Signed-off-by: jiaweig <51759646+jiaweig-amzn@users.noreply.github.com>
2021-11-10 13:32:23 -08:00
Qing Tao 21a254e9dc Fixed a type with pass filter (#5506)
Signed-off-by: Qing Tao <55564570+VickyAtAZ@users.noreply.github.com>
2021-11-10 13:15:04 -08:00
Junbo Liang cf58398c6c [AWSMetrics] Fail to build the project when include AWSMetricsBus header in the project C++ code (#5468) 2021-11-10 13:05:32 -08:00
AMZN-Phil cd2b1fa91c Merge pull request #5503 from aws-lumberyard-dev/Prism/CLIDelFileFolderFix
Fix trying to remove a cache file
2021-11-10 12:21:31 -08:00
antonmic 3fd03479de Addressed PR feedback
Signed-off-by: antonmic <56370189+antonmic@users.noreply.github.com>
2021-11-10 11:56:45 -08:00
sphrose 2fe40929e6 Merge pull request #4625 from aws-lumberyard-dev/terrain/sphrose/dependency_tests
Add missing shape failure test, tidying up.
2021-11-10 19:52:26 +00:00
greerdv d945a031c1 prevent twist limits being created with equal lower and upper limits
Signed-off-by: greerdv <greerdv@amazon.com>
2021-11-10 19:30:12 +00:00
amzn-mike e0cc86e898 Remove AssetProcessorManagerTest AssertAbsorber and update test to use the one from the base class instead (#5216) (#5381)
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>
(cherry picked from commit b3301414ad)

# Conflicts:
#	Code/Tools/AssetProcessor/native/tests/assetmanager/AssetProcessorManagerTest.cpp
2021-11-10 13:21:42 -06:00
Guthrie Adams 87c7023e3c Merge pull request #5109 from aws-lumberyard-dev/Atom/guthadam/material_editor_loads_source_data2
Material editor creates material assets from source JSON data instead of relying on AP
2021-11-10 12:31:17 -06:00
Chris Galvan 314861699d Merge pull request #5492 from aws-lumberyard-dev/cgalvan/FixedScriptCanvasEntityIdSlotNames
Updated some Script Canvas node slot names to EntityID for consistency.
2021-11-10 12:30:43 -06:00
AMZN-Phil f2e191ea77 Fix trying to remove a cache file
Signed-off-by: AMZN-Phil <pconroy@amazon.com>
2021-11-10 10:28:32 -08:00
Shirang Jia 576248a870 Merge Jenkinsfile from development to stabilization (#5391)
Signed-off-by: shiranj <shiranj@amazon.com>
2021-11-10 10:26:44 -08:00
John 3ced915f8e Fix attempted rendering of invalid Entity selection boxes.
Signed-off-by: John <jonawals@amazon.com>
2021-11-10 17:36:21 +00:00
SJ 0c546828d6 1. Add nullptr checks to prevent crashes when non-critical shaders fail to compile. (#5451)
2. Add a higher "launch_ap_timeout" for Mac because launching a newly built/downloaded AP can take a while.

Signed-off-by: amzn-sj <srikkant@amazon.com>
2021-11-10 11:31:59 -06:00
sphrose 7159e3fe57 Moving to stabilization
Signed-off-by: sphrose <82213493+sphrose@users.noreply.github.com>
2021-11-10 17:22:55 +00:00
Guthrie Adams f0b4eb1712 update comment and error message
Signed-off-by: Guthrie Adams <guthadam@amazon.com>
2021-11-10 10:54:53 -06:00
Chris Galvan 847e13154f Updated some Script Canvas node slot names to EntityID for consistency.
Signed-off-by: Chris Galvan <chgalvan@amazon.com>
2021-11-10 09:55:49 -06:00
jonawals adf3357176 Merge pull request #5486 from aws-lumberyard-dev/viewport/ghi_5239
Fix for Issue #5239: Component Edit Mode does not disable Entity Inspector interaction
2021-11-10 14:50:36 +00:00
AMZN-Igarri 027b0f86ae Activate AssetBrowserTableView feature (#5367)
Signed-off-by: igarri <igarri@amazon.com>
2021-11-10 13:41:59 +00:00
John 0e3df14ea2 Add missing bus connection/disconnection.
Signed-off-by: John <jonawals@amazon.com>
2021-11-10 11:59:28 +00:00
sphrose c28e92bf51 Merge pull request #5441 from aws-lumberyard-dev/terrain/sphrose/field_name_fix_LYN-8004
Various bug fixes.
2021-11-10 10:30:01 +00:00
antonmic 1f72001cdb Added two missing MeshDataInstance to ModelDataInstance renames in error message
Signed-off-by: antonmic <56370189+antonmic@users.noreply.github.com>
2021-11-10 00:56:25 -08:00
antonmic dcbcab68d2 merging latest to resolve auto-merge conflict
Signed-off-by: antonmic <56370189+antonmic@users.noreply.github.com>
2021-11-10 00:52:59 -08:00
santorac 0ae2d75261 Merge pull request #5393 from aws-lumberyard-dev/Atom/santorac/FixSkinScreenshotTests
Updated 002_wrinkle_regression_test.material to avoid subsurface scattering artifacts

Having subsurface scattering into a completely back area is an unrealistic scenario and caused colored artifacts. I changed the material to mask out the black areas from applying SS. Corresponding changes will be made to the expceted screenshot in AtomSampleViewer as well.
2021-11-09 19:28:40 -08:00
antonmic dadf06edda Fixed issue where skin material wouldn't render if applied to a model with several submeshes and those submeshes had different material types applied to them.
Signed-off-by: antonmic <56370189+antonmic@users.noreply.github.com>
2021-11-09 19:03:26 -08:00
santorac d6348384c3 Merge remote-tracking branch 'upstream/stabilization/2110' into Atom/santorac/FixSkinScreenshotTests 2021-11-09 16:11:23 -08:00
Ken Pruiksma 31439eb7c8 Adding m_exposure field to terrain's object srg to sync it with the default object srg. (#5462)
Signed-off-by: Ken Pruiksma <pruiksma@amazon.com>
2021-11-09 17:52:26 -06:00
moraaar 15586ee53e Adding missing pragma once at XcbInputDeviceMouse.h (#5448)
Signed-off-by: moraaar <moraaar@amazon.com>
2021-11-09 15:42:01 -08:00
Gene Walters c99071533d Small: fix typo
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-11-09 15:39:43 -08:00
Gene Walters c8b9f05079 Ensuring the 4 types of RPCs (1)Autonomous->Authority (2)Authority->Autonomous (3)Authority->Client and (4)Server->Authority all compile. Invoking anything that starts from Autonomous or Authority requires a controller (otherwise just requires a component), and anything handled by Authority or Autonomous requires a controller for Handle on OnEvent methods (otherwise OnEvent and Handle occurs on the component)
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-11-09 15:35:17 -08:00
Alex Peterson 461b63c61a Temporarily disable the platform filter (#5454)
Signed-off-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com>
2021-11-09 14:14:13 -08:00
Chris Galvan 4a4a6d1873 Merge pull request #5458 from aws-lumberyard-dev/cgalvan/FixedPythonToolGemDependencyOnQtForPython
Ensure QtForPython is a proper dependency for the PythonToolGem.
2021-11-09 16:09:25 -06:00
AMZN-Phil 93c5627c14 Merge pull request #5347 from aws-lumberyard-dev/Prism/clouddownloadicon
Create download UI once
2021-11-09 14:01:05 -08:00
chiyenteng caf1c18fbe Prevent track editor view's default size to be zero (#5453)
* Prevent track editor view's default size to be zero

Signed-off-by: chiyteng <chiyteng@amazon.com>

* minor rewording

Signed-off-by: chiyteng <chiyteng@amazon.com>
2021-11-09 12:40:56 -08:00
dmcdiarmid-ly 897fd955e2 Merge pull request #5431 from aws-lumberyard-dev/Atom/dmcdiar/ATOM-16247
ReflectionProbe exposure controls
2021-11-09 12:39:46 -08:00
Chris Galvan 7cc9c584b7 Ensure QtForPython is a proper dependency for the PythonToolGem.
Signed-off-by: Chris Galvan <chgalvan@amazon.com>
2021-11-09 13:53:04 -06:00