Commit Graph

677 Commits (1431afb51a08535a0ceabc22f11a55c0e5f5bb93)

Author SHA1 Message Date
lumberyard-employee-dm 18ea4ba6a8
Added a CriticalAssetsCompiled Lifecycle event (#6469)
The CriticalAssetsCompiled event can be handled to detect when the
AssetProcessor has finished processing Critical Assets

Also with the new event, an audit has been performed over all the
locations where the AssetCatalogEventBus OnCatalogLoaded event was being
handle to make sure it was the proper event to use.
If the handler was actually examing the enumerating over the full
catalog or querying all assets within the catalog, then it was a proper
use.
For handlers that were interested in a particular asset it was not

Moreover added implementations of `OnCatalogAssetChanged` and
`OnCatalogAssetAdded` to the FileTagComponent and the MaterialViewportComponent.

Any applications which uses the AtomToolsApplication
class(MaterialEditor, AtomSampleViewerStandalone,
ShaderMangementConsole) now signals a "CriticalAssetsCompiled" lifecycle
event as well as loads the "assetcatalog.xml" if it exists.

The Launcher application signals the "CrticalAssetsCompiled" event and
reloads the "assetcatalog.xml" for the ${project}.GameLauncher and
${project}.ServerLauncher in Launcher.cpp

Finally the Editor signals the "CriticalAssetsCompiled" and reloads the
"assetcatalog.xml" in CryEdit.cpp

resolves #6093

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
4 years ago
AMZN-koppersr 603967d61f Fixed build issues with Spawnable Entity Aliases.
Signed-off-by: AMZN-koppersr <82230785+AMZN-koppersr@users.noreply.github.com>
4 years ago
AMZN-koppersr 13375cd7d9 Merge branch 'development' into Prefabs/ProcessStackAddPrefabBug 4 years ago
Gene Walters 8cd4a3dced Fix netbind component to use the new svg icons instead of png (which no longer exist)
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters 8b041f5280 merging latest dev
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters 92d3df17fa Fix incomplete comment
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters bf8422152b Turn off stdout buffering when connecting to editor-server so that the editor properly gets all the server-logging without having to first fill up a buffer. Allows the logs to pipe instantly for easier debugging, and also fixes a problem where the logs wont reach the editor because the buffer doesn't fill
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
AMZN-koppersr a964120b7a Updated the NetworkPrefabProcessor with the latest Prefab builder changes.
Signed-off-by: AMZN-koppersr <82230785+AMZN-koppersr@users.noreply.github.com>
4 years ago
chiyenteng ca49eedc5f
Convert prefab to temp spawnable assets (#6179)
* Convert prefab to temp in-memory spawnable assets

Signed-off-by: chiyenteng <82238204+chiyenteng@users.noreply.github.com>
4 years ago
Gene Walters 8b044e23ce Merge branch 'upstream/development' into LYN-6769_TestingRPCs 4 years ago
Gene Walters 4b3d1452fd
Merge pull request #6066 from aws-lumberyard-dev/LYN-8514_AutomatedReviewServerLogChecks
Updating Multiplayer PyTests To Check Server Logs
4 years ago
Gene Walters 16f5f45b7e
Merge pull request #6170 from aws-lumberyard-dev/LYN-8770_PrintNetEntityNameIfImproperlyDeleted
Print Entity name if Improperly Deleted
4 years ago
Gene Walters 80a216e079 Adding RPC test. Update editor-servers to flush stdout
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters 54fd0011a7 Merge branch 'LYN-8514_AutomatedReviewServerLogChecks' into LYN-6769_TestingRPCs 4 years ago
Gene Walters 1983e94580 Minor tweak to re-add ';' to LOG
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters 8131cf6780 Merge branch 'LYN-8514_AutomatedReviewServerLogChecks' into LYN-6769_TestingRPCs 4 years ago
Gene Walters b123379380 Properly adding newlines when using LogInternalV; removing the need of hand-placed newlines to AZ_LOG
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Esteban Papp cd5306febf Merging from development
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
4 years ago
Gene Walters 390bd6ece3 Merge branch 'upstream/development' into LYN-6769_TestingRPCs 4 years ago
Gene Walters 9ae3da7acd Merge branch 'upstream/development' into LYN-8514_AutomatedReviewServerLogChecks 4 years ago
Gene Walters b19f96f1fe Small safety check. It's unlikely, but possible, that a component is created and not assigned to an entity.
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters b50739f55e Small tweak to assert back to match existing format
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters 4f9d4b7045 Improved logged to print entity name if improperly deleted; helps when debugging to find the problem entity
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Olex Lozitskiy 701fd7f0d0 Multiplayer benchmark cleanup
Signed-off-by: Olex Lozitskiy <5432499+AMZN-Olex@users.noreply.github.com>
4 years ago
Gene Walters fb330b2af9 Merge branch 'upstream/development' into LYN-6769_TestingRPCs 4 years ago
Gene Walters c00d7ff658 Small formatting fix to jinja for autocomponent's behavior context
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Esteban Papp bb685ee40b Merge branch 'development' into redcode/driller_removal
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
4 years ago
Esteban Papp 59ef6f983f Removes Driller from ScriptCanvas
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
4 years ago
Guthrie Adams 50f094c51e Fixing warnings caused by system components not added to serialize context
==================================================================
2021-11-30T20:21:23{000000000000395C}[Module Manager]     Trace::Warning
 D:/projects/lyengine/git/ly-dev/o3de/Code/Framework/AzCore/AzCore/Module/ModuleManager.cpp(34): 'bool __cdecl AZ::ShouldUseSystemComponent(const class AZ::ComponentDescriptor &,const class AZStd::vector<class AZ::Crc32,class AZStd::allocator> &,const class AZ::SerializeContext &)'
2021-11-30T20:21:23{000000000000395C}[Module Manager]     Component type MultiplayerToolsSystemComponent not reflected to SerializeContext!
2021-11-30T20:21:23{000000000000395C}[Module Manager]     ==================================================================
2021-11-30T20:21:23{000000000000395C}[Module Manager]
==================================================================
2021-11-30T20:21:23{000000000000395C}[Module Manager]     Trace::Warning
 D:/projects/lyengine/git/ly-dev/o3de/Code/Framework/AzCore/AzCore/Module/ModuleManager.cpp(34): 'bool __cdecl AZ::ShouldUseSystemComponent(const class AZ::ComponentDescriptor &,const class AZStd::vector<class AZ::Crc32,class AZStd::allocator> &,const class AZ::SerializeContext &)'
2021-11-30T20:21:23{000000000000395C}[Module Manager]     Component type PythonEditorFuncs not reflected to SerializeContext!
2021-11-30T20:21:23{000000000000395C}[Module Manager]     ==================================================================

Signed-off-by: Guthrie Adams <guthadam@amazon.com>
4 years ago
Gene Walters b262909117 Misc whitespace edit
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters c8b631054f Misc edit to keep an AZLOG_INFO instead of AZPrint. No real difference, but good as an example for pytest
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters 78d0a8e54a Merging latest LYN-8025_PipeEditorServerLogsToEditor
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters 8afd47950c Removing an extra new-line I added by accident
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters 6d0ba68b55 Using new GetBool value when checking if we're an editor-server. Clean up MPEditorSystemComponent for unused #includes, and null-checking when piping server logs
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters d786e9d8e2 Merge branch 'LYN-8025_PipeEditorServerLogsToEditor' into LYN-8514_AutomatedReviewServerLogChecks 4 years ago
Gene Walters 9c9d2c70f5 Making sure to stop pulling server logs before terminating the server process; otherwise we might be pulling an invalid process-communicator. Updating AZCoreLogSink to also allow for piping warnings/errors/asserts
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters f4e762d9bd Adding warning if server fails to load the sv_defaultPlayerSpawnAsset when a client joins the server. Updating Multiplayer PyTest to watch out for this warning.
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters 75e8ef8089 Misc cleanup. Making sure ServerLauncher closes if tests fail
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters 97b27513e9 Editor is now listening to editor-server stdout so adding newlines to lines we care about. (Editor is separating out the log lines based on newline)
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters ff862a2f20 Fix memory leak of ProcessWatcher
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters 0bd86cf0a4 small edit: removing pragma optimize offs
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters 02590a1766 AzCoreLogSink will check if it's running in an editor-server and will allow stdouts
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Gene Walters 6005a4e08b Merging last dev
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago
Esteban Papp 7100d48e16
Cherry-picking some changes from stabilization into development (#5810)
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
4 years ago
Olex Lozitskiy e804fd2a42
Refactored away circular dependencies in Multiplayer gem cmake targets. 4 years ago
Olex Lozitskiy 52742dff48 Created Gem::Multiplayer.Tools.Static cmake target
Signed-off-by: Olex Lozitskiy <5432499+AMZN-Olex@users.noreply.github.com>
4 years ago
Olex Lozitskiy 69efe7cf26 Addressing PR
Signed-off-by: Olex Lozitskiy <5432499+AMZN-Olex@users.noreply.github.com>
4 years ago
Olex Lozitskiy 89f4ebb298 Refactored away circular dependencies in Multiplayer gem.
Signed-off-by: Olex Lozitskiy <5432499+AMZN-Olex@users.noreply.github.com>
4 years ago
Tommy Walton 21d5e62f85 Merge commit 'cb1a45f9ec01ebaede35da2924bde66f31c31ea2' into amzn-tommy/gitflow_211116_o3de2 4 years ago
Gene Walters 4d161f42df WiP. fwrites are being stopped by AZCoreLogSink; need a long term solution to work around this...
Signed-off-by: Gene Walters <genewalt@amazon.com>
4 years ago