d357d1ed1f
Merge branch 'upstream/development' into LYN-8514_AutomatedReviewServerLogChecks
2021-11-23 19:15:53 -08:00
97f7e5afd6
merging latest dev
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-11-23 16:16:55 -08:00
7975629a7a
Merge pull request #5872 from aws-lumberyard-dev/FixedVectorOptimization
...
Performance improvement for fixed_vector.
2021-11-23 15:43:24 -08:00
abb37c0b4a
Merge commit '4ac8b5dc429b6c87b3bd9e743839c47f7a02c0ce' into junbo/gitflow_211123_o3de
2021-11-23 13:29:30 -08:00
2bdee5c9e6
Merge commit 'bf3a5118069d287c013febd94a977966e4d1f944' into junbo/gitflow_211123_o3de
2021-11-23 13:29:23 -08:00
7086aa1a75
Merge commit 'dbc5d7a8bc5404b80fbc38b6b004aaa1f9e06df9' into junbo/gitflow_211123_o3de
2021-11-23 13:28:04 -08:00
e2649512b2
Merge commit '4be1e68bad1b627668a4517b00526bba6cc7acea' into junbo/gitflow_211123_o3de
2021-11-23 13:16:55 -08:00
6a40d21b66
Merge commit '4ee2f341dc0dc709aedb446b57d5cca61b86160d' into junbo/gitflow_211123_o3de
2021-11-23 13:14:59 -08:00
3b39be7fd0
Merge commit '4ad35f424e01356a4745e5f50631dc050b328c98' into junbo/gitflow_211123_o3de
2021-11-23 13:14:57 -08:00
4ac8b5dc42
Display version number correctly in installer builds from branches that properly set the name on Jenkins. ( #5856 )
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-11-23 13:13:21 -08:00
33e44a4813
revert rawoutput function. we'll update any of the logs we care about to include newlines
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-11-23 09:27:50 -08:00
389f29f0e7
Performance improvement for fixed_vector
...
AZStd::fixed_vector had all its functions marked with constexpr, but this requires all member variables to be fully initialized. This meant that the internal array used to store elements always has to be fully initialized. This was done for trivial classes but not for non-trivial classes. As a result trivial classes always did a memset (or more optimized versions for smaller buffers) while the non-trivial version couldn't actually be stored in a constexpr variable. Since AZStd::fixed_vector is meant to be dynamic the choice was made to remove the constexpr from all non-static member functions in favor of avoiding the overhead of memset, which profiling showed was a considerable overhead depending on the reserved size. If a truly constexpr array is needed than AZStd::array is a better choice as that's designed to not by dynamic.
Signed-off-by: AMZN-koppersr <82230785+AMZN-koppersr@users.noreply.github.com >
2021-11-23 09:26:37 -08:00
ea0afae502
Fix for how viewport icons highlight (accent) when sticky select is disabled ( #5833 )
...
* fix for how viewport icons highlight when sticky select is disabled
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* naming - update highlight to accent
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
2021-11-23 12:28:38 +00:00
ba32937867
Cherry pick release unused warning error into Stabilization/2110 ( #5845 )
...
* Fixed unused variable warning in Release configuration in Linux. (#5830 )
Signed-off-by: moraaar <moraaar@amazon.com >
* Fix unused variable errors (#5843 )
Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com >
Co-authored-by: moraaar <moraaar@amazon.com >
2021-11-22 15:32:54 -08:00
1a0d466443
Adds simple stats tracking to AssetProcessor ( #5573 )
...
* Adds simple stats tracking to AssetProcessor
The system captures cumulative and individual processing times.
It avoids touching any part of the app which affects decision
making or flow, or altering any structures such as JobEntry which
are involved in processing, in order to keep it as simple and
small as possible.
Signed-off-by: lawsonamzn <70027408+lawsonamzn@users.noreply.github.com >
2021-11-22 11:18:19 -08:00
bf3a511806
Merge pull request #5817 from aws-lumberyard-dev/Prism/CMakePATH
...
Fix Project Manager not finding CMake on Windows
2021-11-22 11:04:27 -08:00
d958502f2c
Check return value of qputenv
...
Signed-off-by: AMZN-Phil <pconroy@amazon.com >
2021-11-22 09:26:34 -08:00
5c71a7481d
Modify resource limit function to warn ( #5807 )
...
The function that modifies resource limits will return true always and warn instead
of giving an error.
Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com >
2021-11-22 10:53:59 -06:00
c2145a6387
Use QStringList to avoid false matches against a partial path
...
Signed-off-by: AMZN-Phil <pconroy@amazon.com >
2021-11-22 08:31:12 -08:00
ab1b6d057d
Fixed unused variable warning in Release configuration in Linux. ( #5830 )
...
Signed-off-by: moraaar <moraaar@amazon.com >
2021-11-22 13:25:29 +00:00
0bd86cf0a4
small edit: removing pragma optimize offs
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-11-20 14:58:09 -08:00
02590a1766
AzCoreLogSink will check if it's running in an editor-server and will allow stdouts
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-11-20 14:48:48 -08:00
def5b3a65d
Fix additional left over references to QProcessEnvironment
...
Signed-off-by: AMZN-Phil <pconroy@amazon.com >
2021-11-20 10:37:55 -08:00
74e1ee1862
Fix non-Windows platforms
...
Signed-off-by: AMZN-Phil <pconroy@amazon.com >
2021-11-20 10:23:50 -08:00
6005a4e08b
Merging last dev
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-11-19 23:12:59 -08:00
e1b6054ff8
Fix Project Manager not finding CMake on Windows
...
Signed-off-by: AMZN-Phil <pconroy@amazon.com >
2021-11-19 19:13:19 -08:00
6eec6c8f8e
Merge pull request #5752 from aws-lumberyard-dev/puvvadar/gitflow_211118_o3de
...
Merge stabilization/2110
2021-11-19 15:46:16 -08:00
dbc5d7a8bc
Cherry-pick of Linux deb package to stabilization ( #5778 )
...
* Cherry-pick 49e8f3585881431996+amznestebanpapp@users.noreply.github.com >
* Merging differences from development of other changes that need to be there for deb packaging
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Picks a needed change for the installer
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Fixes warning in mac
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Takes version from environment if defined
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Do not pick up version if it is empty string since that will also break version comparison
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* creating temp directories if they dont exist
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* removing a dependency to itself (Multiplayer.Builders is an alias of Multiplayer.Editor)
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Filters which runtime dependencies are passed from private build dependencies to only those that are actual targets.
This avoids something like a "d3d12" private build dependency from being passed to the runtime dependencies
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-11-19 14:07:25 -08:00
1aa444d669
Update build copy back to Developer Preview
...
Signed-off-by: puvvadar <puvvadar@amazon.com >
2021-11-19 11:40:01 -08:00
af85060856
[SPEC-7644] Cherry Pick - ParallelDeepAssetReferences is failing intermittently ( #5797 )
...
* [SPEC-7644] ParallelDeepAssetReferences is failing intermittently (#5721 )
* Fixed race condition caused by trying to handle asset ready event before asset container has finished filling out all the data structures.
Added check to only handle asset ready once init is complete
Added unit test to verify fix
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Re-enable test
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Add missing space to error message
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Add comment on sleep
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Collapse nested namespace
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Collapse nested namespace
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
(cherry picked from commit 56900484fc80125227+amzn-mike@users.noreply.github.com >
2021-11-19 11:22:43 -08:00
4be1e68bad
Fix oversight from recent change to PrefabFocusHandler internals. ( #5794 )
...
* Fix oversight from recent change to PrefabFocusHandler internals.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Introduce check for null instance in case this is called before the Prefab Focus Handler is initialized.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-11-19 10:45:06 -08:00
4ee2f341dc
Fix several Prefab outliner ordering issues ( #5747 )
...
* Fix several Prefab outliner ordering issues
This change does a few things to address instability in entity order when prefabs are enabled:
- Changes ordering behavior on entity add to always be "insert after the last selected sibling of the new entity, or at the end if there is no selected sibling"
- Adds some logic to ensure selection stays frozen during prefab propagation to allow this behavior to be used
- Alters delta generation in `PrefabPublicHandler::CreateEntity` to use the template instead of reserializing the DOM - this avoids a whole bunch of patching issues caused by EditorEntitySortComponent doing post-hoc order fix-up and should generally be safer/faster as we're producing patches for the actual target for those patches
- Because the duplicate action is DOM-driven, and there's some thorniness around making changes that will affect the template during propagation, this adds `PrefabPublicHandler::AddNewEntityToSortOrder` to directly patch the DOM for the duplicate case
Two bits of this come from patches from the incredibly helpful @AMZN-daimini
- Alters `PrefabPublicHandler::GenerateUndoNodesForEntityChangeAndUpdateCache` behavior for determining what's an override: we now check to see if we're part of the current focused instance but *not* owned by the focus instance directly. This lets entity order for nested prefabs get saved to the owning prefab instead of as an override. I'm putting this up for discussion without a feature flag gating it, but we may wish to make this a toggle or disable it outright for stabilization (in which case entity order won't be saved to the owning prefab)
- Adds a custom serializer for EditorEntitySortComponent. This isn't strictly necessary now, but it was very useful for debugging and ended up receiving much more manual testing its migration path and save/load path more than I've tested without using the serializer.
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
* Add missing serializers
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
* Address some review feedback
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
* Generate patch in `PrefabPublicHandler::CreateEntity` using the instance's fully evaluated template in-memory
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
* Fix up comment
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
* Fix Linux build
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
* Try to make test less timing dependent (haven't been able to repro failure locally)
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
* Fix another build issue
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
* Fix unit test failures
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
* Fix a duplicate issue with sanitization that was causing sporadic test failure (thanks, test!)
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
* One more Linux fix...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-11-19 23:35:19 +05:30
4ad35f424e
Adds check to make sure that there are not too many samples created. ( #5789 )
...
* Adds check to make sure that there are not too many samples created.
Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com >
* Changes made from PR
Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com >
* Changes made from PR 2
Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com >
2021-11-19 17:57:38 +00:00
b0dc1ea6fa
CMake Xcode Generator fix ( #5771 )
...
Removed the generator expression from the `LY_ARCHIVE_FILE_SEARCH_MODE` define as Xcode doesn't support per-config per-file definitions.
Updated the #else block in ArchiveVars to default to PakOnly mode if the `LY_ARCHIVE_FILE_SEARCH_MODE` define isn't set.
Moved the the `LY_ARCHIVE_FILE_SEARCH_MODE` Cache Variable from cmake/Deployment.cmake to feature_options.cmake within the AzFramework folder.
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com >
2021-11-19 11:23:38 -06:00
40aff91f18
Merge commit 'ebb24d2285635ee8bd840a5b58b1a519b73d8c0a' into puvvadar/gitflow_211118_o3de
2021-11-19 09:19:10 -08:00
ab58773388
Merge commit '092d125acf2eb23099e08f0d93e9b2a3b90ce016' into puvvadar/gitflow_211118_o3de
2021-11-19 09:18:52 -08:00
87b338f5f6
Merge commit 'e50735c127d9a3a8e5f38fc737222e4b542a54f8' into puvvadar/gitflow_211118_o3de
2021-11-19 09:18:28 -08:00
e8cdff627c
Merge commit '4ad6d3e9f75880558d4003474621b9ada3aef060' into puvvadar/gitflow_211118_o3de
2021-11-19 09:16:31 -08:00
8b5a322d67
Merge commit '9cbd323a3b799c3cc7fb285a96ba7ed2cace896b' into puvvadar/gitflow_211118_o3de
2021-11-19 09:16:20 -08:00
f65f744358
Merge commit 'ac959bcc01a52f1738e439b0291dfb8b0a73b388' into puvvadar/gitflow_211118_o3de
2021-11-19 09:16:14 -08:00
ef25271d80
Merge commit 'e8576acbb0510717d57f168096a9cc6ad0c2fbf9' into puvvadar/gitflow_211118_o3de
2021-11-19 09:16:01 -08:00
ebb24d2285
Improvement for click detection when clicking quickly between mouse moves ( #5786 )
...
* improvement for click detection when clicking quickly between mouse moves
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* remove magic number and introduce constant
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* add missing update from camera test
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
2021-11-19 16:52:44 +00:00
092d125acf
Merge pull request #5769 from aws-lumberyard-dev/Prism/RemoteGemWarning
...
Extra gem download failure handling
2021-11-19 07:30:25 -08:00
e50735c127
Improved look for viewport ui border close button ( #5757 )
...
* improved look for viewport ui border close button
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* remove unused variable
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* removed commented 'fixme' calls
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* updates following PR feedback
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
2021-11-19 11:04:49 +00:00
a465bf30a7
Iterate over dependent gems
...
Signed-off-by: AMZN-Phil <pconroy@amazon.com >
2021-11-18 17:30:52 -08:00
4ad6d3e9f7
Updated project manager backgrounds ( #5770 )
...
Signed-off-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com >
2021-11-18 16:54:04 -08:00
49e8f35858
Creates a deb package ( #5567 )
...
* configure/generation working
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Generates deb package forLinux
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Fixes to EngineFinder
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* changes the owner of the installed folder so it is writable by the user
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* jenkins scripts
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Fixes execution permission for scripts
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Fixes wrong parameter to build for linux
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* removal of clang parameters in build_config.json
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Simplifies and fixes build configs
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* fixes to EngineFinder
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Adds linux deb package upload and small fixes/organization cleanup
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* fixes checksum generation
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Some more small fixes for reviewing
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Test if this space is necessary for cpack
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* More fixes for installer jobs
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Adding eval to variables that need to double-expand
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Removing unused variables being passed
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Do not remove symlink
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Use cmake_path for concatenating paths
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* removing quotes so the variable expands
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* cleaned up some variables that have way too many ways to be passed
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Multiple fixes for Jenkins
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Cleanup/re-organization
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* fixes some temp variables so we can run cpack jenkins jobs locally
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Delays cmake download to install step
Cleanup on installer_windows.cmd, we already have the path to cpack (same as cmake, which is added to the path)
Some simplification in the windows installer generation, we now generate the same even if we dont upload
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Fixes mac install
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* CPack can generate hashes for us
Defiine CPACK_OUTPUT_FILE_PREFIX to prevent the exe/msi from ending in the bin dir
Remove unnecessary generation of folder from 3rdPartyPacakges which fails when including from cpack
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* multiple fixes
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* fixes typo
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* more fixes
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Fixes for linux/mac/windows (fixing discrepancies with Jenkins)
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* uploads to S3 from the upload directory and fixes the latest upload
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Adds ERROR_VARIABLE to S3 upload to find a Jenkins issue
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* printing command invocation to try to figure out the errors
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Changes the hashing algorithm to sha256 and fixes the cmd used to call to pythojn
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* wrong path being passed in mac
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* removes compiler parameters from a config job (after rebase)
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* more fixes fro deb packaging job
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* small fix for fingerprint patching for latest
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Changing extension of public key and leaving better TODO places for code signing
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Removes sdl as a dependency, leaving it commented since it is needed for wwise
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* fixes runtime copy during install, makes it more consistent with regular runtime dependencies and optimizes copy when there is already an install
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* $ENV{DESTDIR} and CMAKE_INSTALL_PREFIX cannot be used in cmake_path because the CMAKE_INSTALL_PREFIX is absolute
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Fixing some runtime_dependencies optimizations, we cannot take size of a bundle
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Fixes warning in mac for an unused variable
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Fixes a variable that was being passed to fix qt frameworks
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* More fixes for Jenkins
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Updates email to use for maintainer to match certificate
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* make directory because in some cases the dependency is copied before the actual library and the directory has to be created
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Fix for a new warning/error in linux
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* The sha file is created after the upload happens, so creating it
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* remove the size comparison for install since it stomps over the copy from the target and doesnt trigger stripping
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-11-18 16:26:49 -08:00
9cbd323a3b
Merge pull request #5763 from aws-lumberyard-dev/Atom/antonmic/AuxGeomFeedback
...
Capsule light aux geom: addressed feedback from previous PR plus some cleanup
2021-11-18 15:19:08 -08:00
ac959bcc01
Dragging an entity from outside the focused Prefab into it may crash the Editor ( #5762 )
...
* Replace Instance References with EntityId of the Prefab Container (WIP)
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Use the invalid entity id for the root instance and get the root instance every time to prevent weird Prefab EOS shenanigans.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Revert unnecessary changes, fix IsOwningPrefabBeingFocused to match previous behavior. Disable some tests that no longer apply correctly due to the testing environment not relying on the Prefab EOS.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Fix minor typo in test comment
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-11-18 15:06:58 -08:00
7e43b53d16
Extra gem download failure handling
...
Signed-off-by: AMZN-Phil <pconroy@amazon.com >
2021-11-18 15:01:11 -08:00
Gene Walters
Ronald Koppers
Junbo Liang
Danilo Aimini
Tom Hulton-Harrop
Steve Pham
Nicholas Lawson
AMZN-Phil
AMZN-Phil
amzn-phist
moraaar
puvvadar
Esteban Papp
amzn-mike
Nicholas Van Sickle
John Jones-Steele
lumberyard-employee-dm
Alex Peterson
antonmic