d084027b6e
Bugfixes to enable slice-to-prefab conversion to run with less warnings/errors/crashes ( #768 )
...
While trying to process all slices and levels in Automated Testing, a few bugs came up that needed to be addressed:
- [LYN-3832] TransformComponent had a field removed without updating the version number and converter, which caused a lot of excessive warnings
- SliceComponent would crash in debug builds on instantiation failures due to a null dereference that was guarded against in most but not all places
- SliceConverter now detects when nested slices exist and gracefully warns about it.
- InstanceUpdateExecutor / TemplateInstanceMapper will now immediately remove instances that are unregistered, so that any in the queue don't get processed on a subsequent tick. This was causing crashes when the instance was destroyed before the processing occurred. It also has a side benefit of preventing the same instance from executing multiple times.
- Minor logic bugfix to the pack close warning, the boolean check was flipped.
Also added an early-out on SetTemplateId, since this was causing some unnecessary instance queue entries.
2021-05-17 14:58:18 -05:00
0cfc7f10a9
Merge pull request #728 from aws-lumberyard-dev/Prefab/CyclicalDependencyCheck
...
Detect cyclical dependencies in the nested prefabs of the prefab being instantiated
2021-05-14 16:33:13 -07:00
1a456cc9b9
Marked an our parameter correctly and changed a ref to const ref
2021-05-14 11:48:31 -07:00
b72836fa8f
Fixed a typo
2021-05-13 18:03:49 -07:00
d8865a8f0d
Remove links when deleting prefabs
2021-05-13 17:41:45 -07:00
16b2dabde2
Removed additional spacing
2021-05-13 14:51:27 -07:00
9328c944b2
Remove an unnecessary check in the if statement
2021-05-13 14:49:06 -07:00
7d8180a3bb
Fixed a typo
2021-05-13 14:46:30 -07:00
b92a68f5a4
Improved a comment
2021-05-13 14:45:06 -07:00
cd4be3a708
Found a better way to find common owning instance
2021-05-13 14:37:22 -07:00
76e8a0ef47
Fixed bug with delete prefab where the prefabs were not being deleted from the correct instances
2021-05-13 14:11:47 -07:00
1895c2d18d
Merge pull request #675 from aws-lumberyard-dev/Prefab/CreatePrefab
...
Get instantiation to work after creation of a prefab is undone
2021-05-12 13:54:26 -07:00
7bdf44a099
Detect cyclical dependencies in the nested prefabs of the prefab being instantiated
2021-05-12 13:38:44 -07:00
98a579abef
Added a comment
2021-05-12 12:17:36 -07:00
33af6c1014
Merge branch 'main' into Prefab/CreatePrefab
2021-05-11 13:41:48 -07:00
b11234097d
Fixed a capitalization issue
2021-05-11 11:30:16 -07:00
c2a9ab18e4
Merge branch 'main' into Spawnable/ProductDependency
2021-05-11 09:59:50 -07:00
2e32b2ee57
Merge pull request #671 from aws-lumberyard-dev/Prefabs/AssetPreload
...
Asset Preload fix for json serialization and prefab game mode
2021-05-11 09:35:06 -07:00
d61c93a7b6
Merge pull request #431 from aws-lumberyard-dev/Prefab/Create/IgnoreLevel
...
LYN-3211 | Create Prefab can be triggered on the Level Container, generating an invalid level hierarchy
2021-05-10 23:09:51 -07:00
36911723c2
Addressed PR feedback
2021-05-10 18:17:39 -07:00
f7ea02afdc
Fix for NetworkingProcessor using CreateSpawnable without ReferencedAssets arg
2021-05-10 13:21:13 -07:00
17ccf90480
Updated function header comment
2021-05-10 12:59:16 -07:00
886fe22b16
Merge branch 'main' into Prefab/CreatePrefab
2021-05-10 12:31:18 -07:00
b57dd02d90
Removed a debug print command
2021-05-10 12:28:33 -07:00
2e9ae76596
Removed print statement, adding in new files that were missed
2021-05-10 12:11:53 -07:00
4994103627
Add const ref function parameters as needed
2021-05-10 11:58:54 -07:00
b04bfc459f
Asset Preload fix for json serialization and prefab game mode
2021-05-10 11:46:58 -07:00
0da6e450a6
Improved comments
2021-05-10 11:43:32 -07:00
e24827efb3
Fix direct editing of a reference
2021-05-07 17:08:35 -07:00
4662290d92
Switching IsPrefabInInstanceAncestorHierarchy to use const refs
2021-05-07 16:50:41 -07:00
47001dc0c3
Merge main
2021-05-07 16:42:51 -07:00
1c04160966
Added a missing header
2021-05-07 16:23:14 -07:00
eb8084d3f6
Initial draft for getting instantiation to work immediately after creation is undone
2021-05-07 16:21:23 -07:00
a5ccfa6053
Merge pull request #456 from aws-lumberyard-dev/Prefab/CreatePrefab
...
Fix undo for nested prefab creation by providing link patches to the undo node
2021-05-04 13:20:37 -07:00
a7624bb985
Removed returning AZ::Failure when AZ::Assert is thrown
2021-05-03 17:23:00 -07:00
5eeeaf4346
Fixed several release build compile errors.
2021-05-01 13:26:54 -07:00
bc3f285601
Refactored IsPrefabInInstanceAncestorHierarchy to use Instance Optional References. Added more information to the error message.
2021-04-29 18:45:42 -07:00
6e8b1d1000
Update on how we move string values in AddProductDependency
2021-04-29 18:28:07 -07:00
a9de24ef7d
Addressed PR feedback on function args and names
2021-04-29 18:09:38 -07:00
7f971f726d
Merge branch 'main' into Prefab/Instantiate/Loop
2021-04-29 17:05:17 -07:00
d433cd623b
Fix undo for nested prefab creation by providing link patches to the undo node
2021-04-29 17:02:44 -07:00
e22398700d
Simplified some checks, added early outs.
2021-04-29 16:19:58 -07:00
15b1ae4b2d
Removed excess whitespace
2021-04-29 14:24:09 -07:00
7df8a88b0e
Merge branch 'main' into Spawnable/ProductDependency
2021-04-29 14:19:43 -07:00
845b748061
Updated PrefabBuilder to include product dependencies defined in AddProductDependency
2021-04-29 14:15:48 -07:00
8f1499581b
Merge branch 'main' into Prefab/Create/IgnoreLevel
2021-04-29 11:20:08 -07:00
c3c90cc821
Merge branch 'main' into Spawnable/ProductDependency
2021-04-28 15:40:10 -07:00
48c34628f6
Exclude the Level root prefab container when creating prefabs.
2021-04-28 13:34:02 -07:00
6947e8fe29
Added an IsObject check for nested instance DOM during link creation that happens during prefab loading
2021-04-28 12:14:55 -07:00
3b49b59c32
Added AddProductDependency calls to PrefabProcessorContext
2021-04-28 12:03:09 -07:00
Mike Balfour
srikappa-amzn
srikappa
sconel
sconel
Danilo Aimini
daimini
AMZN-koppersr