d084027b6e
Bugfixes to enable slice-to-prefab conversion to run with less warnings/errors/crashes ( #768 )
...
While trying to process all slices and levels in Automated Testing, a few bugs came up that needed to be addressed:
- [LYN-3832] TransformComponent had a field removed without updating the version number and converter, which caused a lot of excessive warnings
- SliceComponent would crash in debug builds on instantiation failures due to a null dereference that was guarded against in most but not all places
- SliceConverter now detects when nested slices exist and gracefully warns about it.
- InstanceUpdateExecutor / TemplateInstanceMapper will now immediately remove instances that are unregistered, so that any in the queue don't get processed on a subsequent tick. This was causing crashes when the instance was destroyed before the processing occurred. It also has a side benefit of preventing the same instance from executing multiple times.
- Minor logic bugfix to the pack close warning, the boolean check was flipped.
Also added an early-out on SetTemplateId, since this was causing some unnecessary instance queue entries.
5 years ago
0cfc7f10a9
Merge pull request #728 from aws-lumberyard-dev/Prefab/CyclicalDependencyCheck
...
Detect cyclical dependencies in the nested prefabs of the prefab being instantiated
5 years ago
1a456cc9b9
Marked an our parameter correctly and changed a ref to const ref
5 years ago
b72836fa8f
Fixed a typo
5 years ago
d8865a8f0d
Remove links when deleting prefabs
5 years ago
16b2dabde2
Removed additional spacing
5 years ago
9328c944b2
Remove an unnecessary check in the if statement
5 years ago
7d8180a3bb
Fixed a typo
5 years ago
b92a68f5a4
Improved a comment
5 years ago
cd4be3a708
Found a better way to find common owning instance
5 years ago
76e8a0ef47
Fixed bug with delete prefab where the prefabs were not being deleted from the correct instances
5 years ago
1895c2d18d
Merge pull request #675 from aws-lumberyard-dev/Prefab/CreatePrefab
...
Get instantiation to work after creation of a prefab is undone
5 years ago
7bdf44a099
Detect cyclical dependencies in the nested prefabs of the prefab being instantiated
5 years ago
98a579abef
Added a comment
5 years ago
33af6c1014
Merge branch 'main' into Prefab/CreatePrefab
5 years ago
b11234097d
Fixed a capitalization issue
5 years ago
c2a9ab18e4
Merge branch 'main' into Spawnable/ProductDependency
5 years ago
2e32b2ee57
Merge pull request #671 from aws-lumberyard-dev/Prefabs/AssetPreload
...
Asset Preload fix for json serialization and prefab game mode
5 years ago
d61c93a7b6
Merge pull request #431 from aws-lumberyard-dev/Prefab/Create/IgnoreLevel
...
LYN-3211 | Create Prefab can be triggered on the Level Container, generating an invalid level hierarchy
5 years ago
36911723c2
Addressed PR feedback
5 years ago
f7ea02afdc
Fix for NetworkingProcessor using CreateSpawnable without ReferencedAssets arg
5 years ago
17ccf90480
Updated function header comment
5 years ago
886fe22b16
Merge branch 'main' into Prefab/CreatePrefab
5 years ago
b57dd02d90
Removed a debug print command
5 years ago
2e9ae76596
Removed print statement, adding in new files that were missed
5 years ago
4994103627
Add const ref function parameters as needed
5 years ago
b04bfc459f
Asset Preload fix for json serialization and prefab game mode
5 years ago
0da6e450a6
Improved comments
5 years ago
e24827efb3
Fix direct editing of a reference
5 years ago
4662290d92
Switching IsPrefabInInstanceAncestorHierarchy to use const refs
5 years ago
47001dc0c3
Merge main
5 years ago
1c04160966
Added a missing header
5 years ago
eb8084d3f6
Initial draft for getting instantiation to work immediately after creation is undone
5 years ago
a5ccfa6053
Merge pull request #456 from aws-lumberyard-dev/Prefab/CreatePrefab
...
Fix undo for nested prefab creation by providing link patches to the undo node
5 years ago
a7624bb985
Removed returning AZ::Failure when AZ::Assert is thrown
5 years ago
5eeeaf4346
Fixed several release build compile errors.
5 years ago
bc3f285601
Refactored IsPrefabInInstanceAncestorHierarchy to use Instance Optional References. Added more information to the error message.
5 years ago
6e8b1d1000
Update on how we move string values in AddProductDependency
5 years ago
a9de24ef7d
Addressed PR feedback on function args and names
5 years ago
7f971f726d
Merge branch 'main' into Prefab/Instantiate/Loop
5 years ago
d433cd623b
Fix undo for nested prefab creation by providing link patches to the undo node
5 years ago
e22398700d
Simplified some checks, added early outs.
5 years ago
15b1ae4b2d
Removed excess whitespace
5 years ago
7df8a88b0e
Merge branch 'main' into Spawnable/ProductDependency
5 years ago
845b748061
Updated PrefabBuilder to include product dependencies defined in AddProductDependency
5 years ago
8f1499581b
Merge branch 'main' into Prefab/Create/IgnoreLevel
5 years ago
c3c90cc821
Merge branch 'main' into Spawnable/ProductDependency
5 years ago
48c34628f6
Exclude the Level root prefab container when creating prefabs.
5 years ago
6947e8fe29
Added an IsObject check for nested instance DOM during link creation that happens during prefab loading
5 years ago
3b49b59c32
Added AddProductDependency calls to PrefabProcessorContext
5 years ago
Mike Balfour
srikappa-amzn
srikappa
sconel
sconel
Danilo Aimini
daimini
AMZN-koppersr