* Reinstates an allocator for FileCacheManager
Replaces the allocator that was removed during redcode that is used for
loading banks. Default schema for now to get things working again.
* Update path functions to AZ::IO::Path
Removes old PathUtil functions in favor of AZ::IO::Path apis.
* Update the audio allocator classes
Cleans up the audio allocator classes a bit.
* Addresses PR feedback
Updates some code to handle nullptr a bit better, and improve log
messages.
* Updates to audio CVars and address feedback
Per feedback, converted more of the audio cvars to AZ_CVAR, but not all
of them could be converted at this time. Moved audio allocator
initialization to system component ctor/dtor to give RAII. Updated
location of a PAL file.
* Updates the copyright of the file added in this PR
Merged copyright changes, so need to update new files.
This function creates a new object on the stack, and was returning it as
a reference. This would trigger Clang 12's `-Wreturn-stack-address`
warning, and cause the build to fail.
This is a cherry-pick from #1285
* Add ability to change project name
* Fixed several issues where path types were changed
* Added PythonBindings CreateProject unit test
* Fix python warning format
* Validate new project name in CLI
* Fix issue creating pathview on linux
* Use better testing macros
* Refactored the unit_test_engine_template.py test to actually test
against the current engine_template.py commands
The commands of create-template, create-from-template, create-project
and create-gem is now being validated.
Registered the unit_test_engine_template.py script with CTest in the smoke test
suite so that it runs in Automated Review
Fixed issues in the engine_template.py script where the template_restricted_path parameter was required in the create_project and create_gem functions
Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
* add repository to ci_build_metrics
* fixing build
* changing the job to pass the right parameters
* passing parameters that need to be expanded
* missed this, important
* fixing typo
Fixed shader and material "Failed to find builder dependency" errors
Merge pull request #1462 from aws-lumberyard-dev/santorac/stabilization/2106/MissingDependencyWarnings-ATOM-15136
Fixed a couple builders to avoid adding job dependencies on source files that don't exist.
This removes mostly benign (but noisy) messages about "Failed to find builder dependency".
Changed AssetUtils::GetPossibleDepenencyPaths to return all possible source paths, rather than stopping when one is found. This function is now used to report a list of all possible source dependencies, so that CreateJobs will get called by the AP whenever a file shows up at one of those locations. If a file was missing before and then appears, this will cause the builders to wake up and add the appropriate job dependencies on the new files. In ShaderVariantAssetBuilder and MaterialBuilder, we now use GetPossibleDepenencyPaths to report source dependencies rather than job dependencies. We only report a job dependency when the actual source file has been identified. This should all now be consistent with the intended design of the AP's dependency systems (the prior approach was a hack based on misunderstanding of what source dependencies are).
SrgLayoutBuilder's change is a bit tricky. The above changes did not fix all of the "Failed to find builder dependency" messages because AzslBuilder sometimes skips particular files in CreateJobs. When this happens, it is invalid to report an AzslBuilder job dependency on that file. So I copied the same conditional code that is used to skip an azsli file in CreateJobs, and used that to skip AddAzslBuilderJobDependency() in SrgLayoutBuilder as well.
With all these changes combined, I do think we've solved the issue where jobs fail to evict outdated jobs, as described in ATOM-15134. However, we are not yet seeing the iteration time improvements we were hoping for. Before these changes I was seeing roughly a 0.5 minute delay for the initial change, and a 2 minute delay for a subsequent change. With these changes it's more like 0.5 mibutes and 1.5 minutes. It appears that the AP scan is being starved by all the AssetBuilder processing going on, and perhaps IO contention. I suspect that this will be greatly improved on the development branch where we no longer have AzslBuilder and SrgLayoutBuilder slowing things down.
ATOM-15136 Builder dependency errors reported in mainline
ATOM-15134 Replace GetPossibleDepenencyPaths Approach with Source Dependencies
Testing:
- Deleted and rebuild the ASV cache a few times.
- Ran through a few different scenarios of adding and removing referenced files in the project folder and gem folder. Covering...
- Parent materials
- Material types
- Material functors
- I discovered a particular scenario that produces incorrect results, but I verified the scenario fails without my changes too: LYN-4757
- Opened a few levels in AtomTest.
[ATOM-14344][ATOM-13908] Merging skinned and static mesh motion shaders using an optional vertext stream. This removes the log spam "Mesh does not have all the required input streams. Missing 'POSITIONT0'." and allows Material::GetShaderCollection() to be const only as it was intended. The MeshFeatureProcessor also no longer needs to decide which motion vector shader to use, and therefore no longer has m_skinnedMeshWithMotion in the descriptor to acquire a mesh.
* Updated Project Settings Screen with preview and fixed moving projects
* Tests for some Project Utils
* Remove old defined consts
* Update UX to use display name when avaliable where appropriate
* Use newPreviewImagePath for temp changing preview.png otherwise use iconPath for preview in UX
* Removed use of newPreviewImagePath in ProjectButton
* Fix resource mappings file names and client auth warnings and asserts conditions
* Add comments to explain reasoning for client auth role permissions
* Update comments based on feedback
* Fix AWSClientAuth unit test
* Add parameters to specify custom native build path and enable unity build in Android gradle builds
* Enable unity build for gradle to shorten the path to the generated object files which fixes build failures on Jenkins due to paths exceeding limit. This also speeds up builds.
Scott Romero
AMZN-nggieber
Qing Tao
Ken Pruiksma
Eric Phister
amzn-mike
evanchia-ly-sdets
mrieggeramzn
mriegger
Terry Michaels
lumberyard-employee-dm
Chris Burel
Jonny Galloway
amzn-sean
Steve Pham
jonawals
sphrose
Alex Peterson
sharmajs-amzn
Esteban Papp
John
dmcdiarmid-ly
Doug McDiarmid
Chris Santora
Chris Santora
amzn-hdoke
AMZN-puvvadar
SJ