Commit Graph

6726 Commits

Author SHA1 Message Date
srikappa-amzn 546ce377f0 Merge branch 'development' into Prefab/IncreaseReadFileSizeLimit
Signed-off-by: srikappa-amzn <srikappa@amazon.com>
2021-09-09 09:09:04 -07:00
hultonha d82b2a0608 Initial test coverage for viewport selection before introducing new 'single' select functionality (#3987)
* WIP changes for viewport single select and better integration tests

Signed-off-by: hultonha <hultonha@amazon.co.uk>

* update test to verify single click selection in the viewport

Signed-off-by: hultonha <hultonha@amazon.co.uk>

* temporarily remove changes for single select

Signed-off-by: hultonha <hultonha@amazon.co.uk>

* temporarily remove ChangeSelectedEntity call

Signed-off-by: hultonha <hultonha@amazon.co.uk>

* initial tests to validate current viewport selection model

Signed-off-by: hultonha <hultonha@amazon.co.uk>

* some tidy-up before publishing PR

Signed-off-by: hultonha <hultonha@amazon.co.uk>

* add reference to const type in loop

Signed-off-by: hultonha <hultonha@amazon.co.uk>

* temporarily disable box select test

Signed-off-by: hultonha <hultonha@amazon.co.uk>
2021-09-09 10:23:55 +01:00
moraaar c86a1427a0 Fixed ragdoll panel being available in Animation Editor when PhysX gem is enabled. (#3985)
Following the same approach as cloth plugin, which is to ask if the system component of the gem is available (in this case PhysX::SystemComponent).

Fixes #2540

Signed-off-by: moraaar moraaar@amazon.com
2021-09-09 09:48:32 +01:00
moraaar 05644a54a5 Merge pull request #3997 from aws-lumberyard-dev/fix_lyn6482_ebp_warning_errors
{LYN6482} Fix warning as error in Editor Python Bindings
Signed-off-by: Jackson 23512001+jackalbe@users.noreply.github.com
2021-09-09 09:41:01 +01:00
AMZN-AlexOteiza 1442f1275b Fixed Physics SC tests (#4001)
Signed-off-by: AMZN-AlexOteiza <aljanru@amazon.co.uk>
2021-09-09 09:32:43 +02:00
srikappa-amzn a80314f84a Added a missing include file
Signed-off-by: srikappa-amzn <srikappa@amazon.com>
2021-09-08 23:25:24 -07:00
Steve Pham e6573766c2 Fixes for release builds for unused variable warnings (#4000)
Signed-off-by: Steve Pham <spham@amazon.com>
2021-09-08 21:13:36 -07:00
Guthrie Adams d46223db05 Merge pull request #3998 from aws-lumberyard-dev/Atom/guthadam/fixing_gestures_gem_warnings
Fixing gestures gem warnings when gEnv/pTimer is null
2021-09-08 17:06:27 -05:00
srikappa-amzn 7bf5894513 Set max file size limit as default parameter for ReadFile
Signed-off-by: srikappa-amzn <srikappa@amazon.com>
2021-09-08 14:29:08 -07:00
srikappa-amzn 1e7af75d94 Merge branch 'development' into Prefab/IncreaseReadFileSizeLimit
Signed-off-by: srikappa-amzn <srikappa@amazon.com>
2021-09-08 14:09:07 -07:00
Nicholas Lawson 30cafff04d new LZ4 package to fix debug compile issue (#3993)
* Updates lz4 to rev3 of packages which fixes debug builds

Signed-off-by: lawsonamzn <70027408+lawsonamzn@users.noreply.github.com>
2021-09-08 13:37:37 -07:00
Alex Peterson 9f06bffc1b Fix ebus node slots not checked for vars (#3994)
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com>
2021-09-08 13:19:03 -07:00
Vincent Liu 81966cbcbf [LYN-5564] Update AWSNativeSDK revision (#3686)
Signed-off-by: onecent1101 <liug@amazon.com>
2021-09-08 12:57:13 -07:00
Guthrie Adams 3ad3e557e5 Fixing gestures gem warnings when gEnv/pTimer is null
Signed-off-by: Guthrie Adams <guthadam@amazon.com>
2021-09-08 14:37:19 -05:00
bosnichd 8941c9d227 Add [[maybe_unused]] to some local variables that are only referenced as arguments to CryLogAlways that is not compiled in release. (#3992)
Signed-off-by: bosnichd <bosnichd@amazon.com>
2021-09-08 13:21:15 -06:00
Jackson 88319fcaf9 {LYN6482} Fix warning as error in Editor Python Bindings
Signed-off-by: Jackson <23512001+jackalbe@users.noreply.github.com>
2021-09-08 13:52:19 -05:00
amzn-phist f2e6c2dc2b Fix compile errors in the Wwise Gem (#3989)
One fixes string literal format specifiers warnings that were disabled.
One fixes a FileFunc utility that was removed.

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>
2021-09-08 13:26:50 -05:00
dmcdiarmid-ly 5f7040a0ae Merge pull request #3972 from aws-lumberyard-dev/Atom/dmcdiar/ATOM-16381
Add RayTracingPass support for the Scene Srg
2021-09-08 11:16:20 -07:00
sphrose cc7cc9b7a8 Terrain/sphrose/layer spawner (#3980)
* #3326 Get layer priorities to work.

Signed-off-by: sphrose <82213493+sphrose@users.noreply.github.com>

* Refresh terrain when layer settings change

Signed-off-by: sphrose <82213493+sphrose@users.noreply.github.com>

* Removed dependency notification handling: it isn't needed due to deactivate/activate cycle caused by editor redrawing.
Moved layer registering to ordered map sorted by priority.

Signed-off-by: sphrose <82213493+sphrose@users.noreply.github.com>

* Remove unused code, add extra sort condition.

Signed-off-by: sphrose <82213493+sphrose@users.noreply.github.com>

* Fix copy/paste error.

Signed-off-by: sphrose <82213493+sphrose@users.noreply.github.com>

* Change erase method.

Signed-off-by: sphrose <82213493+sphrose@users.noreply.github.com>

* Review suggestions.

Signed-off-by: sphrose <82213493+sphrose@users.noreply.github.com>

* Fix bus disconnect order, change GetUseGroundPlane to return bool.

Signed-off-by: sphrose <82213493+sphrose@users.noreply.github.com>

* Create unit tests for Terrain Spawning component #3224

Signed-off-by: sphrose <82213493+sphrose@users.noreply.github.com>

* Remove unintended commit.

Signed-off-by: sphrose <82213493+sphrose@users.noreply.github.com>

* Remove blank line.

Signed-off-by: sphrose <82213493+sphrose@users.noreply.github.com>

* PR changes.

Signed-off-by: sphrose <82213493+sphrose@users.noreply.github.com>
2021-09-08 10:55:22 -05:00
John Jones-Steele 817f8ce4c1 Terrain/jjjoness/3172 axis aligned box shape component (#3981)
* CHanges to Push/Pop Matrix

Signed-off-by: John Jones-Steele <jjjoness@amazon.com>

* Fixed bad commit

Signed-off-by: John Jones-Steele <jjjoness@amazon.com>

* REmoved the AxisAlignedBoxShapeComponentBux and AxisAlignedBoxShapeConfig

Signed-off-by: John Jones-Steele <jjjoness@amazon.com>

* Fixed derivation of AxisAlignedBoxShape

Signed-off-by: John Jones-Steele <jjjoness@amazon.com>

* Added ShowChildrenOnly to Component

Signed-off-by: John Jones-Steele <jjjoness@amazon.com>

* Fixed cmake file

Signed-off-by: John Jones-Steele <jjjoness@amazon.com>

* Changes from review

Signed-off-by: John Jones-Steele <jjjoness@amazon.com>

* Added tests for AxisAlignedBoxShape

Signed-off-by: John Jones-Steele <jjjoness@amazon.com>

* Addressed PR comments and added one further test.

Signed-off-by: John Jones-Steele <jjjoness@amazon.com>

* Removed dead code.

Signed-off-by: John Jones-Steele <jjjoness@amazon.com>

* Changes from review

Signed-off-by: John Jones-Steele <jjjoness@amazon.com>

* Spelling fix and changed link to docs

Signed-off-by: John Jones-Steele <jjjoness@amazon.com>

* Fixed profile bug in Linux

Signed-off-by: John Jones-Steele <jjjoness@amazon.com>

* Fixed problem with Unity Profile Build in Tests

Signed-off-by: John Jones-Steele <jjjoness@amazon.com>
2021-09-08 10:50:29 -05:00
hultonha 6863e9cf9e Camera orbit fix (#3963)
* Fix for camera look-at and position being the same when calculating orbit point

Signed-off-by: hultonha <hultonha@amazon.co.uk>

* add unit test to verify camera orbit behavior

Signed-off-by: hultonha <hultonha@amazon.co.uk>
2021-09-08 13:37:06 +01:00
jromnoa 5c4ce8cd06 Upload test screenshots to s3 on test failure. (#3815)
* add s3 upload on screenshot test failure, should only apply to the test_gpu_profile_vs2019 job on nightly runs

* adds support for zipping screenshot files up prior to uploading to the s3 bucket and also adds the ACL extra arg to the upload_to_s3.py execution

* remove unused json import

* remove regex to use .endswith() instead and rename variables to be more clear (PR feedback)

* rename create_zip_archive to create_screenshots_archive

Signed-off-by: jromnoa <jromnoa@amazon.com>
2021-09-08 06:11:44 -05:00
srikappa-amzn 5a6daf4352 Maximize read file size limit and set it to 1MiB for Atom use cases
Signed-off-by: srikappa-amzn <srikappa@amazon.com>
2021-09-08 02:02:24 -07:00
hultonha 052ff90c9d Preparatory work to allow for more viewport integration tests (#3961)
* preparatory work to allow for more viewport integration tests

Signed-off-by: hultonha <hultonha@amazon.co.uk>

* minor grammatical fix

Signed-off-by: hultonha <hultonha@amazon.co.uk>

* fix for missed bus call update

Signed-off-by: hultonha <hultonha@amazon.co.uk>
2021-09-08 09:36:04 +01:00
Guthrie Adams 6b5b82717d Merge pull request #3967 from aws-lumberyard-dev/Atom/guthadam/adding_null_checks_to_gestures_gem
Adding null checks to Gestures gem if gEnv isn't set
2021-09-07 18:45:48 -05:00
Esteban Papp 9fe3c87f4e Merge pull request #3968 from aws-lumberyard-dev/FixDebugCompileErrors
Fix some debug compile errors introduced by https://github.com/o3de/o3de/pull/3903
2021-09-07 16:20:15 -07:00
Esteban Papp d814662810 Fixes renderdoc define
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
2021-09-07 16:15:22 -07:00
dmcdiar 5f95c41eb5 Added RayTracingPass support for the Scene Srg.
Signed-off-by: dmcdiar <dmcdiar@amazon.com>
2021-09-07 15:52:03 -07:00
Esteban Papp 46c6923bf7 Enabling warnings around format security
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
2021-09-07 15:17:40 -07:00
dmcdiarmid-ly 89d0557dd3 Merge pull request #3966 from aws-lumberyard-dev/Atom/dmcdiar/ATOM-16380
Remove mesh from raytracing scene when hidden
2021-09-07 14:23:35 -07:00
bosnichd 12fb91a484 Fix some debug compile errors introduced by https://github.com/o3de/o3de/pull/3903
Signed-off-by: bosnichd <bosnichd@amazon.com>
2021-09-07 15:08:39 -06:00
Junbo Liang 8edcc504bd Add AWSI automation tests to a new test suite and pipe (#3913)
Signed-off-by: junbo <junbo@amazon.com>
2021-09-07 13:02:13 -07:00
Esteban Papp fe8f4a7720 typo
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
2021-09-07 12:55:07 -07:00
Guthrie Adams 214ebb7308 Adding null checks to Gestures gem if gEnv isn't set
Signed-off-by: Guthrie Adams <guthadam@amazon.com>
2021-09-07 14:40:20 -05:00
dmcdiar fd007548e0 MeshFeatureProcessor::SetVisible now adds or removes the mesh from the raytracing scene as appropriate.
Signed-off-by: dmcdiar <dmcdiar@amazon.com>
2021-09-07 12:16:04 -07:00
Esteban Papp 1d4487f4f8 Improvement suggestion from another PR
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
2021-09-07 11:53:40 -07:00
Esteban Papp e7156144a8 Merge branch 'development' into renderdoc_define
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
2021-09-07 11:49:11 -07:00
Artur K 2a2847b15d Legacy code cleanup - part 3 (#3903)
* Legacy cleanup - part 3

Not much is left that can be easily removed,
so I think this will be last cleanup before the legacy functionality is replaced.

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

* fix windows build, remove a few more things, re-add one file

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

* Remove legacy RenderBus + more cleanups

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

* Remove MaterialOwnerBus.h

Clean-up in Cry_Matrix34/33

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>
2021-09-07 12:14:16 -06:00
Esteban Papp 1d98ab3a1c Fixes renderdoc define
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
2021-09-07 11:09:31 -07:00
moudgils 4d5b047c1b Fix PipelineLibraries (DX12 backend). (#3768)
* Fix loading of PipelineLibraries from disk for DX12 backend.

Signed-off-by: moudgils <moudgils@amazon.com>

* Disabled Saving out PipelineLibraries (for DX12) if pix or Renderdoc is enabled.
Addressed some feedback

Signed-off-by: moudgils <moudgils@amazon.com>

* Fixed an issue withe loading PipelineLibraries and added a cleaner abstraction to not save empty libraries for dx12

Signed-off-by: moudgils <moudgils@amazon.com>
2021-09-07 11:03:11 -07:00
Esteban Papp d1df0fbe47 reverting one that was changed by mistake
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
2021-09-07 08:17:06 -07:00
Esteban Papp e20c270580 Fixes install failures when RenderDoc and/or PIX are enabled
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
2021-09-07 07:59:03 -07:00
moraaar f551e69b2b PythonProxyNotificationHandler::OnEventGenericHook acquires the Python GIL before executing (#3904)
- Protected python execution of OnEventGenericHook by trying to lock the GIL and show a descriptive error when it was not possible to lock.
- Improved mechanism to lock python mutex and GIL in PhytonSystemComponent. Acquiring/releasing GIL once per thread.
- Added unit test to verify errors are fired when trying to execute OnEventGenericHook from another thread (as it should not able to acquire the GIL).
- Improved python threading tests to actually using python buses.

Signed-off-by: moraaar moraaar@amazon.com
2021-09-07 15:35:04 +01:00
hultonha 33299399af File renames for settings updates
Merge pull request #3952 from aws-lumberyard-dev/hultonha_GH-3579_tidyup
2021-09-07 09:16:31 +01:00
AMZN-AlexOteiza c002515036 Merge pull request #3945 from aws-lumberyard-dev/reorg_px2
Final part of PhysX/Whitebox/NvCloth/Blast Standarization of paths and multiple fixes
2021-09-06 22:18:28 +02:00
hultonha b8f65cc78b updates after file renames
Signed-off-by: hultonha <hultonha@amazon.co.uk>
2021-09-06 18:24:45 +01:00
ANT\aljanru 9159eccb25 Fixes for periodic and gpu tests affected by the move 2021-09-06 17:03:10 +02:00
Hulton-Harrop 3e9a415b27 EditorPreferences modernize file rename
Signed-off-by: Hulton-Harrop <hultonha@amazon.co.uk>
Signed-off-by: hultonha <hultonha@amazon.co.uk>
2021-09-06 15:06:45 +01:00
Hulton-Harrop 6c1185bcbb rename CEditorPreferencesPage_ViewportMovmement to CEditorPreferencesPage_ViewportCamera
Signed-off-by: Hulton-Harrop <hultonha@amazon.co.uk>
Signed-off-by: hultonha <hultonha@amazon.co.uk>
2021-09-06 15:06:43 +01:00
Benjamin Jillich 784542d82e EMotionFX: Resetting motion sets is not registered in the Motions pane which may lead to a crash (#3762)
Remove motion set callback was missing and the window wasn't updated in case it was hidden.

Signed-off-by: Benjamin Jillich <jillich@amazon.com>
2021-09-06 16:00:16 +02:00