Fixes for release builds for unused variable warnings (#4000)

Signed-off-by: Steve Pham <spham@amazon.com>
4 years ago · e6573766c2
parent d46223db05
commit e6573766c2
24 changed files with 25 additions and 25 deletions
--- a/Code/Framework/AzToolsFramework/AzToolsFramework/Asset/AssetBundler.cpp
+++ b/Code/Framework/AzToolsFramework/AzToolsFramework/Asset/AssetBundler.cpp
@ -44,7 +44,7 @@ namespace AzToolsFramework
    const char AssetBundleSettingsFileExtension[] = "bundlesettings";
    const char BundleFileExtension[] = "pak";
    const char ComparisonRulesFileExtension[] = "rules";
-    const char ErrorWindowName[] = "AssetBundler";
+    [[maybe_unused]] const char ErrorWindowName[] = "AssetBundler";
    const char* AssetFileInfoListComparison::ComparisonTypeNames[] = { "delta", "union", "intersection", "complement", "filepattern", "intersectioncount" };
    const char* AssetFileInfoListComparison::FilePatternTypeNames[] = { "wildcard", "regex" };
    const char DefaultTypeName[] = "default";
--- a/Code/Framework/AzToolsFramework/Platform/Linux/AzToolsFramework/Archive/ArchiveComponent_Linux.cpp
+++ b/Code/Framework/AzToolsFramework/Platform/Linux/AzToolsFramework/Archive/ArchiveComponent_Linux.cpp
@ -15,7 +15,7 @@ namespace AzToolsFramework
 {
    namespace Platform
    {
-        static const char ErrorChannel[] = "ArchiveComponent_Linux";
+        [[maybe_unused]] static const char ErrorChannel[] = "ArchiveComponent_Linux";

        static const char ZipExePath[] = R"(/usr/bin/zip)";
        static const char UnzipExePath[] = R"(/usr/bin/unzip)";
--- a/Code/Tools/Standalone/Source/LUA/LUAEditorMainWindow.cpp
+++ b/Code/Tools/Standalone/Source/LUA/LUAEditorMainWindow.cpp
@ -60,8 +60,8 @@ void initSharedResources()

 namespace
 {
-    const char* LUAEditorDebugName = "LUA Debug";
-    const char* LUAEditorInfoName = "LUA Editor";
+    [[maybe_unused]] const char* LUAEditorDebugName = "LUA Debug";
+    [[maybe_unused]] const char* LUAEditorInfoName = "LUA Editor";
 }


--- a/Gems/Atom/Asset/ImageProcessingAtom/Code/Source/Processing/ImageConvert.cpp
+++ b/Gems/Atom/Asset/ImageProcessingAtom/Code/Source/Processing/ImageConvert.cpp
@ -63,7 +63,7 @@ namespace ImageProcessingAtom
        StepAll
    };

-    const char ProcessStepNames[StepAll][64] =
+    [[maybe_unused]] const char ProcessStepNames[StepAll][64] =
    {
        "ValidateInput",
        "GenerateColorChart",
--- a/Gems/Atom/Asset/Shader/Code/Source/Editor/AtomShaderConfig.cpp
+++ b/Gems/Atom/Asset/Shader/Code/Source/Editor/AtomShaderConfig.cpp
@ -21,7 +21,7 @@ namespace AZ
    {
        namespace AtomShaderConfig
        {
-            static constexpr char AtomShaderConfigName[] = "AtomShaderConfig";
+            [[maybe_unused]] static constexpr char AtomShaderConfigName[] = "AtomShaderConfig";

            bool MutateToFirstAbsoluteFolderThatExists(AZStd::string& relativeFolder, AZStd::vector<AZStd::string>& watchFolders)
            {
--- a/Gems/Atom/Asset/Shader/Code/Source/Editor/CommonFiles/CommonTypes.cpp
+++ b/Gems/Atom/Asset/Shader/Code/Source/Editor/CommonFiles/CommonTypes.cpp
@ -16,7 +16,7 @@ namespace AZ
 {
    namespace ShaderBuilder
    {
-        static const char* s_azslShaderCompilerName = "AZSL Compiler";
+        [[maybe_unused]] static const char* s_azslShaderCompilerName = "AZSL Compiler";

        AZ::RHI::Format StringToFormat(const char* format)
        {
--- a/Gems/Atom/Asset/Shader/Code/Source/Editor/PrecompiledShaderBuilder.cpp
+++ b/Gems/Atom/Asset/Shader/Code/Source/Editor/PrecompiledShaderBuilder.cpp
@ -26,7 +26,7 @@ namespace AZ
 {
    namespace
    {
-        static const char* PrecompiledShaderBuilderName = "PrecompiledShaderBuilder";
+        [[maybe_unused]] static const char* PrecompiledShaderBuilderName = "PrecompiledShaderBuilder";
        static const char* PrecompiledShaderBuilderJobKey = "PrecompiledShader Asset Builder";
        static const char* ShaderAssetExtension = "azshader";
    }
--- a/Gems/Atom/Asset/Shader/Code/Source/Editor/ShaderBuilderUtility.cpp
+++ b/Gems/Atom/Asset/Shader/Code/Source/Editor/ShaderBuilderUtility.cpp
@ -45,7 +45,7 @@ namespace AZ
    {
        namespace ShaderBuilderUtility
        {
-            static constexpr char ShaderBuilderUtilityName[] = "ShaderBuilderUtility";
+            [[maybe_unused]] static constexpr char ShaderBuilderUtilityName[] = "ShaderBuilderUtility";

            Outcome<RPI::ShaderSourceData, AZStd::string> LoadShaderDataJson(const AZStd::string& fullPathToJsonFile)
            {
--- a/Gems/Atom/RHI/Code/Source/RHI.Edit/Utils.cpp
+++ b/Gems/Atom/RHI/Code/Source/RHI.Edit/Utils.cpp
@ -30,7 +30,7 @@ namespace AZ
    namespace RHI
    {
        static AZStd::mutex s_profilingMutex;
-        static constexpr char ShaderPlatformInterfaceName[] = "ShaderPlatformInterface";
+        [[maybe_unused]] static constexpr char ShaderPlatformInterfaceName[] = "ShaderPlatformInterface";

        void ShaderCompilerProfiling::Entry::Reflect(ReflectContext* context)
        {
--- a/Gems/Atom/RHI/Vulkan/Code/Source/RHI.Builders/ShaderPlatformInterface.cpp
+++ b/Gems/Atom/RHI/Vulkan/Code/Source/RHI.Builders/ShaderPlatformInterface.cpp
@ -23,7 +23,7 @@ namespace AZ
 {
    namespace Vulkan
    {
-        static const char* VulkanShaderPlatformName = "VulkanShaderPlatform";
+        [[maybe_unused]] static const char* VulkanShaderPlatformName = "VulkanShaderPlatform";
        static const char* WindowsPlatformShaderHeader = "Builders/ShaderHeaders/Platform/Windows/Vulkan/PlatformHeader.hlsli";
        static const char* AndroidPlatformShaderHeader = "Builders/ShaderHeaders/Platform/Android/Vulkan/PlatformHeader.hlsli";
        static const char* WindowsAzslShaderHeader = "Builders/ShaderHeaders/Platform/Windows/Vulkan/AzslcHeader.azsli";
--- a/Gems/Atom/RPI/Code/Source/RPI.Builders/Common/AnyAssetBuilder.cpp
+++ b/Gems/Atom/RPI/Code/Source/RPI.Builders/Common/AnyAssetBuilder.cpp
@ -30,7 +30,7 @@ namespace AZ
    {
        namespace
        {
-            const char* AnyAssetBuilderName = "AnyAssetBuilder";
+            [[maybe_unused]] const char* AnyAssetBuilderName = "AnyAssetBuilder";
            const char* AnyAssetBuilderJobKey = "Any Asset Builder";
            const char* AnyAssetBuilderDefaultExtension = "azasset";
            const char* AnyAssetSourceExtensions[] =
--- a/Gems/Atom/RPI/Code/Source/RPI.Builders/Material/MaterialBuilder.cpp
+++ b/Gems/Atom/RPI/Code/Source/RPI.Builders/Material/MaterialBuilder.cpp
@ -36,7 +36,7 @@ namespace AZ
    {
        namespace
        {
-            static constexpr char const MaterialBuilderName[] = "MaterialBuilder";
+            [[maybe_unused]] static constexpr char const MaterialBuilderName[] = "MaterialBuilder";
        }

        const char* MaterialBuilder::JobKey = "Atom Material Builder";
--- a/Gems/Atom/RPI/Code/Source/RPI.Builders/Model/MaterialAssetBuilderComponent.cpp
+++ b/Gems/Atom/RPI/Code/Source/RPI.Builders/Model/MaterialAssetBuilderComponent.cpp
@ -37,7 +37,7 @@ namespace AZ
 {
    namespace RPI
    {
-        static const char* MaterialExporterName = "Scene Material Builder";
+        [[maybe_unused]] static const char* MaterialExporterName = "Scene Material Builder";

        void MaterialAssetDependenciesComponent::Reflect(ReflectContext* context)
        {
--- a/Gems/Atom/RPI/Code/Source/RPI.Builders/Model/ModelExporterComponent.cpp
+++ b/Gems/Atom/RPI/Code/Source/RPI.Builders/Model/ModelExporterComponent.cpp
@ -37,7 +37,7 @@ namespace AZ
 {
    namespace RPI
    {
-        static const char* s_exporterName = "Atom Model Builder";
+        [[maybe_unused]] static const char* s_exporterName = "Atom Model Builder";

        ModelExporterComponent::ModelExporterComponent()
        {
--- a/Gems/Atom/RPI/Code/Source/RPI.Builders/Pass/PassBuilder.cpp
+++ b/Gems/Atom/RPI/Code/Source/RPI.Builders/Pass/PassBuilder.cpp
@ -28,7 +28,7 @@ namespace AZ
    {
        namespace
        {
-            static const char* PassBuilderName = "PassBuilder";
+            [[maybe_unused]] static const char* PassBuilderName = "PassBuilder";
            static const char* PassBuilderJobKey = "Pass Asset Builder";
            static const char* PassAssetExtension = "pass";
        }
--- a/Gems/AtomLyIntegration/AtomBridge/Code/Source/Editor/AssetCollectionAsyncLoaderTestComponent.cpp
+++ b/Gems/AtomLyIntegration/AtomBridge/Code/Source/Editor/AssetCollectionAsyncLoaderTestComponent.cpp
@ -24,7 +24,7 @@ namespace AZ
 {
    namespace AtomBridge
    {
-        static constexpr char AssetCollectionAsyncLoaderTestComponentName[] = " AssetCollectionAsyncLoaderTestComponent";
+        [[maybe_unused]] static constexpr char AssetCollectionAsyncLoaderTestComponentName[] = " AssetCollectionAsyncLoaderTestComponent";

        void AssetCollectionAsyncLoaderTestComponent::Reflect(AZ::ReflectContext* context)
        {
--- a/Gems/EditorPythonBindings/Code/Source/PythonProxyBus.cpp
+++ b/Gems/EditorPythonBindings/Code/Source/PythonProxyBus.cpp
@ -293,7 +293,7 @@ namespace EditorPythonBindings
                    handler->m_ebus->m_name.c_str(), eventName);
            }

-            void OnEventGenericHook(const char* eventName, pybind11::function callback, [[maybe_unused]] int eventIndex, AZ::BehaviorValueParameter* result, int numParameters, AZ::BehaviorValueParameter* parameters)
+            void OnEventGenericHook([[maybe_unused]] const char* eventName, pybind11::function callback, [[maybe_unused]] int eventIndex, AZ::BehaviorValueParameter* result, int numParameters, AZ::BehaviorValueParameter* parameters)
            {
                // build the parameters to send to callback
                Convert::StackVariableAllocator stackVariableAllocator;
--- a/Gems/LmbrCentral/Code/Source/Builders/MaterialBuilder/MaterialBuilderComponent.cpp
+++ b/Gems/LmbrCentral/Code/Source/Builders/MaterialBuilder/MaterialBuilderComponent.cpp
@ -19,7 +19,7 @@

 namespace MaterialBuilder
 {
-    const char s_materialBuilder[] = "MaterialBuilder";
+    [[maybe_unused]] const char s_materialBuilder[] = "MaterialBuilder";

    namespace Internal
    {
--- a/Gems/LmbrCentral/Code/Source/Builders/SliceBuilder/SliceBuilderWorker.cpp
+++ b/Gems/LmbrCentral/Code/Source/Builders/SliceBuilder/SliceBuilderWorker.cpp
@ -49,7 +49,7 @@ namespace SliceBuilder
        }
    } // namespace anonymous

-    static const char* const s_sliceBuilder = "SliceBuilder";
+    [[maybe_unused]] static const char* const s_sliceBuilder = "SliceBuilder";
    static const char* const s_sliceBuilderSettingsFilename = "SliceBuilderSettings.json";

    SliceBuilderWorker::SliceBuilderWorker()
--- a/Gems/LyShine/Code/Pipeline/LyShineBuilder/UiCanvasBuilderWorker.cpp
+++ b/Gems/LyShine/Code/Pipeline/LyShineBuilder/UiCanvasBuilderWorker.cpp
@ -31,7 +31,7 @@

 namespace LyShine
 {
-    static const char* const s_uiSliceBuilder = "UiSliceBuilder";
+    [[maybe_unused]] static const char* const s_uiSliceBuilder = "UiSliceBuilder";

    void UiCanvasBuilderWorker::ShutDown()
    {
--- a/Gems/ScriptCanvas/Code/Include/ScriptCanvas/Core/SubgraphInterface.cpp
+++ b/Gems/ScriptCanvas/Code/Include/ScriptCanvas/Core/SubgraphInterface.cpp
@ -33,7 +33,7 @@ namespace SubgraphInterfaceCpp
        Current
    };

-    const size_t k_maxTabs = 20;
+    [[maybe_unused]] const size_t k_maxTabs = 20;

    AZ_INLINE const char* GetTabs(size_t tabs)
    {
--- a/Gems/ScriptCanvas/Code/Include/ScriptCanvas/Execution/Interpreted/ExecutionInterpretedAPI.cpp
+++ b/Gems/ScriptCanvas/Code/Include/ScriptCanvas/Execution/Interpreted/ExecutionInterpretedAPI.cpp
@ -45,7 +45,7 @@ namespace ExecutionInterpretedAPICpp
        0, 1, 2, 3, 4, 5, 6, 7, 8, 9, k_Bad,k_Bad,k_Bad,k_Bad,k_Bad,k_Bad,k_Bad, 10, 11, 12, 13, 14, 15
    };

-    constexpr unsigned char k_FastValuesIndexSentinel = 'G' - '0';
+    [[maybe_unused]] constexpr unsigned char k_FastValuesIndexSentinel = 'G' - '0';

    template<typename T>
    T* GetAs(AZ::BehaviorValueParameter& argument)
--- a/Gems/ScriptEvents/Code/Builder/ScriptEventsBuilderWorker.cpp
+++ b/Gems/ScriptEvents/Code/Builder/ScriptEventsBuilderWorker.cpp
@ -27,7 +27,7 @@

 namespace ScriptEventsBuilder
 {
-    static const char* s_scriptEventsBuilder = "ScriptEventsBuilder";
+    [[maybe_unused]] static const char* s_scriptEventsBuilder = "ScriptEventsBuilder";

    Worker::Worker()
    {
--- a/Gems/Terrain/Code/Source/TerrainRenderer/TerrainFeatureProcessor.cpp
+++ b/Gems/Terrain/Code/Source/TerrainRenderer/TerrainFeatureProcessor.cpp
@ -36,7 +36,7 @@ namespace Terrain
    namespace
    {
        const uint32_t DEFAULT_UploadBufferSize = 512 * 1024; // 512k
-        const char* TerrainFPName = "TerrainFeatureProcessor";
+        [[maybe_unused]] const char* TerrainFPName = "TerrainFeatureProcessor";
    }

    namespace ShaderInputs