0bccecaa15
Fixed logic for when to cull entities from having their viewport manipulators regenerated.
...
Signed-off-by: Chris Galvan <chgalvan@amazon.com >
2021-12-09 11:36:39 -06:00
c2341a7e3c
Fix for change with axis gizmo labels not appearing ( #6256 )
...
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
2021-12-09 09:30:51 +00:00
f62ba7d1a4
Add ComponentApplicationLifecycle::RegisterEvent calls to avoid test console spam ( #6245 )
...
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
2021-12-09 09:30:24 +00:00
1aed839271
Fixed typo.
...
Signed-off-by: Chris Galvan <chgalvan@amazon.com >
2021-12-08 15:02:41 -06:00
9dc32a0381
Additional read-only prefab workflow changes.
...
Signed-off-by: Chris Galvan <chgalvan@amazon.com >
2021-12-08 12:30:31 -06:00
b54215552c
Prevent the camera from easily being set to an invalid orientation ( #6203 )
...
* add temporary debug logging
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* improvement for box select sometimes getting stuck on
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* add temporary debug logging
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* improvement for box select sometimes getting stuck on
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* remove temporary logging
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* fixes for camera pitch issues
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* missed file with camera pitch fixes
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* remove debug logs
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* add some tests for new pitch constraint updates
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
2021-12-08 09:42:40 +00:00
a8ef23e4ae
Merge pull request #6232 from aws-lumberyard-dev/cgalvan/ReadOnlyPrefabWorkflowChanges
...
Some read-only prefab workflow updates.
2021-12-07 19:38:54 -06:00
3a7d9f9b3a
LYN-8633 | Read-Only Entities - Entity Outliner behavior changes ( #6230 )
...
* Add invalid entityId check to IsReadOnly
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Ensure read-only entities editing is limited (no renaming, limited drag/drop, no asset drop on them)
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Removing redundant class definition in wrong namespace.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-12-07 16:58:29 -08:00
6532c50c27
Some read-only prefab workflow updates.
...
Signed-off-by: Chris Galvan <chgalvan@amazon.com >
2021-12-07 17:22:10 -06:00
5cca52e73c
Merge branch 'development' into redcode/driller_removal
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
# Conflicts:
# Code/Framework/AzCore/AzCore/azcore_files.cmake
# Gems/Atom/Feature/Common/Assets/Materials/Presets/MacBeth/15_red_sRGB.tif
2021-12-07 13:31:55 -08:00
cd5306febf
Merging from development
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-07 12:35:41 -08:00
7c96bc4f1f
Fix loaded procprefabs not going through the asset hint fixup process… ( #6077 )
...
* Fix loaded procprefabs not going through the asset hint fixup process for all versions of LoadInstanceFromPrefabDom.
Fixes procprefab asset references not working when pressing Ctrl+G in the editor
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Add unit test
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Add missing include
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
2021-12-07 13:00:47 -06:00
4b97f7bac2
Merge pull request #5296 from aws-lumberyard-dev/sc-editor-asset-redux
...
Sc editor asset redux
2021-12-07 09:15:52 -08:00
6e0ac97f13
Merge pull request #6178 from aws-lumberyard-dev/daimini/gitflow_211206_o3de
...
Merged `stabilization/2111RTE` to `development`
2021-12-06 15:51:01 -08:00
efe63f3e95
Merge commit 'c5615f812ccc9d235747a1c5ba396ac2e9a23690' into daimini/gitflow_211206_o3de
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
# Conflicts:
# Code/Framework/AzToolsFramework/Tests/Prefab/PrefabTestFixture.cpp
# Code/Framework/AzToolsFramework/Tests/Prefab/PrefabTestFixture.h
# Code/Framework/AzToolsFramework/Tests/UI/EntityOutlinerTests.cpp
2021-12-06 13:14:14 -08:00
d04f4d238c
Merge branch 'development' of https://github.com/o3de/o3de into cgalvan/ReadOnlyViewportChanges
2021-12-06 14:24:19 -06:00
15e26b7515
merge development
...
Signed-off-by: carlitosan <82187351+carlitosan@users.noreply.github.com >
2021-12-06 12:21:45 -08:00
10e95cd863
Updated logic to use AZStd::erase_if
...
Signed-off-by: Chris Galvan <chgalvan@amazon.com >
2021-12-06 14:21:00 -06:00
476e66d902
LYN-8631 + LYN-8632 | Display appropriate read-only icons and procedural prefabs ui in the Outliner ( #6160 )
...
* First step of procedural prefab styling and read-only registration.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* WIP - Introduce read-only handler for procedural prefabs (not hooked up)
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Introduce read-only entity interface, handler and unit tests.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Introduce temp read-only icon, use new icon hierarchy in Outliner.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Switch from a push paradigm to a pull paradigm - handlers get to implement logic to determine if an entity should be read-only. This allows multiple systems to weigh into whether an entity is read-only.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Fixed to missing call in test
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Post-rebase fixes to class name changes
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Display a lock icon on top of the entity icon in the Entity Outliner. This icon is added programmatically, which prevents having to alter all Outliner icons and future-proofs this functionality.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Minor style changes to procedural prefabs in the Outliner (use white icon)
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Ensure cache is refreshed when the handler is created, and also whenever the focus changes.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Remove Procedural Prefab setreg that was added in the wrong place
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Remove redundant function
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Fix spacing issue caused by rebase
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Change tooltip so that it accurately says "inspect" instead of "edit" for procedural prefabs.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Address minor styling issues mentioned in PR.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-12-06 12:16:16 -08:00
e24323660b
Fixed typo.
...
Signed-off-by: Chris Galvan <chgalvan@amazon.com >
2021-12-06 12:44:52 -06:00
1f279ca713
Updated viewport to hide the transform maniuplators for entities marked as read only.
...
Signed-off-by: Chris Galvan <chgalvan@amazon.com >
2021-12-06 12:19:02 -06:00
d583256b17
Merge pull request #6144 from aws-lumberyard-dev/cgalvan/ReadOnlyEntityInspectorChanges
...
Updated Entity Inspector to changed behavior when an Entity has been marked as read-only.
2021-12-06 12:01:39 -06:00
aa5563803f
Merge pull request #6110 from aws-lumberyard-dev/Atom/guthadam/update_trace_logger_to_clear_log
...
Changing trace logger to clear log file when opened
2021-12-06 11:17:46 -06:00
a7989df051
Fixed status combo box style in Entity Inspector.
...
Signed-off-by: Chris Galvan <chgalvan@amazon.com >
2021-12-06 10:39:49 -06:00
969dbf407a
Add tests for planar manipulator draw when dealing with scaling ( #6164 )
...
* add support to add a custom debug display request interface for manipulator test framework
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* wip changes to support tests for manipulator view drawing
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* add test for planar manipulator draw when dealing with scaling
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* additional comments for added context
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* small updates/fixes after PR feedback
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* fix for missing NullDebugDisplayRequests
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
2021-12-06 14:53:45 +00:00
c5615f812c
Fixing pivot offset when performing undo on Transform component ( #6150 )
...
* Fixing undo offest on transform component
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Fixining possible issue with firing an unnecessary OnTransformChanged event when entity is manually disabled/enabled
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Adding better comments
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Unit tests
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Cherrupicking changes
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
2021-12-06 14:46:47 +00:00
87fb6be964
Fixes to Procedural Prefab instantiation - ensure the container of the procprefab has the correct editor components, and remove limitation to instantiating at the root. ( #6147 )
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-12-03 15:38:29 -08:00
b470f917ca
Listen to read-only entity state changes so we can refresh if the read-only state changes on one of our selected entities.
...
Signed-off-by: Chris Galvan <chgalvan@amazon.com >
2021-12-03 16:37:35 -06:00
0dbf1b0b43
Enables memory tracking (leak detection) in more unit tests
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-03 14:32:27 -08:00
273fb87eeb
Renamed variable to be more descriptive.
...
Signed-off-by: Chris Galvan <chgalvan@amazon.com >
2021-12-03 16:21:31 -06:00
af75b3a52a
Made clearing the log file optional and renamed the function
...
Signed-off-by: Guthrie Adams <guthadam@amazon.com >
2021-12-03 15:44:04 -06:00
03adf700fe
Merge branch 'development' into redcode/driller_removal
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-03 13:35:16 -08:00
d56cfa40dd
Changing trace logger to clear log file when opened
...
Also switched the log message sink from a vector to a list so the entire container does not have to be rebuilt every time and entry is added.
Signed-off-by: Guthrie Adams <guthadam@amazon.com >
2021-12-03 15:00:53 -06:00
954642c1ce
Updated Entity Inspector to changed behavior when an Entity has been marked as read-only.
...
Signed-off-by: Chris Galvan <chgalvan@amazon.com >
2021-12-03 13:40:07 -06:00
799cc68de2
no message
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-03 11:38:49 -08:00
d0511cf444
Fix warnings on Mac builds. ( #6112 )
...
* Fix warnings on Mac builds.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Save one map query
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-12-03 10:31:40 -08:00
8344539ab6
Manipulator Bounds updates ( #5959 )
...
* first pass updates to improve manipulators
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* add setting to enable/disable manipulator axis flipping
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* update manipulator cvar to use ed_ naming convention
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* wip updates to add AzToolsFramework values to the SettingsRegistry
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* expose a number of manipulator settings for configuration
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* add setting for manipulator base scale to change size of all manipulators together
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* minor updates before posting PR
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* add manipulator section for settings registry paths
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* fix for failing unit test after manipulator changes
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* fix total scale
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* fix for polygon prism component shape tests
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
2021-12-03 14:46:15 +00:00
2dd2e53a29
Linux build fixes
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-02 18:50:51 -08:00
bb685ee40b
Merge branch 'development' into redcode/driller_removal
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-02 18:12:48 -08:00
7817ed76bf
Removes FileIOEventBus
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-02 18:08:45 -08:00
c5460c2064
Removes driller from AzToolsFramework
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-02 15:40:23 -08:00
6bd0308339
Merge remote-tracking branch 'origin/development' into sc-editor-asset-redux
...
Signed-off-by: carlitosan <82187351+carlitosan@users.noreply.github.com >
2021-12-02 14:17:35 -08:00
625fca71ab
Prefab/unit tests for deletion ( #6034 )
...
* Added tests for deleting entity under level and other prefabs
Signed-off-by: srikappa-amzn <82230713+srikappa-amzn@users.noreply.github.com >
* Added class comments and improved variable names
Signed-off-by: srikappa-amzn <82230713+srikappa-amzn@users.noreply.github.com >
* Called the reflect function of PrefabFocusHandler from PrefabSystemComponent
Signed-off-by: srikappa-amzn <82230713+srikappa-amzn@users.noreply.github.com >
* Added couple of unit tests around entity and prefab deletion
Signed-off-by: srikappa-amzn <82230713+srikappa-amzn@users.noreply.github.com >
* Used engine root path from settings registry as fake path for prefab creation
Signed-off-by: srikappa-amzn <82230713+srikappa-amzn@users.noreply.github.com >
* Added 2 unit tests around deleting prefabs
Signed-off-by: srikappa-amzn <82230713+srikappa-amzn@users.noreply.github.com >
2021-12-02 08:09:28 -08:00
47de333e94
Removes m_enableDrilling
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-01 16:50:45 -08:00
e16781e6b6
LYN-8629 | Read-Only Entities - Setup ( #6059 )
...
* Introduce read-only entity interface, handler and unit tests.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Switch from a push paradigm to a pull paradigm - handlers get to implement logic to determine if an entity should be read-only. This allows multiple systems to weigh into whether an entity is read-only.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Fixed to missing call in test
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Renaming ReadOnlyEntityQueryNotificationBus to ReadOnlyEntityQueryRequestBus for consistency with engine patterns.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-12-01 12:24:49 -08:00
fb6e6e339f
Add CRC validator ( #5857 )
...
* Adds crc validation checks
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Fixes invalid CRCs
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Changes test to smoke suite
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* excludes some test data from the validator
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* uses pathlib instead of os.path
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* fixes wrong path to test scripts
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Escape not needed
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-11-30 15:07:57 -08:00
4dd9e94bc3
Add tests for deleting an entity from the level and from another prefab ( #5839 )
...
* Added tests for deleting entity under level and other prefabs
Signed-off-by: srikappa-amzn <82230713+srikappa-amzn@users.noreply.github.com >
* Added class comments and improved variable names
Signed-off-by: srikappa-amzn <82230713+srikappa-amzn@users.noreply.github.com >
* Called the reflect function of PrefabFocusHandler from PrefabSystemComponent
Signed-off-by: srikappa-amzn <82230713+srikappa-amzn@users.noreply.github.com >
* Added function comments and made an if statement to be one line
Signed-off-by: srikappa-amzn <82230713+srikappa-amzn@users.noreply.github.com >
2021-11-30 08:20:25 -08:00
6908a3e945
Update intersect behavior for positioning entities in the viewport ( #5906 )
...
* update intersect behavior for positioning entities in the viewport and restore SurfaceManipulator
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* tests for surface manipulator from EditorTransformComponentSelection
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* update comments in tests and remove #pragma optimize('', off)@
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* add new file for FindClosestPickIntersection tests
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* add remaining tests for surface manipulator and snap fixes
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* some small updates and polish before PR
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* small updates following PR feedback
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
2021-11-30 15:07:40 +00:00
75d6cb2527
Connected filterChanged signal to Update the table Model ( #5901 )
...
Signed-off-by: AMZN-Igarri <82394219+AMZN-Igarri@users.noreply.github.com >
2021-11-30 14:54:01 +00:00
4424b4d51e
Fix Integer Spin Controller not sending PropertyEditorGUIMessages::Bus::Handler::OnEditingFinished ( #5942 )
...
* IntWidgetHandler::CreateUI now registers and sends editingFinished event
* add tests for int spin control valueChanged and editingFinished signals
Signed-off-by: amzn-sean <75276488+amzn-sean@users.noreply.github.com >
2021-11-30 10:49:53 +00:00
Chris Galvan
Tom Hulton-Harrop
Danilo Aimini
Esteban Papp
amzn-mike
carlitosan
Guthrie Adams
Mikhail Naumov
Guthrie Adams
srikappa-amzn
AMZN-Igarri
amzn-sean