I'm pretty sure that CryString::Format is broken, but it's slated for removal along with the rest of CrySystem, so I'm just addressing the symptom rather than the likely cause (mainly to save time, but also out of an abundance of caution in case other code is inadvertently depending on the existing behaviour of CryString::Format).
Signed-off-by: bosnichd <bosnichd@amazon.com>
Updated and simplified the version number validation regex to support 4-component numerical only version strings
Removed stale WAF reconfigure and replaced save notification dialog to inform the user a manual reconfigure of the project may be required for the settings to be propagated
* Visualizer: implement basic performance widget with controls
Signed-off-by: Jacob Hilliard <jhlliar@amazon.com>
* Visualizer: implement basic function statistics
- Fix floating point bug in drawing logic
- Implement color picker for regions
- Aggregate invocations and average time across frames
Signed-off-by: Jacob Hilliard <jhlliar@amazon.com>
* Visualizer: drawing execution time labels
Signed-off-by: Jacob Hilliard <jhlliar@amazon.com>
* Visualizer: fix fstring type errors
Signed-off-by: Jacob Hilliard <jhlliar@amazon.com>
* Visualizer: fix remaining fstring errors
Signed-off-by: Jacob Hilliard <jhlliar@amazon.com>
* Visualizer: implement cursor-relative zooming
Signed-off-by: Jacob Hilliard <jhlliar@amazon.com>
* Visualizer: try to update AR status
Signed-off-by: Jacob Hilliard <jhlliar@amazon.com>
* Visualizer: address PR comments + cleanup
Signed-off-by: Jacob Hilliard <jhlliar@amazon.com>
* Visualizer: address more PR comments
Signed-off-by: Jacob Hilliard <jhlliar@amazon.com>
* Visualizer: address more PR comments
Signed-off-by: Jacob Hilliard <jhlliar@amazon.com>
-Don't eat mouse/keyboard release events in the ViewportManipulatorController
-Do a key activity check in the LegacyViewportCameraController instead of checking state (this could be done elsewhere but it seems to be working as-is and is scheduled to go away)
-Ignore idle mouse delta updates sent to the modular camera controller
Signed-off-by: nvsickle <nvsickle@amazon.com>
* Cherry Picking (lyn1751)
Problem with DCO so we need to cherry pick this branch.
Signed-off-by: aaguilea <aaguilea@amazon.com>
* Cherry picking #2
Signed-off-by: aaguilea <aaguilea@amazon.com>
* Cherry picking 3
Signed-off-by: aaguilea <aaguilea@amazon.com>
* Changed variables reverseurls
This was just changing some name variables.
Signed-off-by: aaguilea <aaguilea@amazon.com>
* Changes from past PR
Signed-off-by: aaguilea <aaguilea@amazon.com>
* changes from past PR and fixed small bug:
Also removed some legacy code from Resources.h
Signed-off-by: aaguilea <aaguilea@amazon.com>
* couple of changes from actual PR
Signed-off-by: aaguilea <aaguilea@amazon.com>
* fixed copyright issues for AR
Signed-off-by: aaguilea <aaguilea@amazon.com>
We currently cannot predict when a given snapshot will be taken. This is
problematic as test impact analysis assumes that the coverage data will
be updated after each run. As we have no control over when our coverage
data will persist we will instead always seed when the pipeline and
branch is one of the seeding pipelines, otherwise we will attempt to
read that seed data and perform test impact analysis (if no seed data is
present we will fall back to a regular, uninstrumented run of all test
targets).
This approach has the following implications:
1. PR builds will benefit from test impact analysis as the seed data is
(hopefully) available at the time the snapshot is created.
2. Builds for the aforementioned seeding branches and pipelines will not
benefit from test impact analysis and will incur the cost of seeding
regardless of whether or not that generated seed data ends up in the
snapshot.
Signed-off-by: John <jonawals@amazon.com>
* Determine the original vertex index based on the position
The Assimp library does not expose the FBX control point indices. This
change causes vertices that are close enough in their position to be
considered as coming from the same control point. This allows the mesh
optimizer to consider vertices with the same control point index (or
"original vertex index" as it is called in the code) for deduplication.
Signed-off-by: Chris Burel <burelc@amazon.com>
* Use a filter view instead of reimplementing a filter view
Signed-off-by: Chris Burel <burelc@amazon.com>
* Don't attempt to weld similar vertices if there's blendshapes
Signed-off-by: Chris Burel <burelc@amazon.com>
* Add test for the mesh optimizer's ability to weld nearby vertices
Signed-off-by: Chris Burel <burelc@amazon.com>
* Add logging call to show mesh optimizer effect on vertex count
Signed-off-by: Chris Burel <burelc@amazon.com>
* Use a bunch of temporaries in order to make `position` `const`
Signed-off-by: Chris Burel <burelc@amazon.com>
jonawals
SergeyAMZN
bosnichd
Scott Romero
Jacob Hilliard
mgwynn
Chris Galvan
pereslav
jckand-amzn
Jeongseok Lee
nvsickle
amzn-phist
Royal OBrien
Brian Herrera
mcphedar
Terry Michaels
hultonha
hultonha
AMZN-Alexandre Corcia Aguilera
Benjamin Jillich
amzn-sean
AMZN-Igarri
Chris Burel
lumberyard-employee-dm