You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
o3de/Code/Framework/AzToolsFramework/Tests
lumberyard-employee-dm f648cb1fd8
Update the FileIO Aliases (#4186)
* Update the FileIOAlias naming to make the cache, project root and engine
root paths more clear

The alias of `@root@`, `@assets@`, and `@projectplatformcache@` has been
collapsed to `@projectproductassets@`

The alias of `@devroot@` and `@engroot@` has been collapsed to
`@engroot@`

The alias of `@devassets@` and `@projectroot@` has been collapsed to
`@projectroot@`

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated use of devassets and devroot properties in python

Those properties now use projectroot and engroot

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updating the alias @engroot@ alias path comment in each platform specific LocalFileIO_*.cpp file

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Removed hardcoded size of 9 for the product asset alias.

The ResolvePath function now just appends the @projectproductassets@
alias with the input path

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Remove duplicate @projectproductassets@ check in ProcessFileTreeRequest

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Fix for typos in Hydra python test

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated LocalFileIO::Copy call on Windows to use the Unicode aware CopyFileW API

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated the AWSMetreicsGemAllocatorFixture to properly suppress asset
cache write errors for Test file creation.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Removed unneeded call to set the @projectproductasstes@ alias at the bottom of the AssetSeedManagerTest SetUp

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Added a deprecated alias map to the FileIO System

When a deprecated alias is accessed, the FileIO System logs an AZ_Error and indicates the alias that should be used

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated python test scripts to use the projectroot binding

Retrieving the AutomatedTesting project path based on "<devroot>/AutomatedTesting" has been removed.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated references to devroot and devgame within the codebase

The GetAbsoluteDevGameFolderPath functions has been replaced with direct call to AZ::Utils::GetProjectPath
The GetAbsoluteDevRootFolderPath functions has been replaced with direct calls to AZ::Utils::GetEnginePath

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated <engroot>/AutomatedTesting references to projectroot


Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Replaced references that assumes the project path is <engroot>/AutomatedTesting with <projectroot> in the AutomatedTesting python test

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Correct casing in emfxworkspace file


Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Removed newly added AppendPathParts function
Removed the Path constructors which accepts a PathIterable instance

The PathIterable isn't safe to return to a user of the Path class as it might be referencing temporary paths supplied via PathView arguments

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Fixed unused parameter warning

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Undid change to the LexicallyProximate function to set the path result to the base path.

It needs to return the *this path if the pathResult is empty

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Moved the LocalFileIO ConvertToAbsolutePath implementations to AZ::Utils

Fixed the ConvertToAbsolutePath implementation for Unix platforms to use a buffer that is size PATH_MAX(4096 on all our supported Unix platforms).
Because the buffer before was AZ::IO::MaxPathLength which as a size of 1024, this was resulting in the Unix `realpath` function smashing the stack when it converts a path to an absolute path that is longer than 1024 characters

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated the EditorCore.Tests to attach the AZ Environment to the EditorCore shared library that is statically loaded on launch.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Fixed for DeprecatedAlaisesKeyVisitor Visit function causing the non string_view overloads being hidden causing a hidden base class function warning

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Changed the AWSMetricsGemMock to use a temporary for writing test assets

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated the LocalFileIO::ResolvePath function to use HasRootPath to determine if a path starts with a root path such as "D:", "D:/" or "/"

IsAbsolute was not the corect check as the path of "D:" is a relative
path.
To be absolute according to the Windows the path must have a root
directory. i.e "D:/" or "D:\"

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Removed absolute path comment from LocalFile_UnixLike.cpp and LocalFile_Android.cpp FindFiles implementations
Updated the ConvertToAlias to supply an AZ::IO::FixedMaxPath

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Replaced usage of the @projectproductassets@ alias with @engroot@ when referring to the LmbrCentral source folder in the CopyDependencyBuilderTest and the SeedBuilderTests

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated the ScriptCanvas Upgrade Tool to output backed up files to the
Project User Path instead of the engine root

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Fixed whitespacing issues in Application.cpp

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Remove unnecessary creation of a FixedMaxPath in the UpgradeTool.cpp

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Modified testSeedFolder variable in the SeedBuilderTests to use the
@engroot@ alias instead of @projectproductassets@/.. alias when
referring to the LmbrCentral Gem source path

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated references to the Project Asset Cache in the PythonTests.

Those tests no longer use the logic `azlmbr.paths.projectroot / "Cache" / "pc"` to retrieve a path to the cache root but instead the `azlmbr.paths.projectproductassets` constant

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Fixed the FileIO Deprecated Alias test on Windows

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Removing @projectsourceassets@ alias, as it is only used once.

Updated the PhysX EditorSystemComponent.cpp to query the ProjectPath
form the SettingsRegistry.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Replaced @projectproductassets@ alias with @products@

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Rollback changes to the PhysX EditorSystemComponent.cpp

The changes to use the ProjectPath from the SettingsRegistry has been implemented in PR #4497

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
4 years ago
..
Entity Modernization + AZStd::function compare fix. (#3680) 4 years ago
EntityOwnershipService Shorten copyright headers by splitting into 2 lines (#2213) 4 years ago
FocusMode Fixes to unit tests after merge 4 years ago
Prefab Fix Entity id consistency issue & refactor prefab workflows/tests (#4373) 4 years ago
Script Modernization + AZStd::function compare fix. (#3680) 4 years ago
SliceStabilityTests Update the FileIO Aliases (#4186) 4 years ago
ToolsComponents Code/Framework/AzToolsFramework 4 years ago
UI Shorten copyright headers by splitting into 2 lines (#2213) 4 years ago
Viewport Add explanatory comment to broadcast fixture. 4 years ago
Visibility Shorten copyright headers by splitting into 2 lines (#2213) 4 years ago
ArchiveTests.cpp Update the FileIO Aliases (#4186) 4 years ago
AssetFileInfoListComparison.cpp Add linux equivalents for all the places that enumerate platforms (#3325) 4 years ago
AssetSeedManager.cpp Update the FileIO Aliases (#4186) 4 years ago
AssetSystemMocks.h Update the FileIO Aliases (#4186) 4 years ago
AssetUtils.cpp Shorten copyright headers by splitting into 2 lines (#2213) 4 years ago
BoundsTestComponent.cpp LYN-7008 | Focus Mode - Selection unit tests (#4357) 4 years ago
BoundsTestComponent.h LYN-7008 | Focus Mode - Selection unit tests (#4357) 4 years ago
ComponentAdapterTests.cpp Shorten copyright headers by splitting into 2 lines (#2213) 4 years ago
ComponentAddRemove.cpp Modernization + AZStd::function compare fix. (#3680) 4 years ago
ComponentModeTestDoubles.cpp Shorten copyright headers by splitting into 2 lines (#2213) 4 years ago
ComponentModeTestDoubles.h Shorten copyright headers by splitting into 2 lines (#2213) 4 years ago
ComponentModeTestFixture.cpp Preparatory work to allow for more viewport integration tests (#3961) 4 years ago
ComponentModeTestFixture.h Shorten copyright headers by splitting into 2 lines (#2213) 4 years ago
ComponentModeTests.cpp Shorten copyright headers by splitting into 2 lines (#2213) 4 years ago
EditorTransformComponentSelectionTests.cpp LYN-7008 | Focus Mode - Selection unit tests (#4357) 4 years ago
EditorVertexSelectionTests.cpp Shorten copyright headers by splitting into 2 lines (#2213) 4 years ago
EntityIdQLabelTests.cpp Modernization + AZStd::function compare fix. (#3680) 4 years ago
EntityInspectorTests.cpp Modernization + AZStd::function compare fix. (#3680) 4 years ago
EntityTestbed.h Update the FileIO Aliases (#4186) 4 years ago
FileFunc.cpp Modernization + AZStd::function compare fix. (#3680) 4 years ago
FingerprintingTests.cpp Shorten copyright headers by splitting into 2 lines (#2213) 4 years ago
GenericComponentWrapperTest.cpp Shorten copyright headers by splitting into 2 lines (#2213) 4 years ago
InstanceDataHierarchy.cpp Modernization + AZStd::function compare fix. (#3680) 4 years ago
IntegerPrimtitiveTestConfig.h Shorten copyright headers by splitting into 2 lines (#2213) 4 years ago
LogLines.cpp Shorten copyright headers by splitting into 2 lines (#2213) 4 years ago
Main.cpp Shorten copyright headers by splitting into 2 lines (#2213) 4 years ago
ManipulatorBoundsTests.cpp Add a new implementation for cone/ray intersect to simplify code and fix issue with current implementation (#3902) 4 years ago
ManipulatorCoreTests.cpp Shorten copyright headers by splitting into 2 lines (#2213) 4 years ago
ManipulatorViewTests.cpp Shorten copyright headers by splitting into 2 lines (#2213) 4 years ago
PerforceComponentTests.cpp Shorten copyright headers by splitting into 2 lines (#2213) 4 years ago
PlatformAddressedAssetCatalogTests.cpp Update the FileIO Aliases (#4186) 4 years ago
PropertyIntCtrlCommonTests.cpp Shorten copyright headers by splitting into 2 lines (#2213) 4 years ago
PropertyIntCtrlCommonTests.h Shorten copyright headers by splitting into 2 lines (#2213) 4 years ago
PropertyIntSliderCtrlTests.cpp Shorten copyright headers by splitting into 2 lines (#2213) 4 years ago
PropertyIntSpinCtrlTests.cpp Shorten copyright headers by splitting into 2 lines (#2213) 4 years ago
PropertyTreeEditorTests.cpp Cleanup SerializeContext.h pt.1 (#4264) 4 years ago
PythonBindingTests.cpp Shorten copyright headers by splitting into 2 lines (#2213) 4 years ago
QtWidgetLimitsTests.cpp Shorten copyright headers by splitting into 2 lines (#2213) 4 years ago
SQLiteConnectionTests.cpp Modernization + AZStd::function compare fix. (#3680) 4 years ago
Slice.cpp Modernization + AZStd::function compare fix. (#3680) 4 years ago
SliceUpgradeTests.cpp Shorten copyright headers by splitting into 2 lines (#2213) 4 years ago
SliceUpgradeTestsData.h Shorten copyright headers by splitting into 2 lines (#2213) 4 years ago
Slices.cpp Shorten copyright headers by splitting into 2 lines (#2213) 4 years ago
SpinBoxTests.cpp Fix for events that should have been consumed by manipulators (#3108) 4 years ago
ThumbnailerTests.cpp Shorten copyright headers by splitting into 2 lines (#2213) 4 years ago
TransformComponent.cpp Code/Framework/AzToolsFramework 4 years ago
UndoStack.cpp Modernization + AZStd::function compare fix. (#3680) 4 years ago
aztoolsframeworktests_files.cmake LYN-7008 | Focus Mode - Selection unit tests (#4357) 4 years ago