* Re-enabled linux tests physics
* Fix for python load errors on Linux (#5627)
* Explicitly load libpython on Linux
Downstream loads of python modules that weren't linked to libpython would
fail to load because libraries were loaded using the RTLD_LOCAL flag. This
adds a function that will explicitly load libpython on Linux using the
RTLD_GLOBAL flag.
Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>
* Fix misspelled function name
Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>
* Addressing PR feedback
- Updates naming and location of things.
- Adds load code to a Gem template.
- Updates error checking.
Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>
* Address further feedback
Removes the api function in favor of just having modules inherit off a
PythonLoader class, that way we get RAAI behavior and lifetime management
for free.
Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>
Signed-off-by: aljanru <aljanru@amazon.co.uk>
Co-authored-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>
We no longer need a timeout here. A timeout mechanism was added to the mount script to raise an exeception if the EBS volume is not mounted in the configured timeframe.
This also causes a bug with the retry mechanism where Jenkins will hit this timeout in the event the node goes offline during the setup stage instead of raising an exception.
Signed-off-by: brianherrera <briher@amazon.com>
We no longer need a timeout here. A timeout mechanism was added to the mount script to raise an exeception if the EBS volume is not mounted in the configured timeframe.
This also causes a bug with the retry mechanism where Jenkins will hit this timeout in the event the node goes offline during the setup stage instead of raising an exception.
Signed-off-by: brianherrera <briher@amazon.com>
This updates the licenses script to pull in all PackageInfo.json files with a specific argument, then follows each license file defined and writes the contents to a file. In this mode, if a packageinfo file is found, it will only grab the license file path defined within.
Also has the following features:
* Generalizes the function and variable names for non-license specific references
* Sorts os.walk to maintain consistent ordering
* Uses an ordered dict for the output, also to maintain ordering if using Python below 3.7
* Adds an additional json config file to have specific exclusion rules for 3p packages
* Adds a package creation function and config file entry
* Allow multipath scans, optional use of gitignore, merged license file scan
Signed-off-by: Mike Chang <changml@amazon.com>
* adds a test_install_profile_vs2019_pipe job to validate a project can build from the SDK
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
* missed escaping these variables and breaks runtime dependencines in the install layout
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
* Changes to PIPELINE_ENV_OVERRIDE
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
* Tries to propagate ENV variables from pipeline jobs to jobs under it
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
* Fixes typo
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
* echoing a var to understand why is not going to the right path
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
* put the COMMAND_CWD in the wrong job
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
* adding similar jobs for linux/mac
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
* dont pass an empty LY_PROJECTS
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
* cmd -> sh, copy-paste mistake
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
* inverting check in linux/mac
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
* more fixes for linux/mac
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
* fixing script paths for macos
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
* more fixes for linux/mac
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
* Test use of %% instead of !! for windows builds
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
* fixes typo
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
* Add platform name to AP log path on S3
Signed-off-by: shiranj <shiranj@amazon.com>
* Add platform name to AP log path on S3
Signed-off-by: shiranj <shiranj@amazon.com>
* Fixed the return value of the ConvertToAbsolutePath function
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
* Added the generated cmake_dependencies.*.setreg files to engine.pak (#5073)
* Copied the generated cmake_dependencies.*.setreg file to the Cache
directory
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
* Removed the platform name from the bootstrap.game.*.setreg
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
* Update how the project related file paths are determined when not
supplied.
The project-path determination now goes back to only detecting a "project.json" file.
It no longer attempts to detect a "Cache" directory
The project-cache-path determination now in addition to checking the
project_cache_path key searches for a "Cache" directory.
The project-path defaults to executable folder if it cannot be detected.
The copying of generated executable folder Registry directory contents
to the product cache is now removed after the archive step.
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
* Updated the invocation of the AssetProcessor in Jenkins to supply an
absolute path to the project.
The project-path is no longer treated as relative to the engine root,
but instead relative to the current working directory at application
startup.
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
* Added constant for the storing the name of Cache directory
Fixed typos and grammatical errors in the SettingsRegistryMergeUtils.cpp
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
* Updated UnitTest prepend the EngineRoot path to "AutomatedTesting" when
setting the project path.
This is needed now that the project-path isn't treated relative to the
EngineRoot if it is not absolute.
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
* Fix AssetSeedManagerTest and PlatformAddressedAssetCatalogManagerTest
Instead of trying to used the AutomatedTesting directory as the project root, the temp directory created during the test is used as the project root.
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
* Moved the setting of the project cache root folder and project
asset platform root folder into the `if (!projectCachePath.empty())`
block
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
* Removing the scan up logic for the "Cache" directory.
This is no longer needed to locate the project cache path in a Project Game Release Layout.
Because the project path defaults to the executable directory if, it is not found, the Cache directory will be set to the "Cache" directory within the executable directory.
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
Added pathlib.Path.resolve() calls to make sure the compared paths were both absolute
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
* Validation lists cleanup
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
* more cleanup
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
* Updating LFS config to new endpoint (#1624)
Signed-off-by: AMZN-alexpete
* Updates licenses to APACHE-2.0 OR MIT (#1685)
Not to be committed before 7/6/2021
Signed-off-by: lawsonamzn <70027408+lawsonamzn@users.noreply.github.com>
* Updating CONTRIBUTING.md
Signed-off-by: Terry Michaels <miterenc@amazon.com>
* Fixed typo
Signed-off-by: Terry Michaels <miterenc@amazon.com>
* Updated text to be more descriptive
Signed-off-by: Terry Michaels <miterenc@amazon.com>
* Upload AP logs when there is an AP eeror
Signed-off-by: shiranj <shiranj@amazon.com>
* Add AP log upload step for single step Asset jobs
Signed-off-by: shiranj <shiranj@amazon.com>
* Address more comments
Signed-off-by: shiranj <shiranj@amazon.com>
* Only call CreateUploadAPLogsStage() once in try/catch block
Signed-off-by: shiranj <shiranj@amazon.com>
* Revert acciental update to README.md
Signed-off-by: shiranj <shiranj@amazon.com>
Co-authored-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com>
Co-authored-by: Chris Galvan <chgalvan@amazon.com>
Co-authored-by: Nicholas Lawson <70027408+lawsonamzn@users.noreply.github.com>
Co-authored-by: Terry Michaels <miterenc@amazon.com>
* Fixed create-project/create-gem to use relative paths directly
It was previously making relative paths, relative to the default_projects_folder and default_gems_folders
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
* Removed uppercase of "Templates" param in get_registered call.
That method looks up the restricted template directory location based on the lowercase key of "templates"
Updated argparse doc to fix typos or clarify which directories a path is relative to.
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
old vs. new defaults:
%USERHOME%/.o3de/Projects-> %USERHOME%/O3DE/Projects
%USERHOME%/.o3de/Gems-> %USERHOME%/O3DE/Gems
%USERHOME%/.o3de/Templates-> %USERHOME%/O3DE/Templates
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com>
Fixes the test screenshot upload build step:
- Added missing positional parameters
- Double quoting the command statements to allow variable expansion (also fixes broken Python call)
- Escaping the double quotes within the command statement
Signed-off-by: Mike Chang <changml@amazon.com>
Some Windows configs will automatically set new drives as online causing diskpart setup script to fail.
Signed-off-by: brianherrera <briher@amazon.com>
This change makes the inc_build_util script more resilient against transient network issues and issues encountered during node boot-up.
Signed-off-by: brianherrera <briher@amazon.com>
* adding Windows/release to PR-validation builds
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
* changing trace back to expand to nothing for release
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
* typo
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
* more fixes
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
* fixing some more unused variable cases
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
* renaming file in ScriptCanvas that causes a msbuild warning
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
* reverting a previous change
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
* Added a codesigning script to pre and post build steps in the Windows installer CD job
* Changed `windows_installer` job name to `installer_vs2019`
* Added `installer-nightly` tag for `installer_vs2019`
* Updated `build_config.json` to use an envvar for the installer url and bucket
Signed-off-by: Mike Chang <changml@amazon.com>
This change is required to support spot instances in the AR pipeline.
- When a node goes offline the job is retried on a new node
- Valid script errors are handled properly and the status is updated in Jenkins
Signed-off-by: brianherrera <briher@amazon.com>
Make awsi_test_profile_vs2019 a nonblocking step to make sure that resources are cleaned up even though automation tests failed
Signed-off-by: Junbo Liang <junbo@amazon.com>
* add s3 upload on screenshot test failure, should only apply to the test_gpu_profile_vs2019 job on nightly runs
* adds support for zipping screenshot files up prior to uploading to the s3 bucket and also adds the ACL extra arg to the upload_to_s3.py execution
* remove unused json import
* remove regex to use .endswith() instead and rename variables to be more clear (PR feedback)
* rename create_zip_archive to create_screenshots_archive
Signed-off-by: jromnoa <jromnoa@amazon.com>
* - Add support for a custom path root separator using a trait.
- Ensure to set both FilePathKey_ProjectUserPath and FilePathKey_ProjectLogPath to a writeable storage location on non-host platforms.
Signed-off-by: bosnichd <bosnichd@amazon.com>
* Remove az_trait_validator.py, as our PAL guidance no longer dictates that all traits must be defined for all platforms.
Signed-off-by: bosnichd <bosnichd@amazon.com>
* Updated based on review feedback.
Signed-off-by: bosnichd <bosnichd@amazon.com>
* Send SNS topic on build failure
* send build failure root cause data to SNS topic that triggeres lambda function to automatically create Github issues
* Change SNS topic subject to Build failure and add build url to the message
* Change SNS topic name
These scripts will configure build and test Ubuntu 18/20 nodes with:
Nvidia gaming drivers for GPU instances (g4dn)
lightdm for Ubuntu 18 and gdm3 for Ubuntu 20 (wayland is disabled here, but should have xcb capabilities)
NiceDCV for remote console access
Note: Does not include user setup and firewall configurations
Signed-off-by: Mike Chang <changml@amazon.com>
Mike Chang
AMZN-Phil
puvvadar
Tommy Walton
AMZN-AlexOteiza
Alex Peterson
Junbo Liang
sweeneys
Nicholas Van Sickle
Pip Potter
nggieber
AMZN-Phil
Shirang Jia
brianherrera
Esteban Papp
Chris Burel
AMZN-nggieber
lumberyard-employee-dm
Mike Balfour
Danilo Aimini
evanchia
Chris Galvan
jonawals
dialweb6
Mike Chang
scspaldi
jromnoa
bosnichd