Commit Graph

10658 Commits

Author SHA1 Message Date
carlitosan da0a10bb4c fix for edit SC action in entity context menu (#6686)
* on demand reflect az events when they are the return value of ebuses

Signed-off-by: carlitosan <82187351+carlitosan@users.noreply.github.com>

* fix crash and functionality for edit sc editor context menu action

Signed-off-by: carlitosan <82187351+carlitosan@users.noreply.github.com>
2022-01-05 19:04:55 -08:00
Esteban Papp 09fd52ef73 AzCore Math tests produce errors that need to be disabled in debug (#6678)
* Tests produce errors that need to be disabled in debug

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* PR suggestion

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
2022-01-05 16:07:52 -08:00
michabr 01c5fb7817 Add clamp mode to Draw2d (#6630)
Signed-off-by: abrmich <abrmich@amazon.com>
2022-01-05 15:27:52 -08:00
Allen Jackson 6c3d5c434e {lyn8865} Adding DataTypes::ScriptProcessorFallbackLogic (#6396)
* {lyn8865} Adding DataTypes::ScriptProcessorFallbackLogic

- Give the user an option how to handle fallback logic for script rules

Signed-off-by: Allen Jackson <23512001+jackalbe@users.noreply.github.com>

* the new code found an error in a Python script... it seems to work!

Signed-off-by: Allen Jackson <23512001+jackalbe@users.noreply.github.com>

* fixing up the regression test

Signed-off-by: Jackson <23512001+jackalbe@users.noreply.github.com>

* dump version number

Signed-off-by: Allen Jackson <23512001+jackalbe@users.noreply.github.com>
2022-01-05 16:08:58 -06:00
Chris Galvan 8a271cabb3 Merge pull request #6708 from aws-lumberyard-dev/cgalvan/RemoveMoreUnusedEditorCode
Removed unused Editor code from EditMode/Geometry/Include/LightmapCompiler
2022-01-05 15:27:07 -06:00
Roman 55fb63da48 Debug render aabb now include node, mesh and static aabb. (#6685)
Signed-off-by: rhhong <rhhong@amazon.com>
2022-01-05 12:54:41 -08:00
Chris Galvan 233349ffe3 Removed unused Editor code from EditMode/Geometry/Include/LightmapCompiler
Signed-off-by: Chris Galvan <chgalvan@amazon.com>
2022-01-05 13:35:09 -06:00
Esteban Papp 89067fe667 Memory/benchmarks (#5896)
* initial version ported from an old implementation

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* simplification of code

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* Fixes a recursive loop

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* Removing commented code of different options for getting memory usage of a process

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* PR comment (NULL->nullptr)

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* Adds mulit-threaded tests

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* Improving runtime and making the whole duration manageable

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* Fixes Linux build

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* Fixes for mac

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* Fixes for HeapSchema to get a default block if none is passed

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* Adds recording functionality (disabled) and a benchmark that can run recordings

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* Removes Heap allocator from being possible to use as a SystemAllocator since it doesnt allow dynamic allocating (only works with pre-allocated blocks)

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* WIP trying to use SystemAllocator instead of raw reads

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* Makes the recorded benchmark more stable

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* More stability changes, improvement on type usage within the benchmark, cleanup of unstable stats

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* Adds benchmark files for Android

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* Fixes Linux nounity build

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* PR comments

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* Death test relies on an exception from ocurring, that exception is an access violation, which could not happen (i.e. the memory could be valid for the process)
The test didnt have to be a death test. Also handled the situation better in the code to be able to continue in that scenario (useful for release configurations)"

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
2022-01-05 10:40:03 -08:00
Shirang Jia 1d0cd46cb7 Escape % for windows batch in palSh (#6688)
Signed-off-by: Shirang Jia <shiranj@amazon.com>
2022-01-05 09:54:52 -08:00
Esteban Papp 05da6aaa67 Removes unnecessary loop (#6684)
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
2022-01-05 09:26:08 -08:00
SWMasterson 4ce6909aaf Move, convert, and rename Lucy level to Hermanubis in AutomatedTesting (#6627)
Signed-off-by: Sean Masterson <semaster@amazon.com>
2022-01-05 11:03:28 -06:00
Michael Pollind e3bf4311eb bugfix: update attenuation when light intensity changed for mode Automatic (#6499)
REF: https://github.com/o3de/o3de/issues/6128

Signed-off-by: Michael Pollind <mpollind@gmail.com>
2022-01-05 10:22:47 -06:00
Esteban Papp c548fd7682 Death test relies on an exception from ocurring, that exception is an access violation, which could not happen (i.e. the memory could be valid for the process) (#6683)
The test didnt have to be a death test. Also handled the situation better in the code to be able to continue in that scenario (useful for release configurations)"

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
2022-01-05 08:15:08 -08:00
Benjamin Jillich 21d73033b7 Atom: Frame counter string sometimes extends across the whole width of the viewport (#6689)
When going into game mode or after initializing some system that takes a few seconds, the FPS counter showed really large numbers, extending across the whole with of the viewport. In this case, values show "inf" now.

Signed-off-by: Benjamin Jillich <jillich@amazon.com>
2022-01-05 16:53:49 +01:00
Chris Galvan ff947dfcc3 Merge pull request #6682 from aws-lumberyard-dev/cgalvan/RemoveUnusedEditorControls
Removed some unused classes from Editor/Controls
2022-01-05 06:05:29 -06:00
tjmgd 4695d36ea5 Fix: Blend node applies both poses at value 1 (#6292)
Signed-off-by: T.J. McGrath-Daly <tj.mcgrath.daly@huawei.com>

Co-authored-by: Tobias Alexander Franke <tobias.alexander.franke@huawei.com>
2022-01-05 09:54:34 +01:00
Benjamin Jillich 40ca1dcbf9 EMotion FX: Extendable pose data and pose debug visualization (#6639)
* Added debug draw function to the pose class for sharable and easy-to-use pose debug visualization that includes pose data debug rendering.
* Extended the pose data factory with the ability to add pose data types from outside of the EMFX SDK and external gems.
* In order to get access to the pose data factory, it got added to the EMFX manager.

Signed-off-by: Benjamin Jillich <jillich@amazon.com>
2022-01-05 09:10:12 +01:00
Chris Burel bfb1d0ad9e Merge pull request #6225 from aws-lumberyard-dev/burelc/inotify
[AssetProcessor] Refactor the FileWatcher to use only one watch thread
2022-01-04 18:18:29 -08:00
michabr 5eb6c2d24b Update UiCustomImageComponent to use Atom (#6628)
Signed-off-by: abrmich <abrmich@amazon.com>
2022-01-04 18:13:44 -08:00
dmcdiarmid-ly b719b1e8ee Merge pull request #6681 from aws-lumberyard-dev/rgba16f/revertAddingPassClass
Revert "added pass class (#6244)"
2022-01-04 17:41:21 -07:00
Chris Burel 648a21ab5c [Linux] Correct handling of new dirs added to non-recursive watch roots
Signed-off-by: Chris Burel <burelc@amazon.com>
2022-01-04 16:12:17 -08:00
Chris Burel 2bc1d8620e Rename file to adhere to PAL conventions
Signed-off-by: Chris Burel <burelc@amazon.com>
2022-01-04 16:12:17 -08:00
Chris Burel 484e27c109 Use AZStd::equal to implement path comparison
Signed-off-by: Chris Burel <burelc@amazon.com>
2022-01-04 16:12:17 -08:00
Chris Burel ce0bb1ca2b [AssetProcessor] Refactor the FileWatcher to use only one watch thread
This change reworks the AssetProcessor's FileWatcher so that it only uses
one thread. This is motivated by getting better support for inotify on
Linux. The previous architecture required calling `inotify_init` once for
each directory that was being watched, and using separate inotify instances
for each watched tree. In addition, having separate threads per watched
tree is not necessary, and just consumes system resources. Each platform
supports watching multiple directories with the same platform-specific
watcher API, so each platform has been updated accordingly.

The interface to the FileWatcher class is greatly simplified. Previously,
it supported client-supplied filtering of the paths that would generate
notifications. This was done by subclassing `FolderWatchBase` and
implementing `OnFileChange`. However, only one filter was ever used, so
that filter is now hard-coded in the FileWatcher class, and the classes
driving the old filtering mechanism are removed. Users of the interface
now have a much easier time, they just call `AddFolderWatch` with the path
to watch, and only have to connect to one set of signals, instead of
separate signals per watched directory.

Signed-off-by: Chris Burel <burelc@amazon.com>
2022-01-04 16:12:17 -08:00
Chris Burel 7ac5bc3d5c [Linux] Display a warning in AP if inotify fails to initialize
Signed-off-by: Chris Burel <burelc@amazon.com>
2022-01-04 16:12:17 -08:00
Chris Burel 04f4d5e031 [Linux] Avoid recursive inotify when a watch folder is set to recursive=false
Signed-off-by: Chris Burel <burelc@amazon.com>
2022-01-04 16:12:17 -08:00
michabr daf4dbb54d Fix LyShine debug display to work with Atom (#6516)
* LyShine cleanup pass for Atom conversion

Signed-off-by: abrmich <abrmich@amazon.com>

* Add GHI numbers to comments

Signed-off-by: abrmich <abrmich@amazon.com>

* Fix debug texture data

Signed-off-by: abrmich <abrmich@amazon.com>

* Fix debug canvas and draw call data

Signed-off-by: abrmich <abrmich@amazon.com>

* Add GHI issue

Signed-off-by: abrmich <abrmich@amazon.com>

* Address PR feedback

Signed-off-by: abrmich <abrmich@amazon.com>

* Remove unused variable

Signed-off-by: abrmich <abrmich@amazon.com>
2022-01-04 15:14:35 -08:00
Chris Galvan c773c9e9aa Removed some unused classes from Editor/Controls
Signed-off-by: Chris Galvan <chgalvan@amazon.com>
2022-01-04 16:39:04 -06:00
carlitosan c83bf11a3d on demand reflect az events when they are the return value of ebuses (#6625)
Signed-off-by: carlitosan <82187351+carlitosan@users.noreply.github.com>
2022-01-04 14:21:06 -08:00
Ronald Koppers 50b22a23cf Merge pull request #6631 from aws-lumberyard-dev/michabr/lyshine_shader_loc
Move LyShine shader to the gem
2022-01-04 14:01:33 -08:00
rgba16f 641037e30c Revert "added pass class (#6244)"
This reverts commit 515e363151.

Signed-off-by: rgba16f <82187279+rgba16f@users.noreply.github.com>
2022-01-04 15:40:55 -06:00
Vincent Liu 2b9d1ca813 Update to use AWSNativeSDK 1.9.50 (#6618)
* Update to use AWSNativeSDK 1.9.50
* After SDK upgrade, some AWS objects are bound to SDK allocator, init AWS SDK for unit test
2022-01-04 12:45:51 -08:00
Chris Galvan f051886789 Merge pull request #6675 from aws-lumberyard-dev/cgalvan/RemoveUnusedEditorCommonImages
Removed unused images under Editor/Common
2022-01-04 14:36:51 -06:00
amzn-mike 8ee384f436 Asset Processor: Remove gem loading from AP (#6488)
* AssetBuilder sends builder registration network message to AP

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Add AP activating status message

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* First builder handles registration.

Fixed deadlock caused by AP and AssetBuilder waiting on each other when registering by moving AP builder start code to a thread

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Clean up external builder registration

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Add thread description for builder manager idle thread

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Remove gem loading

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Clean up builder registration and remove unused functions

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Remove PostActivate call from batch application since it will be called after builders are registered

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Removal external builder dependency scanning since we no longer support builder dlls

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Fix missing bus disconnect

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Remove unused variable

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Moved AP-AssetBuilder specific types into AssetBuilder.Static library.  Also removed some unused/old code

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>
2022-01-04 12:34:56 -08:00
abrmich fced45cd61 Merge remote-tracking branch 'upstream/development' into michabr/lyshine_shader_loc 2022-01-04 11:33:30 -08:00
Sean Sweeney 052e282208 Merge pull request #6629 from aws-lumberyard-dev/test_artifact_upload
Changed test artifact upload check
2022-01-04 11:05:49 -08:00
Chris Galvan 66e50dfbc1 Merge pull request #6505 from tjmgd/bug-wind-71
Wind bug
2022-01-04 12:56:36 -06:00
Chris Galvan 6a45d36051 Merge pull request #6674 from aws-lumberyard-dev/cgalvan/RemoveUnusedBoneNamesClass
Removed unused bone name class.
2022-01-04 12:55:15 -06:00
Mike Balfour b880b8e3ff Merge pull request #6626 from aws-lumberyard-dev/terrain/mbalfour/terrain_system_benchmarks
Terrain/mbalfour/terrain system benchmarks
2022-01-04 11:33:13 -06:00
Chris Galvan 7c8d1cdf8c Merge pull request #6258 from aws-lumberyard-dev/Network/olexl/rhi_compile_fixes
Network/olexl/rhi compile fixes
2022-01-04 11:29:27 -06:00
Chris Galvan 3194422a33 Merge pull request #6426 from aws-lumberyard-dev/PrefabAutoTests
Make 'test_WindowsMacPlatforms_MoveCorruptedSliceFile_MoveSuccess' to use prefab instead
2022-01-04 11:28:24 -06:00
AMZN-Phil 9f500b1228 Merge pull request #6571 from aws-lumberyard-dev/Prism/RearrangeProjectsAfterRemoval
Reflow Project Tiles Everytime They Are Updated
2022-01-04 09:03:42 -08:00
Chris Galvan 685706f817 Removed unused images under Editor/Common
Signed-off-by: Chris Galvan <chgalvan@amazon.com>
2022-01-04 10:58:50 -06:00
bosnichd 2dfdabdfc9 ProcessWatcher fixes. (#6570)
* ProcessWatcher fixes.

Signed-off-by: bosnichd <bosnichd@amazon.com>

* Update based on review feedback.

Signed-off-by: bosnichd <bosnichd@amazon.com>
2022-01-04 09:54:20 -07:00
Chris Galvan c15ead9c30 Removed unused bone name class.
Signed-off-by: Chris Galvan <chgalvan@amazon.com>
2022-01-04 10:32:52 -06:00
mrieggeramzn 03f6ba55fd Adding cascade blending for pcf (#6181)
* Adding cascade blending for pcf

Signed-off-by: mrieggeramzn <mriegger@amazon.com>

* tabs to spaces

Signed-off-by: mrieggeramzn <mriegger@amazon.com>

* tabs to spaces

Signed-off-by: mrieggeramzn <mriegger@amazon.com>

* tabs 2 spaces

Signed-off-by: mrieggeramzn <mriegger@amazon.com>

* Feedback using min3

Signed-off-by: mrieggeramzn <mriegger@amazon.com>

* Only enable flag if > 1 cascade

Signed-off-by: mrieggeramzn <mriegger@amazon.com>

* no blending if last cascade

Signed-off-by: mrieggeramzn <mriegger@amazon.com>

* Remove unused

Signed-off-by: mrieggeramzn <mriegger@amazon.com>
2022-01-04 11:29:34 -05:00
mrieggeramzn cab09dc4ae Adding better decal culling (#6519)
* Adding better decal culling

Signed-off-by: mrieggeramzn <mriegger@amazon.com>

* removing accidental commit

Signed-off-by: mrieggeramzn <mriegger@amazon.com>

* Breja's suggestion for decal sphere size estimation

Signed-off-by: mrieggeramzn <mriegger@amazon.com>

* Removing unused variable

Signed-off-by: mrieggeramzn <mriegger@amazon.com>
2022-01-04 11:27:43 -05:00
Chris Galvan 6e2ccbc055 Merge pull request #6437 from pollend/chore/update-SafeNormalize-usage-EmotionFX
chore[EmotionFX]: replace usage of SafeNormalize
2022-01-04 09:57:31 -06:00
Mike Balfour 07c862bd52 Fix string format specifier.
Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>
2022-01-04 08:37:58 -06:00
Benjamin Jillich 95245e2424 EMotion FX: Linear and angular velocity calculation and debug visualization helpers (#6613)
* Added helper functions for calculating linear and angular velocities.
* Added debug visualization helper for linear and angular velocities.

Signed-off-by: Benjamin Jillich <jillich@amazon.com>
2022-01-04 09:13:14 +01:00