Commit Graph

328 Commits

Author SHA1 Message Date
IgnacioMartinezGarrido d86e8b63c1 Merge pull request #781 from aws-lumberyard-dev/LYN-1767-AB
LYN-1767 : Asset Browser Search View
2021-06-16 17:05:40 +01:00
Nicholas Van Sickle bfeb3e0ab9 Merge pull request #1306 from yuriy0/FullScreenGamePreview
Full screen game preview for Atom viewport
2021-06-16 08:40:29 -07:00
igarri 3ed6b318ab Merge branch 'develop' into LYN-1767-AB 2021-06-16 12:30:10 +01:00
Yuriy Toporovskyy 7d1a12a14f Bug fix: crash after full screen preview due to dangling pointer 2021-06-15 18:33:44 -04:00
mnaumov 9ca0e731f4 Merge remote-tracking branch 'upstream/stabilization/2106' into mnaumov/StabilizationJun15
# Conflicts:
#	Code/CryEngine/CrySystem/LevelSystem/LevelSystem.cpp
2021-06-15 10:41:13 -07:00
yuriy0 aade48e751 Allow smaller values and increments for editor camera speed, allow custom speed values 2021-06-15 10:36:35 -07:00
rgba16f 0198f6121b Rebind the DebugDisplayRequestBus Instance to handle drawing in GameMode. (#1275) 2021-06-14 20:29:37 -05:00
Alex Peterson ecded991b5 Display error when unable to start Python
Added AzFramework Application, logging, unit tests
2021-06-14 17:02:22 -07:00
Yuriy Toporovskyy 84492dee48 Address some PR feedback
- Use AZ::IConsole instead of deprecated Cry IConsole.
- Create fullscreen preview widget on the same screen where the main window is found, instead of on the 'primary' screen
- Remove "ed_previewGameInFullscreen", which had the effect of always doing a full screen preview. If this functionality is desired, it should be re-added as a registry key instead of a cvar
2021-06-14 16:19:37 -04:00
Yuriy Toporovskyy 5becf25a79 Address some PR feedback.
- Better comment explaining signal blocking
- Clang format
2021-06-14 12:14:58 -04:00
Yuriy Toporovskyy 37f70fb47c Address some PR feedback.
- Better variable names
- Close a parenthesis in a comment
- Check equality against nullptr instead of 0
- Add comment to document method of clearing a QLayout
- Format some things
- Const correctness
- Remove a TODO in a comment
- Attempt at removing concatenation of string literal AZ_FUNCTION_SIGNATURE, which might not be a literal on every compiler/platform
2021-06-14 12:08:55 -04:00
Yuriy Toporovskyy 074c3107cd Expose protected method required by full screen preview feature 2021-06-14 11:54:11 -04:00
jjjoness fb4cac08a3 Merge pull request #1304 from aws-lumberyard-dev/FixCrashInWireFrame
Fixes crash in adding WireFrame/
2021-06-14 15:36:37 +01:00
Yuriy Toporovskyy 73d5617af3 Full screen game preview for Atom viewport 2021-06-14 10:02:49 -04:00
John Jones-Steele 4dc9752620 Fixes crash in adding WireFrame/ 2021-06-14 13:50:29 +01:00
Tom Hulton-Harrop 0f09a6d8bf Move new camera settings to the Settings Registry and connect them to viewport border elements (#1267)
* ensure the new camera respects changing ui values and move camera settings to the settings registry

* factor out creation of modular camera controller

* small updates before posting PR

* updates following review feedback

* updates following review feedback
2021-06-14 12:32:35 +01:00
Danilo Aimini 9bb34a6121 Remove references to Wireframe menu item that was removed in a previous PR (#1263) 2021-06-11 11:48:59 -07:00
jackalbe 4818d1ce80 {LYN-4224} Fix for the file scan slowdown (#1252)
* {LYN-4224} Fix for the file scan slowdown (#1183)

* {LYN-4224} Fix for the file scan slowdown

* Fixed a slowdown in the file scanning logic
* Improved the file scanning logic from previous code by 40%

Tests:
Using Testing\Pytest\AutomatedTesting_BlastTest

old code:
=== 7 passed in 96.13s (0:01:36) ===

current code:
=== 7 passed in 160.45s (0:02:40) ====

newest code:
=== 7 passed in 52.91s ===

* fixing a unit test compile error

* unit test fixes

* another file improvement

* fix for legacy level loading taking too long

* making an enum for the search types

* switched the enum to "allow" types to make the input more clear

* got rid of orphaned const variables
2021-06-11 12:25:45 -05:00
hultonha 2d41a701af Merge branch 'stabilization/2106' into tomhh_stabilization-to-development 2021-06-11 09:43:11 +01:00
Terry Michaels 6fdf7b01a5 Updated camera speed display and bounds (#1251) 2021-06-10 17:23:39 -05:00
cgalvan 64ea419c5c Merge pull request #1243 from aws-lumberyard-dev/cgalvan/FixCreateCameraFromView
[LYN-4390] Implemented EditorCameraRequestBus::GetActiveCameraState on the EditorViewportWidget so that the "Create camera entity from view" action works again.
2021-06-10 15:51:50 -05:00
Terry Michaels 829a6fcc8d Removed Wireframe menu option since it doesn't work with Atom (#1248) 2021-06-10 15:42:06 -05:00
cgalvan c684714e4b Merge pull request #1241 from aws-lumberyard-dev/cgalvan/AddGameModeLogging
[LYN-3801] Added back log message when entering/exiting game mode.
2021-06-10 12:20:32 -05:00
Tom Hulton-Harrop 1946561b8d Updates to Goto Position to work with the new camera system (#1212)
* add support for 'GoTo Position' to work with the new camera enabled

* small updates to move away from more legacy calls

* minor formatting change

* ensure values are converted from degrees to radians

* revert change to use Enumerate viewport call

* remove formatting changes from SandboxIntegration
2021-06-10 17:46:01 +01:00
Terry Michaels 91fb8be535 Added toolbar icons, updated viewport header UX (#1240) 2021-06-10 11:42:25 -05:00
Esteban Papp 67489d2907 Remove PAL_TRAIT_BUILD_EDITOR_APPLICATION_TYPE 2021-06-10 09:36:16 -07:00
Chris Galvan 45b2391303 [LYN-4390] Implemented EditorCameraRequestBus::GetActiveCameraState on the EditorViewportWidget so that the "Create camera entity from view" action works again. 2021-06-10 11:18:29 -05:00
jackalbe fedc85f51f {LYN-4224} Fix for the file scan slowdown (#1183)
* {LYN-4224} Fix for the file scan slowdown

* Fixed a slowdown in the file scanning logic
* Improved the file scanning logic from previous code by 40%

Tests:
Using Testing\Pytest\AutomatedTesting_BlastTest

old code:
=== 7 passed in 96.13s (0:01:36) ===

current code:
=== 7 passed in 160.45s (0:02:40) ====

newest code:
=== 7 passed in 52.91s ===

* fixing a unit test compile error

* unit test fixes

* another file improvement

* fix for legacy level loading taking too long

* making an enum for the search types

* switched the enum to "allow" types to make the input more clear
2021-06-10 10:58:37 -05:00
Chris Galvan 992a37df8d [LYN-3801] Added back log message when entering/exiting game mode. 2021-06-10 10:42:13 -05:00
igarri 5a53c074c2 Fixing Header Data in AssetBrowserTableModel 2021-06-10 15:14:35 +01:00
Terry Michaels adf6d93a06 Moved toggle pivot to lower in the context menu, converted all context menu additions to use a singular mechanism (#1209) 2021-06-09 22:37:28 -05:00
cgalvan da4e006621 Merge pull request #1227 from aws-lumberyard-dev/cgalvan/RemoveUnhandledEventMessages
[LYN-3145] Removed unnecessary spam message from legacy CEntityObject class when entering game mode.
2021-06-09 18:49:15 -05:00
Terry Michaels 05d177568c Fixed cut & paste error of menu item name (#1230) 2021-06-09 18:33:12 -05:00
Chris Galvan 6ac13c19a3 [LYN-3145] Removed unnecessary spam message from legacy CEntityObject class when entering game mode. 2021-06-09 16:32:15 -05:00
daimini d6d2cbae7e Merge branch 'stabilization/2106' into gitflow_210609 2021-06-09 14:26:29 -07:00
Terry Michaels 3c23f5fead Fixed size of Save As window (#1208) 2021-06-09 16:21:02 -05:00
jjjoness fc33a0496d LYN-2509 Welcome page for active project when opening O3DE (#1187)
* First changes to ui

* Pre merge from main checkin

* Commit before merge from main

* Pre-merge from maon checkin.

* Commit before merge from main

* Commit before merge from main

* Pre merge from main.

* Old and new levels handled.

* New WelcomeScreenDialog.

* Fixed qss file errors.

* Removed unused file from cmake.

* Commit before change to development branch

* Final changes to WelcomeScreenDialog
2021-06-09 15:34:00 +01:00
igarri be21e585a0 Merge branch 'develop' into LYN-1767-AB 2021-06-09 11:42:31 +01:00
igarri 66bbcb08e5 Fixing Thumbnails preview from TableView 2021-06-09 11:02:09 +01:00
Danilo Aimini 2d1e47793d Move Duplicate menu items and shortcuts out of the Prefab Wip flag
Make duplicate prefab workflows available by default in Prefab mode.
2021-06-08 10:06:25 -07:00
Terry Michaels 0fcd6e84ec Added mechanism for viewpanes to request buttons on the main toolbar (#1189) 2021-06-08 12:02:02 -05:00
Terry Michaels 593b679fa3 Main toolbar consolidation and cleanup (#1167)
* Moving menu options around

* Consolidation and moving of toolbar functioanlity

* Fixed non-unity build missing header

* Updated camera icon to the correct one

* Addressed review feedback

* Addressed review feedback

* Moved icons to new folder structure/naming
2021-06-07 18:11:56 -05:00
Esteban Papp 36cb0f6d40 SPEC-7178 Removal of precompiled cpp files (#1171)
* SPEC-7178  Removal of precompiled cpp files

* Missing files...
2021-06-07 15:59:58 -07:00
igarri 4f2acd1340 Merge branch 'main' into LYN-1767-AB 2021-06-07 15:22:26 +01:00
amzn-hdoke bf29b27937 Add AWSAttribution feature (#1164)
* LYN-3601: Provide skeleton classes for AWS Attribution (#31)

Provide skeleton classes for AWS Attribution, along with some basic unit tests

* Add AWS Attribution UI and settings (#56)

* Adding AWS Attributions UX and corresponding editor preference s setting

* Fix serialized field description

* Fixed update frequency to be  a day

* Handling editor startup with default values for AWSAttribution

* Add missing header and remove AWSCoreSystemComponentMock fron test

* Generate and post AWSAttribution metric (#69)

* Adding AWS Attribution Api service job

* Adding support for config endpoint override

* Update Api endpoint formatting, fix default region

* Remove extra header

* Fixes for link issues

* Fix Unittest namespace

* Instantiating AWSAttributionSystemComponent in AWS.Editor module

* Update AttributionMetric with engine version and AWS enabled gems (#77)

* Update AttributionMetric with engine version and AWS enabled gems

* Fix warnings

* Undoing accidental change

* Saving level PrefabLevel_OpensLevelWithEntities

* Remove overriding editorprefrences.setreg

* Revert "Saving level PrefabLevel_OpensLevelWithEntities"

This reverts commit 529af70c55ece70fc6bc29ceb83bef60413713a3.

* Move AWS preferences to its own temp settings file

* Undo accidental file add

* Add missing string params in warning messages

Co-authored-by: Pip Potter <61438964+lmbr-pip@users.noreply.github.com>
2021-06-04 20:48:35 -07:00
Esteban Papp 50d6e36ccd Bug and improvements to Editor/AP debugging settings (#1146) 2021-06-04 14:36:46 -07:00
Esteban Papp 76a6df341b SPEC-2513 Fixes to enable w4457 2021-06-04 10:51:47 -07:00
igarri 3d1abdc4e3 Pull request corrections, namespaces, style, etc 2021-06-04 12:16:32 +01:00
Nicholas Van Sickle 30eedc1c55 Avoid more sources of camera update re-entrancy that can lead to stack overflow (#1136) 2021-06-03 20:09:15 -07:00
Nicholas Van Sickle f39460e617 Fix rare re-entrancy issue with CCryEditApp::IdleProcessing (#1134)
This issue manifested in a crash in rare circumstances when the Editor lost and gained focus while a modal dialog was active. After investigation, it was discovered that native event processing can lead to IdleProcessing being called again from the main thread while idle processing is still happening. As this is unintentional and generally undesirable, we now guard against this within the IdleProcessing method.
2021-06-03 20:08:51 -07:00