Commit Graph

10251 Commits

Author SHA1 Message Date
Gene Walters 874bbbfca3 Better magic number naming based on review feedback
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-12-18 10:26:37 -08:00
Gene Walters 92d3df17fa Fix incomplete comment
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-12-18 10:16:02 -08:00
Gene Walters fd078e3c29 Small py var name change based on review feedback. Updating script graphs from previous commit to use new RPC name
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-12-18 10:11:20 -08:00
Gene Walters d508d5c4c2 Updating pytest code comments and RPC name based on review feedback
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-12-17 17:49:36 -08:00
Gene Walters bf8422152b Turn off stdout buffering when connecting to editor-server so that the editor properly gets all the server-logging without having to first fill up a buffer. Allows the logs to pipe instantly for easier debugging, and also fixes a problem where the logs wont reach the editor because the buffer doesn't fill
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-12-17 00:12:21 -08:00
Gene Walters 0a7e9388ad Cleanup: Adding wait_for_critical_expected_line as a public method to utils.py and updated the RPC test to use it.
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-12-09 19:23:48 -08:00
Gene Walters 8b044e23ce Merge branch 'upstream/development' into LYN-6769_TestingRPCs 2021-12-09 10:43:16 -08:00
Steve Pham 8fd603cd50 Fix failed archive tests on linux and remove trait
- Change the test Archive Folder name, Extract Folder Name, and File List file to be all lowercase to prevent the 'ResolvePath' function in LocalFileIO when executed to cause issues on case sensitive file systems (#6277)
- Fix memory corruption in profile builds on Linux when using AZ::IO::PathView by using AZ::IO::FixedMaxPath instead

Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com>
2021-12-09 10:18:11 -08:00
Chris Galvan a8a96d3e66 Merge pull request #6291 from aws-lumberyard-dev/cgalvan/gitflow_211209_o3de
Merged `stabilization/2111RTE` to `development`
2021-12-09 11:52:00 -06:00
carlitosan 48ca34eb9f Merge pull request #6267 from aws-lumberyard-dev/sc-editor-asset-redux
Make version explorer wait on AP for dependent assets
2021-12-09 09:49:58 -08:00
moudgils 3540974b08 Multiple bug fixes (#6221)
* Multiple bug fixes
 - Handle Dx12 validation error related to multiple resource transitions happening on the same resource.
 - Added API to better query for image/buffer views associated with an attachment.
 - Address possible serialization issues by usage of size_t
 - Reduced number of Descriptor sets allowed per SRG Pool in order to reduce descriptor waste.

Signed-off-by: moudgils <47460854+moudgils@users.noreply.github.com>

* Addressed minor feedback

Signed-off-by: moudgils <47460854+moudgils@users.noreply.github.com>

* Fix compile issues

Signed-off-by: moudgils <47460854+moudgils@users.noreply.github.com>

* Missed a few other fixes

Signed-off-by: moudgils <47460854+moudgils@users.noreply.github.com>
2021-12-09 09:45:45 -08:00
Gene Walters 4b3d1452fd Merge pull request #6066 from aws-lumberyard-dev/LYN-8514_AutomatedReviewServerLogChecks
Updating Multiplayer PyTests To Check Server Logs
2021-12-09 09:15:58 -08:00
Chris Galvan c1b7efcf7e Merged stabilization/2111RTE -> development, fixed merge conflicts.
Signed-off-by: Chris Galvan <chgalvan@amazon.com>
2021-12-09 09:11:36 -06:00
amzn-sean 7d3399cf96 fixed failing physx script canvas auto tests (#6280)
I noticed the periodic script canvas physics automated tests were failing. It was because the Script Component no longer had the SC scripts assigned (not sure why). So i reassigned them and the tests are back to green.

Affected tests:
    ScriptCanvas_CollisionEvents
    ScriptCanvas_ShapeCast
    ScriptCanvas_PostUpdateEvent
    ScriptCanvas_PreUpdateEvent

Signed-off-by: amzn-sean <75276488+amzn-sean@users.noreply.github.com>
2021-12-09 13:00:06 +00:00
Tom Hulton-Harrop 1672ae268d Add call to DisableSaveOnFinalize (#6242)
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>
2021-12-09 09:36:50 +00:00
Tom Hulton-Harrop c2341a7e3c Fix for change with axis gizmo labels not appearing (#6256)
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>
2021-12-09 09:30:51 +00:00
Tom Hulton-Harrop f62ba7d1a4 Add ComponentApplicationLifecycle::RegisterEvent calls to avoid test console spam (#6245)
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>
2021-12-09 09:30:24 +00:00
Shirang Jia 6e6845dbf3 Pass pipeline name to post ar build sns topic (#6274)
Signed-off-by: Shirang Jia <shiranj@amazon.com>
2021-12-08 18:52:28 -08:00
carlitosan 1d0e2e6379 clean up debug output settings
Signed-off-by: carlitosan <82187351+carlitosan@users.noreply.github.com>
2021-12-08 18:52:24 -08:00
carlitosan f551cb2345 fix verbose setting
Signed-off-by: carlitosan <82187351+carlitosan@users.noreply.github.com>
2021-12-08 17:44:01 -08:00
carlitosan c3bd48b10e pre-PR cleanup
Signed-off-by: carlitosan <82187351+carlitosan@users.noreply.github.com>
2021-12-08 17:32:57 -08:00
carlitosan edd1fe9a05 remove testing code
Signed-off-by: carlitosan <82187351+carlitosan@users.noreply.github.com>
2021-12-08 16:31:08 -08:00
carlitosan 64d21c9448 Make version explorer wait on AP for dependent assets
Signed-off-by: carlitosan <82187351+carlitosan@users.noreply.github.com>
2021-12-08 16:11:38 -08:00
lumberyard-employee-dm 003727ca57 Fixed the get_registration.py script to print the manifest data (#6236)
Added a --project-engine-name/-pen argument to print_registration.py to
output the engine registered with the project.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
2021-12-08 18:08:51 -06:00
michabr ea33d792f6 Fix assert in LyShine when unloading a level (#6260)
* Fix assert in LyShine when unloading a level

Signed-off-by: abrmich <abrmich@amazon.com>

* Remove use of iter now that it's no longer used

Signed-off-by: abrmich <abrmich@amazon.com>
2021-12-08 15:53:16 -08:00
galibzon 76e09a36d9 Make math classes & EntityId visible in Lua Documentation. (#6261)
Small change in behavior context attribute for a few
classes so they become visible when extracting Lua symbols
from the ScriptContextDebug() API.

From:
Attribute(AZ::Script::Attributes::ExcludeFrom,
    AZ::Script::Attributes::ExcludeFlags::All)

To:
Attribute(AZ::Script::Attributes::ExcludeFrom,
    AZ::Script::Attributes::ExcludeFlags::ListOnly)

It seems the previous code was simply trying to hide those symbols from
the Script Canvas node palette. But it was also, seemingly unintentional,
hiding those symbol from Lua Documentation.

Signed-off-by: galibzon <66021303+galibzon@users.noreply.github.com>
2021-12-08 16:51:44 -06:00
Steve Pham 9b480f252e Fix and enable failed gradient signal tests on Linux
* Fix failure reason for PerlinGradientComponent_GoldenTest: non-standard behavior of std::shuffle producing different results across platforms
* Fix failure reason for GradientImageAssetConversionU8SingleScale: Undefined behavior when float casts to a uint8 has overflow

Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com>
2021-12-08 14:28:45 -08:00
Chris Galvan fc71f3f81d Merge pull request #6257 from aws-lumberyard-dev/cgalvan/MoreReadOnlyPrefabChanges
Additional read-only prefab workflow changes.
2021-12-08 15:53:33 -06:00
Luis Sempé 667512c7ff Merge pull request #6233 from o3de/scripting/rte_02
Script Canvas node translation system and naming consistency
2021-12-08 13:39:25 -08:00
Chris Galvan 1aed839271 Fixed typo.
Signed-off-by: Chris Galvan <chgalvan@amazon.com>
2021-12-08 15:02:41 -06:00
Mike Chang 6c299000a7 Notices automation install (#6228)
This will generate the NOTICES.txt license file and SPDX-Licenses.json manifest file on every installer run.

Signed-off-by: Mike Chang <changml@amazon.com>
2021-12-08 12:45:44 -08:00
AMZN-Phil 0b028a827c Merge pull request #6229 from aws-lumberyard-dev/Prism/InstallerVersionBuildNumber
Force string check on build version numbers so that versions such as 21.11.1 are detected correctly.
2021-12-08 12:34:03 -08:00
Thomas Poulet 6726d7a886 Fix quad light NAN on contact with other surfaces (#6174)
* Fix quad light NAN on contact with other surfaces

- Quad lights can produce nan if intersecting other surfaces. This is caused by a division by 0 in the edge integration functions. Fixed by saturating the output.
- Small refactoring on LTC edge integration functions. To make the terms more explicit.

Signed-off-by: Thomas Poulet <1039134+Bindless-Chicken@users.noreply.github.com>

* Replace incorrect saturate with EPSILON clamp

Signed-off-by: Thomas Poulet <1039134+Bindless-Chicken@users.noreply.github.com>

Co-authored-by: Thomas Poulet <1039134+Lord-Nazdar@users.noreply.github.com>
2021-12-08 13:51:55 -06:00
Chris Galvan 9dc32a0381 Additional read-only prefab workflow changes.
Signed-off-by: Chris Galvan <chgalvan@amazon.com>
2021-12-08 12:30:31 -06:00
Esteban Papp e79d79ec45 Fixes some missing includes/declaring budgets (#6238)
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
2021-12-08 09:53:37 -08:00
Steve Pham 558532f094 Process launcher updates (#6183)
* Enable process and ap connection tests on linux
* Updated 'OpenProjectManager' to use new the ProcessLauncher argument type
* Add logic to double-escape escaped double quotes in arguments on windows platforms
* Updated argument for LaunchProjectManager to reflect new ProcessLauncher argument type
* Fixed unit test arguments for 'arg=value' condition
* Fix compile errors for BuilderManager and RHI.Edit\Utils.cpp
* PAL'ify the GetCommandLineParametersAsString() to handle windows specific behavior

Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com>

Co-authored-by: byrcolin <byrcolin@amazon.com>
2021-12-08 09:30:19 -08:00
lumberyard-employee-dm cd65d8a5ac Pass relative path IsFileExcluded so that only paths relative to the root scan folder are matched against the exclude filters (#4504) (#6234)
* Pass relative path IsFileExcluded so that only paths relative to the root scan folder are matched against the exclude filters.

Signed-off-by: amzn-sj <srikkant@amazon.com>

* Revert previous change. Remove the exclude filter for the Install directory.

Signed-off-by: amzn-sj <srikkant@amazon.com>

* Pass in relative path to the exclude filter as before. Fix the AssetScanner tests.

Signed-off-by: amzn-sj <srikkant@amazon.com>

* Prepend a ./ to the relative path in order to match the exclude patterns

Signed-off-by: amzn-sj <srikkant@amazon.com>

* Remove hack to prepend ./. Update the exclude patterns so that the hack is no longer required.

Signed-off-by: amzn-sj <srikkant@amazon.com>

* Add missing ? and remove whitespace

Signed-off-by: amzn-sj <srikkant@amazon.com>

* 1. IsFileExcluded() now converts the input path to a path that's relative to its corresponding scan folder.
2. Update regex patterns in gems and AutomatedTesting as well.
3. Remove unnecessary escaping for '/'.

Signed-off-by: amzn-sj <srikkant@amazon.com>

* Use ConvertToRelativePath() function to compute path relative to a scan folder.

Signed-off-by: amzn-sj <srikkant@amazon.com>

* More fixes to regex patterns

Signed-off-by: amzn-sj <srikkant@amazon.com>

* Remove test case which tests a hypothetical scenario that cannot occur. Fix another test case by adding scan folder.

Signed-off-by: amzn-sj <srikkant@amazon.com>

* Remove assert that's not needed since it's a valid scenario

Signed-off-by: amzn-sj <srikkant@amazon.com>

Co-authored-by: amzn-sj <srikkant@amazon.com>
2021-12-08 11:12:25 -06:00
benblack75 29da71e64e Updated Sponza Model (.ma, .fbx, textures) (#6080)
* Updated Sponza Model (.ma, .fbx, textures)

Signed-off-by: Benjamin Black <benblac@amazon.com>

* Removed corrupted file

Signed-off-by: Benjamin Black <benblac@amazon.com>

* Revisions to Sponza Scene

Signed-off-by: Benjamin Black <benblac@amazon.com>

* Sponza updates

Signed-off-by: Benjamin Black <benblac@amazon.com>

* Updated Cloth Irradiance Values

Signed-off-by: Benjamin Black <benblac@amazon.com>

* Added Sponza scene to Automated Testing- request from QA

Signed-off-by: Benjamin Black <benblac@amazon.com>

* Clean up removed files

Signed-off-by: Benjamin Black <benblac@amazon.com>
2021-12-08 08:49:18 -08:00
amzn-sj 47bd6fc4d4 [Mac] Format string specifier for size_t should be %zu (#6237)
Fixes this build error: error: format specifies type 'int' but the argument has type 'size_t' (aka 'unsigned long') [-Werror,-Wformat]

Signed-off-by: amzn-sj srikkant@amazon.com
2021-12-08 08:34:34 -08:00
moraaar 045eea03e6 Converted NvCloth automated tests to prefabs (#6253)
* Deleted cloth slice assets and AutomatedTesting levels based on slices

Signed-off-by: moraaar <moraaar@amazon.com>

* Recreated nvcloth AutomatedTesting levels for prefabs

Signed-off-by: moraaar <moraaar@amazon.com>

* Run nvcloth automated tests with prefabs enabled (which is the default)

Signed-off-by: moraaar <moraaar@amazon.com>
2021-12-08 16:07:03 +00:00
Gene Walters 16f5f45b7e Merge pull request #6170 from aws-lumberyard-dev/LYN-8770_PrintNetEntityNameIfImproperlyDeleted
Print Entity name if Improperly Deleted
2021-12-08 07:38:43 -08:00
sphrose 1e11e54702 Merge pull request #6246 from aws-lumberyard-dev/debug_compile_fix
Fix debug compilation.
2021-12-08 15:20:32 +00:00
John Jones-Steele 9e7d5fe52b Test the Terrain World configuration changes when parameters are chan… (#6063)
* Test the Terrain World configuration changes when parameters are changed in the component

Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com>

* Changes from PR

Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com>

* Before merge

Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com>

* Before merge 2

Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com>

* Changes from PR

Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com>

* Change from PR

Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com>

* Change before merge

Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com>

* Change before merge 2

Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com>

* Change before merge 3

Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com>

* Change after merge to fix conflicts

Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com>

* Fix merge conflict

Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com>

* Fix merge conflict

Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com>

* CHanges from PR

Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com>
2021-12-08 14:09:56 +00:00
moraaar 5eb058f679 Use LegacySystemInterfaceCreated to initialize physics material library. (#6168)
* Use LegacySystemInterfaceCreated to initialize physics material library. OnCatalogLoaded was used before but it's not called when running the editor without assets processed yet.

Signed-off-by: moraaar <moraaar@amazon.com>
2021-12-08 12:23:19 +00:00
sphrose 1a94caee47 Fix debug compilation.
Signed-off-by: sphrose <82213493+sphrose@users.noreply.github.com>
2021-12-08 11:06:02 +00:00
moraaar f9f11d98b1 Fixed critical json property (cherry picked from RTE branch) (#6220)
* Fixing critical tag as it needs a boolean, not a string.

Signed-off-by: moraaar <moraaar@amazon.com>

* Marking blast material library assets as criticals since it's necessary to be ready before the editor opens

Signed-off-by: moraaar <moraaar@amazon.com>
2021-12-08 10:26:02 +00:00
Tom Hulton-Harrop b54215552c Prevent the camera from easily being set to an invalid orientation (#6203)
* add temporary debug logging

Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>

* improvement for box select sometimes getting stuck on

Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>

* add temporary debug logging

Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>

* improvement for box select sometimes getting stuck on

Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>

* remove temporary logging

Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>

* fixes for camera pitch issues

Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>

* missed file with camera pitch fixes

Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>

* remove debug logs

Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>

* add some tests for new pitch constraint updates

Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>
2021-12-08 09:42:40 +00:00
Gene Walters 80a216e079 Adding RPC test. Update editor-servers to flush stdout
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-12-08 00:21:02 -08:00
Gene Walters 54fd0011a7 Merge branch 'LYN-8514_AutomatedReviewServerLogChecks' into LYN-6769_TestingRPCs 2021-12-07 22:51:22 -08:00
Chris Galvan a8ef23e4ae Merge pull request #6232 from aws-lumberyard-dev/cgalvan/ReadOnlyPrefabWorkflowChanges
Some read-only prefab workflow updates.
2021-12-07 19:38:54 -06:00