Commit Graph

24 Commits (604dca1c3e894ed0f577635dedf81d6c89a0f9cb)

Author SHA1 Message Date
srikappa-amzn bd8b6aea8e Moved vector declartion inside state for loop 5 years ago
srikappa-amzn 9f9c01e781 Used reserve instead of resize 5 years ago
srikappa-amzn 5b4333e4b1 Added a comment and gave a variable better name 5 years ago
srikappa-amzn c8ba42d04f Merge branch 'stabilization/2106' into BenchMarksReset 5 years ago
sconel e4921c8d0a Fix nested container entities not getting editor info removed during prefab processing 5 years ago
srikappa-amzn e6ec9e48b4 Changed spawnables benchmark test to create multiple spawnables at once 5 years ago
srikappa-amzn 1582cb5257 Enabled instantiate benchmarks 5 years ago
srikappa-amzn 4c6bd5fcb7 Disabled instantiate and spawnable benchmarks 5 years ago
srikappa-amzn 2722ed46c3 Reset prefab system in all prefab benchmarks 5 years ago
sconel 40fa0a3a46 Remove optimization pragma 5 years ago
sconel 9efcc3a6b5 Fix compilation error and failing unit test 5 years ago
Danilo Aimini 80f62d0523
LYN-3708 | Optimize Prefab instance propagation to stabilize UX (#700)
* Add instanceToIgnore to calls leading to instances being added to the queue for propagation.

* Change PrefabUndoEntityUpdate to make it so that the instance triggering the prefab template change is not reloaded on propagation, since it will already be up to date due to the way we generated the patch to begin with.

* Add FindPrefabDomValue utility function for paths

* Expose the level root prefab template id in the Prefab EOS Interface

* Fix Instance Alias Path generation to work with the new FindValueInPrefabDom function

* Stop reloading ancestors on propagation, and fix instance reloading so that the level dom is used (and overrides are preserved)

* Remove commented out code, refactor FindPrefabDomValue for paths (was handling an edge case incorrectly, and it's not even triggered)

* Fix issue with PathView reference - with PathView already being a reference, this resulted in a copy and triggered a warning during automated review builds.

* Additional fix to the build warning, remove redundant error message

* Revert changes to Instance::GetAbsoluteInstanceAliasPath(), as they were impacting serialization.

* Remove the dependency to the level root prefab template in the propagation code, climb up the hierarchy instead. This allows tests to work despite not using the EOS properly.
Also use PrefabDomPaths to retrieve the instance dom from the root dom instead of iterating.

* Remove now unused PrefabDomUtils function, extend optimization to link updates.

* Trigger a full instance propagation to correctly refresh alias references.
This is an issue in the test because some operations are called from the backend API and will not trigger propagation properly. Tests will soon be rewritten to more properly represent frontend workflows.

* Fixes lingering issues with propagation:
- Restores code that fixes the selection if entityIds have changed;
- Fixes Do() function on link update. Prefab containers will propagate correctly while still being stable during editing.

* Remove GetRootPrefabInstanceTemplateId (no longer necessary after the code has been rewritten)

* Fix optimization code to account for instances being removed and propagation being run out of order in Create Prefab undo.

* Renamed variable, added comments for clarity.

* Restore asserts on instance not being found; Rename Do to Redo for clarity; Add comments.

* Fixed incomplete comment.
5 years ago
AMZN-koppersr c45697fd51 Fixed unit test compile error with spawnables 5 years ago
Chris Galvan c105894aa5 [LYN-2255] Made PrefabTestFixture have the prefab system enabled so that the duplicate tests pass on Jenkins (they rely on the PrefabEditorEntityOwnershipInterface being registered). 5 years ago
Chris Galvan 2d89c60175 [LYN-2255] Updated Prefab Duplicate to select the newly duplicated entities. Also addressed some other PR feedback. 5 years ago
srikappa 886fe22b16 Merge branch 'main' into Prefab/CreatePrefab 5 years ago
srikappa eb8084d3f6 Initial draft for getting instantiation to work immediately after creation is undone 5 years ago
chiyenteng ede1889507
[CherryPick][LYN-3398][LYN-3399] Let EditorEntityModel always use the optimized algorithm even in Slice mode (#585)
* [LYN-3398][LYN-3399] Let EditorEntityModel always use the optimized algorithm even in Slice mode (#490)
5 years ago
chiyenteng efc0cbacba
Prevent AzToolsFramework benchmarks timeout for now (#398) (#403) 5 years ago
alexpete c5b955d281 Integrating github/staging through commit b0dd7ed 5 years ago
alexpete 1044dc3da1 Integrating github/staging through commit ab87ed9 5 years ago
alexpete c2cbd430fe Integrating up through commit 90f050496 5 years ago
alexpete 75dc720198 Integrating latest 47acbe8 5 years ago
alexpete a10351f38d Initial commit 5 years ago