You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
d0e5f9d20b
* Added Async APIs for the various Process*FromList terrain functions. Please note that we are currently defaulting the number of worker threads to one, because splitting the work over multiple threads causes contention when locking various mutexes, resulting in slower overall wall time for async requests split over multiple threads vs one where all the work is done on a single thread. The latter is still preferable over a regular synchronous call because it is just as quick and prevents the main thread from blocking. This should be changed once the mutex contention issues have been addressed, so that async calls automatically split the work between available job manager worker threads, unless the ProcessAsyncParams specify a different desired number of jobs. Signed-off-by: bosnichd <bosnichd@amazon.com> * Fix Linux builds by adding missing #include Signed-off-by: bosnichd <bosnichd@amazon.com> * Added a test for cancellation of terrain async requests, and fix it so that it works. Note that the benchmarks show this implementation to be slightly slower than the previous one, which I presume is because we're now calling a 'perSurfacePointFunction' in the inner loop; this can probably be addressed, but will result in a lot of code duplication, and I think efforts will be better spent on removing the mutex contention to enable running multiple terrain async jobs at the same time. Signed-off-by: bosnichd <bosnichd@amazon.com> * Added Async versions for all Process*Region terrain API functions, along with benchmarks. Signed-off-by: bosnichd <bosnichd@amazon.com> * Fix the newly added terrain async request benchmarks to actually use the async APIs. Signed-off-by: bosnichd <bosnichd@amazon.com> * Revert to the original version which just calls the synchronous API from the job function, along with some other updates in response to review feedback. Signed-off-by: bosnichd <bosnichd@amazon.com> * Change the TerrainWorldDebugger to use the async API, along with the following changes: - TerrainJobContext no longer uses a JobCancelGroup so we can guarantee the completion callbacks of associated jobs will be invoked even if it is cancelled. - As a result of the above change, the ProcessAsyncCompleteCallback function signature again accepts the associated TerrainJobContext as a param. - The TerrainProcessAsyncCancellation test has been resurrected and simplified by using binary semaphores instead of condition variables. - All the async related TerrainSystemBenchmark functions have been simplified by using binary semaphores instead of condition variables. - Global cancellation of all terrain jobs on deactivation of the TerrainSystem has been reintroduced, but in a different way than before. - Other miscellaneous changes/fixes made while testing and based on earlier PR feedback. Signed-off-by: bosnichd <bosnichd@amazon.com> * Updates based on review feedback: - Go back to using a vector instead of an array (fixed the original problem by adding custom copy/assignment constructors/operators to the WireframeSector struct). - When calling WireframeSector::Reset, block until any associated in flight has completed. - Added the concept of a minimum number of positions per terrain job. Signed-off-by: bosnichd <bosnichd@amazon.com> * Use semaphore instead of binary_semaphore in a bunch of places to account for the race condition where a completion callback fires before we started waiting for it. Signed-off-by: bosnichd <bosnichd@amazon.com> |
4 years ago | |
|---|---|---|
| .. | ||
| Mocks | 4 years ago | |
| Platform | 4 years ago | |
| Spawnable | 4 years ago | |
| Utils | 4 years ago | |
| Application.cpp | 4 years ago | |
| ArchiveCompressionTests.cpp | 4 years ago | |
| ArchiveTests.cpp | 4 years ago | |
| AssetCatalog.cpp | 4 years ago | |
| AssetProcessorConnection.cpp | 4 years ago | |
| BehaviorEntityTests.cpp | 4 years ago | |
| BinToTextEncode.cpp | 4 years ago | |
| CameraInputTests.cpp | 4 years ago | |
| CameraState.cpp | 4 years ago | |
| ClickDetectorTests.cpp | 4 years ago | |
| CursorStateTests.cpp | 4 years ago | |
| EntityContext.cpp | 4 years ago | |
| FileIO.cpp | 4 years ago | |
| FileTagTests.cpp | 4 years ago | |
| FrameworkApplicationFixture.h | 4 years ago | |
| GenAppDescriptors.cpp | 4 years ago | |
| InputTests.cpp | 4 years ago | |
| Main.cpp | 4 years ago | |
| NativeWindow.cpp | 4 years ago | |
| OctreePerformanceTests.cpp | 4 years ago | |
| OctreeTests.cpp | 4 years ago | |
| PlatformHelper.cpp | 4 years ago | |
| ProcessLaunchMain.cpp | 4 years ago | |
| ProcessLaunchParseTests.cpp | 4 years ago | |
| Scene.cpp | 4 years ago | |
| framework_shared_tests_files.cmake | 4 years ago | |
| frameworktests_files.cmake | 4 years ago | |
| process_launch_test_files.cmake | 4 years ago | |
| terrain_mock_files.cmake | 4 years ago | |