You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
o3de/Code/Legacy/CrySystem
AMZN-stankowi 6d592d78cd
Fixes for release builds with DCO fix (#5164)
* This set of changes is work toward allowing release builds to work with asset bundler generated bundles and legacy, non-prefab levels. This requires some other in-flight changes before this work is complete.

    Updated engine seed list + fixed automated test
    ComponentApplicationLifecycle has the ability to automatically register events if asked to register a handler and the event doesn't exist. This is only intended for cases where you need to register a handler early in startup before the settings registry file is loaded.
    Added two new lifecycle events: One after the system entity has been activated, and one after the system interface has been created.
    If you load an archive before the system entity has been activated, archive.cpp caches information about those archives until that time, so it can finish registration. This is because the serialization system and BundlingSystemComponent both need to be available to do this registration, but the bundles have to be loaded before those are initialized so that the settings registry file can be loaded.
    Fixed an error were mounted pak files were searching for levels.pak and not level.pak, and not finding them. I'm pretty sure this logic doesn't do anything functional either way, but I've been testing legacy levels with this change and they work now.
    Moved wildcard pak loading to where engine.pak is loaded. This is because the settings registry file that defines the IO stack to spin up must be available early in application startup, and this file must be within a mounted pak file. If you're using asset bundler generated bundles, they need to be loaded at this time so that file can be loaded.
    Atom's BootstrapSystemComponent.cpp no longer initializes on AssetCatalogLoaded, and instead initializes on the ApplicationLifecycle event SystemInterfaceCreated. This is because the base assetcatalog.xml file is really just a development time concept, this file should not be used in packaged release builds, because those builds will make use of delta catalogs in each bundle loaded. The asset catalog contains the list of all assets that were in the cache at development time, and this contains content that developers don't want to ship, and they may want to specifically hide from their customers, so data miners don't find secrets about upcoming game content.

Recovering from a branch that had incorrect DCO

Signed-off-by: stankowi <4838196+AMZN-stankowi@users.noreply.github.com>

* Fixed an incorrect ebus disconnect and removed an include that's no longer needed

Signed-off-by: stankowi <4838196+AMZN-stankowi@users.noreply.github.com>

* Fixed a copy and paste typo from trying to recover the previous pull request

Signed-off-by: stankowi <4838196+AMZN-stankowi@users.noreply.github.com>

* Updated product IDs for the settings registry builder to no longer collide with the JSON builder. Now they are based on a hash of the configuration.
Updated the engine default seed list to include the new asset ID info for the renamed bootstrap file

Signed-off-by: stankowi <4838196+AMZN-stankowi@users.noreply.github.com>

* Updated the path to the application lifecycle events, because runtime settings aren't included in the merged bootstrap file.
Addressed some feedback on printing out a string view on an error

Signed-off-by: stankowi <4838196+AMZN-stankowi@users.noreply.github.com>

* Removed a test that uses old assets that aren't relevant. We may not need this test anymore, but if we do we've backlogged a task to create a new test to cover this behavior without using old assets.

Signed-off-by: stankowi <4838196+AMZN-stankowi@users.noreply.github.com>

* Renamed SystemInterfaceCreated event to LegacySystemInterfaceCreated
Removed SystemEntityActivated event. Now that I have the rest of the fixes in this pull request, this new event wasn't needed, the already existing SystemComponentsActivated event does what I need.
Changed list to vector

Signed-off-by: stankowi <4838196+AMZN-stankowi@users.noreply.github.com>
4 years ago
..
LevelSystem Update all the hardcoded filenames inside the level.pak file to be lowercase now the editor no longer forces them to be lower case. (#4802) 4 years ago
Platform Various fixes and empty boilerplate files required for restricted platforms. (#3610) 4 years ago
RemoteConsole Legacy cleanup (#3383) 4 years ago
ViewSystem Fixes debug console's "quit" issues (#4975) 4 years ago
XML Updated the GameApplication to mount the engine.pak (#4128) 4 years ago
AZCoreLogSink.h [profiler_capture_api] fixed release compile error 4 years ago
AZCrySystemInitLogSink.cpp Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
AZCrySystemInitLogSink.h Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
CMakeLists.txt Update tiff to the new package revision (fixes IOS TIFF package) (#4638) 4 years ago
CmdLine.cpp Code/Legacy 4 years ago
CmdLine.h More string fixes 5 years ago
CmdLineArg.cpp Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
CmdLineArg.h More string fixes 5 years ago
ConsoleBatchFile.cpp Update the FileIO Aliases (#4186) 4 years ago
ConsoleBatchFile.h Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
ConsoleHelpGen.cpp Code/Legacy cleanup 5 years ago
ConsoleHelpGen.h More string fixes 5 years ago
CrySystem_precompiled.h Removes some usage of DEDICATED_SERVER (#5119) 4 years ago
DebugCallStack.cpp Added extra output and callstack information for improving debugging automated tests (#4528) 4 years ago
DebugCallStack.h More string fixes 5 years ago
DllMain.cpp Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
Huffman.cpp Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
Huffman.h Legacy code cleanup - part 3 (#3903) 4 years ago
IDebugCallStack.cpp Moved the Asset Catalog loading from LmbrCentral to the AzFramework::Application (#4568) 4 years ago
IDebugCallStack.h linux fixes 5 years ago
LocalizedStringManager.cpp Legacy code cleanup - part 3 (#3903) 4 years ago
LocalizedStringManager.h Merge branch 'development' into cmake/warn_virtual 4 years ago
Log.cpp enabling warn format security and some fixes 4 years ago
Log.h Legacy code cleanup - part 3 (#3903) 4 years ago
SimpleStringPool.h Legacy cleanup, part 2 (#3659) 4 years ago
System.cpp Perform global deinitialization when exiting the game launcher (#4131) 4 years ago
System.h Fixes for release builds with DCO fix (#5164) 4 years ago
SystemCFG.cpp Update the FileIO Aliases (#4186) 4 years ago
SystemEventDispatcher.cpp Refactor budget definitions as named functions instead of template specializations 4 years ago
SystemEventDispatcher.h [redcode/crythread-2nd-pass] removed CryThread*.h files 4 years ago
SystemInit.cpp Fixes for release builds with DCO fix (#5164) 4 years ago
SystemWin32.cpp Miscellaneous fixes and PAL changes required for restricted platforms. (#4021) 4 years ago
Timer.cpp Fix unused warnings release (#3677) 4 years ago
Timer.h PR comments 4 years ago
WindowsErrorReporting.cpp Updated the GameApplication to mount the engine.pak (#4128) 4 years ago
XConsole.cpp Enabling warnings around format security 4 years ago
XConsole.h Merge branch 'development' into cmake/warn_virtual 4 years ago
XConsoleVariable.cpp Legacy code cleanup - part 3 (#3903) 4 years ago
XConsoleVariable.h Updated the GameApplication to mount the engine.pak (#4128) 4 years ago
crysystem_files.cmake Legacy code cleanup - part 3 (#3903) 4 years ago
crysystem_shared_files.cmake Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago