You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
o3de/Code/Tools/AssetProcessor/native/utilities
amzn-phist fec77632ef
Archive Component - Rewrite and additional work on Archive and Asset Bundler (#4332)
* Fix issues with seedlist for AutomatedTesting

Fixes error reporting so it will show the file hint in the tool.
Removes any missing assets from the .seed file.
Remove an unnecessary dependency from AutomatedTesting dependencies
file.

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Make ArchiveComponent use AZ::IO::IArchive

Initial changes that will get the sychronous calls in ArchiveComponent
to use IArchive interface rather than external zip/7z tools.

Some of the asynchronous api are still in place, anything that wasn't
being used has been removed for now.  This may change later if we move
towards all the api being asynchronous.  Until then, we can't remove the
reliance upon the external archive tools completely.

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Updates AZStd::thread constructors

Adds a variadic constructor which forwards args to the functor.
Because of our thread_desc extension, there was confusion on the
arugments, so the args were reordered to take the thread_desc first,
before the functor and args.
Also the thread_desc is taken as reference rather than by pointer.
Update callsites to account for this change.

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Async operation of ArchiveComponent api

This sets up the ArchiveComponent to operate asynchronously.  It uses
promise/future to transfer results to caller.

This is still broken, there's a few things that need to get fixed up,
but this is a good checkpoint for the work as it solidifies the api,
cleans up a bunch of unused code, and compiles.

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Removes the platform-specific ArchiveComponen

These are no longer needed, as they control the direct interaction with
host OS tools like 7za.exe or /bin/zip.

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Removes the platform-specific files from cmake

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Removes the 7za.exe (and legal notice)

This tool is no longer needed in the repo.

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Fixes usage of IArchive::GetFullPath()

This changed to return a PathView, updated to reflect that.

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Fix promises and threads

Make sure promises are only set exactly once.  This meant reworking some
of the initial error checking.
Detach threads when created.  Adds [[nodiscard]] to the functions that
return a future.  Since threads are detached, the future is the main way
to get communication from the thread.
Clean up interface, add comments.

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* More edits to thread creation

Changes to thread construction to account for parameter change.

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Fix some remaining issues with ArchiveComponent

Put created threads inside a container, then join them at Deactivate.
Fix asset bundler case when injecting a file with no working directory.
Fix thread constructor that applies args to a function.
Fix lambdas to take string args by value rather than reference.

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Fixes some remaining bugs in ArchiveComponent

Open archive as read-only during extract & list operations.
Fixes paths issues.

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Fix initialize of opaque thread handle in thread_UnixLike.h

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Removed unused variable in AssetBundleComponent.cpp to fix compiler warning

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Fix some issues with archives

File paths in the CDR and the local headers need to match, but there
were issues with path separators and case that made it possible to get
invalid headers errors in some archives.

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Adds some new ArchiveComponent unit tests

Adds new tests for extraction of archive and adding files from a file
list to an archive.

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Fix file data offset issues when opening archives

When opening an INestedArchive it would run through the CDR headers to
create file entries in the zip cache.  The offsets to the compressed
data were being calculated incorrectly because they were using the CDR
headers rather than jumping to the local file headers and getting
offsets from those sizes.

Removed and refactored some archive validation flow and zip cache
factory init methods to either init default or init w/ additional
validation checks.

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Addresses PR feedback

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Address more points of feedback in PR

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Address additional PR feedback

 Fixes up some error checks and uses of strings vs paths.
 Enable archive component tests on Linux so we can see if they will
 pass.

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Address PR feedback

Change the INestedArchive interface to list files as AZ::IO::Path.

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Disabling the ArchiveComponent tests on Linux

They failed so we will revisit them to attempt a fix.

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Rename a member variable to be more accurate

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Address feedback on PR

Bump version of Archive Components for serialize context.
Improve error messages during archive open and validation.

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Revert recent changes

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
4 years ago
..
ApplicationManager.cpp Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
ApplicationManager.h Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
ApplicationManagerAPI.h Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
ApplicationManagerBase.cpp Code/Tools 4 years ago
ApplicationManagerBase.h Code/Tools/AssetProcessor 4 years ago
ApplicationServer.cpp Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
ApplicationServer.h Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
AssetBuilderInfo.cpp Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
AssetBuilderInfo.h Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
AssetServerHandler.cpp Archive Component - Rewrite and additional work on Archive and Asset Bundler (#4332) 4 years ago
AssetServerHandler.h Code/Tools/AssetProcessor 4 years ago
AssetUtilEBusHelper.h Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
BatchApplicationManager.cpp Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
BatchApplicationManager.h Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
BatchApplicationServer.cpp Code/Tools fixes 4 years ago
BatchApplicationServer.h Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
BuilderConfigurationBus.h Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
BuilderConfigurationManager.cpp Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
BuilderConfigurationManager.h Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
BuilderManager.cpp [Mac] Building and running game projects from an SDK (#2943) 4 years ago
BuilderManager.h Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
BuilderManager.inl Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
ByteArrayStream.cpp enable warning 4296: 'operator': expression is always false 4 years ago
ByteArrayStream.h Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
CommunicatorTracePrinter.cpp Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
CommunicatorTracePrinter.h Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
GUIApplicationManager.cpp Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
GUIApplicationManager.h Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
GUIApplicationServer.cpp Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
GUIApplicationServer.h Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
IniConfiguration.cpp Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
IniConfiguration.h Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
JobDiagnosticTracker.cpp Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
JobDiagnosticTracker.h Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
LineByLineDependencyScanner.cpp Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
LineByLineDependencyScanner.h Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
LogPanel.cpp Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
LogPanel.h Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
MissingDependencyScanner.cpp Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
MissingDependencyScanner.h Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
PlatformConfiguration.cpp Final fixes for MSVC 4 years ago
PlatformConfiguration.h Final fixes for MSVC 4 years ago
PotentialDependencies.h Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
SpecializedDependencyScanner.h Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
ThreadHelper.cpp Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
ThreadHelper.h Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
UnitTestShaderCompilerServer.cpp Code/Tools fixes 4 years ago
UnitTestShaderCompilerServer.h Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
assetUtils.cpp Avoid redefining `PRI` macros on Linux (#4055) 4 years ago
assetUtils.h Merge branch 'development' into cmake/SPEC-7179 5 years ago
windowscreen.cpp Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
windowscreen.h Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago