You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
o3de/Code/Framework/AzFramework/Tests
Mike Balfour 0e328afcdd
Optimize surface providers (#7631)
* Add comparison operators to SurfaceTagWeight.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Changed AddSurfaceTagWeight to always combine weights.
This simplifies the API a bit and defines the behavior if someone ever tries to add a duplicate tag.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Added benchmarks for measuring the performance-critical APIs.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Changed SurfaceTagWeights to a fixed_vector.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Add inPosition to AddSurfacePoint.
This will be used to detect which input the surface point is associated with.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Add inPositionIndex to the appropriate APIs.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Switched Gradient Surface benchmarks to use actual surface components.
The gradient unit tests and benchmarks were previously using a mock surface data system, which led to misleading benchmark results. Now, the actual SurfaceData system gets constructed, and the tests use a mock provider, but the benchmarks use actual shape providers for more realistic benchmarking.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Fixed unit tests to have better query ranges.
Half of each previous range was querying outside the surface provider's data.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* First attempt at removing SurfacePointLists.
This currently runs significantly slower than the previous code but passes the unit tests.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Another attempt at optimization.
This one runs faster than the previous, but still slow.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Fix the cmake dependency so that the gradient tests rebuild SurfaceData.dll when run.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Switch SurfaceAltitudeGradient over to the new bulk API.
Also, optimized the non-bulk API by having it reuse the SurfacePointList to avoid the repeated allocation / deallocation cost.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Switched to using an indirect index so that all allocations are consecutive in our reserved buffer.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Switched back to SurfaceTagWeight again.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Added runtime dependency to LmbrCentral for unit tests.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Switched code over to use the full EnumeratePoints in most cases.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Added knowledge of max surface point creation into the system.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Add generic GetSurfacePointsFromList API implementation for surface providers.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Fixed implementation to use the correct maximum number of input points based on the surface providers being queried.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Fix out-of-bounds references on empty lists.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Fix memory allocation that caused benchmark runs to crash.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Starting to clean up the API.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Move SurfacePointList into separate files for easier maintainability.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Fixed bug where too many points were filtered out due to using the position Z as a part of the AABB check.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Made FilterPoints an internal part of SurfacePointList so we can choose when and how to perform the filtering.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Final cleanup / comments.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Added includes for non-unity builds.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Optimized GetValues() implementations.
Also consolidated GetValue() and GetValues() down to a single implementation under the covers for easier maintenance.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Changed how unit tests initialize the mock lists to try and fix the linux errors.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Switch to explicit span declarations to help ensure this works with linux.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Fixed compile error.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Make the bulk terrain APIs take in const Vector instead of non-const.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Optimize the surface data providers for bulk queries.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>
4 years ago
..
Mocks Optimize surface providers (#7631) 4 years ago
Platform Removes some leftover log 4 years ago
Spawnable Minor updates to the Spawnable Entity Aliases in response to PR feedback. 4 years ago
Utils Fixes for viewport selection issues (#5494) 4 years ago
Application.cpp Update the FileIO Aliases (#4186) 4 years ago
ArchiveCompressionTests.cpp Update how Project Filepaths are calculated when not supplied via command line (#5194) 4 years ago
ArchiveTests.cpp Add support for configuring default Archive File Search Mode through a Cache Var (#5668) 4 years ago
AssetCatalog.cpp [development] fixed ambiguous 'byte' type MSVC build error (#7184) 4 years ago
AssetProcessorConnection.cpp Remove unused traits that disabled certain failed unit tests 4 years ago
BehaviorEntityTests.cpp Modernization + AZStd::function compare fix. (#3680) 4 years ago
BinToTextEncode.cpp Fixes test in AzFramework 4 years ago
CameraInputTests.cpp Fixes for `CameraInput` handling (#6425) 4 years ago
CameraState.cpp Clang 13: Fix build errors ... 4 years ago
ClickDetectorTests.cpp Improvement for click detection when clicking quickly between mouse moves (#5786) 4 years ago
CursorStateTests.cpp Fixes for viewport selection issues (#5494) 4 years ago
EntityContext.cpp Removes m_enableDrilling 4 years ago
FileIO.cpp Update the FileIO Aliases (#4186) 4 years ago
FileTagTests.cpp Removes m_enableDrilling 4 years ago
FrameworkApplicationFixture.h Shorten copyright headers by splitting into 2 lines (#2213) 4 years ago
GenAppDescriptors.cpp Update the FileIO Aliases (#4186) 4 years ago
InputTests.cpp Removed trait AZ_TRAIT_DISABLE_FAILED_INPUT_TESTS 4 years ago
Main.cpp Add a unit test for `XcbInputDeviceKeyboard` (#4393) 4 years ago
NativeWindow.cpp Modernization + AZStd::function compare fix. (#3680) 4 years ago
OctreePerformanceTests.cpp Mark benchmark state variables in for loops as unused in benchmarks 4 years ago
OctreeTests.cpp Code/Framework compiling 4 years ago
PlatformHelper.cpp Add linux equivalents for all the places that enumerate platforms (#3325) 4 years ago
ProcessLaunchMain.cpp Shorten copyright headers by splitting into 2 lines (#2213) 4 years ago
ProcessLaunchParseTests.cpp Remove AZ_TRAIT_DISABLE_FAILED_PROCESS_LAUNCHER_TESTS and disabled tests from it (#7325) 4 years ago
Scene.cpp Removes m_enableDrilling 4 years ago
framework_shared_tests_files.cmake Fixes for viewport selection issues (#5494) 4 years ago
frameworktests_files.cmake Added unit tests for spawnable entity aliases. 4 years ago
process_launch_test_files.cmake Shorten copyright headers by splitting into 2 lines (#2213) 4 years ago
terrain_mock_files.cmake Moved TerrainDataRquestBus to AzFrameworkTestShared (#5835) 4 years ago