7c88f20e1e
Spinboxes now correct when rounding. ( #6748 )
...
* Spinboxes now correct when rounding.
Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com >
* Changes from PR
Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com >
* Fixed tests after change to rounding in spinbox
Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com >
2022-01-10 11:49:22 +00:00
8503915cdd
bugfix: correct mouseMove under AzToolsFrameworkHelper ( #6493 )
...
* bugfix: correct mouseMove under AzToolsFrameworkHelper
REF: https://github.com/o3de/o3de/issues/6481
Signed-off-by: Michael Pollind <mpollind@gmail.com >
* chore: added unit test
Signed-off-by: Michael Pollind <mpollind@gmail.com >
* chore: address comments
Signed-off-by: Michael Pollind <mpollind@gmail.com >
* chore: correct fixture
Signed-off-by: Michael Pollind <mpollind@gmail.com >
* chore: tweak mouse move logic
Signed-off-by: Michael Pollind <mpollind@gmail.com >
* updates to track mouse/cursor position via events instead of using QCursor::pos()
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* rename AzToolFrameworkTestHelperTest.cpp to AzToolsFrameworkTestHelpersTest.cpp
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
Co-authored-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
2022-01-07 14:43:34 +00:00
1a8b7aeb48
Small workaround and fix to ensure line fade (alpha) displays correctly ( #6733 )
...
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
2022-01-07 09:37:33 +00:00
98b0f206a0
Merge pull request #6705 from aws-lumberyard-dev/3495_preferences_panel_update
...
3495 Preferences panel update: fix richtext elision and allow html links
2022-01-07 08:52:45 +00:00
e2a960e442
Fixed a sync issue when a PrefaDOM was taken from a PrefabDocument.
...
When a PrefabDOM was taken from a PrefabDocument the Instance would continue to have the data from the original Prefab, which means they'd no longer be in sync as the Prefab would be empty. This was fixed by resetting the Instance so they're both clear.
Signed-off-by: AMZN-koppersr <82230785+AMZN-koppersr@users.noreply.github.com >
2022-01-05 17:21:15 -08:00
13375cd7d9
Merge branch 'development' into Prefabs/ProcessStackAddPrefabBug
2022-01-05 11:12:57 -08:00
31e51f8c3a
Minor updates to the Spawnable Entity Aliases in response to PR feedback.
...
Signed-off-by: AMZN-koppersr <82230785+AMZN-koppersr@users.noreply.github.com >
2022-01-05 10:47:23 -08:00
783a04b880
3495 Preferences panel update: fix richtext elision and allow html links
...
Signed-off-by: sphrose <82213493+sphrose@users.noreply.github.com >
2022-01-05 18:00:07 +00:00
e09a4d20d3
Merge pull request #6240 from tjmgd/bug-keyword-prefab-23
...
Fix for bug in entity outliner search box
2021-12-27 13:12:08 -06:00
a6240ff6bc
Editor issue after clicking Find Layer in Asset Browser and ( #6327 )
...
Find Slice in Asset Browser in Slice mode
Signed-off-by: T.J. McGrath-Daly <tj.mcgrath.daly@huawei.com >
2021-12-22 11:51:33 -08:00
33495e4858
Slice save path incorrect, and error message incomplete ( #6214 )
...
Signed-off-by: T.J. McGrath-Daly <tj.mcgrath.daly@huawei.com >
2021-12-22 11:32:14 -08:00
3f766629bc
Lua Editor log - text ghosted ( #6329 )
...
Signed-off-by: T.J. McGrath-Daly <tj.mcgrath.daly@huawei.com >
2021-12-22 09:36:34 -08:00
bb14675db7
Fix tests Debug ( #6405 )
...
Signed-off-by: AMZN-Igarri <82394219+AMZN-Igarri@users.noreply.github.com >
2021-12-20 16:53:41 +00:00
34edd4d0c0
Fixed post rebase Spawnable issues.
...
Signed-off-by: AMZN-koppersr <82230785+AMZN-koppersr@users.noreply.github.com >
2021-12-16 18:06:25 -08:00
1efbb7216f
Addressed issues found in/by the Spawnables benchmarks and unit tests.
...
Signed-off-by: AMZN-koppersr <82230785+AMZN-koppersr@users.noreply.github.com >
2021-12-16 16:01:17 -08:00
02137e2219
Fixed existing tests for Prefab processing.
...
Signed-off-by: AMZN-koppersr <82230785+AMZN-koppersr@users.noreply.github.com >
2021-12-16 16:01:13 -08:00
43c42f63c6
Cleaned up some unused code in the Prefab processor.
...
Signed-off-by: AMZN-koppersr <82230785+AMZN-koppersr@users.noreply.github.com >
2021-12-16 16:01:04 -08:00
7b5868d198
Added additional functions to edit prefabs during processing to PrefabDocument.
...
Signed-off-by: AMZN-koppersr <82230785+AMZN-koppersr@users.noreply.github.com >
2021-12-16 16:00:54 -08:00
b8e3b27ea9
Added a PrefabDocument for Prefab to simplify working with Prefabs during conversion to spawnables.
...
The new PrefabDocument handles the Prefab and the Instance. This reduces the number of times the Instance has to be reloaded from the Prefab and keeps the entity ids stable between steps. The intention is for all the PrefabDocument to conceptually manipulate the Prefab DOM, although behind the scenes it will manipulate the Instance for now. The Instance should only be directly used in case the PrefabDocument doesn't provide the functionality yet.
Signed-off-by: AMZN-koppersr <82230785+AMZN-koppersr@users.noreply.github.com >
2021-12-16 16:00:00 -08:00
9def902e1c
Fixes up parents for entities that are moved to another Prefab.
...
This fixes issues with entities that are moved to another Prefab and have a parent that was also moved to the same Prefab. Entities that have their parent moved to another Prefab continue to work as is because a placeholder entity is always left behind. Entities that are moved to another Prefab but have a parent that's still in the original Prefab will currently not work correctly. This will be a addressed in a future commit.
Signed-off-by: AMZN-koppersr <82230785+AMZN-koppersr@users.noreply.github.com >
2021-12-16 15:35:51 -08:00
76a913882c
Resolving links in the Prefab Processing Stack now also makes sure that entity ids of aliased entities are appropriately unique or match.
...
Signed-off-by: AMZN-koppersr <82230785+AMZN-koppersr@users.noreply.github.com >
2021-12-16 15:35:47 -08:00
cbea11c452
Minor performance optimization to Prefab Instance.
...
Signed-off-by: AMZN-koppersr <82230785+AMZN-koppersr@users.noreply.github.com >
2021-12-16 15:35:43 -08:00
7e38a5f35c
Fixed entity registration issue when setting up Spawnable Entity Aliases.
...
In some cases entities created for use as a Spawnable Entity Alias would share an entity id with their original. This is no longer working due to a reverse lookup from an entity id to its PrefabDOM. Upon further investigation this turned out to not matter as instances that are created by the PrefabCatchmentProcessor would create new entity ids any way. This cause unexpected behavior at runtime as entity relations may be broken. This will be addressed in a future fix.
Testing the above also highlighted a possible double delete in the builder when aliases were registered. This has also been fixed.
Signed-off-by: AMZN-koppersr <82230785+AMZN-koppersr@users.noreply.github.com >
2021-12-16 15:35:38 -08:00
016eda6cf1
Fixed infinite recursion when adding prefabs
...
While processing prefabs into spawnables new prefabs can be added for later processing. Because the new prefabs were immediately added to the list of prefabs it could happen that the new prefabs would be added to the active processor for processing, which could lead to infinite recursion. Adding prefabs while iterating prefabs now delays the addition until the iteration has completed.
Signed-off-by: AMZN-koppersr <82230785+AMZN-koppersr@users.noreply.github.com >
2021-12-16 15:35:33 -08:00
18cfcd659b
Fix missing parent class reflection for ProceduralPrefabSystemComponent ( #6413 )
...
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
2021-12-16 07:49:32 -08:00
d065eb9498
Initial improvements to fix viewport icon selection and draw order ( #6284 )
...
* wip fixes for entity viewport icons displaying in the correct order and handling selection correctly
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* add additional comment about z value
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* move manual sorting and some small tidy-up
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* update comment
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* updates following initial round of PR feedback
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* additional changes to support tests for entity icon intersection
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* add support to enable/disable icons separately from helpers
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* final tests added and small tidy-up to display EntityId correctly
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* update some manipulator test framework calls after utility functions were moved
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* fix for implicit cast
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* move icon scale values to AZ_CVARS
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* fix failing tests caught in AR and update some naming conventions for tests
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* update naming convention for members of ProjectedViewportRay
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* update other references to ProjectedViewportRay
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* update more references to ProjectedViewportRay change
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* update menus for python tests
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
2021-12-16 09:35:23 +00:00
8b7cdd45a3
Merge pull request #6344 from aws-lumberyard-dev/daimini/ReadOnly/TransformResetFix
...
Disable invalid operations related to procedural prefabs in the Inspector
2021-12-14 09:33:43 -06:00
71bb200e0a
[LYN-7064] Hot Loading of Procedural Prefabs ( #4923 )
...
* Prefab hotloading - load and maintain asset references
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Working hotloading
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Clean up code, add comments
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Add missing includes
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Add event for template removal.
Clear ProceduralPrefabSystemComponent lookup when templates are removed.
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Add unit test.
Fix missing include, make sure source name is set
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix missing include
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix missing include
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Update comments to make ebus event behavior more clear
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix missing include
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix missing includes
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix missing include
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix temp directory usage which doesn't work on linux
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix temp directory usage which doesn't work on linux
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Use AZ::IO::Path for comparison. Print paths on failure
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix unit test - register asset with catalog so it can be looked up later
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
2021-12-13 12:44:41 -08:00
45abb9f88e
Proc Prefabs: Remove feature toggle ( #6348 )
...
* Disable feature flag - redirect proc prefab check to IsPrefabSystemEnabled.
Procedural Prefabs are now on by default when the prefab system is enabled.
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Bump scene builder version to cause all procedural prefabs to rebuild
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Switch to lambda for ebus call
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Remove unused const
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
2021-12-13 11:52:03 -08:00
0dfb8d42c4
Disable the ability to instantiate into closed prefabs, and to move the root prefab in focus mode. ( #6320 )
...
* Disable "Move Up" and "Move Down" for focused prefab containers.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Disable the ability to instantiate prefabs inside closed prefab instances.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Minor comment fix.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-12-13 19:10:04 +01:00
586f146a84
Fixed nullptr error ( #6386 )
...
Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com >
2021-12-13 17:56:46 +00:00
c06b697c6b
Revert part of the fix as it would break unit tests. Verified the remaining code still achieves the same purpose on the UI side without impacting the backend.
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-12-10 15:06:55 -08:00
d1533914ab
Disable the additional transform context menu items in the inspector. Prevent the user from reparenting entities under procprefabs using the entity picker.
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-12-10 13:16:02 -08:00
8f134a82d1
Procedural Prefabs: Stable transform component ID ( #6227 )
...
* Set Procedural Prefab Transform ComponentId to the hash of the file path.
Procedural prefabs needs to have a deterministic transform component ID in order for saved patches still work when the prefab is regenerated.
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Switch to Cityhash instead of XXHash since prefab system is using that elsewhere
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Added unit test
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix missing include
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
2021-12-10 11:20:31 -08:00
ca49eedc5f
Convert prefab to temp spawnable assets ( #6179 )
...
* Convert prefab to temp in-memory spawnable assets
Signed-off-by: chiyenteng <82238204+chiyenteng@users.noreply.github.com >
2021-12-10 10:55:01 -08:00
53b88d4752
Preapre codebase for FileRequest compiletime improvements ( #6192 )
...
* Preapre codebase for FileRequest compiletime improvements
This is preparing grounds for the next PR that will contain the 'meat'
of the changes.
Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com >
* Remove spurious newline.
Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com >
2021-12-10 13:08:24 +00:00
e9379c1746
[development] updated editor event handling with respect to imgui ( #6114 )
...
Fixes #4366
- Added support for sending text events from the Qt event mapper
- Fixed several issues found while running the Profiler gem in debug
- Added ability to track AZ-consumed events in the Qt event mapper
- Minor clean up to input handling in ImGuiManager
- Select ImGui mouse events can now be properly consumed during AZ-input processing in the editor viewport
- Added tests for the Qt event mapper
Signed-off-by: AMZN-ScottR 24445312+AMZN-ScottR@users.noreply.github.com
2021-12-09 13:58:27 -08:00
c63b4eb905
Removing unused variable and fix typo ( #6265 )
...
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
2021-12-09 12:53:25 -08:00
e1d36bc445
Merge pull request #6302 from aws-lumberyard-dev/cgalvan/HideViewportManiuplatorsOnReadOnlyEntitiesEdgeCase
...
Fixed logic for when to cull entities from having their viewport manipulators regenerated.
2021-12-09 14:24:39 -06:00
e636ea39e3
Fixed comment casing to match rest of file.
...
Signed-off-by: Chris Galvan <chgalvan@amazon.com >
2021-12-09 13:15:20 -06:00
8fd603cd50
Fix failed archive tests on linux and remove trait
...
- Change the test Archive Folder name, Extract Folder Name, and File List file to be all lowercase to prevent the 'ResolvePath' function in LocalFileIO when executed to cause issues on case sensitive file systems (#6277 )
- Fix memory corruption in profile builds on Linux when using AZ::IO::PathView by using AZ::IO::FixedMaxPath instead
Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com >
2021-12-09 10:18:11 -08:00
0bccecaa15
Fixed logic for when to cull entities from having their viewport manipulators regenerated.
...
Signed-off-by: Chris Galvan <chgalvan@amazon.com >
2021-12-09 11:36:39 -06:00
c2341a7e3c
Fix for change with axis gizmo labels not appearing ( #6256 )
...
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
2021-12-09 09:30:51 +00:00
f62ba7d1a4
Add ComponentApplicationLifecycle::RegisterEvent calls to avoid test console spam ( #6245 )
...
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
2021-12-09 09:30:24 +00:00
1aed839271
Fixed typo.
...
Signed-off-by: Chris Galvan <chgalvan@amazon.com >
2021-12-08 15:02:41 -06:00
9dc32a0381
Additional read-only prefab workflow changes.
...
Signed-off-by: Chris Galvan <chgalvan@amazon.com >
2021-12-08 12:30:31 -06:00
b54215552c
Prevent the camera from easily being set to an invalid orientation ( #6203 )
...
* add temporary debug logging
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* improvement for box select sometimes getting stuck on
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* add temporary debug logging
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* improvement for box select sometimes getting stuck on
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* remove temporary logging
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* fixes for camera pitch issues
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* missed file with camera pitch fixes
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* remove debug logs
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* add some tests for new pitch constraint updates
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
2021-12-08 09:42:40 +00:00
363007363a
In the entity outliner search box, the matching results are not expanded and displayed
...
Signed-off-by: T.J. McGrath-Daly <tj.mcgrath.daly@huawei.com >
2021-12-08 09:02:05 +00:00
a8ef23e4ae
Merge pull request #6232 from aws-lumberyard-dev/cgalvan/ReadOnlyPrefabWorkflowChanges
...
Some read-only prefab workflow updates.
2021-12-07 19:38:54 -06:00
3a7d9f9b3a
LYN-8633 | Read-Only Entities - Entity Outliner behavior changes ( #6230 )
...
* Add invalid entityId check to IsReadOnly
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Ensure read-only entities editing is limited (no renaming, limited drag/drop, no asset drop on them)
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Removing redundant class definition in wrong namespace.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-12-07 16:58:29 -08:00
John Jones-Steele
Michael Pollind
Tom Hulton-Harrop
sphrose
AMZN-koppersr
Chris Galvan
tjmgd
AMZN-Igarri
amzn-mike
Danilo Aimini
chiyenteng
Artur K
Scott Romero
Steve Pham
Tobias Alexander Franke