Esteban Papp
e4122bff22
Removes unused files from TestImpactFramework
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2022-01-20 15:35:43 -08:00
Esteban Papp
92d77c2b4a
Removes unused files from LuaIDE, Telemetry is not being used, the only ebus called is Initialized, but no "LogEvents are being called.
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2022-01-20 15:35:39 -08:00
Esteban Papp
d624381885
Removes resource/targetver files from LuaIDE
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2022-01-20 15:35:35 -08:00
Esteban Papp
65516e5bd1
Removes OverlayWidgetLayer from SceneUI
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2022-01-20 15:35:31 -08:00
Esteban Papp
fdd75bbbf5
Removes SceneUIStandaloneAllocator from SceneUI
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2022-01-20 15:35:27 -08:00
Esteban Papp
7d2e53ca7a
Remove unused files from SceneCore
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2022-01-20 15:35:23 -08:00
Esteban Papp
f9f427bd9c
Remove unused test files from SceneAPI/SceneBuilder
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2022-01-20 15:35:18 -08:00
Esteban Papp
a9d8a5dcb3
Removes BufferedDataStream and FileStreamDataSource from CrashHandler
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2022-01-20 15:35:14 -08:00
Esteban Papp
583020b3ae
Removes unused files from AsetProcessor
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2022-01-20 15:35:03 -08:00
Esteban Papp
b3ba73db3b
Removing unneded include form multiple files
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2022-01-20 15:30:50 -08:00
Chris Galvan
514f0c1546
Merge pull request #6935 from RoddieKieley/issue5299
...
issue5299: Resolved via change to not disable custom window decorations.
2022-01-20 15:17:37 -06:00
Steve Pham
59e43813f0
GCC Support for Linux
...
Updates and fixes to support GCC for Linux
Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com >
Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com >
2022-01-20 13:00:02 -08:00
AMZN-byrcolin
63d755b8f1
fix launcher not showing gems ( #7015 )
...
Signed-off-by: byrcolin <byrcolin@amazon.com >
2022-01-19 17:09:40 -08:00
Vincent Liu
5cac67bfad
Silence aws logging for unit test and have a new AWSNativeSDK as entry point for test env ( #6865 )
...
* Silence aws logging for unit test
* Create a new AWSNativeSDK entry point for test environment only
* Update naming for target and file
2022-01-19 12:11:39 -08:00
Roddie Kieley
646443cfe5
issue5299: Resolved via change to not disable custom window decorations.
...
Signed-off-by: Roddie Kieley <rkieley@redhat.com >
2022-01-15 14:54:23 -03:30
AMZN-byrcolin
c778606c89
Templates restricted ( #6498 )
...
* Templates/Restricted upgrade/fixes:
Fixed template storage format: templates now only store true relative paths and no longer save "origin" paths and "optional" has been removed, it was never used.
Upgraded all templates to new standard
Template system now correctly handles child objects: Child objects no longer have to specify restricted they inherit from parent
Restricted now operates at the object level and makes no assumptions about parent
Restricted templates can now be combined and seperated on creation
ly_get_list_relative_filename has been deprecated for o3de_pal_dir
All Gems/Projects/Templates updated to use new code
Signed-off-by: byrcolin <byrcolin@amazon.com >
2022-01-14 10:27:20 -08:00
Scott Romero
34d74857f5
[development] fix for a possible MSVC compiler bug ( #6870 )
...
Replaced a variable with the name "interface" to avoid conflict with MSVC keyword
Signed-off-by: AMZN-ScottR <24445312+AMZN-ScottR@users.noreply.github.com >
2022-01-13 12:55:36 -08:00
amzn-mike
fed1278fe6
AP: product dependency optimization ( #6619 )
...
* Initial pass at optimizing product path dependency resolution
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Add version of StripAssetPlatform that doesn't allocate or copy strings. Re-add missing test and fix up compile errors. Add benchmark test
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Change UpdateProductDependencies to directly call s_InsertProductDependencyQuery.BindAndStep
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Add test for same filename on multiple platforms
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Rework search logic to keep track of the source of a search path (source vs product) and keep track of which search matches which dependency to avoid doing another search through every product later on
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Clean up code, expand test
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix paths not being lowercased by SanitizeForDatabase. Fix UpdateProductDependencies not updating existing dependencies
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Add test for duplicate dependency matches. Fix saving duplicates
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Clean up code
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Separate test into test and benchmark versions
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Cleanup include
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix includes, switch hardcoded job manager setup to use JobManagerComponent instead
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Replaced wildcard_match with PathView::Match. Changed StripAssetPlatformNoCopy to use TokenizeNext. Removed Environment Create/Destroy calls. Made ScopedAllocatorFixture a base class of ScopedAllocatorSetupFixture
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Add AZ Environment create/destroy on AP test environment
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Add missing asserts on database functions
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix incorrect usage of StripAssetPlatformNoCopy
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix source/product dependency type being ignored. Removed need for unordered_set for list of resolved dependencies. Updated unit tests
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Better variable names
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Remove testing code
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix missing includes and namespaces
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
2022-01-13 06:56:24 -08:00
lumberyard-employee-dm
18ea4ba6a8
Added a CriticalAssetsCompiled Lifecycle event ( #6469 )
...
The CriticalAssetsCompiled event can be handled to detect when the
AssetProcessor has finished processing Critical Assets
Also with the new event, an audit has been performed over all the
locations where the AssetCatalogEventBus OnCatalogLoaded event was being
handle to make sure it was the proper event to use.
If the handler was actually examing the enumerating over the full
catalog or querying all assets within the catalog, then it was a proper
use.
For handlers that were interested in a particular asset it was not
Moreover added implementations of `OnCatalogAssetChanged` and
`OnCatalogAssetAdded` to the FileTagComponent and the MaterialViewportComponent.
Any applications which uses the AtomToolsApplication
class(MaterialEditor, AtomSampleViewerStandalone,
ShaderMangementConsole) now signals a "CriticalAssetsCompiled" lifecycle
event as well as loads the "assetcatalog.xml" if it exists.
The Launcher application signals the "CrticalAssetsCompiled" event and
reloads the "assetcatalog.xml" for the ${project}.GameLauncher and
${project}.ServerLauncher in Launcher.cpp
Finally the Editor signals the "CriticalAssetsCompiled" and reloads the
"assetcatalog.xml" in CryEdit.cpp
resolves #6093
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com >
2022-01-10 15:21:04 -06:00
Esteban Papp
0f7e55cf59
Some fixes for paths with spaces ( #6757 )
...
* Some fixes for paths with spaces
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* PR comments
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2022-01-10 10:00:29 -08:00
Benjamin Jillich
afc531d4c3
Fixes VS2022 error C5233: explicit lambda capture 'isSlash' is not used ( #6745 )
...
Signed-off-by: Benjamin Jillich <jillich@amazon.com >
2022-01-10 10:22:02 +01:00
Esteban Papp
54e0b8b7b5
Enabling mac tests ( #6716 )
...
* Adds mac test job
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Points to sysctl properly to handle zsh
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Fixes some macos differences with Linux when reading the CTEST_RUN_FLAGS parameters
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* adding the test job to the profile pipe
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Disables some tests in Mac that are not passing
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* passes config to cli_test_driver and sets the right trait for the test (pytest instead of lytesttools)
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Set proper traits for AtomRHI
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Corrected AZ_TRAIT_UNIT_TEST_PERLINE_GRADIANT_GOLDEN_VALUES_7878 values for Mac
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Disables EMotionFX tests in Mac
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Removes debugging prints
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Removes filters that were meant just for Linux
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* quotes are re-quoted in the test_mac.sh script
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2022-01-06 16:16:48 -08:00
Allen Jackson
6c3d5c434e
{lyn8865} Adding DataTypes::ScriptProcessorFallbackLogic ( #6396 )
...
* {lyn8865} Adding DataTypes::ScriptProcessorFallbackLogic
- Give the user an option how to handle fallback logic for script rules
Signed-off-by: Allen Jackson <23512001+jackalbe@users.noreply.github.com >
* the new code found an error in a Python script... it seems to work!
Signed-off-by: Allen Jackson <23512001+jackalbe@users.noreply.github.com >
* fixing up the regression test
Signed-off-by: Jackson <23512001+jackalbe@users.noreply.github.com >
* dump version number
Signed-off-by: Allen Jackson <23512001+jackalbe@users.noreply.github.com >
2022-01-05 16:08:58 -06:00
Chris Burel
648a21ab5c
[Linux] Correct handling of new dirs added to non-recursive watch roots
...
Signed-off-by: Chris Burel <burelc@amazon.com >
2022-01-04 16:12:17 -08:00
Chris Burel
2bc1d8620e
Rename file to adhere to PAL conventions
...
Signed-off-by: Chris Burel <burelc@amazon.com >
2022-01-04 16:12:17 -08:00
Chris Burel
484e27c109
Use AZStd::equal to implement path comparison
...
Signed-off-by: Chris Burel <burelc@amazon.com >
2022-01-04 16:12:17 -08:00
Chris Burel
ce0bb1ca2b
[AssetProcessor] Refactor the FileWatcher to use only one watch thread
...
This change reworks the AssetProcessor's FileWatcher so that it only uses
one thread. This is motivated by getting better support for inotify on
Linux. The previous architecture required calling `inotify_init` once for
each directory that was being watched, and using separate inotify instances
for each watched tree. In addition, having separate threads per watched
tree is not necessary, and just consumes system resources. Each platform
supports watching multiple directories with the same platform-specific
watcher API, so each platform has been updated accordingly.
The interface to the FileWatcher class is greatly simplified. Previously,
it supported client-supplied filtering of the paths that would generate
notifications. This was done by subclassing `FolderWatchBase` and
implementing `OnFileChange`. However, only one filter was ever used, so
that filter is now hard-coded in the FileWatcher class, and the classes
driving the old filtering mechanism are removed. Users of the interface
now have a much easier time, they just call `AddFolderWatch` with the path
to watch, and only have to connect to one set of signals, instead of
separate signals per watched directory.
Signed-off-by: Chris Burel <burelc@amazon.com >
2022-01-04 16:12:17 -08:00
Chris Burel
7ac5bc3d5c
[Linux] Display a warning in AP if inotify fails to initialize
...
Signed-off-by: Chris Burel <burelc@amazon.com >
2022-01-04 16:12:17 -08:00
Chris Burel
04f4d5e031
[Linux] Avoid recursive inotify when a watch folder is set to recursive=false
...
Signed-off-by: Chris Burel <burelc@amazon.com >
2022-01-04 16:12:17 -08:00
Vincent Liu
2b9d1ca813
Update to use AWSNativeSDK 1.9.50 ( #6618 )
...
* Update to use AWSNativeSDK 1.9.50
* After SDK upgrade, some AWS objects are bound to SDK allocator, init AWS SDK for unit test
2022-01-04 12:45:51 -08:00
amzn-mike
8ee384f436
Asset Processor: Remove gem loading from AP ( #6488 )
...
* AssetBuilder sends builder registration network message to AP
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Add AP activating status message
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* First builder handles registration.
Fixed deadlock caused by AP and AssetBuilder waiting on each other when registering by moving AP builder start code to a thread
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Clean up external builder registration
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Add thread description for builder manager idle thread
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Remove gem loading
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Clean up builder registration and remove unused functions
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Remove PostActivate call from batch application since it will be called after builders are registered
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Removal external builder dependency scanning since we no longer support builder dlls
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix missing bus disconnect
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Remove unused variable
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Moved AP-AssetBuilder specific types into AssetBuilder.Static library. Also removed some unused/old code
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
2022-01-04 12:34:56 -08:00
AMZN-Phil
9f500b1228
Merge pull request #6571 from aws-lumberyard-dev/Prism/RearrangeProjectsAfterRemoval
...
Reflow Project Tiles Everytime They Are Updated
2022-01-04 09:03:42 -08:00
amzn-mike
81453defa0
Load QIcons once for asset tree and share with each Asset Tree Item to avoid file loads for every asset and improve start up time ( #6485 )
...
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
2022-01-03 09:56:19 -06:00
amzn-mike
a95b303f19
Remove Shader compiler tab from Asset Processor ( #6486 )
...
* Remove Shader compiler tab from Asset Processor
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Remove more references to shader compiler
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
2022-01-03 09:44:51 -06:00
amzn-mike
346a414aff
Change AP unit test project to a DLL like all others, add benchmarks project ( #6588 )
...
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
2022-01-03 09:44:34 -06:00
nggieber
451ebf2691
Reflow Project Tiles Everytime They Are Updated
...
Signed-off-by: nggieber <52797929+AMZN-nggieber@users.noreply.github.com >
2021-12-27 12:32:24 -08:00
tjmgd
f1a1cb3ec0
Fix: Lua directory empty and always loading in editor ( #6207 )
...
* Fix: Lua directory empty and always loading in editor
Signed-off-by: T.J. McGrath-Daly <tj.mcgrath.daly@huawei.com >
* fixed naming convention errors
Signed-off-by: T.J. McGrath-Daly <tj.mcgrath.daly@huawei.com >
* Tidy up
Signed-off-by: T.J. McGrath-Daly <tj.mcgrath.daly@huawei.com >
Co-authored-by: Tobias Alexander Franke <tobias.alexander.franke@huawei.com >
2021-12-23 12:12:40 -08:00
tjmgd
c2373f1f59
Fix: search results not expanded when searching for .lua files ( #6211 )
...
Signed-off-by: T.J. McGrath-Daly <tj.mcgrath.daly@huawei.com >
Co-authored-by: Tobias Alexander Franke <tobias.alexander.franke@huawei.com >
2021-12-23 12:12:27 -08:00
tjmgd
254906cd83
The line number displayed by Breakpoints in Lua Editor is 1 larger than ( #6299 )
...
the actual line number of the code.
Signed-off-by: T.J. McGrath-Daly <tj.mcgrath.daly@huawei.com >
2021-12-22 11:32:40 -08:00
tjmgd
7b99b6a1e2
Fix: next and prev tabs incorrectly implemented ( #6208 )
...
Signed-off-by: T.J. McGrath-Daly <tj.mcgrath.daly@huawei.com >
Co-authored-by: Tobias Alexander Franke <tobias.alexander.franke@huawei.com >
2021-12-22 11:31:49 -08:00
tjmgd
38bbf9659e
Fix: jumps disordered (Go to Line,Transpose Lines UP,Transpose Lines ( #6210 )
...
Down,Comment Selected Block and UnComment Selected Block)
Signed-off-by: T.J. McGrath-Daly <tj.mcgrath.daly@huawei.com >
Co-authored-by: Tobias Alexander Franke <tobias.alexander.franke@huawei.com >
2021-12-22 10:54:49 -08:00
Michael Pollind
1a26ea439a
bugfix[Linux]: resolve Lua script file not found ( #6369 )
...
* bugfix: resolve Lua script file not found
REF: https://github.com/o3de/o3de/issues/5899
Signed-off-by: Michael Pollind <mpollind@gmail.com >
* chore: user lowcase version of assetIdLower
Signed-off-by: Michael Pollind <mpollind@gmail.com >
2021-12-22 09:07:42 -08:00
Jeremy Ong
a96387ee35
Fix compile issues blocking adoption of Pix 2108
...
Signed-off-by: Jeremy Ong <jcong@amazon.com >
2021-12-21 13:52:20 -07:00
Mike Balfour
f23798a10a
Merge commit '58b6a9c1acfc4e1344e9d0b79b5572ef173c030c' into mbalfour/gitflow_211220_stabilization_2111RTE
2021-12-20 14:43:30 -06:00
Mike Balfour
f6faad4adb
Merge commit '2fa10d7e6a99c38d578fe5ed969cfd07c5f0df28' into mbalfour/gitflow_211220_stabilization_2111RTE
2021-12-20 14:43:24 -06:00
Mike Balfour
22df3a843e
Merge commit '6613030fe691d87c3a870f17c448746616c44787' into mbalfour/gitflow_211220_stabilization_2111RTE
2021-12-20 13:49:19 -06:00
tjmgd
f4ae3a5b7d
Fix: Find function reports code with a line offset of 1 ( #6331 )
...
Signed-off-by: T.J. McGrath-Daly <tj.mcgrath.daly@huawei.com >
2021-12-16 15:39:03 +00:00
AMZN-Phil
105524b7c0
Add a missing comma to fix generator
...
Signed-off-by: AMZN-Phil <pconroy@amazon.com >
2021-12-15 09:29:40 -08:00
AMZN-Phil
98fa18558e
Force Project Manager to use VS2019
...
Signed-off-by: AMZN-Phil <pconroy@amazon.com >
2021-12-13 17:40:09 -08:00
Tommy Walton
7188529652
Fix for GHI-4644: mesh optimization breaking skin influences (DCO fix) ( #6336 )
...
* Average incoming skin influences when multiple vertices have been welded. This is one option which will average out the weights even if two welded vertices have differing boneIds, but we probably also need to add the influences earlier in the process and enforce a process where the vertices do not get welded if they have influences with differing boneIds
Signed-off-by: Tommy Walton <waltont@amazon.com >
* Move skin influences from MeshBuilderSkinningInfo to the vertex attribute layers so they are considered when choosing which vertices can be welded and so they are not duplicated when compatible vertices have been welded
Signed-off-by: Tommy Walton <waltont@amazon.com >
* Updating unit tests
Signed-off-by: Tommy Walton <waltont@amazon.com >
* Remove unused functions
Signed-off-by: Tommy Walton <waltont@amazon.com >
* Update based on feedback from burelc
Signed-off-by: Tommy Walton <waltont@amazon.com >
2021-12-13 13:07:04 -08:00