Commit Graph

664 Commits

Author SHA1 Message Date
Artur K 53b88d4752 Preapre codebase for FileRequest compiletime improvements (#6192)
* Preapre codebase for FileRequest compiletime improvements

This is preparing grounds for the next PR that will contain the 'meat'
of the changes.

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

* Remove spurious newline.

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>
2021-12-10 13:08:24 +00:00
Gene Walters 4b3d1452fd Merge pull request #6066 from aws-lumberyard-dev/LYN-8514_AutomatedReviewServerLogChecks
Updating Multiplayer PyTests To Check Server Logs
2021-12-09 09:15:58 -08:00
galibzon 76e09a36d9 Make math classes & EntityId visible in Lua Documentation. (#6261)
Small change in behavior context attribute for a few
classes so they become visible when extracting Lua symbols
from the ScriptContextDebug() API.

From:
Attribute(AZ::Script::Attributes::ExcludeFrom,
    AZ::Script::Attributes::ExcludeFlags::All)

To:
Attribute(AZ::Script::Attributes::ExcludeFrom,
    AZ::Script::Attributes::ExcludeFlags::ListOnly)

It seems the previous code was simply trying to hide those symbols from
the Script Canvas node palette. But it was also, seemingly unintentional,
hiding those symbol from Lua Documentation.

Signed-off-by: galibzon <66021303+galibzon@users.noreply.github.com>
2021-12-08 16:51:44 -06:00
Gene Walters f97707a28a Removing hand-written /n from all AZLOG_ now that we properly add \n automatically
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-12-07 16:14:08 -08:00
Gene Walters b123379380 Properly adding newlines when using LogInternalV; removing the need of hand-placed newlines to AZ_LOG
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-12-07 14:53:59 -08:00
Esteban Papp 5cca52e73c Merge branch 'development' into redcode/driller_removal
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

# Conflicts:
#	Code/Framework/AzCore/AzCore/azcore_files.cmake
#	Gems/Atom/Feature/Common/Assets/Materials/Presets/MacBeth/15_red_sRGB.tif
2021-12-07 13:31:55 -08:00
Esteban Papp cd5306febf Merging from development
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
2021-12-07 12:35:41 -08:00
Nicholas Van Sickle 3d8664ee92 Merge pull request #5511 from aws-lumberyard-dev/nvsickle/GenericDomJson
Generic DOM: Add DomBackend abstraction and JSON support
2021-12-07 11:20:53 -08:00
Nicholas Van Sickle 6cf805256b Make backend write API string-based
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com>
2021-12-06 15:55:35 -08:00
carlitosan 15e26b7515 merge development
Signed-off-by: carlitosan <82187351+carlitosan@users.noreply.github.com>
2021-12-06 12:21:45 -08:00
Gene Walters 9ae3da7acd Merge branch 'upstream/development' into LYN-8514_AutomatedReviewServerLogChecks 2021-12-06 11:30:12 -08:00
Nicholas Van Sickle ea9d7c9d82 Add optional size parameter to ReadFromBufferInPlace
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com>
2021-12-06 10:45:45 -08:00
Nicholas Van Sickle 1c42cd98cc Address a bit more review feedback
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com>
2021-12-06 10:31:35 -08:00
Esteban Papp 03adf700fe Merge branch 'development' into redcode/driller_removal
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
2021-12-03 13:35:16 -08:00
Nicholas Van Sickle 037a93406a Fix a couple format string issues
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com>
2021-12-03 12:40:52 -08:00
Nicholas Van Sickle f2f7dad972 Remove FormatVisitorErrorMessage
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com>
2021-12-03 12:26:19 -08:00
Nicholas Van Sickle 016e261f36 Add DomUtils
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com>
2021-12-03 11:25:15 -08:00
Esteban Papp 620690f2d6 Fixes Windows release build
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
2021-12-03 10:40:22 -08:00
Gene Walters e2d1cdc9a5 Update Logger to use fixed_string
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-12-03 10:07:28 -08:00
lumberyard-employee-dm c3fdbfb926 Updated the ComponentApplication Settings Registry initialization to no (#6108)
longer read form the users `~/.o3de/Registry` directory in non
debug/profile configurations.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
2021-12-03 11:55:23 -06:00
Esteban Papp 5f41e404a5 PR comment
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
2021-12-02 18:12:40 -08:00
Esteban Papp 7817ed76bf Removes FileIOEventBus
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
2021-12-02 18:08:45 -08:00
Nicholas Van Sickle 59a2216584 Fix a build issue
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com>
2021-12-02 17:49:29 -08:00
Nicholas Van Sickle 4dbce4275b Refactor the interface after some chatting with @amazon-employee-dm
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com>
2021-12-02 17:46:07 -08:00
Esteban Papp af19b53dde Removes FileIOBus
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
2021-12-02 17:43:47 -08:00
Esteban Papp 498673ada0 Removes Driller from AzCore
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
2021-12-02 17:15:46 -08:00
Gene Walters d4e7a9cf16 Removing adding the null-terminator by hand. _vsnprintf_s already does this. Even if the buffer is too small, the /0 is still at the end
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-12-02 14:41:24 -08:00
Esteban Papp 5dfd40d056 Removes leftover from profiler tool
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
2021-12-02 14:39:38 -08:00
Gene Walters efcbc7ccd7 Removing code which was supposed to add a newline, but never did. The comment said it was required because of an assumption with Trace, but clearly Trace doesn't make that assumption
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-12-02 14:36:41 -08:00
carlitosan 6bd0308339 Merge remote-tracking branch 'origin/development' into sc-editor-asset-redux
Signed-off-by: carlitosan <82187351+carlitosan@users.noreply.github.com>
2021-12-02 14:17:35 -08:00
Esteban Papp 59ef6f983f Removes Driller from ScriptCanvas
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
2021-12-02 13:55:00 -08:00
Esteban Papp de06bb75e5 Fixes some unit tests due to the removal of the MemoryDriller
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
2021-12-02 12:41:32 -08:00
Esteban Papp 19ddeeded9 Removes ThreadDrillerEvents, replaces handlers with TreadEventBus
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
2021-12-02 12:40:39 -08:00
Esteban Papp 8bde44d5fb Removes TraceMessageDrillerBus
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
2021-12-02 10:09:42 -08:00
Esteban Papp 59714fb31d Removes MemoryDrillerBus
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
2021-12-01 19:27:30 -08:00
Esteban Papp c3f035c4e3 Removes AssetMemoryAnalyzer that relies on the MemoryDrillerBus
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
2021-12-01 19:08:12 -08:00
Esteban Papp 95ed1015a5 Removes the MemoryDriller
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
2021-12-01 18:48:07 -08:00
Esteban Papp 075eeee0bd Removes PlatformMemoryInstrumentation.h and PLATFORM_MEMORY_INSTRUMENTATION_ENABLED
This was part of another instrumentation framework that was never fully integrated

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
2021-12-01 18:47:23 -08:00
Esteban Papp 3f6246ccbe Removes recording of memory records through the MemoryDriller
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
2021-12-01 18:21:39 -08:00
Esteban Papp 47de333e94 Removes m_enableDrilling
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
2021-12-01 16:50:45 -08:00
Nicholas Van Sickle 1aaa267585 Fix one last bit of minor feedback
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com>
2021-12-01 16:49:48 -08:00
Nicholas Van Sickle 2dddb97b7c One last round of stray review feedback I missed
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com>
2021-12-01 16:32:23 -08:00
Nicholas Van Sickle d519d4cb03 Improve performance for both in-place and copy parsing (faster than AZ::JsonSerializationUtils::ReadJsonString now!)
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com>
2021-12-01 16:22:48 -08:00
Nicholas Van Sickle e0508ddefc Make JsonBackend templated
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com>
2021-12-01 12:10:22 -08:00
lumberyard-employee-dm e8750f8096 Rename sr_regset-file CVar to sr_regset_file (#6067)
The Legacy Cry XConsole code validates that CVars only contain
underscore and alphanumeric characters via an Assert in `debug`
configurations.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
2021-12-01 13:16:19 -06:00
amzn-mike 828431f185 Update AssetManager unit tests to not interact with the disk (#5815)
* Changed AssetManager tests to use memory streams for asset reading/writing

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Fix compilation on non-unity builds

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Fixed handling of path lookups when test folder path is non-empty

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Add more detailed error message for "asset is not loaded"

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Make numThreads a constexpr

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Add FindFile function

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Remove unused lambda capture

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Remove trailing whitespace

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Add size to assert

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>
2021-12-01 09:05:35 -06:00
Nicholas Van Sickle f87021d856 Expose JSON parse flag options
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com>
2021-11-30 22:08:48 -08:00
Nicholas Van Sickle a9c05372d5 API tweaks
- Use ref types
- Support using rapidjson::Value in lieu of rapidjson::Document
- Use the existing JSON comparison util function in tests

Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com>
2021-11-30 18:00:59 -08:00
Esteban Papp fb6e6e339f Add CRC validator (#5857)
* Adds crc validation checks

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* Fixes invalid CRCs

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* Changes test to smoke suite

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* excludes some test data from the validator

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* uses pathlib instead of os.path

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* fixes wrong path to test scripts

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* Escape not needed

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
2021-11-30 15:07:57 -08:00
Nicholas Van Sickle 5dbe9e387b Address some review feedback, remove DomBackendRegistry
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com>
2021-11-30 12:10:16 -08:00