Commit Graph

10854 Commits

Author SHA1 Message Date
sphrose 56837f48d9 Remove error state when user attempts to save empty script event.
Signed-off-by: sphrose <82213493+sphrose@users.noreply.github.com>
2022-01-14 16:29:00 +00:00
moraaar a43cd95313 Fixed physics periodic tests on linux platform (#6881)
- Fixed path separators, now levels will be correctly opened in linux.
- Fixed casing of physics paths.
- Fixed casing of files inside levels Joints_HingeNoLimitsConstrained and RigidBody_KinematicModeWorks.
- Resaved a level that still used old test ids in its name but the python tests didn't match.

Linux:
     Start 21: AutomatedTesting::PhysicsTests_Periodic.periodic::TEST_RUN
8/11 Test #21: AutomatedTesting::PhysicsTests_Periodic.periodic::TEST_RUN ..................   Passed  609.87 sec

Windows:
     Start 21: AutomatedTesting::PhysicsTests_Periodic.periodic::TEST_RUN
8/13 Test #21: AutomatedTesting::PhysicsTests_Periodic.periodic::TEST_RUN .......................   Passed  810.59 sec

Signed-off-by: moraaar <moraaar@amazon.com>
2022-01-14 10:01:38 +00:00
Nicholas Van Sickle f026e543cc Merge pull request #6395 from aws-lumberyard-dev/nvsickle/GenericDomDocument
Add a generic Value type to the Generic DOM
2022-01-13 16:45:32 -08:00
Jeremy Ong 7e5e4842b0 Merge pull request #6676 from aws-lumberyard-dev/Atom/mriegger/format
Remove 'INF' from integer widget and replace it with better formatted…
2022-01-13 17:18:57 -07:00
Vincent Liu 42c523b275 Add SetEnv and UnSetEnv for environment variable to util (#6884)
* Add SetEnv and UnSetEnv for environment variable to util
* Move utils to AzTest
* enable for ios and android
* fix wrong file path
2022-01-13 16:07:44 -08:00
michabr 193f529b9c Add an LyShine client API target (#6829)
* Reduce the need to link with LyShine static lib in other gems

Signed-off-by: abrmich <abrmich@amazon.com>

* Add UiBasics.Builders to VirtualGamepad.Builders alias

Signed-off-by: abrmich <abrmich@amazon.com>

* Add UiBasics to LyShine gem's metadata

Signed-off-by: abrmich <abrmich@amazon.com>

* Change include to a forward declaration

Signed-off-by: abrmich <abrmich@amazon.com>
2022-01-13 12:56:34 -08:00
Scott Romero 34d74857f5 [development] fix for a possible MSVC compiler bug (#6870)
Replaced a variable with the name "interface" to avoid conflict with MSVC keyword

Signed-off-by: AMZN-ScottR <24445312+AMZN-ScottR@users.noreply.github.com>
2022-01-13 12:55:36 -08:00
Mike Balfour 79431f5e5f First batch of GetValues() overrides (#6852)
* Benchmarks and tests for Image and Constant GetValues

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Verify GetValues for Perlin and Random Gradients

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Standardized the assert format for GetValues().

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* More GetValues unit tests and test cleanup

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Fixed typos

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* GetValues() unit tests for surface gradients.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Benchmarks for ShapeAreaFalloff Gradient

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Added benchmarks for all remaining gradients and cleaned up the helper methods.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Renamed class for better report formatting.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Added missing Mocks dependencies for the Editor tests.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* First batch of specific GetValues() overrides.
Each one is measurably faster than the generic version.  Also, in ShapeAreaFalloffGradient, I optimized and simplified the logic a bit, so GetValue() is marginally faster too.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>
2022-01-13 14:50:54 -06:00
Mike Balfour 62e7483b0e Switched GradientSignal to use GemTestEnvironment. (#6886)
This allows actual Shape components to be used instead of MockShapes, which is important for the benchmarks to get accurate results as Mocks are extremely expensive.  It also removes a lot of unnecessary mock handling and test setup code.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>
2022-01-13 14:44:59 -06:00
Chris Galvan a99bf8ff1a Merge pull request #6882 from aws-lumberyard-dev/cgalvan/RemovedUnusedEditorUtils
Removed some unused EditorUtils functions
2022-01-13 13:09:21 -06:00
Chris Galvan 3f0bd92853 Removed some unused EditorUtils functions
Signed-off-by: Chris Galvan <chgalvan@amazon.com>
2022-01-13 10:28:58 -06:00
amzn-mike fed1278fe6 AP: product dependency optimization (#6619)
* Initial pass at optimizing product path dependency resolution

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Add version of StripAssetPlatform that doesn't allocate or copy strings.  Re-add missing test and fix up compile errors.  Add benchmark test

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Change UpdateProductDependencies to directly call s_InsertProductDependencyQuery.BindAndStep

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Add test for same filename on multiple platforms

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Rework search logic to keep track of the source of a search path (source vs product) and keep track of which search matches which dependency to avoid doing another search through every product later on

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Clean up code, expand test

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Fix paths not being lowercased by SanitizeForDatabase.  Fix UpdateProductDependencies not updating existing dependencies

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Add test for duplicate dependency matches.  Fix saving duplicates

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Clean up code

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Separate test into test and benchmark versions

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Cleanup include

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Fix includes, switch hardcoded job manager setup to use JobManagerComponent instead

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Replaced wildcard_match with PathView::Match.  Changed StripAssetPlatformNoCopy to use TokenizeNext.  Removed Environment Create/Destroy calls.  Made ScopedAllocatorFixture a base class of ScopedAllocatorSetupFixture

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Add AZ Environment create/destroy on AP test environment

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Add missing asserts on database functions

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Fix incorrect usage of StripAssetPlatformNoCopy

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Fix source/product dependency type being ignored.  Removed need for unordered_set for list of resolved dependencies.  Updated unit tests

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Better variable names

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Remove testing code

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Fix missing includes and namespaces

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>
2022-01-13 06:56:24 -08:00
tjmgd 6d1a2382e8 Bug hide window (#5939)
* [lyn3736] adding init files to module paths (#5111)

* fixing class names in PYI files

Signed-off-by: jackalbe <23512001+jackalbe@users.noreply.github.com>
Signed-off-by: T.J. McGrath-Daly <tj.mcgrath.daly@huawei.com>

* Fixed crash when typing asset name and clicking browse (#5495)

Signed-off-by: T.J. McGrath-Daly <tj.mcgrath.daly@huawei.com>

* Fixed bug involving inappropriate window

Signed-off-by: T.J. McGrath-Daly <tj.mcgrath.daly@huawei.com>

Co-authored-by: Allen Jackson <23512001+jackalbe@users.noreply.github.com>
Co-authored-by: AMZN-AlexOteiza <82234181+AMZN-AlexOteiza@users.noreply.github.com>
2022-01-13 14:56:38 +01:00
Andre Mitchell ff0df4b8b6 Update behavior reflection of EMotionFX's MotionEvent to use nullptr instead of empty lambdas. (#6617)
Signed-off-by: Andre Mitchell <andre.mitchell@bytesofpi.com>
2022-01-13 09:36:19 +01:00
Roman e224fc2ee5 Bugfix - ViewportInteractionImp connected to the wrong id in RenderViewportWidget (#6867)
Signed-off-by: rhhong <rhhong@amazon.com>
2022-01-12 22:39:56 -08:00
amzn-sj 073994e8e7 Remove quotes around list (#6864)
Signed-off-by: amzn-sj <srikkant@amazon.com>
2022-01-12 19:34:34 -06:00
Luis Sempé bd2ede053c Merge pull request #6860 from aws-lumberyard-dev/scripting/6855
Updated node subtitle, closes #6855
2022-01-12 15:50:59 -08:00
Nicholas Van Sickle 74e4055195 Fix Prefab instance assets not preloading (#6834)
PrefabCatchmentProcessor::ProcessPrefab was no longer updating the ProcessedObjectStore's referenced object list, this change exposes the referenced asset list in the new PrefabDocument API and uses them to update the referenced asset list.

Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com>
2022-01-12 15:23:06 -08:00
santorac 575be414bd Merge pull request #5221 from aws-lumberyard-dev/Atom/santorac/OrderOnceDependencyForPassBuilder
Changed PassBuilder's job dependencies to be OrderOnce.
2022-01-12 14:42:33 -08:00
santorac 68084d6a82 Merge pull request #6356 from aws-lumberyard-dev/Atom/santorac/ShaderVariantListSizeLimit
Removed file size limit on .shadervariantlist files.
2022-01-12 14:42:20 -08:00
Gene Walters c056ae705d Merge pull request #6714 from aws-lumberyard-dev/crash_log_bug
Crash log test tools bug
2022-01-12 12:24:07 -08:00
amzn-sj 5dc442fcb0 [Terrain] First pass of the ProcessList and ProcessRegion APIs for retrieving surface data (#6729)
* [Terrain] First pass of the ProcessList and ProcessRegion APIs for retrieving surface data

Signed-off-by: amzn-sj <srikkant@amazon.com>

* Add a couple of more tests. The expected values were plugged in based on the values generated by the brute force approach.

Signed-off-by: amzn-sj <srikkant@amazon.com>

* Move some declarations out of loops since they can be reused.

Signed-off-by: amzn-sj <srikkant@amazon.com>

* Update all the per position callbacks to pass SurfacePoint refs. Construct only one SurfacePoint object outside the loop which can be reused.

Signed-off-by: amzn-sj <srikkant@amazon.com>

* Update tests to use the new per position callbacks

Signed-off-by: amzn-sj <srikkant@amazon.com>

* Add ProcessRegion functions to the terrain benchmark.

Signed-off-by: amzn-sj <srikkant@amazon.com>

* Change C style static casts to aznumeric_cast. Add maybe_unused to unused params in benchmarks.

Signed-off-by: amzn-sj <srikkant@amazon.com>

* Update the ProcessList API functions to use array_view instead of a vector. This includes some additional changes to satisfy build dependencies.

Signed-off-by: amzn-sj <srikkant@amazon.com>

* Add ProcessList API functions to benchmarks

Signed-off-by: amzn-sj <srikkant@amazon.com>

* Update the ProcessList API functions to take Vector2 as input positions

Signed-off-by: amzn-sj <srikkant@amazon.com>

* Revert changes to AtomCore library split. Add partial implementation of span(mostly just copied over from array_view) to AzCore std containers.

Signed-off-by: amzn-sj <srikkant@amazon.com>

* Adding some const/non-const overloads that were missing in span

Signed-off-by: amzn-sj <srikkant@amazon.com>

* Move input position list generation to a function

Signed-off-by: amzn-sj <srikkant@amazon.com>

* Bring back Vector3 version of ProcessList functions. Rename Vector2 version to follow similar pattern as the Get functions.

Signed-off-by: amzn-sj <srikkant@amazon.com>

* Split span.h into .h/.inl files

Signed-off-by: amzn-sj <srikkant@amazon.com>

* Add [mayby_unused] for unused parameters to fix build errors

Signed-off-by: amzn-sj <srikkant@amazon.com>
2022-01-12 14:07:57 -06:00
amzn-sj 068244b1bb Remove quotes around list of paths (#6857)
Signed-off-by: amzn-sj <srikkant@amazon.com>
2022-01-12 12:00:33 -08:00
Chris Galvan 1053351fd3 Merge pull request #6853 from aws-lumberyard-dev/cgalvan/RemovedUnusedLegacyShowIconsOption
Removed unused legacy show icons option
2022-01-12 13:56:50 -06:00
Chris Galvan f2f4eab92e Merge pull request #6660 from tjmgd/bug-righthand-bones-81
Right hand bones misplaced
2022-01-12 13:45:23 -06:00
Chris Galvan 88d93c7d4c Merge pull request #6654 from tjmgd/bug-ragdoll-77
Ragdoll saving issue
2022-01-12 13:45:02 -06:00
santorac e4fe40aede Merge branch 'development' into Atom/santorac/OrderOnceDependencyForPassBuilder 2022-01-12 11:26:11 -08:00
santorac 4449a87c27 Merge branch 'development' into Atom/santorac/ShaderVariantListSizeLimit 2022-01-12 11:24:15 -08:00
Chris Galvan 5b195cb028 Removed some unused variables
Signed-off-by: Chris Galvan <chgalvan@amazon.com>
2022-01-12 12:33:36 -06:00
lsemp3d bd65da39d0 Updated node subtitle
Signed-off-by: lsemp3d <58790905+lsemp3d@users.noreply.github.com>
2022-01-12 10:20:04 -08:00
Chris Galvan e31fa88c00 Removed unused legacy show icons option
Signed-off-by: Chris Galvan <chgalvan@amazon.com>
2022-01-12 11:13:40 -06:00
santorac a690c76ad4 Fixed depth clipping artifacts for parallax PDO. (#6837)
The "precise" keyword was recently added to several shader inputs, but one was missed. This led to inconsistency between the depth and forward passes which resulted in artifacts when parallax pixel depth offset was in use. See https://github.com/o3de/o3de/pull/6536

Testing: I used AtomSampleViewer to make a local baseline of all screenshots in _fulltestsuite_.bv.lua. The only change was to the parallax test cases, which were a clear improvement.

Signed-off-by: santorac <55155825+santorac@users.noreply.github.com>
2022-01-12 08:54:22 -08:00
Mike Balfour ffa9cc3a66 Unit tests and benchmarks for GetValues() (#6823)
* Benchmarks and tests for Image and Constant GetValues

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Verify GetValues for Perlin and Random Gradients

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Standardized the assert format for GetValues().

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* More GetValues unit tests and test cleanup

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Fixed typos

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* GetValues() unit tests for surface gradients.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Benchmarks for ShapeAreaFalloff Gradient

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Added benchmarks for all remaining gradients and cleaned up the helper methods.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Renamed class for better report formatting.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Added missing Mocks dependencies for the Editor tests.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>
2022-01-12 08:46:10 -06:00
tjmgd f51c845cbb Fix: AnimAudioComponentRequestBus canvas script function failure (#6658)
Signed-off-by: T.J. McGrath-Daly <tj.mcgrath.daly@huawei.com>

Co-authored-by: Tobias Alexander Franke <tobias.alexander.franke@huawei.com>
2022-01-12 14:42:12 +01:00
tjmgd acec79fe2e Node name change cursor missing (#6721)
Signed-off-by: T.J. McGrath-Daly <tj.mcgrath.daly@huawei.com>
2022-01-12 12:57:54 +01:00
sphrose 74483dc3ba Merge pull request #6812 from aws-lumberyard-dev/3736_color_picker_space
change default color picker input color space to SRGB
2022-01-12 09:41:02 +00:00
santorac 44908a80c6 Merge pull request #6825 from aws-lumberyard-dev/Atom/santorac/UpdateTestMaterialsForLucyHermanubisRename
Fixed test materials since all the "lucy" stuff was renamed to "hermanubis"
2022-01-11 17:30:28 -08:00
Vincent Liu b9787fb2b3 [Mac] Update to use AWSNativeSDK 1.9.50 (#6797) 2022-01-11 17:24:33 -08:00
srikappa-amzn 13bc91aa77 Split editor entity activation from PrefabSystemComponent (#6787)
* Split editor entity activation from PrefabSystemComponent

Signed-off-by: srikappa-amzn <82230713+srikappa-amzn@users.noreply.github.com>

* Fixed a small typo

Signed-off-by: srikappa-amzn <82230713+srikappa-amzn@users.noreply.github.com>

* Pass entity activation callback during prefab instantiation for failing tests

Signed-off-by: srikappa-amzn <82230713+srikappa-amzn@users.noreply.github.com>
2022-01-11 16:53:46 -08:00
Alex Peterson 73419387c5 Check engines_path in get_registered (#6828)
Signed-off-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com>
2022-01-11 16:49:59 -08:00
Alex Peterson 07e6b54ca5 Fix names display index and scripting dev gem (#6822)
* Fix input/output params not being zero-based
* Expose missing Dump Database developer command
* Fix issue where developer gem name is not the same as the target
* Let the user specify folder to write to

Signed-off-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com>
2022-01-11 16:49:16 -08:00
santorac 5cd8b0e172 Renamed more files from "lucy" to "hermanubis"
Signed-off-by: santorac <55155825+santorac@users.noreply.github.com>
2022-01-11 14:55:44 -08:00
santorac faf3255ea6 Renamed more files from "lucy" to "hermanubis"
Signed-off-by: santorac <55155825+santorac@users.noreply.github.com>
2022-01-11 14:27:09 -08:00
santorac e7c9a158bb Merge branch 'development' into Atom/santorac/UpdateTestMaterialsForLucyHermanubisRename 2022-01-11 14:17:28 -08:00
Chris Galvan ce2e433b71 Merge pull request #6826 from aws-lumberyard-dev/jckand/DynVegTestSaveFix
Adding extended wait_for_condition checks for slice level save/export and slice creation
2022-01-11 15:39:30 -06:00
SWMasterson f03c2885f0 Moving AutomatedTesting Atom levels into the Graphics subfolder (#6791)
Signed-off-by: Sean Masterson <semaster@amazon.com>
2022-01-11 14:21:45 -06:00
jckand-amzn f42a094606 Merge branch 'development' of https://github.com/o3de/o3de into jckand/DynVegTestSaveFix
Signed-off-by: jckand-amzn <82226555+jckand-amzn@users.noreply.github.com>
2022-01-11 13:38:10 -06:00
jckand-amzn 48a90e0668 Adding wait_for_condition checks for level save/export, and extending wait for slice creation test
Signed-off-by: jckand-amzn <82226555+jckand-amzn@users.noreply.github.com>
2022-01-11 13:37:55 -06:00
santorac d09da902d6 Fixed test materials since all the "lucy" stuff was renamed to "hermanubis".
Signed-off-by: santorac <55155825+santorac@users.noreply.github.com>
2022-01-11 11:26:44 -08:00
Chris Galvan 8162780a65 Merge pull request #6819 from aws-lumberyard-dev/cgalvan/FixNewLevelInputFocus
Fixed tab order for default input focus on new level dialog
2022-01-11 11:55:06 -06:00