Commit Graph

9735 Commits

Author SHA1 Message Date
Gene Walters 562b876734 Merge pull request #5733 from aws-lumberyard-dev/LYN-6769_RPCCompilation
RPC Variants added AutomatedTesting
2021-11-24 07:25:58 -08:00
greerdv 211be14537 Merge pull request #5863 from aws-lumberyard-dev/asset-collider-manip-direction
fix direction of manipulator scaling for asset collider when axes are…
2021-11-24 12:44:01 +00:00
greerdv f32bf3db8a fix typo in include
Signed-off-by: greerdv <greerdv@amazon.com>
2021-11-24 09:39:50 +00:00
John Jones-Steele 2259cb3dc0 Moved TerrainDataRquestBus to AzFrameworkTestShared (#5835)
* Moved TerrainDataRquestBus to AzFrameworkTestShared

Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com>

* Changes from PR

Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com>
2021-11-24 09:29:40 +00:00
Michael Pollind 1649d86568 chore: update static const declerations in AzQtComponent (#5826)
* chore: update static const declerations in AzQtComponent

Signed-off-by: Michael Pollind <mpollind@gmail.com>

* chore: update static const

Signed-off-by: Michael Pollind <mpollind@gmail.com>
2021-11-24 09:17:54 +00:00
Tom Hulton-Harrop 5bd751531d Update return type for viewport screen functions (#5803)
* update return type for viewport screen functions

Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>

* add tests for AZ::Matrix3x4::CreateFromMatrix4x4 and add TransformPoint to Matrix3x4

Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>

* update NDC -> Ndc

Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>

* updates following review feedback

Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>

* updates and improvements following PR feedback

Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>

* add forward declaration of Matrix3x4 type

Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>

* update where forward declarations are defined for Matrix3x4

Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>
2021-11-24 09:17:43 +00:00
moraaar b196473465 O3DE using new 3rdParty PhysX SDK package rev 5 (#5829)
PR with changes to PhysX SDK package: o3de/3p-package-source#71

This fixes O3DE building monolithically on linux and windows.

Signed-off-by: moraaar moraaar@amazon.com
2021-11-24 08:15:52 +00:00
Ronald Koppers 7975629a7a Merge pull request #5872 from aws-lumberyard-dev/FixedVectorOptimization
Performance improvement for fixed_vector.
2021-11-23 15:43:24 -08:00
Ken Pruiksma bbdf871a13 Terrain detail material blending (#5714)
* Added buffer for material properties of detail mateirals, storing them in a multi-indexed data vector. Updated shader with relevant struct and buffer, but the buffer will need to be moved out of the mateiral SRG to work.

Signed-off-by: Ken Pruiksma <pruiksma@amazon.com>

* Added buffer for material properties of detail mateirals, storing them in a multi-indexed data vector. Updated shader with relevant struct and buffer, but the buffer will need to be moved out of the mateiral SRG to work.

Signed-off-by: Ken Pruiksma <pruiksma@amazon.com>

* Added buffer for material properties of detail mateirals, storing them in a multi-indexed data vector. Updated shader with relevant struct and buffer, but the buffer will need to be moved out of the mateiral SRG to work.

Signed-off-by: Ken Pruiksma <pruiksma@amazon.com>

* - Moved settings related to the detail material to a partial view srg owned by the terrain gem.
- Added support for base color in detail materials.
- Hooked up basic base color rendering of detail materials.
- Corrected the way the material data was stored.
- Added ref counting for detail materials so they can be released when no longer used.

Signed-off-by: Ken Pruiksma <pruiksma@amazon.com>

* Added buffer for material properties of detail mateirals, storing them in a multi-indexed data vector. Updated shader with relevant struct and buffer, but the buffer will need to be moved out of the mateiral SRG to work.

Signed-off-by: Ken Pruiksma <pruiksma@amazon.com>

* - Moved settings related to the detail material to a partial view srg owned by the terrain gem.
- Added support for base color in detail materials.
- Hooked up basic base color rendering of detail materials.
- Corrected the way the material data was stored.
- Added ref counting for detail materials so they can be released when no longer used.

Signed-off-by: Ken Pruiksma <pruiksma@amazon.com>

* Detail materials now put textures into bindless array that's accessed in the shader. Shader now pulls all the detail materal information for a single mateiral but does no blending.

Signed-off-by: Ken Pruiksma <pruiksma@amazon.com>

* Correcting rebase merge problem.

Signed-off-by: Ken Pruiksma <pruiksma@amazon.com>

* Fix detail roughness fade out with distance.

Signed-off-by: Ken Pruiksma <pruiksma@amazon.com>

* Adding tests for new MultiIndexedDataVector functions

Signed-off-by: Ken Pruiksma <pruiksma@amazon.com>

* Updates to move bindless array to separate SRG
- Exposed BindSrg() in renderpass so it's possible to add additional SRGs to a pass
- Created a TerrainSrg for use by the terrain forward shader
- Moved the bindless array out of the partial view SRG to the TerrainSrg

Signed-off-by: Ken Pruiksma <pruiksma@amazon.com>

* Moved more properties out of the view srg to the terrain srg.

Signed-off-by: Ken Pruiksma <pruiksma@amazon.com>

* Spelling fixes

Signed-off-by: Ken Pruiksma <pruiksma@amazon.com>

* Fixing bug where the roughness min/max value were inverted. Also fixed bug where bad data would show for areas where there was no macro material.

Signed-off-by: Ken Pruiksma <pruiksma@amazon.com>

* Detail material blending WIP. Mostly working, but small seams between each materila id pixel.

Signed-off-by: Ken Pruiksma <pruiksma@amazon.com>

* Switching to using Load() for the detail material IDs and calculating the positions manually since Gather()'s precsion leaves seams along the edges.

Signed-off-by: Ken Pruiksma <pruiksma@amazon.com>

* Updates from PR review

Signed-off-by: Ken Pruiksma <pruiksma@amazon.com>

* Fixing case issues and updating function name due to a recent fix.

Signed-off-by: Ken Pruiksma <pruiksma@amazon.com>

* Switching to using SampleGrad() instead of Sample() for detail textures to fix a bug where the incorrect mip level was chosen around the seams of the detail material id texture.

Signed-off-by: Ken Pruiksma <pruiksma@amazon.com>

* Remove unneeded sampler and some debug settings in the shader. Condensing some duplicate code

Signed-off-by: Ken Pruiksma <pruiksma@amazon.com>

* Updates from PR review and some minor improvements

Signed-off-by: Ken Pruiksma <pruiksma@amazon.com>

* Updated with PR feedback. Fixed a fairly significant bug with blending. Also contains a few minor fixes, simplifications, and comments for clarity.

Signed-off-by: Ken Pruiksma <pruiksma@amazon.com>

* Update weight adjustment equation to trust the compiler less

Signed-off-by: Ken Pruiksma <pruiksma@amazon.com>

* fix bug

Signed-off-by: Ken Pruiksma <pruiksma@amazon.com>

* Fixing bug in terrain normal factor. Adjusting normal calculation to avoid the need for an identity transform.

Signed-off-by: Ken Pruiksma <pruiksma@amazon.com>

* Removing unused fields from the material SRG. Adding basecolor back in in the material type. Updating the default terrain material to not use fields that no longer exist.

Signed-off-by: Ken Pruiksma <pruiksma@amazon.com>
2021-11-23 17:07:29 -06:00
Junbo Liang 4da6dd812b Merge pull request #5877 from aws-lumberyard-dev/junbo/gitflow_211123_o3de
Merge stabilization/2110
2021-11-23 14:25:41 -08:00
Mike Chang 28e2681b65 Add signer script and new gpg signing cert (#5847)
* Add signer script and new gpg signing cert

Signed-off-by: Mike Chang <changml@amazon.com>
2021-11-23 13:41:55 -08:00
Junbo Liang abb37c0b4a Merge commit '4ac8b5dc429b6c87b3bd9e743839c47f7a02c0ce' into junbo/gitflow_211123_o3de 2021-11-23 13:29:30 -08:00
Junbo Liang ad922a312b Merge commit 'd09171fc535f6b51161e38375071c3247da6f09a' into junbo/gitflow_211123_o3de 2021-11-23 13:29:28 -08:00
Junbo Liang fa025013b6 Merge commit 'ba329378677590cdad0019c476cccccb5dec102f' into junbo/gitflow_211123_o3de 2021-11-23 13:29:26 -08:00
Junbo Liang 1f7705096c Merge commit '1f2385ca1adb422380b52252925f6eb397a2172d' into junbo/gitflow_211123_o3de 2021-11-23 13:29:25 -08:00
Junbo Liang 2bdee5c9e6 Merge commit 'bf3a5118069d287c013febd94a977966e4d1f944' into junbo/gitflow_211123_o3de 2021-11-23 13:29:23 -08:00
Junbo Liang d6121b5ac6 Merge commit 'b3c0200345eb56d7a35b8a75deb12b479b0a839a' into junbo/gitflow_211123_o3de 2021-11-23 13:29:21 -08:00
Junbo Liang ac7587e82e Merge commit 'a0ab5920dafb3e20b29370f0cc63eda97c9d975b' into junbo/gitflow_211123_o3de 2021-11-23 13:29:12 -08:00
Junbo Liang 7086aa1a75 Merge commit 'dbc5d7a8bc5404b80fbc38b6b004aaa1f9e06df9' into junbo/gitflow_211123_o3de 2021-11-23 13:28:04 -08:00
greerdv 8c7e3c090c merge from development
Signed-off-by: greerdv <greerdv@amazon.com>
2021-11-23 21:26:52 +00:00
greerdv 75d7c61ba1 fix variable capitalization
Signed-off-by: greerdv <greerdv@amazon.com>
2021-11-23 21:25:50 +00:00
Junbo Liang f94c0113ab Merge commit '3cf3e45b38d66269862c47d482e2f794a7f6418f' into junbo/gitflow_211123_o3de 2021-11-23 13:21:05 -08:00
Junbo Liang 526c006023 Merge commit 'af85060856faef554308dadc8251349147680ecc' into junbo/gitflow_211123_o3de 2021-11-23 13:20:57 -08:00
Junbo Liang fd72d5646e Merge commit '95da7fcb645224d4dcd50ede2fe282407927e31b' into junbo/gitflow_211123_o3de 2021-11-23 13:16:57 -08:00
Junbo Liang e2649512b2 Merge commit '4be1e68bad1b627668a4517b00526bba6cc7acea' into junbo/gitflow_211123_o3de 2021-11-23 13:16:55 -08:00
Junbo Liang 3a395dd03f Merge commit '5e8c8484befeb713e4867cb7fa6cfd28e4ee79c7' into junbo/gitflow_211123_o3de 2021-11-23 13:16:29 -08:00
Esteban Papp 75bb0f24ad Msbuild warning fix for jenkins (#5818) 2021-11-23 13:16:04 -08:00
Junbo Liang 6a40d21b66 Merge commit '4ee2f341dc0dc709aedb446b57d5cca61b86160d' into junbo/gitflow_211123_o3de 2021-11-23 13:14:59 -08:00
Junbo Liang 3b39be7fd0 Merge commit '4ad35f424e01356a4745e5f50631dc050b328c98' into junbo/gitflow_211123_o3de 2021-11-23 13:14:57 -08:00
Danilo Aimini 4ac8b5dc42 Display version number correctly in installer builds from branches that properly set the name on Jenkins. (#5856)
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
2021-11-23 13:13:21 -08:00
Gene Walters c446744e2b merging latest dev
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-11-23 12:16:54 -08:00
Vincent Liu 423e2e8da8 Unify resource mapping json schema across cpp and python usage (#5799)
* Unify resource mapping json schema across cpp and python usage

Signed-off-by: onecent1101 <liug@amazon.com>

* Update based on feedback

Signed-off-by: onecent1101 <liug@amazon.com>

* Add empty line at end of file

Signed-off-by: onecent1101 <liug@amazon.com>
2021-11-23 12:06:39 -08:00
Luis Sempé d614857da3 Merge pull request #5875 from aws-lumberyard-dev/scripting/remove_key_named_key
Updated all names files to use 'base' instead of 'key' to avoid valid…
2021-11-23 11:56:03 -08:00
lsemp3d d30ac7cfa6 Updated all names files to use 'base' instead of 'key' to avoid validation issues
Signed-off-by: lsemp3d <58790905+lsemp3d@users.noreply.github.com>
2021-11-23 10:36:34 -08:00
Luis Sempé 3b9b654070 Merge pull request #5871 from aws-lumberyard-dev/scripting/text_updates_pass6
Renamed 'key' to 'base' to avoid future problems with secrets patterns, cleanup and improvements
2021-11-23 10:17:56 -08:00
AMZN-koppersr 389f29f0e7 Performance improvement for fixed_vector
AZStd::fixed_vector had all its functions marked with constexpr, but this requires all member variables to be fully initialized. This meant that the internal array used to store elements always has to be fully initialized. This was done for trivial classes but not for non-trivial classes. As a result trivial classes always did a memset (or more optimized versions for smaller buffers) while the non-trivial version couldn't actually be stored in a constexpr variable. Since AZStd::fixed_vector is meant to be dynamic the choice was made to remove the constexpr from all non-static member functions in favor of avoiding the overhead of memset, which profiling showed was a considerable overhead depending on the reserved size. If a truly constexpr array is needed than AZStd::array is a better choice as that's designed to not by dynamic.

Signed-off-by: AMZN-koppersr <82230785+AMZN-koppersr@users.noreply.github.com>
2021-11-23 09:26:37 -08:00
carlitosan d09171fc53 Merge pull request #5851 from aws-lumberyard-dev/carlitosan-redcode-scripteventref
remove scripteventreference deprecated code
2021-11-23 08:52:44 -08:00
lsemp3d 2da3ab42fd Renamed 'key' to 'base' to avoid future problems with secrets patterns, cleanup and improvements
Signed-off-by: lsemp3d <58790905+lsemp3d@users.noreply.github.com>
2021-11-23 08:50:41 -08:00
Mike Balfour 39ba06b84e misc small terrain bugfixes (#5834)
* Removed "chatty" profile markers.
These three markers were making terrain refreshes take ~200% longer in profile builds.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Terrain surface data wasn't updating its AABB correctly.
The code was making an invalid assumption that changes to the world bounds would result in an invalid dirtyRegion.  It actually gets a valid region encapsulating the old and new bounds.  The fix is an additional check to see if the terrain bounds changed.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>

* Addressed previous PR feedback that terrainSystem ought to be a local variable in each test.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>
2021-11-23 09:21:27 -06:00
Tom Hulton-Harrop ea0afae502 Fix for how viewport icons highlight (accent) when sticky select is disabled (#5833)
* fix for how viewport icons highlight when sticky select is disabled

Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>

* naming - update highlight to accent

Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>
2021-11-23 12:28:38 +00:00
greerdv 23750b8c81 fix direction of manipulator scaling for asset collider when axes are flipped
Signed-off-by: greerdv <greerdv@amazon.com>
2021-11-23 11:34:31 +00:00
greerdv 706987cbf4 Merge pull request #5790 from aws-lumberyard-dev/collider-cluster-ui-reorder
Collider cluster UI reorder
2021-11-23 11:31:27 +00:00
amzn-sean e52557ee76 restoring physx joint typed tests on all platforms (#5836)
Signed-off-by: amzn-sean <75276488+amzn-sean@users.noreply.github.com>
2021-11-23 10:54:00 +00:00
greerdv f3347f56db remove variable only used in assert
Signed-off-by: greerdv <greerdv@amazon.com>
2021-11-23 09:40:13 +00:00
Benjamin Jillich 2fbb2a73c6 Animation Editor: Morph targets window shows duplicated morph targets (#5831)
Dialog stack wasn't deleting the morph target widgets after reinitializing the window which ended up in duplicated morph targets

Signed-off-by: Benjamin Jillich <jillich@amazon.com>
2021-11-23 08:55:53 +01:00
Shirang Jia ebd679d8cf Don't fail the build when AP logs upload fails (#5849)
* Fix retry of failures from catch block

Signed-off-by: Shirang Jia <shiranj@amazon.com>

* Make the build unstable when AP load fails

Signed-off-by: Shirang Jia <shiranj@amazon.com>

* Remove test codes

Signed-off-by: Shirang Jia <shiranj@amazon.com>
2021-11-22 17:46:49 -08:00
lsemp3d 9e6e83ff7f First pass at rendering node name generation
Signed-off-by: lsemp3d <58790905+lsemp3d@users.noreply.github.com>
2021-11-22 17:21:19 -08:00
lsemp3d 42c9395554 Updated more categories and names for constants
Signed-off-by: lsemp3d <58790905+lsemp3d@users.noreply.github.com>
2021-11-22 17:16:28 -08:00
lsemp3d eb402ee361 Improved categories and names for constants
Signed-off-by: lsemp3d <58790905+lsemp3d@users.noreply.github.com>
2021-11-22 17:01:18 -08:00
carlitosan 81bf27c4e0 remove scripteventreference deprecated code
Signed-off-by: carlitosan <82187351+carlitosan@users.noreply.github.com>
2021-11-22 16:57:21 -08:00