1c42cd98cc
Address a bit more review feedback
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-06 10:31:35 -08:00
be252d797d
Remove disabled failed asset load tests trait from linux ( #6100 )
...
* Remove trait AZ_TRAIT_DISABLE_FAILED_ASSET_LOAD_TESTS for Linux
Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com >
2021-12-06 09:11:56 -08:00
8165f54c05
Use temporary lifetimes for test
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-03 13:52:16 -08:00
03adf700fe
Merge branch 'development' into redcode/driller_removal
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-03 13:35:16 -08:00
037a93406a
Fix a couple format string issues
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-03 12:40:52 -08:00
f2f7dad972
Remove FormatVisitorErrorMessage
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-03 12:26:19 -08:00
bfae86dcf9
Adds missing header needed for mac/ios
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-03 12:04:03 -08:00
799cc68de2
no message
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-03 11:38:49 -08:00
016e261f36
Add DomUtils
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-03 11:25:15 -08:00
620690f2d6
Fixes Windows release build
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-03 10:40:22 -08:00
e2d1cdc9a5
Update Logger to use fixed_string
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-12-03 10:07:28 -08:00
c3fdbfb926
Updated the ComponentApplication Settings Registry initialization to no ( #6108 )
...
longer read form the users `~/.o3de/Registry` directory in non
debug/profile configurations.
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com >
2021-12-03 11:55:23 -06:00
5f41e404a5
PR comment
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-02 18:12:40 -08:00
7817ed76bf
Removes FileIOEventBus
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-02 18:08:45 -08:00
59a2216584
Fix a build issue
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-02 17:49:29 -08:00
4dbce4275b
Refactor the interface after some chatting with @amazon-employee-dm
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-02 17:46:07 -08:00
af19b53dde
Removes FileIOBus
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-02 17:43:47 -08:00
498673ada0
Removes Driller from AzCore
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-02 17:15:46 -08:00
d4e7a9cf16
Removing adding the null-terminator by hand. _vsnprintf_s already does this. Even if the buffer is too small, the /0 is still at the end
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-12-02 14:41:24 -08:00
5dfd40d056
Removes leftover from profiler tool
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-02 14:39:38 -08:00
efcbc7ccd7
Removing code which was supposed to add a newline, but never did. The comment said it was required because of an assumption with Trace, but clearly Trace doesn't make that assumption
...
Signed-off-by: Gene Walters <genewalt@amazon.com >
2021-12-02 14:36:41 -08:00
6bd0308339
Merge remote-tracking branch 'origin/development' into sc-editor-asset-redux
...
Signed-off-by: carlitosan <82187351+carlitosan@users.noreply.github.com >
2021-12-02 14:17:35 -08:00
59ef6f983f
Removes Driller from ScriptCanvas
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-02 13:55:00 -08:00
de06bb75e5
Fixes some unit tests due to the removal of the MemoryDriller
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-02 12:41:32 -08:00
19ddeeded9
Removes ThreadDrillerEvents, replaces handlers with TreadEventBus
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-02 12:40:39 -08:00
72f338a689
Fixes for HeapSchema to get a default block if none is passed
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-02 11:55:36 -08:00
8bde44d5fb
Removes TraceMessageDrillerBus
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-02 10:09:42 -08:00
1b01ec18b0
Replaces handlers of TraceMessageDrillerBus with handlers of TraceMessageBus
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-02 10:09:39 -08:00
59714fb31d
Removes MemoryDrillerBus
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-01 19:27:30 -08:00
c3f035c4e3
Removes AssetMemoryAnalyzer that relies on the MemoryDrillerBus
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-01 19:08:12 -08:00
95ed1015a5
Removes the MemoryDriller
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-01 18:48:07 -08:00
075eeee0bd
Removes PlatformMemoryInstrumentation.h and PLATFORM_MEMORY_INSTRUMENTATION_ENABLED
...
This was part of another instrumentation framework that was never fully integrated
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-01 18:47:23 -08:00
3f6246ccbe
Removes recording of memory records through the MemoryDriller
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-01 18:21:39 -08:00
47de333e94
Removes m_enableDrilling
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-01 16:50:45 -08:00
1aaa267585
Fix one last bit of minor feedback
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-01 16:49:48 -08:00
2dddb97b7c
One last round of stray review feedback I missed
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-01 16:32:23 -08:00
d519d4cb03
Improve performance for both in-place and copy parsing (faster than AZ::JsonSerializationUtils::ReadJsonString now!)
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-01 16:22:48 -08:00
e0508ddefc
Make JsonBackend templated
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-01 12:10:22 -08:00
e8750f8096
Rename sr_regset-file CVar to sr_regset_file ( #6067 )
...
The Legacy Cry XConsole code validates that CVars only contain
underscore and alphanumeric characters via an Assert in `debug`
configurations.
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com >
2021-12-01 13:16:19 -06:00
828431f185
Update AssetManager unit tests to not interact with the disk ( #5815 )
...
* Changed AssetManager tests to use memory streams for asset reading/writing
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix compilation on non-unity builds
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fixed handling of path lookups when test folder path is non-empty
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Add more detailed error message for "asset is not loaded"
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Make numThreads a constexpr
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Add FindFile function
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Remove unused lambda capture
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Remove trailing whitespace
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Add size to assert
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
2021-12-01 09:05:35 -06:00
f87021d856
Expose JSON parse flag options
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-11-30 22:08:48 -08:00
b5a697cb1c
Merge branch 'development' into memory/benchmarks
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-11-30 18:26:49 -08:00
fbd2d60fc1
Fixes for mac
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-11-30 18:15:22 -08:00
0f5cb54a38
Fixes Linux build
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-11-30 18:11:08 -08:00
a9c05372d5
API tweaks
...
- Use ref types
- Support using rapidjson::Value in lieu of rapidjson::Document
- Use the existing JSON comparison util function in tests
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-11-30 18:00:59 -08:00
f062b563c8
Improving runtime and making the whole duration manageable
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-11-30 17:30:55 -08:00
215cb9b52f
Adds mulit-threaded tests
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-11-30 16:06:26 -08:00
fb6e6e339f
Add CRC validator ( #5857 )
...
* Adds crc validation checks
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Fixes invalid CRCs
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Changes test to smoke suite
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* excludes some test data from the validator
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* uses pathlib instead of os.path
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* fixes wrong path to test scripts
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Escape not needed
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-11-30 15:07:57 -08:00
febaebc386
PR comment (NULL->nullptr)
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-11-30 13:51:08 -08:00
5dbe9e387b
Address some review feedback, remove DomBackendRegistry
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-11-30 12:10:16 -08:00
Nicholas Van Sickle
Steve Pham
Esteban Papp
Gene Walters
lumberyard-employee-dm
carlitosan
amzn-mike