birkeh/o3de
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
12,064 Commits 3 Branches 3 Tags
3207e909f7c66bd5d1b0ae2bf3da1f07c5827975
Commit Graph

108 Commits

Author SHA1 Message Date
Chris Burel 872f2a0cfa Remove unused private class member 
Signed-off-by: Chris Burel <burelc@amazon.com>
 2022-02-10 21:49:42 -08:00
Chris Burel 41be03f193 Silence warning about unnecessary lambda captures with clang 
The `unused-lambda-capture` will be triggered by the following code:

```cpp
void foo(int);
int main() {
    const int i = 0;
    auto l = [i](){foo(i);};
}
```

The issue here is that reading from the constant variable `i` does not
constitute an ODR-use, and consequently the variable does not have to be
captured. See
https://github.com/llvm/llvm-project/issues/34213#issuecomment-980987311
for a related discussion.

However, MSVC sees it differently.

In order to make both compilers happy, mark this variable with
`AZ_UNUSED`, since lambda captures can't be marked with attributes like
`[[maybe_unused]]`.

Signed-off-by: Chris Burel <burelc@amazon.com>
 2022-02-10 21:49:41 -08:00
Chris Burel be785dbae8 Correct the signature for the copy constructor of TestImpact::Pipe 
Signed-off-by: Chris Burel <burelc@amazon.com>
 2022-02-10 15:36:35 -08:00
Chris Burel 86aa5093ec Use enable_if to control what types can instantiate a template 
Using a `static_assert(false, ...)` expression in the `else` block of a
`if constexpr` statement doesn't work. The `else` block is not protected by
the `constexpr`-ness of the `if`s, so it is always compiled. Consequently
it will always fail to compile.

Signed-off-by: Chris Burel <burelc@amazon.com>
 2022-02-10 15:36:34 -08:00
Chris Burel 20e268930c Correct use of the typename keyword 
Signed-off-by: Chris Burel <burelc@amazon.com>
 2022-02-10 15:36:32 -08:00
Chris Burel 24339e36ab Fix non-constexpr RepoPath class to not try to be constexpr 
`RepoPath` is implemented with an `AZ::IO::Path`, which is not `constexpr`.
Consequently, its constructors also cannot be `constexpr`.

This also marks the function definitions in the header as `inline`, to
avoid ODR violations.

Signed-off-by: Chris Burel <burelc@amazon.com>
 2022-02-10 15:36:31 -08:00
Chris Burel 66ba970a3b Fix methods that recurse infinitely 
Signed-off-by: Chris Burel <burelc@amazon.com>
 2022-02-10 15:36:30 -08:00
Esteban Papp e4122bff22 Removes unused files from TestImpactFramework 
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
 2022-01-20 15:35:43 -08:00
AMZN-byrcolin c778606c89 Templates restricted (#6498) 
* Templates/Restricted upgrade/fixes:
Fixed template storage format: templates now only store true relative paths and no longer save "origin" paths and "optional" has been removed, it was never used.
Upgraded all templates to new standard
Template system now correctly handles child objects: Child objects no longer have to specify restricted they inherit from parent
Restricted now operates at the object level and makes no assumptions about parent
Restricted templates can now be combined and seperated on creation
ly_get_list_relative_filename has been deprecated for o3de_pal_dir
All Gems/Projects/Templates updated to use new code

Signed-off-by: byrcolin <byrcolin@amazon.com>
 2022-01-14 10:27:20 -08:00
Esteban Papp f3e6adce7f LYN-6882 release builds are executing code in asserts (#4305) 
* adding Windows/release to PR-validation builds

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* changing trace back to expand to nothing for release

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* typo

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* more fixes

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* fixing some more unused variable cases

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* renaming file in ScriptCanvas that causes a msbuild warning

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* reverting a previous change

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
 2021-10-01 13:52:52 -07:00
jonawals c28bc7c6d8 Add deserialization to sequence reports. (#4018) 
* Add deserialization to sequence reports.

Signed-off-by: John <jonawals@amazon.com>

* Address PR comments.

Signed-off-by: John <jonawals@amazon.com>

* Address PR comments.

Signed-off-by: John <jonawals@amazon.com>

* Address PR comments.

Signed-off-by: John <jonawals@amazon.com>

* Revert last change.

Signed-off-by: John <jonawals@amazon.com>
 2021-09-17 12:41:19 +01:00
Junbo Liang 8edcc504bd Add AWSI automation tests to a new test suite and pipe (#3913) 
Signed-off-by: junbo <junbo@amazon.com>
 2021-09-07 13:02:13 -07:00
Esteban Papp 39cf45e544 Setting /permissive- to make MSVC more "standard" (#3701) 
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
 2021-08-31 14:46:50 -07:00
Esteban Papp 1be95a1e76 Potential Memory Corruption in Release Build (#3559) 
* Potential Memory Corruption in Release Build

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* @lumberyard-employee-dm suggested code

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* warnings as errors found in VS2022

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* simplifying some strucutres used and fixing a bug

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* some unused fixes for VS2022

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* fix for other platforms

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* fixes check used in unit tests to be case-insensitive
fixes memory leaks/invalid memory operations in AWSCore tests

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
 2021-08-26 15:59:40 -07:00
Esteban Papp a75994e0b9 more fixes 
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
 2021-08-23 15:11:09 -07:00
Esteban Papp 31addc43dc Windows and Linux compiling 
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
 2021-08-23 14:02:45 -07:00
Esteban Papp b255334535 Code/Tools fixes 
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
 2021-08-16 16:42:24 -07:00
pappeste 52cba32bed TestImpactFramework 
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
 2021-08-16 16:05:27 -07:00
jonawals 5925bd22f6 Further subdivide TIAF data by suite. (#3128) 
* Further subdivide TIAF data by suite.
* Key fix typo.

Signed-off-by: John <jonawals@amazon.com>
 2021-08-16 14:15:02 +01:00
Esteban Papp 8f05c7aa2f Several build fixes 2021-08-12 16:42:18 -07:00
Esteban Papp 2147b1d128 Merge branch 'development' into cmake/SPEC-7484 2021-08-10 14:30:07 -07:00
Esteban Papp ec1a08d487 Merge branch 'development' into cmake/SPEC-7484 
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

# Conflicts:
#	Code/Editor/ConfigGroup.cpp
#	Code/Editor/ControlMRU.cpp
#	Code/Editor/CryEdit.cpp
#	Code/Editor/CryEdit.h
#	Code/Editor/IEditorImpl.cpp
#	Gems/EMotionFX/Code/EMotionFX/Tools/EMotionStudio/Plugins/StandardPlugins/Source/AnimGraph/GameController.cpp
 2021-08-10 09:23:34 -07:00
John c2a2d1c5c7 Add changes from TIF/Feature branch. 
Signed-off-by: John <jonawals@amazon.com>
 2021-08-10 14:20:46 +01:00
John 7b0118268c Remove missing header from cmake. 
Signed-off-by: John <jonawals@amazon.com>
 2021-08-06 20:40:37 +01:00
John d7c1185dc2 Add previously approved changes. 
Signed-off-by: John <jonawals@amazon.com>
 2021-08-06 20:09:53 +01:00
Esteban Papp e28d04aea6 Merge branch 'development' into cmake/SPEC-7484 
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

# Conflicts:
#	Code/Editor/CryEditDoc.cpp
#	Code/Editor/CryEditDoc.h
#	Code/Legacy/CryCommon/CryArray.h
#	Code/Legacy/CryCommon/CryString.h
#	Code/Legacy/CryCommon/UnicodeBinding.h
#	Code/Legacy/CrySystem/LocalizedStringManager.cpp
#	Gems/LyShine/Code/Source/StringUtfUtils.h
#	Gems/PhysXDebug/Code/Source/SystemComponent.cpp
 2021-08-05 20:05:25 -07:00
Esteban Papp 9bab676109 enabling test impact framework tool build and fixed it 
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
 2021-08-03 20:25:21 -07:00
Esteban Papp e28602dbbb linux fixes 
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
 2021-08-03 17:59:35 -07:00
pappeste 95914e3fd6 merging from development + fixing linux 
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
 2021-07-27 19:32:07 -07:00
Steve Pham 38261d0800 Shorten copyright headers by splitting into 2 lines (#2213) 
* Updated all copyright headers to split the longer original copyright line into 2 shorter lines

Signed-off-by: Steve Pham <spham@amazon.com>
 2021-07-16 15:25:48 -07:00
jonawals 06c65be40a Add handling for integrity failures when applying and resolving change lists (#1993) 
* ApplyAndResoveChangeList integration failure policy

Signed-off-by: John <jonawals@amazon.com>

* Default integrity failure policy for TIAF sequences

Signed-off-by: John <jonawals@amazon.com>

* Fix superfluous quotation marks

Signed-off-by: John <jonawals@amazon.com>

* Remove superfluous args parse

Signed-off-by: John <jonawals@amazon.com>

* Fix broken storage of last commit hash

Signed-off-by: John <jonawals@amazon.com>
 2021-07-08 15:59:05 -05:00
John c5a4fd382d Address PR comments 2021-07-05 16:25:29 +01:00
John f86708a812 Fix run payload checking logic 2021-07-05 15:28:20 +01:00
John 2003d81aba Fix missing log call site 2021-07-05 15:05:17 +01:00
John b63468d95e Fix API comments 2021-07-05 14:58:42 +01:00
John 0d7d507889 Fix instrumented non-gtests treated as failures 2021-07-05 14:58:25 +01:00
Chris Galvan 40f9761f86 Fixed more copyright header issues caused by script replacement 
Signed-off-by: Chris Galvan <chgalvan@amazon.com>
 2021-07-02 16:21:26 -05:00
Chris Galvan b9e06e70d9 Fixed copyright header issues per new validator 
Signed-off-by: Chris Galvan <chgalvan@amazon.com>
 2021-07-02 15:34:04 -05:00
Chris Galvan d7574777a8 Resolved merge conflicts 
Signed-off-by: Chris Galvan <chgalvan@amazon.com>
 2021-07-02 12:42:44 -05:00
Steve Pham b4a2edec6a Final update copyright headers to reference license files at the repo root (#1693) 
* Final update copyright headers to reference license files at the repo root

Signed-off-by: spham <spham@amazon.com>

* Fix copyright validator unit tests to support the stale O3DE header scenario

Signed-off-by: spham <spham@amazon.com>
 2021-06-30 19:51:55 -07:00
Gene Walters 9814e9dc6c Adding missing o3de copyright headers 
Signed-off-by: Gene Walters <genewalt@amazon.com>
 2021-06-29 16:31:06 -07:00
Gene Walters f905b71844 Adding missing o3de copyright headers 
Signed-off-by: Gene Walters <genewalt@amazon.com>
 2021-06-29 13:48:45 -07:00
Gene Walters 4e14c0069b Merge branch 'upstream/stabilization/2106' into genewalt/gitflow_210628 2021-06-28 19:09:20 -07:00
Steve Pham 70042fcdcd O3DE Copyright Updates for Linux Foundation (#1504) 2021-06-23 10:55:22 -07:00
John 1cef72ab8d Fix uncommented tests 2021-06-10 17:32:16 +01:00
John af0bcb0636 Remove test files 2021-06-10 14:58:34 +01:00
John 169d4da288 Address PR comments 2021-06-10 14:54:46 +01:00
jonawals 656aa528d8 Implement new handling of tiaf seed data 2021-06-08 13:39:37 +01:00
jonawals 7a884c85b3 Address PR comments 2021-06-08 12:19:07 +01:00
jonawals 9e187d67a4 Fix typo with delete files filter 2021-06-08 12:08:42 +01:00