Address PR comments
This commit is contained in:
+3
-3
@@ -255,7 +255,7 @@ namespace TestImpact
|
||||
|
||||
TestEngine::~TestEngine() = default;
|
||||
|
||||
void TestEngine::CleanArtifactDir() const
|
||||
void TestEngine::DeleteArtifactXmls() const
|
||||
{
|
||||
DeleteFiles(m_artifactDir, "*.xml");
|
||||
}
|
||||
@@ -291,7 +291,7 @@ namespace TestImpact
|
||||
AZStd::optional<AZStd::chrono::milliseconds> globalTimeout,
|
||||
AZStd::optional<TestEngineJobCompleteCallback> callback)
|
||||
{
|
||||
CleanArtifactDir();
|
||||
DeleteArtifactXmls();
|
||||
|
||||
TestEngineJobMap<TestRunner::JobInfo::IdType> engineJobs;
|
||||
const auto jobInfos = m_testJobInfoGenerator->GenerateRegularTestRunJobInfos(testTargets);
|
||||
@@ -318,7 +318,7 @@ namespace TestImpact
|
||||
AZStd::optional<AZStd::chrono::milliseconds> globalTimeout,
|
||||
AZStd::optional<TestEngineJobCompleteCallback> callback)
|
||||
{
|
||||
CleanArtifactDir();
|
||||
DeleteArtifactXmls();
|
||||
|
||||
TestEngineJobMap<InstrumentedTestRunner::JobInfo::IdType> engineJobs;
|
||||
const auto jobInfos = m_testJobInfoGenerator->GenerateInstrumentedTestRunJobInfos(testTargets, CoverageLevel::Source);
|
||||
|
||||
+1
-1
@@ -119,7 +119,7 @@ namespace TestImpact
|
||||
|
||||
private:
|
||||
//! Cleans up the artifacts directory of any artifacts from previous runs.
|
||||
void CleanArtifactDir() const;
|
||||
void DeleteArtifactXmls() const;
|
||||
|
||||
size_t m_maxConcurrentRuns = 0;
|
||||
AZStd::unique_ptr<TestJobInfoGenerator> m_testJobInfoGenerator;
|
||||
|
||||
Reference in New Issue
Block a user