Address PR comments

This commit is contained in:
jonawals
2021-06-08 12:19:07 +01:00
parent 9e187d67a4
commit 7a884c85b3
2 changed files with 4 additions and 4 deletions
@@ -255,7 +255,7 @@ namespace TestImpact
TestEngine::~TestEngine() = default;
void TestEngine::CleanArtifactDir() const
void TestEngine::DeleteArtifactXmls() const
{
DeleteFiles(m_artifactDir, "*.xml");
}
@@ -291,7 +291,7 @@ namespace TestImpact
AZStd::optional<AZStd::chrono::milliseconds> globalTimeout,
AZStd::optional<TestEngineJobCompleteCallback> callback)
{
CleanArtifactDir();
DeleteArtifactXmls();
TestEngineJobMap<TestRunner::JobInfo::IdType> engineJobs;
const auto jobInfos = m_testJobInfoGenerator->GenerateRegularTestRunJobInfos(testTargets);
@@ -318,7 +318,7 @@ namespace TestImpact
AZStd::optional<AZStd::chrono::milliseconds> globalTimeout,
AZStd::optional<TestEngineJobCompleteCallback> callback)
{
CleanArtifactDir();
DeleteArtifactXmls();
TestEngineJobMap<InstrumentedTestRunner::JobInfo::IdType> engineJobs;
const auto jobInfos = m_testJobInfoGenerator->GenerateInstrumentedTestRunJobInfos(testTargets, CoverageLevel::Source);
@@ -119,7 +119,7 @@ namespace TestImpact
private:
//! Cleans up the artifacts directory of any artifacts from previous runs.
void CleanArtifactDir() const;
void DeleteArtifactXmls() const;
size_t m_maxConcurrentRuns = 0;
AZStd::unique_ptr<TestJobInfoGenerator> m_testJobInfoGenerator;