05ece2adba
Merge pull request #7213 from siretty/cleanup_unused_var_empty_line_bool_init
...
Remove an Unused Variable Breaking the Build With Clang 13 on Linux and Minor Cleanup
2022-01-31 11:22:26 -06:00
8263a50f97
Fixed issue with viewport not rendering when creating a new level
...
Signed-off-by: Chris Galvan <chgalvan@amazon.com >
2022-01-31 11:11:42 -06:00
5ec416ca1f
Asset processor: separate modtime scanning tests ( #7217 )
...
* Move modtime scanning tests out of APM tests file and into its own file.
Changes were kept to a minimum to get things compiling, this is just a move of code
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix rebase compile errors
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
2022-01-31 08:41:18 -08:00
49d120b316
Merge pull request #7259 from aws-lumberyard-dev/cgalvan/RemovedLegacyIEventLoopHook
...
Removed legacy/unused IEventLoopHook
2022-01-31 10:29:41 -06:00
d7b3d33711
chore: simplify logic for handling expanding entries in Outliner ( #5219 ) ( #5394 )
...
* chore: simplify logic for handling expanding entries in Outliner
Signed-off-by: Michael Pollind <mpollind@gmail.com >
* bugfix: fix bottom border for collapsed prefabs.
issue: https://github.com/o3de/o3de/issues/5219
Signed-off-by: Michael Pollind <mpollind@gmail.com >
* chore: revert changes for expanding entities
Signed-off-by: Michael Pollind <mpollind@gmail.com >
2022-01-31 09:57:34 +00:00
aa093945a6
Remove an unused variable and explicitly initialize some bools to false
...
Signed-off-by: Daniel Edwards <dev@danieledwards.de >
2022-01-30 10:01:32 +01:00
1c6fbdab2a
Removed legacy/unused IEventLoopHook
...
Signed-off-by: Chris Galvan <chgalvan@amazon.com >
2022-01-28 15:44:25 -06:00
24086ab394
Resizable Headers for Gem Catalog and Gem Repo Screen ( #6885 )
...
* Initial mostly working attempt at resizable headers
Signed-off-by: nggieber <52797929+AMZN-nggieber@users.noreply.github.com >
* Add const and constexpr to variables
Signed-off-by: nggieber <52797929+AMZN-nggieber@users.noreply.github.com >
* Add header tracking for buttons, display items based on header scrollbar position, fix some spacing issues
Signed-off-by: nggieber <52797929+AMZN-nggieber@users.noreply.github.com >
* Correct styling for adjustable header, and intending header section and alingned item content with header text
Signed-off-by: nggieber <52797929+AMZN-nggieber@users.noreply.github.com >
* Prevent header resizing larger than table width.
Signed-off-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com >
* Fix resize graphical glitching
Signed-off-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com >
* Remove unecessary qss
Signed-off-by: nggieber <52797929+AMZN-nggieber@users.noreply.github.com >
* Removed necessary headers
Signed-off-by: nggieber <52797929+AMZN-nggieber@users.noreply.github.com >
* Remove extra nl and old comment
Signed-off-by: nggieber <52797929+AMZN-nggieber@users.noreply.github.com >
* Address PR feedback
Signed-off-by: nggieber <52797929+AMZN-nggieber@users.noreply.github.com >
* Removed unused variables
Signed-off-by: nggieber <52797929+AMZN-nggieber@users.noreply.github.com >
* Change variable to constexpr
Signed-off-by: nggieber <52797929+AMZN-nggieber@users.noreply.github.com >
* Remove AUTOMOC from headers, set background color of Gem Catalog to 333333 and adjustable header to transparent
Signed-off-by: nggieber <52797929+AMZN-nggieber@users.noreply.github.com >
* Change to using update instead of repaint when sections are resized
Signed-off-by: nggieber <52797929+AMZN-nggieber@users.noreply.github.com >
* Change temp directory creation on for gradle
Signed-off-by: nggieber <52797929+AMZN-nggieber@users.noreply.github.com >
Co-authored-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com >
2022-01-28 10:05:03 -08:00
0ba1cff08e
Remove legacy 'CrySetFileAttributes' ( #7226 )
...
* Remove legacy function 'CrySetFileAttributes' and replace its only use with AZ::IO::SystemFile::* functions
Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com >
2022-01-28 09:48:46 -08:00
112e310419
[Serialization] Add support for updating the values of existing keys in associative containers ( #6832 )
...
* Add support for updating the values of existing keys in associative containers
Signed-off-by: amzn-sj <srikkant@amazon.com >
* Map/Unordered Map serialization updates values corresponding to existing keys by default. Multimaps always add a new entry for existing keys.
Signed-off-by: amzn-sj <srikkant@amazon.com >
* Fix unused parameter warning
Signed-off-by: amzn-sj <srikkant@amazon.com >
* Update comparison function for test case
Signed-off-by: amzn-sj <srikkant@amazon.com >
2022-01-28 09:13:24 -08:00
b34a955c3d
Fixed platform settings not using unique values for Android and iOS ( #7198 )
...
* Fixed platform settings not using unique values for Android and iOS
Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com >
* Removed unnecessary comment
Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com >
* Changes from PR
Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com >
2022-01-28 16:38:33 +00:00
8ecaaf36c0
[development] updated Profiler interface to allow the forwarding of format string arguments ( #7173 )
...
Signed-off-by: AMZN-ScottR <24445312+AMZN-ScottR@users.noreply.github.com >
2022-01-27 14:43:52 -08:00
b695bfa832
Merge pull request #7145 from aws-lumberyard-dev/Prefabs/PlayInEditorMissingAssets
...
Fixed missing assets when entering Play-In-Editor.
2022-01-27 14:41:11 -08:00
9f8b32f20b
Merge pull request #7201 from aws-lumberyard-dev/cgalvan/RemovedUnusedViewPaneClass
...
Removed legacy IViewPane Editor class
2022-01-27 15:53:13 -06:00
155cc5845b
Add Path::IsEmpty
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2022-01-27 13:44:35 -08:00
73f166241e
Address review feedback
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2022-01-27 13:15:30 -08:00
3a08a3b325
Removed some unused local variables.
...
Signed-off-by: AMZN-koppersr <82230785+AMZN-koppersr@users.noreply.github.com >
2022-01-27 12:38:57 -08:00
f7f17c98b4
[development] fixed ambiguous 'byte' type MSVC build error ( #7184 )
...
- fully quality 'byte' type in AZStd::span
- remove unnecessary 'using namespace AZStd;' statement from AssetCatalog tests
Signed-off-by: AMZN-ScottR <24445312+AMZN-ScottR@users.noreply.github.com >
2022-01-27 11:12:15 -08:00
4471b7008d
Merge branch 'development' into Prefabs/PlayInEditorMissingAssets
2022-01-27 09:51:06 -08:00
94919fe270
Moved Serialize Context retrieval out of a loop and expanded an error message in InMemorySpawnableAssetContainer::LoadReferencedAssets.
...
Signed-off-by: AMZN-koppersr <82230785+AMZN-koppersr@users.noreply.github.com >
2022-01-27 09:47:12 -08:00
cc6f687359
Merge branch 'development' of https://github.com/o3de/o3de into cgalvan/RemovedUnusedViewPaneClass
2022-01-27 09:56:47 -06:00
61b494a3c7
fix for changes in non-uniform scale component mode not persisting
...
Signed-off-by: greerdv <greerdv@amazon.com >
2022-01-27 13:56:24 +00:00
75d39d9ce5
makes bucket variables atomic ( #7179 )
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2022-01-26 17:51:20 -08:00
2f4ff1072c
Merge pull request #7170 from aws-lumberyard-dev/cgalvan/RemovedLegacyEditorConfigSpec
...
Removed legacy Editor config spec
2022-01-26 19:03:11 -06:00
498e5b738f
Removed SetAutoLoadBehavior from InMemorySpawnableAssetContainer.
...
These calls didn't have any practical effect and created confusion, so they were removed.
Signed-off-by: AMZN-koppersr <82230785+AMZN-koppersr@users.noreply.github.com >
2022-01-26 16:40:53 -08:00
b9824ed172
Updated all array_view uses with the C++20 span. ( #7157 )
...
* Updated all array_view uses with the C++20 span.
The updates were done in the following order
1. `AZStd::array_view<([^>].+)\* ?>` -> `AZStd::span<\1 const>`
2. `AZStd::array_view<(?:const )(.+)>` -> `AZStd::span<const \1>`
3. `AZStd::array_view` -> `AZStd::span`
Removed the implementation of array_view.
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com >
* Added missing whitespace between `const` and the typename for spans.
Updated the ShaderTest comparison of the ShaderResourceGroupLayout span
to compare the sizes as well
Updated comments on some of the methods that stated that they return "an
array" to mention they return "a span".
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com >
2022-01-26 16:15:47 -06:00
a4741f98d2
Merge branch 'development' of https://github.com/o3de/o3de into cgalvan/RemovedLegacyEditorConfigSpec
2022-01-26 15:48:03 -06:00
c2ae853d95
Fixed python bindings unit test
...
Signed-off-by: Chris Galvan <chgalvan@amazon.com >
2022-01-26 15:37:30 -06:00
52f1ef84c7
Fixed string_view compilation in GCC 10+. ( #7153 )
...
* Fixed string_view compilation in GCC 10+.
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com >
* More GCC 10+ Fixes.
GCC 11 seems to have an issue with linkage regarding using a lambda as a default parameter in a function declaration.
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com >
* GCC10+ Fix - Fixed binding to a temporary references.
> error: loop variable ‘pathName’ of type ‘const QString&’ binds to a temporary constructed from type ‘const char* const’ [-Werror=range-loop-construct]
415 | for (const QString& pathName : { "CrySystem",
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com >
2022-01-26 14:20:01 -06:00
8151856e83
Removed legacy Editor config spec
...
Signed-off-by: Chris Galvan <chgalvan@amazon.com >
2022-01-26 13:01:30 -06:00
d605b5636d
Merge pull request #5532 from aws-lumberyard-dev/optimization/unused_files
...
Optimization: remove unused files
2022-01-26 08:19:08 -08:00
75f511d851
Merge pull request #6390 from aws-lumberyard-dev/memory/overrideshim_removal
...
Memory/overrideshim removal
2022-01-26 08:15:20 -08:00
1a7a350880
Introduce a new Focus Mode API function to retrieve full list of EntityIds that are in focus. ( #7159 )
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2022-01-26 08:12:34 -08:00
c789814d75
adds another maybe_unused to a new variable using assert
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2022-01-26 07:36:33 -08:00
22616cc7c4
Merge branch 'development' into optimization/unused_files
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
# Conflicts:
# Gems/LmbrCentral/Code/Tests/lmbrcentral_editor_tests_files.cmake
2022-01-26 07:35:17 -08:00
ec47c4fdfc
Merge pull request #7152 from aws-lumberyard-dev/cgalvan/DisableRenderPipelineUntilLevelIsLoaded
...
Disable render pipeline for EditorViewportWidget until a level has been loaded
2022-01-26 08:29:21 -06:00
e6113eb9c5
Add checks to handle failure in creating entity as a child of a read-only entity in TrackView and LandscapeCanvas ( #7156 )
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2022-01-25 21:09:00 -08:00
ae3503b74c
Fixes build after merge
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2022-01-25 18:31:51 -08:00
27a75fa6a1
Addressing feedback for the Play In Editor missing asset fixes.
...
- Deduplicated code for StoreInstanceInPrefabDom.
- Used QueueLoad to load an asset instead of starting a load by getting a new asset instance.
- Extended the error information when failing to load an asset.
- RefreshPrefabDom no longer returns a boolean as it wasn't used.
Signed-off-by: AMZN-koppersr <82230785+AMZN-koppersr@users.noreply.github.com >
2022-01-25 18:15:09 -08:00
25157b3fa1
PR comments
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2022-01-25 16:26:00 -08:00
6fad254b59
Merge branch 'development' into optimization/unused_files
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
# Conflicts:
# Code/Editor/IEditorImpl.cpp
# Code/Editor/IEditorImpl.h
# Gems/LmbrCentral/Code/Tests/lmbrcentral_editor_tests_files.cmake
2022-01-25 15:40:30 -08:00
56e7e70735
[development] properly pal-ify Android utilities in AzCore ( #7147 )
...
Signed-off-by: AMZN-ScottR 24445312+AMZN-ScottR@users.noreply.github.com
2022-01-25 14:57:51 -08:00
6e05ac678d
Hide the RenderViewportWidget when there is no level loaded so the gradient background is visible
...
Signed-off-by: Chris Galvan <chgalvan@amazon.com >
2022-01-25 16:46:49 -06:00
99764df120
Fix GCC Build Errors
...
- Fix gcc error caused by implicit conversion of Qt::ByteArray to const char*
- Fix Linker errors to QtTest in AtomToolsFramework.Tests and ScriptCanvasDeveloper.Editor
Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com >
2022-01-25 14:44:24 -08:00
dbf9e3f0e5
Move Android-specific AzFramework dependency of AzTestRunner to Android platform include file ( #7151 )
...
Signed-off-by: Chris Burel <burelc@amazon.com >
2022-01-25 14:20:49 -08:00
8b5f532e30
Disable render pipeline for EditorViewportWidget until a level has been loaded
...
Signed-off-by: Chris Galvan <chgalvan@amazon.com >
2022-01-25 14:25:32 -06:00
50015f8599
Add icon support for the Breadcrumbs UI Component, use it in the Prefab Focus Mode breadcrumbs. ( #7136 )
...
* Add icon support for the Breadcrumbs UI Component, use it in the prefab focus mode breadcrumb.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Simplified iconAt logic
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2022-01-25 12:00:30 -08:00
55146d037a
Add manipulator for atom render plugin in animation editor. ( #7068 )
...
* small bugfix
Signed-off-by: rhhong <rhhong@amazon.com >
* ActorInstanceId default to -1 when no %lastresult matches
Signed-off-by: rhhong <rhhong@amazon.com >
* CR feedback - wrap function to get the first available editor actor instance.
Signed-off-by: rhhong <rhhong@amazon.com >
* Remove mcore inline
Signed-off-by: rhhong <rhhong@amazon.com >
* Fixed the bug that delete an instance from actor manager crashes the editor.
Signed-off-by: rhhong <rhhong@amazon.com >
* Move the manipulator controller.
Signed-off-by: rhhong <rhhong@amazon.com >
* Add manipulator icon
Signed-off-by: rhhong <rhhong@amazon.com >
* Add manipulators
Signed-off-by: rhhong <rhhong@amazon.com >
* move more option to renderOption, and loading all going through the plugin
Signed-off-by: rhhong <rhhong@amazon.com >
* code cleanup
Signed-off-by: rhhong <rhhong@amazon.com >
* code cleanup
Signed-off-by: rhhong <rhhong@amazon.com >
* more code cleanup
Signed-off-by: rhhong <rhhong@amazon.com >
* CR FEEDBACK
Signed-off-by: rhhong <rhhong@amazon.com >
* Fix profile_nounity build
Signed-off-by: rhhong <rhhong@amazon.com >
* CR feedback - move more code to azToolsframework and share them between animation editor and editorlib
Signed-off-by: rhhong <rhhong@amazon.com >
* Using the MouseViewportRequests in viewportMessage and remove the custom bus
Signed-off-by: rhhong <rhhong@amazon.com >
2022-01-25 11:25:18 -08:00
956a1e59bb
[LYN-9039] Object stream write response change ( #7085 )
...
* Updated the ObjectStreamWriteOverride Callback to return a
ObjectStreamWriteOverrideResponse.
The ObjectStreamWriteOverrideResponse allows the callback to indicate
that the default ObjectStream::WriteElement behavior should occur if the
callback hasn't implemented the write itself.
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com >
* Fixed forward declaration not matching actual enum class name
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Add unit tests
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Remove unused member
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Add virtual destructor for test class
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Change string literal to not have tabs in it
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com >
2022-01-25 10:58:17 -08:00
a3cb6b8c5b
AP: Update Sqlite to version 3.37.2 ( #7124 )
...
* Update sqlite package for windows
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Add assert to make sure sqlite header and lib version match
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Update linux
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Update Builting Package / Mac for Sqlite 3.37.2-rev1
Signed-off-by: spham <82231385+spham-amzn@users.noreply.github.com >
* Re-add newline at end of file
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
Co-authored-by: spham <82231385+spham-amzn@users.noreply.github.com >
2022-01-25 10:58:07 -08:00
Chris Galvan
amzn-mike
Michael Pollind
Daniel Edwards
AMZN-nggieber
Steve Pham
amzn-sj
John Jones-Steele
Scott Romero
Ronald Koppers
Nicholas Van Sickle
greerdv
Esteban Papp
lumberyard-employee-dm
Danilo Aimini
Chris Burel
Roman