Commit Graph

85 Commits (18631b1a30f128cf5027e343a7b4d8a3cddca2db)

Author SHA1 Message Date
jckand-amzn 2d28c19c0a Simplifying entity creation and asset path calls
Signed-off-by: jckand-amzn <82226555+jckand-amzn@users.noreply.github.com>
4 years ago
jckand-amzn 52354d4c2e Simplifying surface tag assignment, fixing incomplete comment, and removing un-needed property tree query
Signed-off-by: jckand-amzn <82226555+jckand-amzn@users.noreply.github.com>
4 years ago
jckand-amzn bc29e31367 Updating whitespace and improving component CRUD readability
Signed-off-by: jckand-amzn <82226555+jckand-amzn@users.noreply.github.com>
4 years ago
jckand-amzn 16758ae52f Adding new Image Gradient test to validate surface modification
Signed-off-by: jckand-amzn <82226555+jckand-amzn@users.noreply.github.com>
4 years ago
jckand-amzn aab3d8df67
Converting Landscape Canvas tests to utilize the prefab system (#7142)
* Converting LandscapeCanvas automated tests to utilize prefab system

Signed-off-by: jckand-amzn <82226555+jckand-amzn@users.noreply.github.com>

* Finalizing LandscapeCanvas automated test conversions to utilize prefab system

Signed-off-by: jckand-amzn <82226555+jckand-amzn@users.noreply.github.com>

* Removing test gem from enabled_gems for AutomatedTesting

Signed-off-by: jckand-amzn <82226555+jckand-amzn@users.noreply.github.com>

* Removing test gem subdirectory that was mistakenly committed

Signed-off-by: jckand-amzn <82226555+jckand-amzn@users.noreply.github.com>

* Removing debug wait

Signed-off-by: jckand-amzn <82226555+jckand-amzn@users.noreply.github.com>
4 years ago
chiyenteng dd7706f9fe
Fire OnEditorEntityCreated notification in SandboxIntegrationManager::CreateNewEntityAtPosition (#7079)
* Ensure to fire OnEditorEntityCreated notification in SandboxIntegrationManager::CreateNewEntityAtPosition

Signed-off-by: chiyenteng <82238204+chiyenteng@users.noreply.github.com>

* Ensure to fire OnEditorEntityCreated notification in SandboxIntegrationManager::CreateNewEntityAtPosition

Signed-off-by: chiyenteng <82238204+chiyenteng@users.noreply.github.com>

* convert test AreaNodes_DependentComponentsAdded to use prefab system

Signed-off-by: chiyenteng <82238204+chiyenteng@users.noreply.github.com>

* Prevent SetupEditorEntity being called twice

Signed-off-by: chiyenteng <82238204+chiyenteng@users.noreply.github.com>
4 years ago
jckand-amzn 2c33240b72
Converting Dynamic Vegetation and Gradient Signal tests to utilize prefab system (#7034)
* Adding on-disk prefabs for automated tests

Signed-off-by: jckand-amzn <82226555+jckand-amzn@users.noreply.github.com>

* Resolving import conflict with cherrypick

Signed-off-by: jckand-amzn <82226555+jckand-amzn@users.noreply.github.com>

* Updating DynVeg tests to use open_base_level function

Signed-off-by: jckand-amzn <82226555+jckand-amzn@users.noreply.github.com>

* Converting initial set of DynVeg tests to utilize prefab system

Signed-off-by: jckand-amzn <82226555+jckand-amzn@users.noreply.github.com>

* Finalizing DynVeg test conversion to use prefab system

Signed-off-by: jckand-amzn <82226555+jckand-amzn@users.noreply.github.com>

* Removing old test runners

Signed-off-by: jckand-amzn <82226555+jckand-amzn@users.noreply.github.com>

* Removing optimized suffix from optimized test runners

Signed-off-by: jckand-amzn <82226555+jckand-amzn@users.noreply.github.com>

* Removing unoptimized test runner

Signed-off-by: jckand-amzn <82226555+jckand-amzn@users.noreply.github.com>

* Removing optimized suffix from optimized test runner

Signed-off-by: jckand-amzn <82226555+jckand-amzn@users.noreply.github.com>

* Adding wait_for_condition on level save for E2E tests

Signed-off-by: jckand-amzn <82226555+jckand-amzn@users.noreply.github.com>
4 years ago
jckand-amzn d223513ffe Updating query areas for instance count validation
Signed-off-by: jckand-amzn <82226555+jckand-amzn@users.noreply.github.com>
4 years ago
jckand-amzn 9f25c9f677 Skipping ShapeIntersectionFilter test
Signed-off-by: jckand-amzn <82226555+jckand-amzn@users.noreply.github.com>
4 years ago
jckand-amzn 48a90e0668 Adding wait_for_condition checks for level save/export, and extending wait for slice creation test
Signed-off-by: jckand-amzn <82226555+jckand-amzn@users.noreply.github.com>
4 years ago
chiyenteng ca49eedc5f
Convert prefab to temp spawnable assets (#6179)
* Convert prefab to temp in-memory spawnable assets

Signed-off-by: chiyenteng <82238204+chiyenteng@users.noreply.github.com>
4 years ago
sphrose 0e5c9c3867
Merge pull request #5908 from aws-lumberyard-dev/terrain/sphrose/reference_shape
LYN-7693 Rename and move vegetation reference shape.
4 years ago
jckand-amzn 68bf7c85ed
Adding setup step to remove temporary level that fails to cleanup (#6056)
* Adding setup step to remove temporary level that fails to cleanup with test teardown

Signed-off-by: jckand-amzn <82226555+jckand-amzn@users.noreply.github.com>

* Adding new create_level to TestHelper class with additional error logging

Signed-off-by: jckand-amzn <82226555+jckand-amzn@users.noreply.github.com>

* Cleaning up custom setup/teardown

Signed-off-by: jckand-amzn <82226555+jckand-amzn@users.noreply.github.com>
4 years ago
sphrose 1026c598b2 merge conflict fixes
Signed-off-by: sphrose <82213493+sphrose@users.noreply.github.com>
4 years ago
jckand-amzn 2809661794
Xfailing 2 DynVeg tests that fail to create levels in AR (#6051)
* Xfailing 2 DynVeg tests that fail to create levels in AR

Signed-off-by: jckand-amzn <82226555+jckand-amzn@users.noreply.github.com>

* Adding xfail to one more test, and updating reason

Signed-off-by: jckand-amzn <82226555+jckand-amzn@users.noreply.github.com>
4 years ago
jckand-amzn f05b63bcba
Enabling only optimized test runners for Editor/DynVeg/GradSignal (#5873)
Signed-off-by: jckand-amzn <82226555+jckand-amzn@users.noreply.github.com>
4 years ago
sphrose bad38f5ed0 Missed python tests
Signed-off-by: sphrose <82213493+sphrose@users.noreply.github.com>
4 years ago
chiyenteng ab76254b43
Make prefab system enabled as default for automated tests (#5670)
* Make prefab system enabled as default for automated tests

Signed-off-by: chiyenteng <82238204+chiyenteng@users.noreply.github.com>

* Modify auto tests after preventing regset saved into disk after editor main window closed

Signed-off-by: chiyenteng <82238204+chiyenteng@users.noreply.github.com>

* Uncomment xfail

Signed-off-by: chiyenteng <82238204+chiyenteng@users.noreply.github.com>

* Use --regset for editor tests

Signed-off-by: chiyenteng <82238204+chiyenteng@users.noreply.github.com>
4 years ago
jckand-amzn d2d83079eb Cleaning up test docstring
Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago
jckand-amzn e5ebdaebcf Removing unused helper for now and utilizing helper function for opening base level
Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago
jckand-amzn 60f7ea54aa Reverting unintentional change to create_vegetation_area() helper
Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago
jckand-amzn 327d4192f8 Enabling new optimized periodic test runner for DynamicVegetation tests
Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago
jckand-amzn 0a801ffd78 Finalizing temporary prefab helpers and test
Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago
jckand-amzn 0d3ab12d42 Removing unused imports and debug waits
Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago
jckand-amzn 11c219701e Initial check-in of in-memory prefab creation helpers for Dynamic Vegetation tests
Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago
jckand-amzn 3a6cc2498b
Skipping GraphUpdate test due to LC node issue in Debug configuration (#4847)
* Skipping GraphUpdate test due to LC node issue in Debug configuration

Signed-off-by: jckand-amzn <jckand@amazon.com>

* Reverting test type for GraphUpdates test to EditorSharedTest

Signed-off-by: jckand-amzn <jckand@amazon.com>

* Updating xfail reason for GraphUpdates test with GitHub issue link

Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago
jckand-amzn 52ced4a4ee Merge branch 'development' of https://github.com/o3de/o3de into jckand/LCXfailUpdate 4 years ago
lumberyard-employee-dm f648cb1fd8
Update the FileIO Aliases (#4186)
* Update the FileIOAlias naming to make the cache, project root and engine
root paths more clear

The alias of `@root@`, `@assets@`, and `@projectplatformcache@` has been
collapsed to `@projectproductassets@`

The alias of `@devroot@` and `@engroot@` has been collapsed to
`@engroot@`

The alias of `@devassets@` and `@projectroot@` has been collapsed to
`@projectroot@`

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated use of devassets and devroot properties in python

Those properties now use projectroot and engroot

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updating the alias @engroot@ alias path comment in each platform specific LocalFileIO_*.cpp file

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Removed hardcoded size of 9 for the product asset alias.

The ResolvePath function now just appends the @projectproductassets@
alias with the input path

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Remove duplicate @projectproductassets@ check in ProcessFileTreeRequest

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Fix for typos in Hydra python test

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated LocalFileIO::Copy call on Windows to use the Unicode aware CopyFileW API

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated the AWSMetreicsGemAllocatorFixture to properly suppress asset
cache write errors for Test file creation.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Removed unneeded call to set the @projectproductasstes@ alias at the bottom of the AssetSeedManagerTest SetUp

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Added a deprecated alias map to the FileIO System

When a deprecated alias is accessed, the FileIO System logs an AZ_Error and indicates the alias that should be used

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated python test scripts to use the projectroot binding

Retrieving the AutomatedTesting project path based on "<devroot>/AutomatedTesting" has been removed.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated references to devroot and devgame within the codebase

The GetAbsoluteDevGameFolderPath functions has been replaced with direct call to AZ::Utils::GetProjectPath
The GetAbsoluteDevRootFolderPath functions has been replaced with direct calls to AZ::Utils::GetEnginePath

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated <engroot>/AutomatedTesting references to projectroot


Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Replaced references that assumes the project path is <engroot>/AutomatedTesting with <projectroot> in the AutomatedTesting python test

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Correct casing in emfxworkspace file


Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Removed newly added AppendPathParts function
Removed the Path constructors which accepts a PathIterable instance

The PathIterable isn't safe to return to a user of the Path class as it might be referencing temporary paths supplied via PathView arguments

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Fixed unused parameter warning

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Undid change to the LexicallyProximate function to set the path result to the base path.

It needs to return the *this path if the pathResult is empty

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Moved the LocalFileIO ConvertToAbsolutePath implementations to AZ::Utils

Fixed the ConvertToAbsolutePath implementation for Unix platforms to use a buffer that is size PATH_MAX(4096 on all our supported Unix platforms).
Because the buffer before was AZ::IO::MaxPathLength which as a size of 1024, this was resulting in the Unix `realpath` function smashing the stack when it converts a path to an absolute path that is longer than 1024 characters

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated the EditorCore.Tests to attach the AZ Environment to the EditorCore shared library that is statically loaded on launch.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Fixed for DeprecatedAlaisesKeyVisitor Visit function causing the non string_view overloads being hidden causing a hidden base class function warning

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Changed the AWSMetricsGemMock to use a temporary for writing test assets

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated the LocalFileIO::ResolvePath function to use HasRootPath to determine if a path starts with a root path such as "D:", "D:/" or "/"

IsAbsolute was not the corect check as the path of "D:" is a relative
path.
To be absolute according to the Windows the path must have a root
directory. i.e "D:/" or "D:\"

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Removed absolute path comment from LocalFile_UnixLike.cpp and LocalFile_Android.cpp FindFiles implementations
Updated the ConvertToAlias to supply an AZ::IO::FixedMaxPath

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Replaced usage of the @projectproductassets@ alias with @engroot@ when referring to the LmbrCentral source folder in the CopyDependencyBuilderTest and the SeedBuilderTests

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated the ScriptCanvas Upgrade Tool to output backed up files to the
Project User Path instead of the engine root

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Fixed whitespacing issues in Application.cpp

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Remove unnecessary creation of a FixedMaxPath in the UpgradeTool.cpp

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Modified testSeedFolder variable in the SeedBuilderTests to use the
@engroot@ alias instead of @projectproductassets@/.. alias when
referring to the LmbrCentral Gem source path

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated references to the Project Asset Cache in the PythonTests.

Those tests no longer use the logic `azlmbr.paths.projectroot / "Cache" / "pc"` to retrieve a path to the cache root but instead the `azlmbr.paths.projectproductassets` constant

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Fixed the FileIO Deprecated Alias test on Windows

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Removing @projectsourceassets@ alias, as it is only used once.

Updated the PhysX EditorSystemComponent.cpp to query the ProjectPath
form the SettingsRegistry.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Replaced @projectproductassets@ alias with @products@

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Rollback changes to the PhysX EditorSystemComponent.cpp

The changes to use the ProjectPath from the SettingsRegistry has been implemented in PR #4497

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
4 years ago
jckand-amzn 36eac35bc3
Removing xfail from optimized Gradient Signal tests and disabling non-optimized suite (#4475)
Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago
jckand-amzn e306321b61 Removing xfail from optimized Landscape Canvas suite and disabling non-optimized suites
Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago
jckand-amzn e4479fff4a
Dynamic Vegetation automated test conversion/optimization (#4175)
* Initial batch of optimized Dynamic Vegetation tests

Signed-off-by: jckand-amzn <jckand@amazon.com>

* Adding another round of optimized Dynamic Vegetation tests

Signed-off-by: jckand-amzn <jckand@amazon.com>

* Adding more optimized Dynamic Vegetation tests

Signed-off-by: jckand-amzn <jckand@amazon.com>

* Adding another round of optimized Dynamic Vegetation tests

Signed-off-by: jckand-amzn <jckand@amazon.com>

* Final batch of converted Dynamic Vegetation tests

Signed-off-by: jckand-amzn <jckand@amazon.com>

* Re-organizing/cleaning up TestSuite files

Signed-off-by: jckand-amzn <jckand@amazon.com>

* Running optimized tests without xfail marker for Jenkins test

Signed-off-by: jckand-amzn <jckand@amazon.com>

* Corrected path on CMakeLists.txt to point to the correct TestSuite file for optimized tests

Signed-off-by: jckand-amzn <jckand@amazon.com>

* Adding xfail mark to DistanceBetweenFilter tests due to Editor deadlock

Signed-off-by: jckand-amzn <jckand@amazon.com>

* Updating CMakeLists to build Launcher

Signed-off-by: jckand-amzn <jckand@amazon.com>

* Updating xfail for DistanceBetweenFilter tests to skips as they timeout and cause cascading test failures

Signed-off-by: jckand-amzn <jckand@amazon.com>

* Re-added xfail marker to optimized tests

Signed-off-by: jckand-amzn <jckand@amazon.com>

* Correcting a few typos

Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago
jckand-amzn a4424ea820
Adding xfail mark to LayerBlender test due to Launcher crash on quit (#4173)
Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago
jckand-amzn b95e170f9e
Marking DistanceBetweenFilter tests with xfail due to Editor deadlock (#4156)
* Marking DistanceBetweenFilter tests with xfail due to Editor deadlock

Signed-off-by: jckand-amzn <jckand@amazon.com>

* Updating xfail mark

Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago
ANT\aljanru 9159eccb25 Fixes for periodic and gpu tests affected by the move 4 years ago
AMZN-AlexOteiza 2ca03367bb
Re-added removed xfails by accident (#3901)
Co-authored-by: Garcia Ruiz <aljanru@amazon.co.uk>
4 years ago
jckand-amzn c30642d855 Renaming test files for standardization and setting optimized tests to run alongside existing
Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago
jckand-amzn 860e6b0a5f Merge branch 'development' of https://github.com/o3de/o3de into jckand/PhysXVegTestFix 4 years ago
jckand-amzn e8bca8bc00 Updating test with a workaround for assigning a PhysX Mesh asset to a PhysX Collider component
Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago
jckand-amzn e67485b51f
Gradient Signal automation optimizations with TestAutomationBase/parallelization (#3316)
* GradientSignal automation optimizations with TestAutomationBase/parallelization
* Changing Gradient Signal test registration to use TestAutomationBase

Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago
jckand-amzn 1a430755df
Landscape Canvas automation optimizations with TestAutomationBase/parallelization (#3255)
* Convert Landscape Canvas main tests to use TestAutomationBase
* Updating main Landscape Canvas test suite to batch run tests
* Converting initial batch of Landscape Canvas periodic tests to use TestAutomationBase/test parallelization
* Renaming Editor Script to fit naming convention
* Updating explicit waits to wait_for_condition checks
* Additional test conversions
* Renaming Editor Script to fit naming convention
* Additional test parallelizations
* Additional test conversions
* Renaming optimized test file
* Adding Main test file for non-optimized tests

Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago
Chris Galvan 5b0046ce78 Resolved conflicts in merge from stabilization/2106 -> development.
Signed-off-by: Chris Galvan <chgalvan@amazon.com>
4 years ago
Esteban Papp 181998f810
Fixes a nightly build and a CMake warning (#2941)
* Addressing CMake warning and removing timeouts that are the same as the default

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* missed this one

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* Making it an error so developers stops putting timeouts longer than the allowed one since it causes AR issues

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* fixing warning from the nightly build

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* disabling test that is triggering a timeout

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
4 years ago
Chris Galvan 7ec6feddb8
Merge pull request #2329 from aws-lumberyard-dev/jckand/VegDebuggerTestStabilization
Removing obsolete Vegetation Debugger test
4 years ago
jckand-amzn 7ebdde0be0 Adding xfail mark to test_LandscapeCanvas_GraphClosed_OnEntityDelete
Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago
jckand-amzn 3050a4db47 Removing obsolete Vegetation Debugger test
Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago
jckand-amzn e0c94dcf45 Updating xfail reason for tests currently failing due to instance spawning with null renderer
Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago
jckand-amzn 6fcf9aa9e1 Updated component configuration for new uniform scale in SlopeAlignmentModifier tests
Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago
jckand-amzn 2173693462 Updating component configuration and expected instance counts for SlopeFilter test
Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago
jckand-amzn d9874431e2 Moving test back to xfail due to remaining issues with instance planting on meshes while null renderer is enabled
Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago
jckand-amzn 605c17072e Updating test suite for Position Modifier test
Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago