dd0f21b460
Fix incorrect icon rendering ( #6454 )
...
* fix incorrect icon rendering
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* add redundant parens
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* add tests for icon display fixes
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* update references to EditorVisibleEntityDataCache to EditorVisibleEntityDataCacheInterface
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* updates following review feedback and remaining updates for EditorVisibleEntityDataCacheInterface
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
2022-02-01 09:36:42 +00:00
d065eb9498
Initial improvements to fix viewport icon selection and draw order ( #6284 )
...
* wip fixes for entity viewport icons displaying in the correct order and handling selection correctly
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* add additional comment about z value
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* move manual sorting and some small tidy-up
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* update comment
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* updates following initial round of PR feedback
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* additional changes to support tests for entity icon intersection
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* add support to enable/disable icons separately from helpers
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* final tests added and small tidy-up to display EntityId correctly
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* update some manipulator test framework calls after utility functions were moved
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* fix for implicit cast
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* move icon scale values to AZ_CVARS
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* fix failing tests caught in AR and update some naming conventions for tests
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* update naming convention for members of ProjectedViewportRay
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* update other references to ProjectedViewportRay
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* update more references to ProjectedViewportRay change
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* update menus for python tests
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
2021-12-16 09:35:23 +00:00
969dbf407a
Add tests for planar manipulator draw when dealing with scaling ( #6164 )
...
* add support to add a custom debug display request interface for manipulator test framework
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* wip changes to support tests for manipulator view drawing
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* add test for planar manipulator draw when dealing with scaling
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* additional comments for added context
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* small updates/fixes after PR feedback
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* fix for missing NullDebugDisplayRequests
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
2021-12-06 14:53:45 +00:00
6908a3e945
Update intersect behavior for positioning entities in the viewport ( #5906 )
...
* update intersect behavior for positioning entities in the viewport and restore SurfaceManipulator
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* tests for surface manipulator from EditorTransformComponentSelection
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* update comments in tests and remove #pragma optimize('', off)@
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* add new file for FindClosestPickIntersection tests
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* add remaining tests for surface manipulator and snap fixes
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* some small updates and polish before PR
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* small updates following PR feedback
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
2021-11-30 15:07:40 +00:00
e34ea3bcaa
Fixes for viewport selection issues ( #5494 )
...
* improvements to editor selection in the viewport
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* fix issue with being able to select icons that are not showing for entities inside entity containers
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* update comment after review feedback
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* updates to viewport picking code to simplify the api
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* add test to replicate near clip intersection issue
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* small tidy-up changes
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* updates to how we perform world to screen and screen to world calculations, added test coverage and some tidy-up
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* add some more tests for ViewportInteractionImpl
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* minor tweaks before PR feedback
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* fix typo in fix
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* fix for manipulator test framework tests
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* updates to RPI::View and RenderPipeline after review feedback from VickyAtAZ
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* add constexpr to ScreenPoint, ScreenVector and ScreenSize initializing constructors
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* add PrintTo functions for Screen* types
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* downgrade error to warning temporarily
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* check incoming view is null
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* remove pragma optimize off
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
2021-11-17 17:12:21 +00:00
d8b47a1448
More fixes
...
Signed-off-by: igarri <igarri@amazon.com >
2021-10-18 16:45:26 +01:00
a3c3de4a76
AR fixes
...
Signed-off-by: igarri <igarri@amazon.com >
2021-10-18 16:33:47 +01:00
f6945f1334
Fixed Viewport Interaction
...
Signed-off-by: igarri <igarri@amazon.com >
2021-10-18 16:25:25 +01:00
de9a27597b
Additional test support for Manipulator Ditto commands ( #4191 )
...
* additional test support for manipulator ditto
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* tidy-up to changes
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* fix for non-unity build compile error
Signed-off-by: hultonha <hultonha@amazon.co.uk >
2021-09-20 09:49:01 +01:00
7e85b1512a
Expose sticky select option to the SettingsRegistry and disable by default ( #4149 )
...
* expose sticky select option to the SettingsRegistry
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* update missed callsites after API change to Manipulator Test Framework
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* updates following review feedback
Signed-off-by: hultonha <hultonha@amazon.co.uk >
2021-09-16 09:14:37 +01:00
ee2e728760
Merge branch 'development' into cmake/warn_virtual
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-09-14 10:28:58 -07:00
9d2352c3b7
Update the viewport interaction model to support single click select ( #4094 )
...
* add support for single click select
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* remove redundant profile macro
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* updates following review feedback
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* fix behaviour for fallthrough to match previous code
Signed-off-by: hultonha <hultonha@amazon.co.uk >
2021-09-14 13:24:01 +01:00
972944e762
Merge branch 'development' into cmake/warn_virtual
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
# Conflicts:
# Code/Editor/Viewport.h
2021-09-13 08:59:24 -07:00
7a58b72f15
Add remaining integration tests for viewport selection (box select) ( #4075 )
...
* updates to viewport box select tests
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* add interface for querying keyboard modifiers
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* remove redundant casts
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* update formatting options for trace functions in ActionDispatcher
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* remove redundant GetKeyboardModifiers call
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* update how trace/log functions have been fixed to output during tests
Signed-off-by: hultonha <hultonha@amazon.co.uk >
2021-09-13 15:19:46 +01:00
287d2a0fe7
Code/Framework/AzManipulatorTestFramework
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-09-10 20:19:52 -07:00
d82b2a0608
Initial test coverage for viewport selection before introducing new 'single' select functionality ( #3987 )
...
* WIP changes for viewport single select and better integration tests
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* update test to verify single click selection in the viewport
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* temporarily remove changes for single select
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* temporarily remove ChangeSelectedEntity call
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* initial tests to validate current viewport selection model
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* some tidy-up before publishing PR
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* add reference to const type in loop
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* temporarily disable box select test
Signed-off-by: hultonha <hultonha@amazon.co.uk >
2021-09-09 10:23:55 +01:00
052ff90c9d
Preparatory work to allow for more viewport integration tests ( #3961 )
...
* preparatory work to allow for more viewport integration tests
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* minor grammatical fix
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* fix for missed bus call update
Signed-off-by: hultonha <hultonha@amazon.co.uk >
2021-09-08 09:36:04 +01:00
46c6923bf7
Enabling warnings around format security
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-09-07 15:17:40 -07:00
d1df0fbe47
reverting one that was changed by mistake
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-09-07 08:17:06 -07:00
a374ea29f2
Expose setting to adjust angular manipulator circle bound ( #3932 )
...
* add debug drawing for angular manipulator bounds
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* remove editor viewport settings from RenderViewport
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* add setting for angular manipulator circle bound
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* update minimum value allowed for some camera settings
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* updates following review feedback, some small tidy-up
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* update comment
Signed-off-by: hultonha <hultonha@amazon.co.uk >
2021-09-06 14:22:57 +01:00
ec8e6bcadf
Fixes clang cases
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-09-03 13:27:31 -07:00
522e4bff9e
Merge branch 'development' into cmake/warn_format_security
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
# Conflicts:
# cmake/Platform/Common/Clang/Configurations_clang.cmake
2021-09-03 11:10:40 -07:00
5851031d2e
Expose the ability to control manipulator line bounds ( #3890 )
...
Signed-off-by: hultonha <hultonha@amazon.co.uk >
2021-09-03 10:14:03 +01:00
567c0ae24d
Modernization + AZStd::function compare fix. ( #3680 )
...
* Modernization + small fix.
Modernize ( `bool`/`override`/other) code in AzCore, AzFramework, AzQtComponents, AzToolsFramework, etc.
Replaced a `bind` or two, use `using` in a few places as well.
Fix nullptr comparison of AZStd::function.
Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com >
* Apply review-based changes
Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com >
2021-09-02 14:55:09 -05:00
0df55c3a7f
enabling warn format security and some fixes
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-08-30 16:10:08 -07:00
6b96be82ea
Merge branch 'development' into cmake/linux_fix_warn_unused
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
# Conflicts:
# Code/Legacy/CrySystem/Log.cpp
# Code/Tools/Standalone/Source/Driller/Annotations/AnnotationHeaderView.cpp
# Code/Tools/Standalone/Source/Driller/AreaChart.cpp
# Code/Tools/Standalone/Source/Driller/AreaChart.hxx
# Code/Tools/Standalone/Source/Driller/ChannelDataView.cpp
# Code/Tools/Standalone/Source/Driller/DrillerCaptureWindow.cpp
# Code/Tools/Standalone/Source/Driller/Profiler/ProfilerDataView.cpp
2021-08-25 11:47:19 -07:00
7fbfda0371
Fix mouse capture behavior for Editor Viewport ( #3417 )
...
* first pass of fixes for cursor capture and context menu
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* restore previous behavior of HandleMouseMoveEvent
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* tidy-up from previous cursor/input changes
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* add missing casts
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* small updates to support tests
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* additional tests and some tidy-up
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* small updates before publishing PR (comment/naming updates)
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* add missing parameter to MouseInteractionEvent constructor
Signed-off-by: hultonha <hultonha@amazon.co.uk >
2021-08-25 09:28:41 +01:00
ece541b79f
Code/Framework/AzManipulatorTestFramework
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-08-20 17:55:54 -07:00
38261d0800
Shorten copyright headers by splitting into 2 lines ( #2213 )
...
* Updated all copyright headers to split the longer original copyright line into 2 shorter lines
Signed-off-by: Steve Pham <spham@amazon.com >
2021-07-16 15:25:48 -07:00
b4a2edec6a
Final update copyright headers to reference license files at the repo root ( #1693 )
...
* Final update copyright headers to reference license files at the repo root
Signed-off-by: spham <spham@amazon.com >
* Fix copyright validator unit tests to support the stale O3DE header scenario
Signed-off-by: spham <spham@amazon.com >
2021-06-30 19:51:55 -07:00
f453967388
fix header ordering issue
2021-06-26 18:29:38 +01:00
70042fcdcd
O3DE Copyright Updates for Linux Foundation ( #1504 )
2021-06-23 10:55:22 -07:00
cf8a6761bf
Formatting-only change - Update Manipulator and Viewport AzToolsFramework files ( #1143 )
...
* formatting changes to AzToolsFramework viewport related types + API comment style updates
* minor format change - include ordering
* improve formatting by moving comment
* fix compile error and switch to use AZ_Printf
* small polish changes after review feedback
2021-06-07 14:50:49 +01:00
05e20803a8
First pass for getting things ready for grid snap button ( #1118 )
...
* first pass of change to simplify snapping for snap-to-grid button and fix snapping bug caused by non-uniform scale
2021-06-04 14:32:06 +01:00
5e87250f67
Fix viewport icon rendering on high DPI devices ( #1006 )
...
* Clarify ViewportWorldToScreen being in widget space and add DeviceScalingFactor
* -Fix viewport icons being draw wrong on high DPI displays
-Fix loading viewport icons from absolute paths, which
* Address review feedback, fix build
2021-05-27 16:31:30 -07:00
bb76bccc06
remove unneeded temporary
2021-05-04 17:55:09 +01:00
a206896074
remove QPoint from lower-level interfaces, switch to use AzFramework::ScreenPoint
2021-05-04 17:32:47 +01:00
75dc720198
Integrating latest 47acbe8
2021-03-25 13:57:57 -07:00
a10351f38d
Initial commit
2021-03-08 14:30:57 -08:00
Tom Hulton-Harrop
igarri
Esteban Papp
Artur K
Steve Pham
greerdv
Nicholas Van Sickle
hultonha
alexpete