* WIP - small legacy cleanup
Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>
* More cleanups + build fixes
Use AZstd instead of std types in a few places.
Remove m_nameTable.
Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>
* Legacy code cleanups
Remove unused methods using legacy functionality
* EditorViewportWidget::AdjustObjectPosition
* DisplayContext - remove `renderer` pointer
* DisplayContext - log errors when functions using `renderer` are called
* CTrackGizmo::DrawAxis - log errors when function uses `renderer`.
* Legacy CCamera - remove Project, Unproject and CalcScreenBounds
* Remove all unused methods from Cry_GeoDistance.h/Cry_GeoIntersect.h
* Remove Lineseg_Triangle from Cry_GeoOverlap.h
* IEntityRenderState.h - remove unused types
* SMeshColor remove Lerp method and associated constructor.
* IMaterial.h - remove unused types and a few methods
* IRenderMesh.h - remove a few unused methods and use int8 instead of
byte
* IRender.h - remove almost all of the contents
* IShader.h - remove unused types and a few methods
* IStatObj.h - remove unused types and a few methods
* SSystemGlobalEnvironment - remove `renderer` pointer
* IRenderGraph - remove 2 unused methods
* physinterface.h - remove almost all of the contents
* CXmlUtils no longer inherits ISystemEventListener
* CXmlNode no longer has custom new/delete
* Remove IRenderer from some test mocks.
Removed files:
* CryName.h
* Cry_MatrixDiag.h
* Cry_XOptimise.h
* HeapAllocator.h
* IRendererMock.h
* PoolAllocator.h
Things to consider:
* Remove GetMemoryUsage & friends.
Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>
* Apply review suggestions
IMovieSystem.h - remove unused includes.
Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>
* Move unreachable code to `#if 0` block
This is hopefully temporary measure until the original functionality is
re-implemented
Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>
* Fix bad merge I messed up.
Fix bad merge I messed up, by re-removing FrameProfiler.h from crycommon_files.cmake (this was removed in an earlier commit this morning: https://github.com/o3de/o3de/pull/3394).
Signed-off-by: bosnichd <bosnichd@amazon.com>
* Update Code/Framework/AzCore/AzCore/std/string/string_view.h
Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>
* implement review suggestion
Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>
* following review, using LYSHINE_ATOM_TODO to guard
Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>
* Remove commented out include
Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>
* EditorViewportWidget.cpp: Convert commented out code to guarded one
Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>
Co-authored-by: bosnichd <bosnichd@amazon.com>
Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
NOTE: The memory driller is still intact for now to avoid needing to
modify allocators, but the frame/cpu portions of driller and the
standalone executable are now gone.
Signed-off-by: Jeremy Ong <jcong@amazon.com>
Removes a ToString function that wasn't really needed, it was only
defined for release builds, but AZ_PROFILE macros are still defined to
something in release.
Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>
* Sever dependency on legacy resource selector host
Audio resource selectors (browse dialogs) no longer need to be
registered with the legacy IResourceSelectorHost system. Set up a new
EBus specifically to handle browse button presses and directly invokes
the dialog.
Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>
* Hook up legacy audio control selector to new EBus
Remaining use of legacy audio selectors (trackview) need to be able to
bypass ResourceSelectorHost now.
Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>
* Removes ResourceSelectorHost and legacy selectors
This removes various Variable types that were tied to resource
selectors, such as GeomCache, Model, Animation, File. Removes the
ResourceSelectorHost completely. The two things that still appeared to
have selectors in TrackView are Audio Controls and Texture. Fixed the
audio control selector to work via EBus and the Texture selector didn't
seem to work at all, but left it in as it was.
Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>
* Make the default audio selector return old value
Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>
* Fix some signed/unsigned comparison warnings
Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>
* Remove deleted function from Editor Mock
Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>
* Change audio selector api to use string_view
Per feedback.
Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>
* Fix a crash when reloading ACE controls data
The crash was due to destruction of xml_node that was held in a
unique_ptr. Rapidxml has a very rudimentary memory allocation design,
so in most cases dynamic allocations aren't even made. The memory_pool
does all the cleanup in its destructor, so having a unique_ptr run its
default_delete was causing the crash.
Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>
* Fix numerical conversion warnings
Wwise source files needed a few fixes for the numerical conversion
warning changes that went in recently.
Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>
* Changed blue text to white that is not meant as a link, made 'View in Director' link work for gems in the inspector, added parsing for gem documentation link
Signed-off-by: nggieber <nggieber@amazon.com>
* Added documentation links for gems, changed markup for urls in summaries and requirements so they are clickable
Signed-off-by: nggieber <nggieber@amazon.com>
* Fixed a couple of the documentation links
Signed-off-by: nggieber <nggieber@amazon.com>
* Added documentation url to edit gem properties script and updated unit tests
Signed-off-by: nggieber <nggieber@amazon.com>
- Handle changing of active camera entirely inside CameraComponentController
- Remove a LOT of legacy Cry things related to cameras
- Add a CameraSystemComponent to handle ActiveCameraRequestBus and CameraSystemRequestBus
Signed-off-by: Yuriy Toporovskyy <toporovskyy.y@gmail.com>
These statics were getting dead-stripped by the compiler, so removed
some of the macro magic and just do direct registration instead.
Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>
Replaced a 'uint32' with AZ::u32 to fix a linux compile error that
likely came about after cleaning up includes. Rewrites a failing unit
test after the code under test was updated from CryPak to AZ::IO.
Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>
* Removes use of gEnv->mMainThreadId
Save off the thread id that was used when initializing audio system and
connecting EBuses, use that instead of gEnv.
Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>
* Replace uses of gEnv->pCryPak with AZ::IO
Updated uses of pCryPak to instead go through the AZ::IO::FileIOBase
instance.
Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>
Change DeepCopyNode utility to return a unique_ptr, fix up some
string/path usages to avoid temporaries, etc.
Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>
Rewrote some code to replace gEnv->pCryPak and ISystem usage. One place
was grabbing a Camera view from ISystem, replaced with simple identity
matrix. Cleaned up include headers.
Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>
Updates the Audio Controls Editor code to use rapidxml instead of legacy
xml apis. Further makes improvements to path manipulations away from
strings towards PathView apis and similar.
Fixes some issues encountered with memory management when handling xml
data that did not occur previously.
Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>
There was a change in bahaviour to how files/directories were collected in the AZ::IO::FindData::Scan* functions which allowed the addition of duplicate entries. This created a problem when attempting a recursively greedy search with zips included because of the level system pak files. Their mount points would be the root "levels" folder, so for N-levels there would be N identical entries to the "levels" folder being added perpetually each time ScanZips was called on the "levels" folder or above folders with "*" filtering.
Letting the editor sit idle no longer sees the reported memory in the bottom status bar climb. Also, running the tests which prompted the initial change shows a negligible change in perf.
Signed-off-by: AMZN-ScottR 24445312+AMZN-ScottR@users.noreply.github.com
* Upgrade s_AudioLoggingOptions to AZ_CVAR
Removes this legacy CVar and reimplements it as an AZ_CVAR with similar
functionality of setting flags using alpha characters.
Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>
* Upgrade s_DrawAudioDebug to AZ_CVAR
Removes the legacy CVar and reimplements it as an AZ_CVAR with similar
functionality and options.
Additional updates to the logging options CVar to fix up flag enums.
Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>
* Upgrade s_FileCacheManagerDebugFilter to AZ_CVAR
Removes the legacy CVar and reimplements it as an AZ_CVAR with similar
functionality.
Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>
* Removal of legacy IConsole dependencies from Audio
Moves a g_languageAudio cvar from CrySystem to AudioSystem.
Convert all cvar commands to AZ_CONSOLEFREEFUNC's.
Remove IConsole.h includes from source files.
Removes the CSoundCVars class.
Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>
* Minor update to cvar comments etc.
Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>
* Final update copyright headers to reference license files at the repo root
Signed-off-by: spham <spham@amazon.com>
* Fix copyright validator unit tests to support the stale O3DE header scenario
Signed-off-by: spham <spham@amazon.com>
When Wwise Gem is not enabled, this will fix a nullptr deref crash when
interacting with Audio Controls Editor.
Also fixes another issue in the same function where getting the current
level name was garbage because a temporary QString was created and
immediately destructed.
* Reinstates an allocator for FileCacheManager
Replaces the allocator that was removed during redcode that is used for
loading banks. Default schema for now to get things working again.
* Update path functions to AZ::IO::Path
Removes old PathUtil functions in favor of AZ::IO::Path apis.
* Update the audio allocator classes
Cleans up the audio allocator classes a bit.
* Addresses PR feedback
Updates some code to handle nullptr a bit better, and improve log
messages.
* Updates to audio CVars and address feedback
Per feedback, converted more of the audio cvars to AZ_CVAR, but not all
of them could be converted at this time. Moved audio allocator
initialization to system component ctor/dtor to give RAII. Updated
location of a PAL file.
* Updates the copyright of the file added in this PR
Merged copyright changes, so need to update new files.
Updates to some AzCore functions a while ago made some path functions
strip off a trailing slash, which caused bad paths to be used when
loading middleware data. Updated the code to use better path APIs.
Esteban Papp
Artur K
Jeremy Ong
amzn-phist
pappeste
AMZN-ScottR
hultonha
AMZN-nggieber
Yuriy Toporovskyy
Pratik Patel
Terry Michaels
Steve Pham
Danilo Aimini
AMZN-Phil
lumberyard-employee-dm
Chris Galvan
Mike Cronin