Jeremy Ong
f3d426e638
Merge pull request #4965 from aws-lumberyard-dev/APTetherLifetimeOnByDefault
...
Enable lifetime tethering of the AP by default
2021-12-14 09:31:24 -07:00
Chris Galvan
8b7cdd45a3
Merge pull request #6344 from aws-lumberyard-dev/daimini/ReadOnly/TransformResetFix
...
Disable invalid operations related to procedural prefabs in the Inspector
2021-12-14 09:33:43 -06:00
Tom Hulton-Harrop
197e7b95e1
Fix for change with axis gizmo labels not appearing ( #6256 ) ( #6387 )
...
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
2021-12-14 09:24:10 +00:00
Nicholas Van Sickle
f71b134a84
Ensure JsonSerializer::StoreTypeName stores the correct type for generic types
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-13 23:40:35 -08:00
AMZN-Phil
98fa18558e
Force Project Manager to use VS2019
...
Signed-off-by: AMZN-Phil <pconroy@amazon.com >
2021-12-13 17:40:09 -08:00
michabr
d951e1f652
LyShine cleanup of TODOs ( #6138 )
...
* LyShine cleanup pass for Atom conversion
Signed-off-by: abrmich <abrmich@amazon.com >
* Add GHI numbers to comments
Signed-off-by: abrmich <abrmich@amazon.com >
2021-12-14 00:00:26 +01:00
Steve Pham
04669544cc
Remove unused trait AZ_TRAIT_DISABLE_FAILED_MULTIPLAYER_GRIDMATE_TESTS ( #6389 )
...
Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com >
2021-12-13 14:54:57 -08:00
Tommy Walton
7188529652
Fix for GHI-4644: mesh optimization breaking skin influences (DCO fix) ( #6336 )
...
* Average incoming skin influences when multiple vertices have been welded. This is one option which will average out the weights even if two welded vertices have differing boneIds, but we probably also need to add the influences earlier in the process and enforce a process where the vertices do not get welded if they have influences with differing boneIds
Signed-off-by: Tommy Walton <waltont@amazon.com >
* Move skin influences from MeshBuilderSkinningInfo to the vertex attribute layers so they are considered when choosing which vertices can be welded and so they are not duplicated when compatible vertices have been welded
Signed-off-by: Tommy Walton <waltont@amazon.com >
* Updating unit tests
Signed-off-by: Tommy Walton <waltont@amazon.com >
* Remove unused functions
Signed-off-by: Tommy Walton <waltont@amazon.com >
* Update based on feedback from burelc
Signed-off-by: Tommy Walton <waltont@amazon.com >
2021-12-13 13:07:04 -08:00
amzn-mike
71bb200e0a
[LYN-7064] Hot Loading of Procedural Prefabs ( #4923 )
...
* Prefab hotloading - load and maintain asset references
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Working hotloading
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Clean up code, add comments
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Add missing includes
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Add event for template removal.
Clear ProceduralPrefabSystemComponent lookup when templates are removed.
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Add unit test.
Fix missing include, make sure source name is set
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix missing include
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix missing include
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Update comments to make ebus event behavior more clear
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix missing include
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix missing includes
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix missing include
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix temp directory usage which doesn't work on linux
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix temp directory usage which doesn't work on linux
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Use AZ::IO::Path for comparison. Print paths on failure
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix unit test - register asset with catalog so it can be looked up later
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
2021-12-13 12:44:41 -08:00
amzn-mike
45abb9f88e
Proc Prefabs: Remove feature toggle ( #6348 )
...
* Disable feature flag - redirect proc prefab check to IsPrefabSystemEnabled.
Procedural Prefabs are now on by default when the prefab system is enabled.
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Bump scene builder version to cause all procedural prefabs to rebuild
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Switch to lambda for ebus call
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Remove unused const
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
2021-12-13 11:52:03 -08:00
Danilo Aimini
0dfb8d42c4
Disable the ability to instantiate into closed prefabs, and to move the root prefab in focus mode. ( #6320 )
...
* Disable "Move Up" and "Move Down" for focused prefab containers.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Disable the ability to instantiate prefabs inside closed prefab instances.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Minor comment fix.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-12-13 19:10:04 +01:00
John Jones-Steele
586f146a84
Fixed nullptr error ( #6386 )
...
Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com >
2021-12-13 17:56:46 +00:00
AMZN-Phil
ae3dedfe59
Merge pull request #6172 from aws-lumberyard-dev/Prism/RefactorProjectSettings
...
Refactor Project Manager Settings
2021-12-13 09:40:48 -08:00
moraaar
f941d03f9e
Fix namespace Az for AZ in ProcessWatcher for iOS ( #6382 )
...
Signed-off-by: moraaar <moraaar@amazon.com >
2021-12-13 14:03:00 +00:00
Andre Mitchell
82ebca8261
Disable unused HideActionWhileEntitiesDeselected function in EditorListener.
...
It is only used when the slice editor is enabled, which causes build errors when it is not enabled.
Signed-off-by: Andre Mitchell <andre.mitchell@bytesofpi.com >
2021-12-13 07:16:14 -05:00
Danilo Aimini
c06b697c6b
Revert part of the fix as it would break unit tests. Verified the remaining code still achieves the same purpose on the UI side without impacting the backend.
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-12-10 15:06:55 -08:00
Steve Pham
4670003aaf
Fix failed Atom rpi tests linux ( #6319 )
...
- Remove trait AZ_TRAIT_DISABLE_FAILED_ATOM_RPI_TESTS
- Add template specialization for ConstantsData::SetConstant<Color> and ConstantsData::GetConstant<Color>
- Remove trait AZ_TRAIT_DISABLE_FAILED_ATOM_RPI_TESTS from source code
- Fix ConstantsData::SetConstantArray<bool> to pass unit test SetConstant_GetConstant_FalsePackedInGarbage_Bool on Linux, cause by an unwanted optimization (comments describe the situation). This will make this behavior consistent across platforms
Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com >
2021-12-10 14:54:08 -08:00
Danilo Aimini
502578293b
Merge branch 'development' of https://github.com/o3de/o3de into daimini/ReadOnly/TransformResetFix
2021-12-10 14:35:25 -08:00
John Jones-Steele
3ae6b601a2
Focus issue in editor settings menu #3921 ( #6296 )
...
* Changes to fix DCO
Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com >
* Moved the keyEvent to a helper function for ease of testing
Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com >
* Split definition and declaration of WidgetHandleKeyPressEvent
Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com >
2021-12-10 22:34:41 +00:00
Danilo Aimini
d1533914ab
Disable the additional transform context menu items in the inspector. Prevent the user from reparenting entities under procprefabs using the entity picker.
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-12-10 13:16:02 -08:00
chcurran
8357fa34e9
fixed unit testing code
...
Signed-off-by: chcurran <82187351+carlitosan@users.noreply.github.com >
2021-12-10 11:56:42 -08:00
chcurran
23267fd862
SC Editor serialization update in JSON
...
Signed-off-by: chcurran <82187351+carlitosan@users.noreply.github.com >
2021-12-10 11:56:41 -08:00
Chris Galvan
ca5424dd7b
Fixed asset completer model for source handle picker.
...
Signed-off-by: Chris Galvan <chgalvan@amazon.com >
2021-12-10 11:56:39 -08:00
Chris Galvan
befd84cf0b
Added property handler for SourceHandle type.
...
Signed-off-by: Chris Galvan <chgalvan@amazon.com >
2021-12-10 11:56:36 -08:00
Chris Galvan
b4407e5044
Made PropertyAssetCtrl more extensible.
...
Signed-off-by: Chris Galvan <chgalvan@amazon.com >
2021-12-10 11:56:35 -08:00
Chris Galvan
42382cd8d1
Added logic to AssetPickerDialog to pre-select by file paths.
...
Signed-off-by: Chris Galvan <chgalvan@amazon.com >
2021-12-10 11:56:35 -08:00
Chris Galvan
d9ee02fddf
Added method to AssetCompleterModel for specifying a filter directly.
...
Signed-off-by: Chris Galvan <chgalvan@amazon.com >
2021-12-10 11:56:34 -08:00
Chris Galvan
231aaa5bf5
Added asset selection model option for a source asset type based on regex.
...
Signed-off-by: Chris Galvan <chgalvan@amazon.com >
2021-12-10 11:56:33 -08:00
Chris Galvan
3f6824571f
Added regular expression filter for asset browser entries.
...
Signed-off-by: Chris Galvan <chgalvan@amazon.com >
2021-12-10 11:56:32 -08:00
chcurran
31c627defc
initial scriptcanvas source handle
...
Signed-off-by: chcurran <82187351+carlitosan@users.noreply.github.com >
2021-12-10 11:52:36 -08:00
nggieber
e9db0bca6a
Fix typo, add missing header, remove unecessary asserts
...
Signed-off-by: nggieber <52797929+AMZN-nggieber@users.noreply.github.com >
2021-12-10 11:42:18 -08:00
amzn-mike
8f134a82d1
Procedural Prefabs: Stable transform component ID ( #6227 )
...
* Set Procedural Prefab Transform ComponentId to the hash of the file path.
Procedural prefabs needs to have a deterministic transform component ID in order for saved patches still work when the prefab is regenerated.
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Switch to Cityhash instead of XXHash since prefab system is using that elsewhere
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Added unit test
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix missing include
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
2021-12-10 11:20:31 -08:00
chiyenteng
ca49eedc5f
Convert prefab to temp spawnable assets ( #6179 )
...
* Convert prefab to temp in-memory spawnable assets
Signed-off-by: chiyenteng <82238204+chiyenteng@users.noreply.github.com >
2021-12-10 10:55:01 -08:00
Alex Peterson
6613030fe6
Fix Visual Studio requirements text and doc link ( #6312 )
...
Signed-off-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com >
2021-12-10 10:15:39 -08:00
Steve Pham
5a4a96348f
Remove unused traits that disabled certain failed unit tests
...
- Removed trait AZ_TRAIT_DISABLE_FAILED_AP_CONNECTION_TESTS
- Removed trait AZ_TRAIT_DISABLE_FAILED_FRAMEPROFILER_TEST
- Removed trait AZ_TRAIT_DISABLE_FAILED_FRAMEWORK_TESTS
- Removed AZ_TRAIT_DISABLE_FAILED_METRICS_TESTS
Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com >
2021-12-10 08:44:18 -08:00
nggieber
214716dafc
Add AZStd string header for linux
...
Signed-off-by: nggieber <52797929+AMZN-nggieber@users.noreply.github.com >
2021-12-10 07:48:41 -08:00
nggieber
88b78c0d16
Merge branch 'development' into Prism/RefactorProjectSettings
2021-12-10 06:32:14 -08:00
nggieber
af9e75da66
Minor PR feedback changes
...
Signed-off-by: nggieber <52797929+AMZN-nggieber@users.noreply.github.com >
2021-12-10 06:19:28 -08:00
Artur K
53b88d4752
Preapre codebase for FileRequest compiletime improvements ( #6192 )
...
* Preapre codebase for FileRequest compiletime improvements
This is preparing grounds for the next PR that will contain the 'meat'
of the changes.
Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com >
* Remove spurious newline.
Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com >
2021-12-10 13:08:24 +00:00
T.J. McGrath-Daly
bb3821df45
Fix: Lua breakpoint error
...
Signed-off-by: T.J. McGrath-Daly <tj.mcgrath.daly@huawei.com >
2021-12-10 12:19:12 +00:00
T.J. McGrath-Daly
53429d838e
Fix: Lua script debugging loading problem
...
Signed-off-by: T.J. McGrath-Daly <tj.mcgrath.daly@huawei.com >
2021-12-10 11:28:07 +00:00
nggieber
9f4895aaea
Addressed remaining PR feedback
...
Signed-off-by: nggieber <52797929+AMZN-nggieber@users.noreply.github.com >
2021-12-09 15:30:32 -08:00
nggieber
5641bcd5f1
Update Update Project Settings UI to show advanced settings and move project preview to right side panel
...
Signed-off-by: nggieber <52797929+AMZN-nggieber@users.noreply.github.com >
2021-12-09 14:56:50 -08:00
Scott Romero
e9379c1746
[development] updated editor event handling with respect to imgui ( #6114 )
...
Fixes #4366
- Added support for sending text events from the Qt event mapper
- Fixed several issues found while running the Profiler gem in debug
- Added ability to track AZ-consumed events in the Qt event mapper
- Minor clean up to input handling in ImGuiManager
- Select ImGui mouse events can now be properly consumed during AZ-input processing in the editor viewport
- Added tests for the Qt event mapper
Signed-off-by: AMZN-ScottR 24445312+AMZN-ScottR@users.noreply.github.com
2021-12-09 13:58:27 -08:00
amzn-mike
c63b4eb905
Removing unused variable and fix typo ( #6265 )
...
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
2021-12-09 12:53:25 -08:00
Chris Galvan
e1d36bc445
Merge pull request #6302 from aws-lumberyard-dev/cgalvan/HideViewportManiuplatorsOnReadOnlyEntitiesEdgeCase
...
Fixed logic for when to cull entities from having their viewport manipulators regenerated.
2021-12-09 14:24:39 -06:00
srikappa-amzn
ac03b6f50b
Improve error messaging when duplicating entities before they are created ( #4922 ) ( #6279 )
...
* Improved error messaging when user tries to duplicate before entities are created
Signed-off-by: srikappa-amzn <82230713+srikappa-amzn@users.noreply.github.com >
2021-12-09 11:25:23 -08:00
Chris Galvan
e636ea39e3
Fixed comment casing to match rest of file.
...
Signed-off-by: Chris Galvan <chgalvan@amazon.com >
2021-12-09 13:15:20 -06:00
nggieber
c632fadb8f
Remove Project ID field from New Project settings
...
Signed-off-by: nggieber <52797929+AMZN-nggieber@users.noreply.github.com >
2021-12-09 10:25:04 -08:00
Steve Pham
8fd603cd50
Fix failed archive tests on linux and remove trait
...
- Change the test Archive Folder name, Extract Folder Name, and File List file to be all lowercase to prevent the 'ResolvePath' function in LocalFileIO when executed to cause issues on case sensitive file systems (#6277 )
- Fix memory corruption in profile builds on Linux when using AZ::IO::PathView by using AZ::IO::FixedMaxPath instead
Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com >
2021-12-09 10:18:11 -08:00