016eda6cf1
Fixed infinite recursion when adding prefabs
...
While processing prefabs into spawnables new prefabs can be added for later processing. Because the new prefabs were immediately added to the list of prefabs it could happen that the new prefabs would be added to the active processor for processing, which could lead to infinite recursion. Adding prefabs while iterating prefabs now delays the addition until the iteration has completed.
Signed-off-by: AMZN-koppersr <82230785+AMZN-koppersr@users.noreply.github.com >
2021-12-16 15:35:33 -08:00
f52d49834a
[EMotionFX] Prefer #pragma once ( #6435 )
...
Signed-off-by: Chris Burel <burelc@amazon.com >
2021-12-16 13:42:38 -08:00
285d92ff0d
[AudioSystem] ACE bug fix: Ctrl-S doesn't work correctly when a level is loaded. ( #6411 )
...
Signed-off-by: Maxim Ivanov <imginimg@gmail.com >
2021-12-16 14:53:22 -06:00
ad5f3f0e53
Merge pull request #6439 from aws-lumberyard-dev/Atom/antonmic/ClearPass
...
Atom/antonmic/clear pass
2021-12-16 12:12:36 -08:00
53cf7b462b
Changing all ClearPass to SlowClearPass
...
Signed-off-by: antonmic <56370189+antonmic@users.noreply.github.com >
2021-12-16 11:03:20 -08:00
2bc381811d
addressed PR feedback
...
Signed-off-by: antonmic <56370189+antonmic@users.noreply.github.com >
2021-12-16 10:42:53 -08:00
18cfcd659b
Fix missing parent class reflection for ProceduralPrefabSystemComponent ( #6413 )
...
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
2021-12-16 07:49:32 -08:00
f4ae3a5b7d
Fix: Find function reports code with a line offset of 1 ( #6331 )
...
Signed-off-by: T.J. McGrath-Daly <tj.mcgrath.daly@huawei.com >
2021-12-16 15:39:03 +00:00
01770a1574
Fixes for CameraInput handling ( #6425 )
...
* add temporary optimize off calls
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* fix + tests for camera input issue
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* simplify boolean expression (PR feedback)
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
2021-12-16 09:35:39 +00:00
d065eb9498
Initial improvements to fix viewport icon selection and draw order ( #6284 )
...
* wip fixes for entity viewport icons displaying in the correct order and handling selection correctly
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* add additional comment about z value
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* move manual sorting and some small tidy-up
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* update comment
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* updates following initial round of PR feedback
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* additional changes to support tests for entity icon intersection
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* add support to enable/disable icons separately from helpers
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* final tests added and small tidy-up to display EntityId correctly
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* update some manipulator test framework calls after utility functions were moved
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* fix for implicit cast
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* move icon scale values to AZ_CVARS
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* fix failing tests caught in AR and update some naming conventions for tests
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* update naming convention for members of ProjectedViewportRay
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* update other references to ProjectedViewportRay
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* update more references to ProjectedViewportRay change
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* update menus for python tests
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
2021-12-16 09:35:23 +00:00
df8326a1b0
Merge pull request #6440 from aws-lumberyard-dev/Atom/dmcdiar/ATOM-16961
...
Fix for missing meshes in the RayTracing Acceleration Structure
2021-12-15 22:07:24 -07:00
a1be8f832e
Build BLAS objects from the BLAS instance list instead of the mesh list
...
Signed-off-by: dmcdiarmid-ly <63674186+dmcdiarmid-ly@users.noreply.github.com >
2021-12-15 19:38:39 -07:00
18bb69a5cb
removed unnecessary lines
...
Signed-off-by: antonmic <56370189+antonmic@users.noreply.github.com >
2021-12-15 18:37:48 -08:00
0a8ba35738
Added ClearPass and automatic instantiation from ParentPass for slots specifying a clear action
...
Signed-off-by: antonmic <56370189+antonmic@users.noreply.github.com >
2021-12-15 18:32:59 -08:00
cf9385fc39
Garbled name when using Chinese charaters ( #6379 )
...
Signed-off-by: T.J. McGrath-Daly <tj.mcgrath.daly@huawei.com >
2021-12-15 17:42:14 -06:00
3a4eb3785a
small bugfix ( #6420 )
...
Signed-off-by: rhhong <rhhong@amazon.com >
2021-12-15 13:21:22 -08:00
f82b329291
Minor optimizations from profiling. ( #6416 )
...
Remove noisy profile marker in the SRG validator
Make the SRG compile marker say which srg is being compiled
Move some dx12 validation code behind the AZ_RHI_ENABLE_VALIDATION define
Signed-off-by: rgba16f <82187279+rgba16f@users.noreply.github.com >
2021-12-15 15:06:05 -06:00
b640f6d691
ATOM-16958 [Image Builder] Alpha data would be removed for source image with alpha content ( #6412 )
...
Fixed a regression issue with image builder which it can choose proper preset for images with alpha content.
Signed-off-by: Qing Tao <55564570+VickyAtAZ@users.noreply.github.com >
2021-12-15 08:56:28 -08:00
33bfdc0bd3
corrected implementation of GetRealElapseTime ( #6422 )
...
Signed-off-by: amzn-sean <75276488+amzn-sean@users.noreply.github.com >
2021-12-15 16:44:38 +00:00
cbba00d473
Atom/16852 ( #6316 )
...
* discover build folder, don't assume or require
Signed-off-by: Jonny Gallowy <gallowj@amazon.com >
* update config_utils, no cyclical imports
Signed-off-by: Jonny Gallowy <gallowj@amazon.com >
* improved docstrings and some code formatting
Signed-off-by: Jonny Gallowy <gallowj@amazon.com >
* updates to config.py
Signed-off-by: Jonny Gallowy <gallowj@amazon.com >
* updates to config_utils.py
Signed-off-by: Jonny Gallowy <gallowj@amazon.com >
* dccsi bootstrap changes
Signed-off-by: Jonny Gallowy <gallowj@amazon.com >
* fixed testing for bootstrap externally
Signed-off-by: Jonny Gallowy <gallowj@amazon.com >
* added note for installing substance automation toolkit for tool dev
Signed-off-by: Jonny Gallowy <gallowj@amazon.com >
* based on user feedback suppress global debug by default in IDE
Signed-off-by: Jonny Gallowy <gallowj@amazon.com >
* small adjustments
Signed-off-by: Jonny Gallowy <gallowj@amazon.com >
2021-12-15 08:25:23 -08:00
e2679aad57
Merge pull request #6195 from tjmgd/bug-keyword-22
...
keyword bug fixed
2021-12-15 10:00:58 -06:00
50e06ea8c5
Merge pull request #6328 from tjmgd/bug-lua-debugging-62
...
Fix: Lua script debugging loading problem
2021-12-15 09:58:11 -06:00
0a31483faa
Merge pull request #6333 from tjmgd/bug-lua-breakpoint-67
...
Fix: Lua breakpoint error
2021-12-15 09:57:54 -06:00
50588eb2ad
Merge pull request #6401 from aws-lumberyard-dev/Atom/mriegger/stopdx12warnings
...
Fix for dx12 validation spam
2021-12-14 17:45:58 -06:00
3ee7cef09e
Merge pull request #6306 from aws-lumberyard-dev/scripting/fix_slot_names
...
Fixed incorrect condition that led to badly named slots
2021-12-14 11:27:15 -08:00
f8ca427954
Fixed several material editor bugs related to file paths and hot reload prompts ( #6374 )
...
* draft
Signed-off-by: Guthrie Adams <guthadam@amazon.com >
* Removes automatic generation of relative paths for external references for materials
Updated material editor functions for creating new materials, creating or saving model or lighting presets, to save to the project asset folder instead of the material folder which is not included in the new templates
Changed function for getting saved file names to handle case where Qt save file dialog adds double extensions if the extension contains a dot
Signed-off-by: Guthrie Adams <guthadam@amazon.com >
* Fixed problems with material editor hot reloading after documents or dependencies changed.
Triggering message boxes within the tick function, which is executed from the main application timer, caused the tick function to be called a second time recursively.
Switched from using the tick bus to a timer so that the documents re opening and dialogs are triggered outside of the main tick.
Signed-off-by: Guthrie Adams <guthadam@amazon.com >
2021-12-14 08:52:01 -08:00
f3d426e638
Merge pull request #4965 from aws-lumberyard-dev/APTetherLifetimeOnByDefault
...
Enable lifetime tethering of the AP by default
2021-12-14 09:31:24 -07:00
8b7cdd45a3
Merge pull request #6344 from aws-lumberyard-dev/daimini/ReadOnly/TransformResetFix
...
Disable invalid operations related to procedural prefabs in the Inspector
2021-12-14 09:33:43 -06:00
82e731b1c0
Fix for dx12 validation spam
...
Signed-off-by: mrieggeramzn <mriegger@amazon.com >
2021-12-13 22:43:41 -08:00
d951e1f652
LyShine cleanup of TODOs ( #6138 )
...
* LyShine cleanup pass for Atom conversion
Signed-off-by: abrmich <abrmich@amazon.com >
* Add GHI numbers to comments
Signed-off-by: abrmich <abrmich@amazon.com >
2021-12-14 00:00:26 +01:00
04669544cc
Remove unused trait AZ_TRAIT_DISABLE_FAILED_MULTIPLAYER_GRIDMATE_TESTS ( #6389 )
...
Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com >
2021-12-13 14:54:57 -08:00
d9f0a3012d
LYN-8837 o3de Material Editor - Texture Settings Editor - Hangs when converting texture ( #6359 )
...
Fixed a editor hanging issue when preview texture with astc format (starts multiple job threads inside a job thread)
Fixed an issue of changing texture setting didn't trigger image re-process.
Fixed an issue with image asset which has texture setting may have dependency with wrong preset
Added a EIF_HDR for source image in hdr format.
Fixed astc compression issue which may wrongly compress image to HDR astc format
Signed-off-by: Qing Tao <55564570+VickyAtAZ@users.noreply.github.com >
2021-12-13 14:30:53 -08:00
7188529652
Fix for GHI-4644: mesh optimization breaking skin influences (DCO fix) ( #6336 )
...
* Average incoming skin influences when multiple vertices have been welded. This is one option which will average out the weights even if two welded vertices have differing boneIds, but we probably also need to add the influences earlier in the process and enforce a process where the vertices do not get welded if they have influences with differing boneIds
Signed-off-by: Tommy Walton <waltont@amazon.com >
* Move skin influences from MeshBuilderSkinningInfo to the vertex attribute layers so they are considered when choosing which vertices can be welded and so they are not duplicated when compatible vertices have been welded
Signed-off-by: Tommy Walton <waltont@amazon.com >
* Updating unit tests
Signed-off-by: Tommy Walton <waltont@amazon.com >
* Remove unused functions
Signed-off-by: Tommy Walton <waltont@amazon.com >
* Update based on feedback from burelc
Signed-off-by: Tommy Walton <waltont@amazon.com >
2021-12-13 13:07:04 -08:00
71bb200e0a
[LYN-7064] Hot Loading of Procedural Prefabs ( #4923 )
...
* Prefab hotloading - load and maintain asset references
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Working hotloading
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Clean up code, add comments
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Add missing includes
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Add event for template removal.
Clear ProceduralPrefabSystemComponent lookup when templates are removed.
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Add unit test.
Fix missing include, make sure source name is set
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix missing include
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix missing include
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Update comments to make ebus event behavior more clear
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix missing include
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix missing includes
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix missing include
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix temp directory usage which doesn't work on linux
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix temp directory usage which doesn't work on linux
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Use AZ::IO::Path for comparison. Print paths on failure
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix unit test - register asset with catalog so it can be looked up later
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
2021-12-13 12:44:41 -08:00
45abb9f88e
Proc Prefabs: Remove feature toggle ( #6348 )
...
* Disable feature flag - redirect proc prefab check to IsPrefabSystemEnabled.
Procedural Prefabs are now on by default when the prefab system is enabled.
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Bump scene builder version to cause all procedural prefabs to rebuild
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Switch to lambda for ebus call
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Remove unused const
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
2021-12-13 11:52:03 -08:00
d5980da3d4
Merge pull request #6377 from aws-lumberyard-dev/Atom/dmcdiar/ATOM-16886
...
Vulkan validation fixes for RayTracing
2021-12-13 12:46:53 -07:00
da8967d570
Minor change to comments
...
Signed-off-by: dmcdiarmid-ly <63674186+dmcdiarmid-ly@users.noreply.github.com >
2021-12-13 12:03:40 -07:00
c444978648
Change Vulkan RHI CommandList::SetStreamBuffers to not do 2 memory allocation per draw by using fixed_vector
...
This takes the high instance test from 20fps to 44fps in my local testing.
Signed-off-by: rgba16f 82187279+rgba16f@users.noreply.github.com
2021-12-13 12:23:13 -06:00
0dfb8d42c4
Disable the ability to instantiate into closed prefabs, and to move the root prefab in focus mode. ( #6320 )
...
* Disable "Move Up" and "Move Down" for focused prefab containers.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Disable the ability to instantiate prefabs inside closed prefab instances.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Minor comment fix.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-12-13 19:10:04 +01:00
586f146a84
Fixed nullptr error ( #6386 )
...
Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com >
2021-12-13 17:56:46 +00:00
ae3dedfe59
Merge pull request #6172 from aws-lumberyard-dev/Prism/RefactorProjectSettings
...
Refactor Project Manager Settings
2021-12-13 09:40:48 -08:00
eae66b964b
[AudioSystem] Allow audio engines to provide widgets for modifying connection properties. ( #6303 )
...
Signed-off-by: Maxim Ivanov <imginimg@gmail.com >
2021-12-13 09:32:24 -08:00
f2c9a217da
Revert previous update to ConstantsData::SetConstantArray<bool> and fix unit tests ( #6351 )
...
Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com >
2021-12-13 08:51:30 -08:00
713cd4337c
Merge pull request #6263 from aws-lumberyard-dev/scripting/enable_minimap
...
Enabled the Script Canvas Minimap. It will be tested and any performa…
2021-12-13 07:49:45 -08:00
f941d03f9e
Fix namespace Az for AZ in ProcessWatcher for iOS ( #6382 )
...
Signed-off-by: moraaar <moraaar@amazon.com >
2021-12-13 14:03:00 +00:00
4d187b0980
Minor changes to RayTracingScratchBuffer flag.
...
Signed-off-by: dmcdiarmid-ly <63674186+dmcdiarmid-ly@users.noreply.github.com >
2021-12-12 18:43:12 -07:00
497fe8eccc
Fixes for Vulkan validation warnings related to RayTracing and DiffuseGI.
...
Signed-off-by: dmcdiarmid-ly <63674186+dmcdiarmid-ly@users.noreply.github.com >
2021-12-12 18:02:25 -07:00
ab859d1979
Change Vulkan RHI CommandList::SetStreamBuffers to not do 2 memory allocation per draw by using fixed_vector
...
Signed-off-by: rgba16f <82187279+rgba16f@users.noreply.github.com >
2021-12-10 19:08:18 -06:00
c06b697c6b
Revert part of the fix as it would break unit tests. Verified the remaining code still achieves the same purpose on the UI side without impacting the backend.
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-12-10 15:06:55 -08:00
4670003aaf
Fix failed Atom rpi tests linux ( #6319 )
...
- Remove trait AZ_TRAIT_DISABLE_FAILED_ATOM_RPI_TESTS
- Add template specialization for ConstantsData::SetConstant<Color> and ConstantsData::GetConstant<Color>
- Remove trait AZ_TRAIT_DISABLE_FAILED_ATOM_RPI_TESTS from source code
- Fix ConstantsData::SetConstantArray<bool> to pass unit test SetConstant_GetConstant_FalsePackedInGarbage_Bool on Linux, cause by an unwanted optimization (comments describe the situation). This will make this behavior consistent across platforms
Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com >
2021-12-10 14:54:08 -08:00
AMZN-koppersr
Chris Burel
Maxim Ivanov
antonmic
amzn-mike
tjmgd
Tom Hulton-Harrop
dmcdiarmid-ly
Roman
rgba16f
Qing Tao
amzn-sean
Jonny Galloway
Chris Galvan
Luis Sempé
Guthrie Adams
Jeremy Ong
mrieggeramzn
michabr
Steve Pham
Tommy Walton
Danilo Aimini
John Jones-Steele
AMZN-Phil
moraaar