7b6ce50fe8
Remove un-needed Requests namespace use
...
Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com >
2022-01-11 00:52:21 +01:00
3cac520280
Fix non-unity windows build
...
Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com >
2022-01-11 00:47:00 +01:00
18ea4ba6a8
Added a CriticalAssetsCompiled Lifecycle event ( #6469 )
...
The CriticalAssetsCompiled event can be handled to detect when the
AssetProcessor has finished processing Critical Assets
Also with the new event, an audit has been performed over all the
locations where the AssetCatalogEventBus OnCatalogLoaded event was being
handle to make sure it was the proper event to use.
If the handler was actually examing the enumerating over the full
catalog or querying all assets within the catalog, then it was a proper
use.
For handlers that were interested in a particular asset it was not
Moreover added implementations of `OnCatalogAssetChanged` and
`OnCatalogAssetAdded` to the FileTagComponent and the MaterialViewportComponent.
Any applications which uses the AtomToolsApplication
class(MaterialEditor, AtomSampleViewerStandalone,
ShaderMangementConsole) now signals a "CriticalAssetsCompiled" lifecycle
event as well as loads the "assetcatalog.xml" if it exists.
The Launcher application signals the "CrticalAssetsCompiled" event and
reloads the "assetcatalog.xml" for the ${project}.GameLauncher and
${project}.ServerLauncher in Launcher.cpp
Finally the Editor signals the "CriticalAssetsCompiled" and reloads the
"assetcatalog.xml" in CryEdit.cpp
resolves #6093
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com >
2022-01-10 15:21:04 -06:00
098005afbc
AZStd::basic_string improvements ( #6438 )
...
* AZStd::basic_string improvements
The AZStd::basic_string class has a better implementation of the Short
String Optimization, which increases the amount of characters that can
be stored in a `basic_string<char>` from 15 characters to 22
characters(not-including null-terminating characters). For a
`basic_string<wchar_t>` on Windows the amount of characters that can be
stored increases from 7 to 10. Using `basic_string<wchar_t>` on Unix
platforms SSO character amount from 3 to 4 characters.
An additional benefit is that the size of the AZStd::basic_string class
has been reduced from 40 bytes to 32 bytes when using the
AZStd::allocator.
When using a stateless allocator with no non static data members such as
AZStd::stateless_allocator, the size of the AZStd::basic_string is 24
bytes.
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com >
* Corrected comments and updated type alias to usings for AZStd::basic_string
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com >
* Added Benchmarks for the basic_string and basic_fixed_string class
The benchmarks currently measure the speed of the `assign` overloads.
A benchmark has also been added to compare the speed swapping two
`basic_string` instances by 3 memcpy vs 3 pointer swap operations
Speed up string operation when in the iterator overload cases of the
`assign`, `append`, `insert` and `replace` function.
The code was always performing the logic to copy over a string that is
overlapping, without actually checking if the string was overlapping in
the first place.
Added an `az_builtin_is_constant_evaluated` macro that allows use of the
C++20 `std::is_constant_evaluated` feature to determine if an operation
is being performed at compile time vs run time.
That macro is being used to speed up the char_trait operations at run
time, by using the faster standard library functions.
For example char_traits::move now uses "memmove" at runtime, instead of
a for loop.
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com >
* Simplified string logic in AWSMetricsServiceApiTest.
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com >
2022-01-10 10:03:31 -06:00
90ccae7243
Merge remote-tracking branch 'upstream/development' into compiletime_filerequest_code2
2022-01-10 15:56:57 +01:00
7c88f20e1e
Spinboxes now correct when rounding. ( #6748 )
...
* Spinboxes now correct when rounding.
Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com >
* Changes from PR
Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com >
* Fixed tests after change to rounding in spinbox
Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com >
2022-01-10 11:49:22 +00:00
c65a903c7d
chore: fix unit test
...
Signed-off-by: Michael Pollind <mpollind@gmail.com >
2022-01-08 21:01:29 -08:00
f1f81c3789
Merge remote-tracking branch 'upstream/development' into compiletime_filerequest_code2
2022-01-08 21:25:48 +01:00
8b9e3d2175
Simplify disabling Value ctor for pointer types
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2022-01-07 09:53:14 -08:00
ed39c784c3
chore: add accumulated test for mouse position
...
Signed-off-by: Michael Pollind <mpollind@gmail.com >
2022-01-07 07:27:13 -08:00
1654ff0520
chore: correct test case MouseMove_NoAzHandlers_VerifyMouseMovementViewport
...
Signed-off-by: Michael Pollind <mpollind@gmail.com >
2022-01-07 07:27:09 -08:00
9e91c18726
chore: address changes add test cases
...
Signed-off-by: Michael Pollind <mpollind@gmail.com >
2022-01-07 07:27:07 -08:00
3a6f877a9f
chore: add first test
...
Signed-off-by: Michael Pollind <mpollind@gmail.com >
2022-01-07 07:27:05 -08:00
fa809a76ca
chore: address changes
...
- updated checkstyle
- update enum CursorInputMode
- minor refeactor to QtEventToAzInputMapper
Signed-off-by: Michael Pollind <mpollind@gmail.com >
2022-01-07 07:27:03 -08:00
90f710b8c2
feat: add cursor wrapped mode
...
Signed-off-by: Michael Pollind <mpollind@gmail.com >
2022-01-07 07:27:01 -08:00
8503915cdd
bugfix: correct mouseMove under AzToolsFrameworkHelper ( #6493 )
...
* bugfix: correct mouseMove under AzToolsFrameworkHelper
REF: https://github.com/o3de/o3de/issues/6481
Signed-off-by: Michael Pollind <mpollind@gmail.com >
* chore: added unit test
Signed-off-by: Michael Pollind <mpollind@gmail.com >
* chore: address comments
Signed-off-by: Michael Pollind <mpollind@gmail.com >
* chore: correct fixture
Signed-off-by: Michael Pollind <mpollind@gmail.com >
* chore: tweak mouse move logic
Signed-off-by: Michael Pollind <mpollind@gmail.com >
* updates to track mouse/cursor position via events instead of using QCursor::pos()
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* rename AzToolFrameworkTestHelperTest.cpp to AzToolsFrameworkTestHelpersTest.cpp
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
Co-authored-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
2022-01-07 14:43:34 +00:00
1a8b7aeb48
Small workaround and fix to ensure line fade (alpha) displays correctly ( #6733 )
...
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
2022-01-07 09:37:33 +00:00
98b0f206a0
Merge pull request #6705 from aws-lumberyard-dev/3495_preferences_panel_update
...
3495 Preferences panel update: fix richtext elision and allow html links
2022-01-07 08:52:45 +00:00
839bbd734a
Make operator== avoid implicit comparisons
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2022-01-06 16:55:24 -08:00
25924c3d38
Use more explicit operator= override
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2022-01-06 16:54:57 -08:00
e7f573d22a
Make Value ctor explicit
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2022-01-06 16:48:07 -08:00
54e0b8b7b5
Enabling mac tests ( #6716 )
...
* Adds mac test job
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Points to sysctl properly to handle zsh
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Fixes some macos differences with Linux when reading the CTEST_RUN_FLAGS parameters
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* adding the test job to the profile pipe
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Disables some tests in Mac that are not passing
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* passes config to cli_test_driver and sets the right trait for the test (pytest instead of lytesttools)
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Set proper traits for AtomRHI
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Corrected AZ_TRAIT_UNIT_TEST_PERLINE_GRADIANT_GOLDEN_VALUES_7878 values for Mac
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Disables EMotionFX tests in Mac
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Removes debugging prints
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Removes filters that were meant just for Linux
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* quotes are re-quoted in the test_mac.sh script
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2022-01-06 16:16:48 -08:00
f376d7e379
Merge pull request #6468 from aws-lumberyard-dev/Prefabs/ProcessStackAddPrefabBug
...
Spawnable Entity Alias improvements
2022-01-06 14:58:27 -08:00
273d6e225a
Previous commit wasnt correct. Should be using a string not a int
...
Signed-off-by: mrieggeramzn <mriegger@amazon.com >
2022-01-06 14:00:33 -08:00
f1c8fbe7c0
remove std and replace with az
...
Signed-off-by: mrieggeramzn <mriegger@amazon.com >
2022-01-06 13:45:54 -08:00
030ba4853b
Merge branch 'development' into 3495_preferences_panel_update
2022-01-06 14:29:04 +00:00
39c09ba6f7
chore: correct formatting and address comments
...
Signed-off-by: Michael Pollind <mpollind@gmail.com >
2022-01-05 21:03:16 -08:00
21850aa73e
chore: replace stack trace logic with StackRecorder
...
Signed-off-by: Michael Pollind <mpollind@gmail.com >
2022-01-05 21:03:14 -08:00
833598d68f
chore: remove signal handler
...
Signed-off-by: Michael Pollind <mpollind@gmail.com >
2022-01-05 21:03:12 -08:00
ada7c41a34
feature: add Exception Handler support for unix
...
REF: https://github.com/o3de/o3de/issues/5886
Signed-off-by: Michael Pollind <mpollind@gmail.com >
2022-01-05 21:03:10 -08:00
e2a960e442
Fixed a sync issue when a PrefaDOM was taken from a PrefabDocument.
...
When a PrefabDOM was taken from a PrefabDocument the Instance would continue to have the data from the original Prefab, which means they'd no longer be in sync as the Prefab would be empty. This was fixed by resetting the Instance so they're both clear.
Signed-off-by: AMZN-koppersr <82230785+AMZN-koppersr@users.noreply.github.com >
2022-01-05 17:21:15 -08:00
09fd52ef73
AzCore Math tests produce errors that need to be disabled in debug ( #6678 )
...
* Tests produce errors that need to be disabled in debug
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* PR suggestion
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2022-01-05 16:07:52 -08:00
0bcb514c27
removing qlocale.h compile issue
...
Signed-off-by: mrieggeramzn <mriegger@amazon.com >
2022-01-05 15:56:53 -08:00
7d9f9f99e6
fix unit test
...
Signed-off-by: mrieggeramzn <mriegger@amazon.com >
2022-01-05 14:50:03 -08:00
af6af93dff
Fixes Linux builds
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2022-01-05 14:23:32 -08:00
d347a9d2c0
Fix Linux build (a static_assert unfortunately fires for Clang)
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2022-01-05 12:56:22 -08:00
ddbcc68106
Merge branch 'development' into memory/overrideshim_removal
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
# Conflicts:
# Code/Framework/AzCore/AzCore/Memory/AllocatorBase.cpp
# Code/Framework/AzCore/AzCore/Memory/BestFitExternalMapAllocator.cpp
# Code/Framework/AzCore/AzCore/Memory/BestFitExternalMapSchema.cpp
# Code/Framework/AzCore/AzCore/Memory/PoolSchema.cpp
# Code/Framework/AzCore/AzCore/Memory/SystemAllocator.cpp
# Code/Framework/AzCore/Tests/Memory/AllocatorBenchmarks.cpp
2022-01-05 11:34:52 -08:00
acc6248ec9
Move deep comparison / copy to utils
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2022-01-05 11:31:09 -08:00
13375cd7d9
Merge branch 'development' into Prefabs/ProcessStackAddPrefabBug
2022-01-05 11:12:57 -08:00
31e51f8c3a
Minor updates to the Spawnable Entity Aliases in response to PR feedback.
...
Signed-off-by: AMZN-koppersr <82230785+AMZN-koppersr@users.noreply.github.com >
2022-01-05 10:47:23 -08:00
89067fe667
Memory/benchmarks ( #5896 )
...
* initial version ported from an old implementation
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* simplification of code
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Fixes a recursive loop
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Removing commented code of different options for getting memory usage of a process
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* PR comment (NULL->nullptr)
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Adds mulit-threaded tests
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Improving runtime and making the whole duration manageable
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Fixes Linux build
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Fixes for mac
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Fixes for HeapSchema to get a default block if none is passed
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Adds recording functionality (disabled) and a benchmark that can run recordings
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Removes Heap allocator from being possible to use as a SystemAllocator since it doesnt allow dynamic allocating (only works with pre-allocated blocks)
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* WIP trying to use SystemAllocator instead of raw reads
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Makes the recorded benchmark more stable
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* More stability changes, improvement on type usage within the benchmark, cleanup of unstable stats
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Adds benchmark files for Android
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Fixes Linux nounity build
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* PR comments
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Death test relies on an exception from ocurring, that exception is an access violation, which could not happen (i.e. the memory could be valid for the process)
The test didnt have to be a death test. Also handled the situation better in the code to be able to continue in that scenario (useful for release configurations)"
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2022-01-05 10:40:03 -08:00
8ed3da5b7f
Adding header file
...
Signed-off-by: mrieggeramzn <mriegger@amazon.com >
2022-01-05 10:24:53 -08:00
783a04b880
3495 Preferences panel update: fix richtext elision and allow html links
...
Signed-off-by: sphrose <82213493+sphrose@users.noreply.github.com >
2022-01-05 18:00:07 +00:00
c548fd7682
Death test relies on an exception from ocurring, that exception is an access violation, which could not happen (i.e. the memory could be valid for the process) ( #6683 )
...
The test didnt have to be a death test. Also handled the situation better in the code to be able to continue in that scenario (useful for release configurations)"
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2022-01-05 08:15:08 -08:00
41c0fb2b02
Address some review feedback
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2022-01-04 17:41:58 -08:00
e518faa8be
Merge remote-tracking branch 'upstream/development' into nvsickle/GenericDomDocument
2022-01-04 15:41:17 -08:00
30e21bc2d1
Updating formatting
...
Signed-off-by: mrieggeramzn <mriegger@amazon.com >
2022-01-04 14:52:00 -08:00
a891993c35
Remove 'INF' from integer widget and replace it with better formatted integers. Also fix warning message with invalid param
...
Signed-off-by: mrieggeramzn <mriegger@amazon.com >
2022-01-04 09:58:30 -08:00
2dfdabdfc9
ProcessWatcher fixes. ( #6570 )
...
* ProcessWatcher fixes.
Signed-off-by: bosnichd <bosnichd@amazon.com >
* Update based on review feedback.
Signed-off-by: bosnichd <bosnichd@amazon.com >
2022-01-04 09:54:20 -07:00
aa17120f09
Merge pull request #6496 from pollend/chore/add-assets-plane
...
chore: add assertions to plane to ensure normalization
2022-01-03 12:29:42 -06:00
nemerle
lumberyard-employee-dm
John Jones-Steele
Michael Pollind
Nicholas Van Sickle
Tom Hulton-Harrop
sphrose
Esteban Papp
Ronald Koppers
mrieggeramzn
bosnichd
Chris Galvan