birkeh/o3de
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Animation Editor: Clicking Visualization in Anim Graph in the animation editor has no effect. (#5088)

Browse Source 
asprintf() is returning a new QString and is also deprecated. Switched to use the AZStd::string::format() as that uses the small string optimization and doesn't result in an allocation.

Resolves #2429

Signed-off-by: Benjamin Jillich <jillich@amazon.com>
This commit is contained in:
Benjamin Jillich
2021-11-04 11:52:27 +01:00
committed by GitHub
parent cdf5a0519f
commit 54506b6c6c
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Gems/EMotionFX/Code/EMotionFX/Tools/EMotionStudio/Plugins/StandardPlugins/Source/AnimGraph/NodeGraph.cpp
+6 -5
View File
@@ -6,7 +6,8 @@
*
*/
#include "AzCore/std/numeric.h"
#include <AzCore/std/numeric.h>
#include <AzCore/std/string/fixed_string.h>
#include <AzQtComponents/Utilities/Conversions.h>
#include <EMotionFX/Source/AnimGraphNodeGroup.h>
#include <EMotionFX/Source/AnimGraphReferenceNode.h>
@@ -231,7 +232,7 @@ namespace EMStudio
// add the playspeed
if (plugin->GetIsDisplayFlagEnabled(AnimGraphPlugin::DISPLAYFLAG_PLAYSPEED))
{
m_qtTempString.asprintf("Play Speed = %.2f", emfxNode->GetPlaySpeed(animGraphInstance));
m_qtTempString = AZStd::fixed_string<24>::format("Play Speed = %.2f", emfxNode->GetPlaySpeed(animGraphInstance)).c_str();
painter.drawText(textPosition, m_qtTempString);
textPosition.setY(textPosition.y() + heightSpacing);
}
@@ -239,7 +240,7 @@ namespace EMStudio
// add the global weight
if (plugin->GetIsDisplayFlagEnabled(AnimGraphPlugin::DISPLAYFLAG_GLOBALWEIGHT))
{
m_qtTempString.asprintf("Global Weight = %.2f", uniqueData->GetGlobalWeight());
m_qtTempString = AZStd::fixed_string<24>::format("Global Weight = %.2f", uniqueData->GetGlobalWeight()).c_str();
painter.drawText(textPosition, m_qtTempString);
textPosition.setY(textPosition.y() + heightSpacing);
}
@@ -247,7 +248,7 @@ namespace EMStudio
// add the sync
if (plugin->GetIsDisplayFlagEnabled(AnimGraphPlugin::DISPLAYFLAG_SYNCSTATUS))
{
m_qtTempString.asprintf("Synced = %s", animGraphInstance->GetIsSynced(emfxNode->GetObjectIndex()) ? "Yes" : "No");
m_qtTempString = AZStd::fixed_string<24>::format("Synced = %s", animGraphInstance->GetIsSynced(emfxNode->GetObjectIndex()) ? "Yes" : "No").c_str();
painter.drawText(textPosition, m_qtTempString);
textPosition.setY(textPosition.y() + heightSpacing);
}
@@ -255,7 +256,7 @@ namespace EMStudio
// add the play position
if (plugin->GetIsDisplayFlagEnabled(AnimGraphPlugin::DISPLAYFLAG_PLAYPOSITION))
{
m_qtTempString.asprintf("Play Time = %.3f / %.3f", uniqueData->GetCurrentPlayTime(), uniqueData->GetDuration());
m_qtTempString = AZStd::fixed_string<32>::format("Play Time = %.3f / %.3f", uniqueData->GetCurrentPlayTime(), uniqueData->GetDuration()).c_str();
painter.drawText(textPosition, m_qtTempString);
textPosition.setY(textPosition.y() + heightSpacing);
}