birkeh/o3de
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Made formatting changes per pull comments, incuding adding comments, changing spacing, and changing the ui type of component fields

Browse Source 
Signed-off-by: Kyle B <kylebirnbaum@gmail.com>
This commit is contained in:
Kyle B
2021-08-03 18:28:55 -07:00
parent 1a48118ece
commit 3db93a564d
4 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Gems/Atom/Feature/Common/Code/Include/Atom/Feature/Mesh/MeshFeatureProcessor.h
+4 -4
View File
@@ -62,13 +62,13 @@ namespace AZ
void BuildDrawPacketList(size_t modelLodIndex);
void SetRayTracingData();
void SetSortKey(RHI::DrawItemSortKey sortKey);
RHI::DrawItemSortKey GetSortKey();
RHI::DrawItemSortKey GetSortKey() const;
void SetLodOverride(RPI::Cullable::LodOverride lodOverride);
RPI::Cullable::LodOverride GetLodOverride();
RPI::Cullable::LodOverride GetLodOverride() const;
void SetMinimumScreenCoverage(float minimumScreenCoverage);
float GetMinimumScreenCoverage();
float GetMinimumScreenCoverage() const;
void SetQualityDecayRate(float qualityDecayRate);
float GetQualityDecayRate();
float GetQualityDecayRate() const;
void UpdateDrawPackets(bool forceUpdate = false);
void BuildCullable();
void UpdateCullBounds(const TransformServiceFeatureProcessor* transformService);
Gems/Atom/Feature/Common/Code/Source/Mesh/MeshFeatureProcessor.cpp
+6 -6
View File
@@ -380,7 +380,7 @@ namespace AZ
}
}
void MeshFeatureProcessor::SetMinimumScreenCoverage( const MeshHandle& meshHandle, float minimumScreenCoverage)
void MeshFeatureProcessor::SetMinimumScreenCoverage(const MeshHandle& meshHandle, float minimumScreenCoverage)
{
if (meshHandle.IsValid())
{
@@ -388,7 +388,7 @@ namespace AZ
}
}
float MeshFeatureProcessor::GetMinimumScreenCoverage(const MeshHandle& meshHandle)
float MeshFeatureProcessor::GetMinimumScreenCoverage(const MeshHandle& meshHandle) const
{
if (meshHandle.IsValid())
{
@@ -1028,7 +1028,7 @@ namespace AZ
}
}
RHI::DrawItemSortKey MeshDataInstance::GetSortKey()
RHI::DrawItemSortKey MeshDataInstance::GetSortKey() const
{
return m_sortKey;
}
@@ -1038,7 +1038,7 @@ namespace AZ
m_cullable.m_lodData.m_lodOverride = lodOverride;
}
RPI::Cullable::LodOverride MeshDataInstance::GetLodOverride()
RPI::Cullable::LodOverride MeshDataInstance::GetLodOverride() const
{
return m_cullable.m_lodData.m_lodOverride;
}
@@ -1048,7 +1048,7 @@ namespace AZ
m_cullable.m_lodData.m_minimumScreenCoverage = minimumScreenCoverage;
}
float MeshDataInstance::GetMinimumScreenCoverage()
float MeshDataInstance::GetMinimumScreenCoverage() const
{
return m_cullable.m_lodData.m_minimumScreenCoverage;
}
@@ -1058,7 +1058,7 @@ namespace AZ
m_cullable.m_lodData.m_qualityDecayRate = qualityDecayRate;
}
float MeshDataInstance::GetQualityDecayRate()
float MeshDataInstance::GetQualityDecayRate() const
{
return m_cullable.m_lodData.m_qualityDecayRate;
}
Gems/Atom/RPI/Code/Include/Atom/RPI.Public/Culling.h
+1 -1
View File
@@ -89,7 +89,7 @@ namespace AZ
float m_lodSelectionRadius = 1.0f;
// the minimum possibe area a sphere enclosing a mesh projected onto the screen should have before it is culled.
float m_minimumScreenCoverage = 1.0f / 1080.0f;
float m_minimumScreenCoverage = 1.0f / 1080.0f; //For default, mesh should cover at least a screen pixel at 1080p to be drawn
// The screen area decay between 0 and 1, i.e. closer to 1 -> lose quality immediately, closer to 0 -> never lose quality
float m_qualityDecayRate = 0.5f;
Gems/AtomLyIntegration/CommonFeatures/Code/Source/Mesh/EditorMeshComponent.cpp
+2 -2
View File
@@ -76,11 +76,11 @@ namespace AZ
->DataElement(AZ::Edit::UIHandlers::ComboBox, &MeshComponentConfig::m_lodOverride, "Lod Override", "Allows the rendered LOD to be overridden instead of being calculated automatically.")
->Attribute(AZ::Edit::Attributes::EnumValues, &MeshComponentConfig::GetLodOverrideValues)
->Attribute(AZ::Edit::Attributes::Visibility, &MeshComponentConfig::IsAssetSet)
->DataElement(AZ::Edit::UIHandlers::Default, &MeshComponentConfig::m_minimumScreenCoverage, "Minimum Screen Coverage", "Minimum proportion of screen area an entitiy takes up, after that the entitiy is culled.")
->DataElement(AZ::Edit::UIHandlers::Slider, &MeshComponentConfig::m_minimumScreenCoverage, "Minimum Screen Coverage", "Minimum proportion of screen area an entitiy takes up, after that the entitiy is culled.")
->Attribute(AZ::Edit::Attributes::Min, 0.f)
->Attribute(AZ::Edit::Attributes::Max, 1.f)
->Attribute(AZ::Edit::Attributes::Suffix, " percent")
->DataElement(AZ::Edit::UIHandlers::Default, &MeshComponentConfig::m_qualityDecayRate, "Quality Decay Rate",
->DataElement(AZ::Edit::UIHandlers::Slider, &MeshComponentConfig::m_qualityDecayRate, "Quality Decay Rate",
"Rate at which mesh quality decays (0 -> always stay highest quality, 1 -> quality falls off to lowest quality immediately).")
->Attribute(AZ::Edit::Attributes::Min, 0.f)
->Attribute(AZ::Edit::Attributes::Max, 1.f)